130764 2014-03-25 19:52:53 -0700 Arguments simplification phase should be fine with marking the arguments local itself as an arguments alias 2014-03-25 21:09:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 994481 0 fpizlo 2014-03-25 19:52:53 -0700 Being an arguments alias just means that your OSR exit recovery should attempt arguments creation. This is true of arguments locals. We had special cases that tried to make it not true of arguments locals. The only consequence of those special cases was to cause crashes in case of arguments that are also captured variables (i.e. we have SlowArguments). <rdar://problem/16304788> 994482 1 227824 fpizlo 2014-03-25 19:56:17 -0700 Created attachment 227824 the patch 994490 2 227824 sam 2014-03-25 21:06:09 -0700 Comment on attachment 227824 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=227824&action=review > Source/JavaScriptCore/ChangeLog:17 > + arguments aliases, and non-captured variables get completely SSAified - i.e. no Setocals Setocals -> SetLocals 994491 3 fpizlo 2014-03-25 21:09:35 -0700 Landed in http://trac.webkit.org/changeset/166281 227824 2014-03-25 19:56:17 -0700 2014-03-25 21:06:06 -0700 the patch blah.patch text/plain 4077 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2Mjc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDE0LTAzLTI1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QXJndW1lbnRzIHNpbXBsaWZpY2F0aW9uIHBoYXNlIHNob3VsZCBiZSBmaW5lIHdpdGggbWFya2lu ZyB0aGUgYXJndW1lbnRzIGxvY2FsIGl0c2VsZiBhcyBhbiBhcmd1bWVudHMgYWxpYXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDc2NAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTYzMDQ3ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBCZWluZyBhbiBhcmd1bWVudHMgYWxpYXMganVz dCBtZWFucyB0aGF0IHlvdXIgT1NSIGV4aXQgcmVjb3Zlcnkgc2hvdWxkIGF0dGVtcHQgYXJndW1l bnRzCisgICAgICAgIGNyZWF0aW9uLiBUaGlzIGlzIHRydWUgb2YgYXJndW1lbnRzIGxvY2Fscy4g V2UgaGFkIHNwZWNpYWwgY2FzZXMgdGhhdCB0cmllZCB0byBtYWtlIGl0IG5vdAorICAgICAgICB0 cnVlIG9mIGFyZ3VtZW50cyBsb2NhbHMuIFRoZSBvbmx5IGNvbnNlcXVlbmNlIG9mIHRob3NlIHNw ZWNpYWwgY2FzZXMgd2FzIHRvIGNhdXNlIGNyYXNoZXMKKyAgICAgICAgaW4gY2FzZSBvZiBhcmd1 bWVudHMgdGhhdCBhcmUgYWxzbyBjYXB0dXJlZCB2YXJpYWJsZXMgKGkuZS4gd2UgaGF2ZSBTbG93 QXJndW1lbnRzKS4gVGhpcworICAgICAgICBjaGFuZ2UganVzdCByZW1vdmVzIHRob3NlIHNwZWNp YWwgY2FzZXMuCisgICAgICAgIAorICAgICAgICBUaGlzIGNoYW5nZSBtZWFucyB0aGF0IHRoZSBG VEwgd2lsbCBub3cgc2VlIFNldExvY2FscyB3aXRoIGEgRmx1c2hlZEFyZ3VtZW50cyBmb3JtYXQu CisgICAgICAgIFByZXZpb3VzbHkgeW91IHdvdWxkbid0IHNlZSB0aGVtIGJlY2F1c2UgcHJldmlv dXNseSBvbmx5IG5vbi1jYXB0dXJlZCB2YXJpYWJsZSB3b3VsZCBiZQorICAgICAgICBhcmd1bWVu dHMgYWxpYXNlcywgYW5kIG5vbi1jYXB0dXJlZCB2YXJpYWJsZXMgZ2V0IGNvbXBsZXRlbHkgU1NB aWZpZWQgLSBpLmUuIG5vIFNldG9jYWxzCisgICAgICAgIGxlZnQuIEFkZGluZyBoYW5kbGluZyBm b3IgRmx1c2hlZEFyZ3VtZW50cyBpcyBhIGJlbmlnbiBhbmQgc2ltcGxlIGNoYW5nZSBzaW5jZSBp dHMKKyAgICAgICAgYmVoYXZpb3IgaXMgaWRlbnRpY2FsIHRvIEZsdXNoZWRKU1ZhbHVlIGZvciB0 aGF0IGNvZGUncyBwdXJwb3Nlcy4KKworICAgICAgICAqIGRmZy9ERkdBcmd1bWVudHNTaW1wbGlm aWNhdGlvblBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBcmd1bWVudHNTaW1wbGlmaWNh dGlvblBoYXNlOjpydW4pOgorICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvTExWTS5jcHA6Cisg ICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNvbXBpbGVTZXRMb2NhbCk6CisgICAg ICAgICogdGVzdHMvc3RyZXNzL2NhcHR1cmVkLWFyZ3VtZW50cy12YXJpYWJsZS5qczogQWRkZWQu CisgICAgICAgIChmb28pOgorICAgICAgICAobm9JbmxpbmUpOgorCiAyMDE0LTAzLTI1ICBNYXJr IEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIEhlYXBJ bmxpbmVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c1NpbXBs aWZpY2F0aW9uUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQXJndW1lbnRzU2ltcGxpZmljYXRpb25QaGFzZS5jcHAJKHJldmlzaW9uIDE2NjI3NikK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJndW1lbnRzU2ltcGxpZmljYXRpb25Q aGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5NywxMCArMzk3LDYgQEAgcHVibGljOgogICAg ICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgVmFyaWFibGVBY2Nlc3NEYXRh KiB2YXJpYWJsZUFjY2Vzc0RhdGEgPSBub2RlLT52YXJpYWJsZUFjY2Vzc0RhdGEoKTsKICAgICAg ICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgIGlmIChtX2dyYXBoLmFyZ3VtZW50 c1JlZ2lzdGVyRm9yKG5vZGUtPm9yaWdpbi5zZW1hbnRpYykgPT0gdmFyaWFibGVBY2Nlc3NEYXRh LT5sb2NhbCgpCi0gICAgICAgICAgICAgICAgICAgICAgICB8fCB1bm1vZGlmaWVkQXJndW1lbnRz UmVnaXN0ZXIobV9ncmFwaC5hcmd1bWVudHNSZWdpc3RlckZvcihub2RlLT5vcmlnaW4uc2VtYW50 aWMpKSA9PSB2YXJpYWJsZUFjY2Vzc0RhdGEtPmxvY2FsKCkpCi0gICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKLQogICAgICAgICAgICAgICAgICAgICBpZiAodmFyaWFibGVBY2Nlc3NEYXRh LT5tZXJnZUlzQXJndW1lbnRzQWxpYXModHJ1ZSkpIHsKICAgICAgICAgICAgICAgICAgICAgICAg IGNoYW5nZWQgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgICAgICAgCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24g MTY2Mjc2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTgwNiw3ICs4MDYsOCBAQCBwcml2YXRlOgogICAgIHsKICAg ICAgICAgVmFyaWFibGVBY2Nlc3NEYXRhKiB2YXJpYWJsZSA9IG1fbm9kZS0+dmFyaWFibGVBY2Nl c3NEYXRhKCk7CiAgICAgICAgIHN3aXRjaCAodmFyaWFibGUtPmZsdXNoRm9ybWF0KCkpIHsKLSAg ICAgICAgY2FzZSBGbHVzaGVkSlNWYWx1ZTogeworICAgICAgICBjYXNlIEZsdXNoZWRKU1ZhbHVl OgorICAgICAgICBjYXNlIEZsdXNoZWRBcmd1bWVudHM6IHsKICAgICAgICAgICAgIExWYWx1ZSB2 YWx1ZSA9IGxvd0pTVmFsdWUobV9ub2RlLT5jaGlsZDEoKSk7CiAgICAgICAgICAgICBtX291dC5z dG9yZTY0KHZhbHVlLCBhZGRyZXNzRm9yKHZhcmlhYmxlLT5tYWNoaW5lTG9jYWwoKSkpOwogICAg ICAgICAgICAgYnJlYWs7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNz L2NhcHR1cmVkLWFyZ3VtZW50cy12YXJpYWJsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2NhcHR1cmVkLWFyZ3VtZW50cy12YXJpYWJsZS5qcwko cmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvY2FwdHVy ZWQtYXJndW1lbnRzLXZhcmlhYmxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTcgQEAK K2Z1bmN0aW9uIGZvbyhhKSB7CisgICAgcmV0dXJuIGFyZ3VtZW50c1sxXSArIChmdW5jdGlvbigp IHsgcmV0dXJuIGEgKiAxMDE7IH0pKCk7Cit9CisKK25vSW5saW5lKGZvbyk7CisKK2ZvciAodmFy IGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28oNDIsIDk3KTsK KyAgICBpZiAocmVzdWx0ICE9IDQzMzkpCisgICAgICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3Vs dDogIiArIHJlc3VsdDsKK30KKworT2JqZWN0LnByb3RvdHlwZVsxXSA9IDExMTsKKwordmFyIHJl c3VsdCA9IGZvbyg0Mik7CitpZiAocmVzdWx0ICE9IDQzNTMpCisgICAgdGhyb3cgIkVycm9yOiBi YWQgcmVzdWx0IGF0IGVuZDogIiArIHJlc3VsdDsK