130730 2014-03-25 11:12:24 -0700 Avoid duplicate size checks when creating empty image 2014-03-26 10:02:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue esprehn+autocc gyuyoung.kim oldest_to_newest 994254 0 bfulgham 2014-03-25 11:12:24 -0700 Size-checking logic in CanvasRenderingContext2D.cpp double-checks the size of the buffer, since the call to ImageData::create checks the size and returns nullptr on failure. No need to do this calculation twice. Merge from Blink: https://codereview.chromium.org/190633011 994258 1 227772 bfulgham 2014-03-25 11:19:04 -0700 Created attachment 227772 Patch 994331 2 227772 dino 2014-03-25 14:22:12 -0700 Comment on attachment 227772 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227772&action=review > Source/WebCore/ChangeLog:19 > +2014-03-21 Brent Fulgham <bfulgham@apple.com> > + > + [iOS] Pass additional options to AVFoudnation during playback. > + https://bugs.webkit.org/show_bug.cgi?id=130624 > + oops 994600 3 227772 commit-queue 2014-03-26 09:47:16 -0700 Comment on attachment 227772 Patch Rejecting attachment 227772 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227772, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5560090815889408 994606 4 bfulgham 2014-03-26 10:02:46 -0700 Committed r166300: <http://trac.webkit.org/changeset/166300> 227772 2014-03-25 11:19:04 -0700 2014-03-26 09:47:16 -0700 Patch bug-130730-20140325111843.patch text/plain 2686 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjI0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBACisyMDE0LTAzLTI1ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGR1cGxpY2F0ZSBz aXplIGNoZWNrcyB3aGVuIGNyZWF0aW5nIGVtcHR5IGltYWdlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA3MzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZWQgZnJvbSBCbGluayAocGF0Y2ggYnkg Y2guZHVtZXpAc2Ftc3VuZy5jb20pOgorICAgICAgICBodHRwczovL2Nocm9taXVtLmdvb2dsZXNv dXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy80ODYxYTcxYmMxZjI4NGZjOTc0MTdmNDA1YWI3ZDA4 ZGM2OTQ3Yjg4CisgICAgICAgIGh0dHA6Ly9jcmJ1Zy5jb20vMTkwNjMzMDExCisKKyAgICAgICAg KiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Y3JlYXRlRW1wdHlJbWFnZURhdGEpOiBEb24ndCBwZXJmb3JtIG92ZXJmbG93IGNhbGN1 bGF0aW9uIHR3aWNlLgorCisyMDE0LTAzLTIxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw bGUuY29tPgorCisgICAgICAgIFtpT1NdIFBhc3MgYWRkaXRpb25hbCBvcHRpb25zIHRvIEFWRm91 ZG5hdGlvbiBkdXJpbmcgcGxheWJhY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzA2MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpkb2VzSGF2ZUF0dHJpYnV0ZSk6IFJldHVybiBhdHRy aWJ1dGUgdmFsdWUgaWYgdGhlIHVzZXIKKyAgICAgICAgcGFzc2VzIGEgcG9pbnRlciB0byBmaWxs IGluLgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyOjpkb2VzSGF2ZUF0dHJpYnV0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVk aWFQbGF5ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyQ2xpZW50Ojpkb2VzSGF2 ZUF0dHJpYnV0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OmNyZWF0ZUFWUGxheWVySXRl bSk6IFBhc3MgYWRkaXRpb25hbAorICAgICAgICBvcHRpb24gaWYgc3VwcGxpZWQgYnkgdXNlci4K KwogMjAxNC0wMy0yNSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gUmVtb3ZlIHRoZSBhdXRvdG9vbHMgYnVpbGQKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcAkocmV2aXNpb24gMTY2MjQwKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgyNywxNSArMTgy NywxMiBAQCBHcmFwaGljc0NvbnRleHQqIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyCiAKIHN0YXRp YyBQYXNzUmVmUHRyPEltYWdlRGF0YT4gY3JlYXRlRW1wdHlJbWFnZURhdGEoY29uc3QgSW50U2l6 ZSYgc2l6ZSkKIHsKLSAgICBDaGVja2VkPGludCwgUmVjb3JkT3ZlcmZsb3c+IGRhdGFTaXplID0g NDsKLSAgICBkYXRhU2l6ZSAqPSBzaXplLndpZHRoKCk7Ci0gICAgZGF0YVNpemUgKj0gc2l6ZS5o ZWlnaHQoKTsKLSAgICBpZiAoZGF0YVNpemUuaGFzT3ZlcmZsb3dlZCgpKQotICAgICAgICByZXR1 cm4gMDsKKyAgICBpZiAoUmVmUHRyPEltYWdlRGF0YT4gZGF0YSA9IEltYWdlRGF0YTo6Y3JlYXRl KHNpemUpKSB7CisgICAgICAgIGRhdGEtPmRhdGEoKS0+emVyb0ZpbGwoKTsKKyAgICAgICAgcmV0 dXJuIGRhdGEucmVsZWFzZSgpOworICAgIH0KIAotICAgIFJlZlB0cjxJbWFnZURhdGE+IGRhdGEg PSBJbWFnZURhdGE6OmNyZWF0ZShzaXplKTsKLSAgICBkYXRhLT5kYXRhKCktPnplcm9GaWxsKCk7 Ci0gICAgcmV0dXJuIGRhdGEucmVsZWFzZSgpOworICAgIHJldHVybiBudWxscHRyOwogfQogCiBQ YXNzUmVmUHRyPEltYWdlRGF0YT4gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpjcmVhdGVJbWFn ZURhdGEoUGFzc1JlZlB0cjxJbWFnZURhdGE+IGltYWdlRGF0YSwgRXhjZXB0aW9uQ29kZSYgZWMp IGNvbnN0Cg==