130683 2014-03-24 10:40:41 -0700 Optimizing string construction for type error in JSNavigatorCustom.cpp 2014-03-24 16:44:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda commit-queue eric.carlson oldest_to_newest 993884 0 thiago.lacerda 2014-03-24 10:40:41 -0700 Optimizing string construction for type error in JSNavigatorCustom.cpp 993885 1 227667 thiago.lacerda 2014-03-24 10:43:52 -0700 Created attachment 227667 Patch 994025 2 227667 commit-queue 2014-03-24 16:44:51 -0700 Comment on attachment 227667 Patch Clearing flags on attachment: 227667 Committed r166207: <http://trac.webkit.org/changeset/166207> 994026 3 commit-queue 2014-03-24 16:44:53 -0700 All reviewed patches have been landed. Closing bug. 227667 2014-03-24 10:43:52 -0700 2014-03-24 16:44:50 -0700 Patch bug-130683-20140324144330.patch text/plain 2237 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRlNTdiNzExY2RiODYw YjQwY2ZkZjJmMjcxNmJjYzFlNGViYTE2Yi4uZDlkZjc4NTg1NzdiODY1NTE3OGE3NDQzYmMwYjZm NjhiZTU0NjNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAzLTI0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIE9wdGltaXppbmcgc3RyaW5nIGNvbnN0cnVjdGlvbiBmb3IgdHlwZSBlcnJvciBpbiBK U05hdmlnYXRvckN1c3RvbS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMDY4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SlNOYXZpZ2F0b3I6OndlYmtpdEdldFVzZXJNZWRpYSk6CisKIDIwMTQtMDMt MjQgIE1hcnRpbiBIb2RvdmFuICA8bWhvZG92YW5AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAg IEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpIGd1YXJkIGZvciBDU1NHcmlkTGluZU5hbWVzVmFsdWUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmF2aWdhdG9yQ3VzdG9t LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmF2aWdhdG9yQ3VzdG9tLmNwcApp bmRleCA4MWNkMDI5YjhhMGE1MDk0NjA1NWY4Y2ZlNGFmM2IxYTk2NDRlZjA0Li45MmM2MzZmMDJk OTRkNjZjNmU0OGQyN2I0YTNkMDljMDZhNTFlMTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU05hdmlnYXRvckN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwCkBAIC01NSw3ICs1NSw3IEBAIEpTVmFs dWUgSlNOYXZpZ2F0b3I6OndlYmtpdEdldFVzZXJNZWRpYShFeGVjU3RhdGUqIGV4ZWMpCiAgICAg fQogCiAgICAgaWYgKCFleGVjLT5hcmd1bWVudCgxKS5pc0Z1bmN0aW9uKCkpIHsKLSAgICAgICAg dGhyb3dWTUVycm9yKGV4ZWMsIGNyZWF0ZVR5cGVFcnJvcihleGVjLCAiQXJndW1lbnQgMiAoJ3N1 Y2Nlc3NDYWxsYmFjaycpIHRvIE5hdmlnYXRvci53ZWJraXRHZXRVc2VyTWVkaWEgbXVzdCBiZSBh IGZ1bmN0aW9uIikpOworICAgICAgICB0aHJvd1ZNVHlwZUVycm9yKGV4ZWMsIG1ha2VET01CaW5k aW5nc1R5cGVFcnJvclN0cmluZygiQXJndW1lbnQgMiAoJ3N1Y2Nlc3NDYWxsYmFjaycpIiwgIiB0 byBOYXZpZ2F0b3Iud2Via2l0R2V0VXNlck1lZGlhIG11c3QgYmUgYSBmdW5jdGlvbiIpKTsKICAg ICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiAgICAgfQogCkBAIC02Myw3ICs2Myw3IEBAIEpT VmFsdWUgSlNOYXZpZ2F0b3I6OndlYmtpdEdldFVzZXJNZWRpYShFeGVjU3RhdGUqIGV4ZWMpCiAg ICAgUmVmUHRyPE5hdmlnYXRvclVzZXJNZWRpYUVycm9yQ2FsbGJhY2s+IGVycm9yQ2FsbGJhY2s7 CiAgICAgaWYgKCFleGVjLT5hcmd1bWVudCgyKS5pc1VuZGVmaW5lZE9yTnVsbCgpKSB7CiAgICAg ICAgIGlmICghZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoMikuaXNGdW5jdGlvbigpKSB7Ci0gICAg ICAgICAgICB0aHJvd1ZNRXJyb3IoZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMsICJBcmd1bWVu dCAzICgnZXJyb3JDYWxsYmFjaycpIHRvIE5hdmlnYXRvci53ZWJraXRHZXRVc2VyTWVkaWEgbXVz dCBiZSBhIGZ1bmN0aW9uIikpOworICAgICAgICAgICAgdGhyb3dWTVR5cGVFcnJvcihleGVjLCBt YWtlRE9NQmluZGluZ3NUeXBlRXJyb3JTdHJpbmcoIkFyZ3VtZW50IDMgKCdlcnJvckNhbGxiYWNr JykiLCAiIHRvIE5hdmlnYXRvci53ZWJraXRHZXRVc2VyTWVkaWEgbXVzdCBiZSBhIGZ1bmN0aW9u IikpOwogICAgICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiAgICAgICAgIH0KICAgICAg ICAgZXJyb3JDYWxsYmFjayA9IEpTTmF2aWdhdG9yVXNlck1lZGlhRXJyb3JDYWxsYmFjazo6Y3Jl YXRlKGFzT2JqZWN0KGV4ZWMtPnVuY2hlY2tlZEFyZ3VtZW50KDIpKSwgY2FzdGVkVGhpcy0+Z2xv YmFsT2JqZWN0KCkpOwo=