130674 2014-03-24 09:12:12 -0700 fix prepare-ChangeLog after r166156. 2014-03-24 13:51:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 llango.u-szeged llango.u-szeged commit-queue darin gyuyoung.kim ossy rniwa oldest_to_newest 993824 0 llango.u-szeged 2014-03-24 09:12:12 -0700 After r166156 prepare-ChangeLog lists some functions as deleted, but they are not. See in context: https://bugs.webkit.org/attachment.cgi?id=227641&action=review 993830 1 227653 llango.u-szeged 2014-03-24 09:19:57 -0700 Created attachment 227653 Patch 993938 2 227653 darin 2014-03-24 13:20:15 -0700 Comment on attachment 227653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227653&action=review > Tools/Scripts/prepare-ChangeLog:1977 > - $end = $3 || $1; > + if($4 gt "a") { > + $end = $3 || $1; > + } Missing space before "(". But since this is perl you could write: $end = $3 || $1 if $4 ne "a"; I think “ne” would be better than “gt”. 993954 3 227653 commit-queue 2014-03-24 13:51:45 -0700 Comment on attachment 227653 Patch Clearing flags on attachment: 227653 Committed r166189: <http://trac.webkit.org/changeset/166189> 993955 4 commit-queue 2014-03-24 13:51:51 -0700 All reviewed patches have been landed. Closing bug. 227653 2014-03-24 09:19:57 -0700 2014-03-24 13:51:45 -0700 Patch bug-130674-20140324171936.patch text/plain 4367 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjIwMzg5NWY5YjcxY2QwODBmYmExNGIxNzk2N2MzZDRj MjJkMWY3Zi4uMjhlOTNkZDQwOTk2MDZjOWU1MWZlMGFmMjExN2VkYmNlNjQyMzliNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDE0LTAzLTI0ICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KIAorICAgICAgICBGaXggcHJlcGFyZS1DaGFuZ2VMb2cgYWZ0ZXIgcjE2 NjE1Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MDY3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKyAgICAgICAgKGdlbmVyYXRlRnVuY3Rpb25MaXN0 cyk6CisgICAgICAgIChleHRyYWN0TGluZVJhbmdlQmVmb3JlQ2hhbmdlKToKKworMjAxNC0wMy0y NCAgTMOhc3psw7MgTGFuZ8OzICA8bGxhbmdvLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+ CisKICAgICAgICAgcHJlcGFyZS1DaGFuZ2VMb2cgc2hvdWxkIGxpc3QgZnVuY3Rpb25zIHRoYXQg aGF2ZSBiZWVuIHJlbW92ZWQgdG9vLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMwNTA4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFy ZS1DaGFuZ2VMb2cgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IGQwOGMw NTA2OGU4ZDhhMTRlYzFiNWQ4NWQ3MzRiMTEwMTUxYWM2NWQuLjE4MmY3OWY2NzUzMDA5ZTAwNDZi MDJjZjI3NTJkYWEwOWE0MmM0ZWIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1D aGFuZ2VMb2cKKysrIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMjY0LDcg KzI2NCw3IEBAIHN1YiBnZW5lcmF0ZUZ1bmN0aW9uTGlzdHMoJCQkJCQpCiAgICAgICAgICAgICAk ZmlsZSA9IG1ha2VGaWxlUGF0aFJlbGF0aXZlKCQxKSBpZiAkXyA9fiBkaWZmSGVhZGVyRm9ybWF0 KCk7CiAgICAgICAgICAgICBpZiAoZGVmaW5lZCAkZmlsZSkgewogICAgICAgICAgICAgICAgIG15 ICgkYmVmb3JlX3N0YXJ0LCAkYmVmb3JlX2VuZCkgPSBleHRyYWN0TGluZVJhbmdlQmVmb3JlQ2hh bmdlKCRfKTsKLSAgICAgICAgICAgICAgICBpZiAoJGJlZm9yZV9zdGFydCA+PSAwICYmICRiZWZv cmVfZW5kID49IDApIHsKKyAgICAgICAgICAgICAgICBpZiAoJGJlZm9yZV9zdGFydCA+PSAwICYm ICRiZWZvcmVfZW5kID49ICRiZWZvcmVfc3RhcnQpIHsKICAgICAgICAgICAgICAgICAgICAgcHVz aCBAeyRsaW5lX3Jhbmdlc19iZWZvcmVfY2hhbmdlZHskZmlsZX19LCBbICRiZWZvcmVfc3RhcnQs ICRiZWZvcmVfZW5kIF07CiAgICAgICAgICAgICAgICAgfSBlbHNpZiAoL0RPX05PVF9DT01NSVQv KSB7CiAgICAgICAgICAgICAgICAgICAgIHByaW50IFNUREVSUiAiV0FSTklORzogZmlsZSAkZmls ZSBjb250YWlucyB0aGUgc3RyaW5nIERPX05PVF9DT01NSVQsIGxpbmUgJC5cbiI7CkBAIC0yODEs MTYgKzI4MSwxNiBAQCBzdWIgZ2VuZXJhdGVGdW5jdGlvbkxpc3RzKCQkJCQkKQogICAgIH0KIAog ICAgICMgRm9yIGVhY2ggc291cmNlIGZpbGUsIGNvbnZlcnQgbGluZSByYW5nZSB0byBmdW5jdGlv biBsaXN0LgotICAgIGlmICglbGluZV9yYW5nZXNfYWZ0ZXJfY2hhbmdlZCBhbmQgJWxpbmVfcmFu Z2VzX2JlZm9yZV9jaGFuZ2VkKSB7Ci0gICAgICAgIHByaW50IFNUREVSUiAiICBFeHRyYWN0aW5n IGFmZmVjdGVkIGZ1bmN0aW9uIG5hbWVzIGZyb20gc291cmNlIGZpbGVzLlxuIjsKLSAgICAgICAg Zm9yZWFjaCBteSAkZmlsZSAoa2V5cyAlbGluZV9yYW5nZXNfYWZ0ZXJfY2hhbmdlZCkgewotICAg ICAgICAgICAgIyBGaW5kIGFsbCB0aGUgZnVuY3Rpb25zIGluIHRoZSBmaWxlLgorICAgIHByaW50 IFNUREVSUiAiICBFeHRyYWN0aW5nIGFmZmVjdGVkIGZ1bmN0aW9uIG5hbWVzIGZyb20gc291cmNl IGZpbGVzLlxuIjsKKyAgICBmb3JlYWNoIG15ICRmaWxlIChrZXlzICVsaW5lX3Jhbmdlc19hZnRl cl9jaGFuZ2VkKSB7CisgICAgICAgIG15ICVzYXdfZnVuY3Rpb247CisgICAgICAgICMgRmluZCBh bGwgdGhlIGZ1bmN0aW9ucyBpbiB0aGUgZmlsZS4KKyAgICAgICAgaWYgKCRsaW5lX3Jhbmdlc19h ZnRlcl9jaGFuZ2VkeyRmaWxlfSkgewogICAgICAgICAgICAgb3BlbiBTT1VSQ0UsICRmaWxlIG9y IG5leHQ7CiAgICAgICAgICAgICBteSBAZnVuY3Rpb25fcmFuZ2VzID0gZ2V0X2Z1bmN0aW9uX2xp bmVfcmFuZ2VzKFwqU09VUkNFLCAkZmlsZSk7CiAgICAgICAgICAgICBjbG9zZSBTT1VSQ0U7CiAK ICAgICAgICAgICAgIG15IEBjaGFuZ2VfcmFuZ2VzID0gKEB7JGxpbmVfcmFuZ2VzX2FmdGVyX2No YW5nZWR7JGZpbGV9fSwgW10pOwotICAgICAgICAgICAgbXkgJXNhd19mdW5jdGlvbjsKICAgICAg ICAgICAgIG15IEBmdW5jdGlvbnMgPSBnZW5lcmF0ZUZ1bmN0aW9uTGlzdHNCeVJhbmdlcygkZmls ZSwgXEBjaGFuZ2VfcmFuZ2VzLCBcQGZ1bmN0aW9uX3JhbmdlcywgXCVzYXdfZnVuY3Rpb24pOwog CiAgICAgICAgICAgICAjIEZvcm1hdCB0aGUgbGlzdCBvZiBmdW5jdGlvbnMuCkBAIC0yOTgsMTQg KzI5OCwxNSBAQCBzdWIgZ2VuZXJhdGVGdW5jdGlvbkxpc3RzKCQkJCQkKQogICAgICAgICAgICAg ICAgICRmdW5jdGlvbkxpc3RzLT57JGZpbGV9ID0gIiIgaWYgIWRlZmluZWQgJGZ1bmN0aW9uTGlz dHMtPnskZmlsZX07CiAgICAgICAgICAgICAgICAgJGZ1bmN0aW9uTGlzdHMtPnskZmlsZX0gLj0g IlxuICAgICAgICAoIiAuIGpvaW4oIik6XG4gICAgICAgICgiLCBAZnVuY3Rpb25zKSAuICIpOiI7 CiAgICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgICMgRmluZCB0aGUgZGVsZXRlZCBmdW5jdGlv bnMgaW4gdGhlIG9yaWdpbmFsIGZpbGUuCisgICAgICAgIH0KKyAgICAgICAgIyBGaW5kIHRoZSBk ZWxldGVkIGZ1bmN0aW9ucyBpbiB0aGUgb3JpZ2luYWwgZmlsZS4KKyAgICAgICAgaWYoJGxpbmVf cmFuZ2VzX2JlZm9yZV9jaGFuZ2VkeyRmaWxlfSkgewogICAgICAgICAgICAgb3BlbiBTT1VSQ0Us ICItfCIsIG9yaWdpbmFsRmlsZSgkZmlsZSwgJGdpdENvbW1pdCwgJGdpdEluZGV4LCAkbWVyZ2VC YXNlKSBvciBuZXh0OwogICAgICAgICAgICAgICAgIG15IEBkZWxldGVkX2Z1bmN0aW9uX3Jhbmdl cyA9IGdldF9mdW5jdGlvbl9saW5lX3JhbmdlcyhcKlNPVVJDRSwgJGZpbGUpOwogICAgICAgICAg ICAgY2xvc2UgU09VUkNFOwogCi0gICAgICAgICAgICBAY2hhbmdlX3JhbmdlcyA9IChAeyRsaW5l X3Jhbmdlc19iZWZvcmVfY2hhbmdlZHskZmlsZX19LCBbXSk7Ci0gICAgICAgICAgICBAZnVuY3Rp b25zID0gZ2VuZXJhdGVGdW5jdGlvbkxpc3RzQnlSYW5nZXMoJGZpbGUsIFxAY2hhbmdlX3Jhbmdl cywgXEBkZWxldGVkX2Z1bmN0aW9uX3JhbmdlcywgXCVzYXdfZnVuY3Rpb24pOworICAgICAgICAg ICAgbXkgQGNoYW5nZV9yYW5nZXMgPSAoQHskbGluZV9yYW5nZXNfYmVmb3JlX2NoYW5nZWR7JGZp bGV9fSwgW10pOworICAgICAgICAgICAgbXkgQGZ1bmN0aW9ucyA9IGdlbmVyYXRlRnVuY3Rpb25M aXN0c0J5UmFuZ2VzKCRmaWxlLCBcQGNoYW5nZV9yYW5nZXMsIFxAZGVsZXRlZF9mdW5jdGlvbl9y YW5nZXMsIFwlc2F3X2Z1bmN0aW9uKTsKIAogICAgICAgICAgICAgIyBGb3JtYXQgdGhlIGxpc3Qg b2YgZGVsZXRlZCBmdW5jdGlvbnMuCiAgICAgICAgICAgICBpZiAoQGZ1bmN0aW9ucykgewpAQCAt MTk2OSw5ICsxOTcwLDExIEBAIHN1YiBleHRyYWN0TGluZVJhbmdlQmVmb3JlQ2hhbmdlKCQpCiAK ICAgICBteSAoJHN0YXJ0LCAkZW5kKSA9ICgtMSwgLTEpOwogCi0gICAgaWYgKGlzU1ZOKCkgJiYg JHN0cmluZyA9fiAvXihcZCspKCwoXGQrKSk/W2FjZF1cZCsoLFxkKyk/LykgeworICAgIGlmIChp c1NWTigpICYmICRzdHJpbmcgPX4gL14oXGQrKSgsKFxkKykpPyhbYWNkXSlcZCsoLFxkKyk/Lykg ewogICAgICAgICAkc3RhcnQgPSAkMTsKLSAgICAgICAgJGVuZCA9ICQzIHx8ICQxOworICAgICAg ICBpZigkNCBndCAiYSIpIHsKKyAgICAgICAgICAgICRlbmQgPSAkMyB8fCAkMTsKKyAgICAgICAg fQogICAgIH0gZWxzaWYgKGlzR2l0KCkgJiYgJHN0cmluZyA9fiAvXkBAIC0oXGQrKSgsKFxkKykp PyBcK1xkKygsXGQrKT8gQEAvKSB7CiAgICAgICAgICRzdGFydCA9ICQxOwogICAgICAgICAkZW5k ID0gZGVmaW5lZCgkMykgPyAkMyArICQxIC0gMSA6ICQxOwo=