130672 2014-03-24 08:50:22 -0700 Web Replay: disable page cache during capture/replay 2014-03-26 20:46:01 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 130728 1 bburg bburg ap joepeck kling mhock psolanki sam timothy oldest_to_newest 993819 0 bburg 2014-03-24 08:50:22 -0700 . 994001 1 bburg 2014-03-24 16:15:19 -0700 I may end up splitting this patch, as the MemoryCache is a bit tricky to get right. Since the memory cache is a static singleton, simply setting it as disabled through its API is not foolproof because another context using the same WebProcess could un-disable and start filling the cache, altering execution results. Simply returning 0 from CachedResourceLoader::requestResource whenever the associated page is in "replay mode" won't work because we expect the main resource to always be returned from requestResource. An approach I am investigating now is to make a special SessionID for replay; when the MemoryCache encounters a resource in this session, it will neither return a cache hit nor store an fetched resource into the cache. 994623 2 227861 bburg 2014-03-26 10:35:03 -0700 Created attachment 227861 the patch 994803 3 bburg 2014-03-26 20:39:20 -0700 I will commit this with just the page cache part, so other settings can hook into the common state setup method while I debug problems with the MemoryCache setting. 994805 4 bburg 2014-03-26 20:46:01 -0700 Committed r166337: <http://trac.webkit.org/changeset/166337> 227861 2014-03-26 10:35:03 -0700 2014-03-26 16:22:43 -0700 the patch bug-130672-20140326103442.patch text/plain 4760 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQwNDkwNTcxMzJiOGQ5 YjhiMDc3ZjlhMjRhYTdhNzAyZTM5ZGY1MC4uNmVlMGU4ZTdmNWQwNzdjYzliODg1ZmI3MzcwNTM4 MDNiOTYyMmJkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTAzLTI1ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBSZXBsYXk6IGRpc2FibGUg cGFnZSBjYWNoZSBhbmQgcmVzb3VyY2UgY2FjaGUgZHVyaW5nIGNhcHR1cmUvcmVwbGF5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2NzIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYXZlLCBzZXQsIGFu ZCByZXN0b3JlIGNhY2hlIHNldHRpbmdzIGF0IHRoZSBjb3JyZWN0IHRpbWVzLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gSWYgdGhpcyBjb2RlIGZhaWxzLCB0aGVuIHRoZSB0ZXN0cyBmb3IgbmV0 d29yayByZXBsYXkgd2lsbCBmYWlsLgorCisgICAgICAgICogcmVwbGF5L1JlcGxheUNvbnRyb2xs ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGF5Q29udHJvbGxlcjo6c2V0Rm9yY2VEZXRl cm1pbmlzdGljU2V0dGluZ3MpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlJlcGxheUNvbnRy b2xsZXI6OnN0YXJ0Q2FwdHVyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlJlcGxheUNvbnRyb2xs ZXI6OnN0b3BDYXB0dXJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGF5Q29udHJvbGxlcjo6 Y2FuY2VsUGxheWJhY2spOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGF5Q29udHJvbGxlcjo6cmVw bGF5VG9Qb3NpdGlvbik6CisgICAgICAgICogcmVwbGF5L1JlcGxheUNvbnRyb2xsZXIuaDoKKwor MjAxNC0wMy0yNSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIg UmVwbGF5OiBhZGQgcGFnZS1sZXZlbCBzZXR0aW5nIHRvIGJ5cGFzcyB0aGUgTWVtb3J5Q2FjaGUK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDcyOAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZXBsYXkvUmVwbGF5Q29udHJvbGxlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZXBsYXkvUmVwbGF5Q29udHJvbGxlci5jcHAKaW5kZXggNGYwZjA4 NmY2YWVlMTUzMjM2NDk0MzI1YzAyYzQ5NmQ0ZTA2NDMxYy4uOWJkYTg2NWY3ZTQwNzhkYjgyMzFj ODQ1NzZlYmU5ZjZhZWQyNmU1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVwbGF5L1Jl cGxheUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlcGxheS9SZXBsYXlDb250 cm9sbGVyLmNwcApAQCAtNDQsNiArNDQsNyBAQAogI2luY2x1ZGUgIlJlcGxheVNlc3Npb25TZWdt ZW50LmgiCiAjaW5jbHVkZSAiUmVwbGF5aW5nSW5wdXRDdXJzb3IuaCIKICNpbmNsdWRlICJTY3Jp cHRDb250cm9sbGVyLmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJVc2VySW5w dXRCcmlkZ2UuaCIKICNpbmNsdWRlICJXZWJSZXBsYXlJbnB1dHMuaCIKICNpbmNsdWRlIDxyZXBs YXkvRW1wdHlJbnB1dEN1cnNvci5oPgpAQCAtNjUsNiArNjYsMjIgQEAgUmVwbGF5Q29udHJvbGxl cjo6UmVwbGF5Q29udHJvbGxlcihQYWdlJiBwYWdlKQogewogfQogCit2b2lkIFJlcGxheUNvbnRy b2xsZXI6OnNldEZvcmNlRGV0ZXJtaW5pc3RpY1NldHRpbmdzKGJvb2wgc2hvdWxkRm9yY2UpCit7 CisgICAgQVNTRVJUKHNob3VsZEZvcmNlIF4gKG1fc2Vzc2lvblN0YXRlID09IFNlc3Npb25TdGF0 ZTo6SW5hY3RpdmUpKTsKKworICAgIGlmIChzaG91bGRGb3JjZSkgeworICAgICAgICBtX3NhdmVk U2V0dGluZ3MudXNlc1BhZ2VDYWNoZSA9IG1fcGFnZS5zZXR0aW5ncygpLnVzZXNQYWdlQ2FjaGUo KTsKKyAgICAgICAgbV9zYXZlZFNldHRpbmdzLnVzZXNNZW1vcnlDYWNoZSA9IG1fcGFnZS5zZXR0 aW5ncygpLnVzZXNNZW1vcnlDYWNoZSgpOworCisgICAgICAgIG1fcGFnZS5zZXR0aW5ncygpLnNl dFVzZXNQYWdlQ2FjaGUoZmFsc2UpOworICAgICAgICBtX3BhZ2Uuc2V0dGluZ3MoKS5zZXRVc2Vz TWVtb3J5Q2FjaGUoZmFsc2UpOworICAgIH0gZWxzZSB7CisgICAgICAgIG1fcGFnZS5zZXR0aW5n cygpLnNldFVzZXNQYWdlQ2FjaGUobV9zYXZlZFNldHRpbmdzLnVzZXNQYWdlQ2FjaGUpOworICAg ICAgICBtX3BhZ2Uuc2V0dGluZ3MoKS5zZXRVc2VzTWVtb3J5Q2FjaGUobV9zYXZlZFNldHRpbmdz LnVzZXNNZW1vcnlDYWNoZSk7CisgICAgfQorfQorCiB2b2lkIFJlcGxheUNvbnRyb2xsZXI6OnNl dFNlc3Npb25TdGF0ZShTZXNzaW9uU3RhdGUgc3RhdGUpCiB7CiAgICAgQVNTRVJUKHN0YXRlICE9 IG1fc2Vzc2lvblN0YXRlKTsKQEAgLTE5OSw2ICsyMTYsNyBAQCB2b2lkIFJlcGxheUNvbnRyb2xs ZXI6OnN0YXJ0Q2FwdHVyaW5nKCkKICAgICBBU1NFUlQobV9zZWdtZW50U3RhdGUgPT0gU2VnbWVu dFN0YXRlOjpVbmxvYWRlZCk7CiAKICAgICBzZXRTZXNzaW9uU3RhdGUoU2Vzc2lvblN0YXRlOjpD YXB0dXJpbmcpOworICAgIHNldEZvcmNlRGV0ZXJtaW5pc3RpY1NldHRpbmdzKHRydWUpOwogCiAg ICAgTE9HKFdlYlJlcGxheSwgIiUtMjBzIFN0YXJ0aW5nIGNhcHR1cmUuXG4iLCAiUmVwbGF5Q29u dHJvbGxlciIpOwogICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6Y2FwdHVyZVN0YXJ0ZWQo Jm1fcGFnZSk7CkBAIC0yMTYsNiArMjM0LDcgQEAgdm9pZCBSZXBsYXlDb250cm9sbGVyOjpzdG9w Q2FwdHVyaW5nKCkKICAgICBjb21wbGV0ZVNlZ21lbnQoKTsKIAogICAgIHNldFNlc3Npb25TdGF0 ZShTZXNzaW9uU3RhdGU6OkluYWN0aXZlKTsKKyAgICBzZXRGb3JjZURldGVybWluaXN0aWNTZXR0 aW5ncyhmYWxzZSk7CiAKICAgICBMT0coV2ViUmVwbGF5LCAiJS0yMHMgU3RvcHBpbmcgY2FwdHVy ZS5cbiIsICJSZXBsYXlDb250cm9sbGVyIik7CiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9u OjpjYXB0dXJlU3RvcHBlZCgmbV9wYWdlKTsKQEAgLTI2Myw2ICsyODIsNyBAQCB2b2lkIFJlcGxh eUNvbnRyb2xsZXI6OmNhbmNlbFBsYXliYWNrKCkKICAgICBBU1NFUlQobV9zZWdtZW50U3RhdGUg PT0gU2VnbWVudFN0YXRlOjpMb2FkZWQpOwogICAgIHVubG9hZFNlZ21lbnQoKTsKICAgICBtX3Nl c3Npb25TdGF0ZSA9IFNlc3Npb25TdGF0ZTo6SW5hY3RpdmU7CisgICAgc2V0Rm9yY2VEZXRlcm1p bmlzdGljU2V0dGluZ3MoZmFsc2UpOwogICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6cGxh eWJhY2tGaW5pc2hlZCgmbV9wYWdlKTsKIH0KIApAQCAtMjc0LDggKzI5NCwxMCBAQCB2b2lkIFJl cGxheUNvbnRyb2xsZXI6OnJlcGxheVRvUG9zaXRpb24oY29uc3QgUmVwbGF5UG9zaXRpb24mIHBv c2l0aW9uLCBEaXNwYXRjaAogCiAgICAgbV9kaXNwYXRjaFNwZWVkID0gc3BlZWQ7CiAKLSAgICBp ZiAobV9zZXNzaW9uU3RhdGUgIT0gU2Vzc2lvblN0YXRlOjpSZXBsYXlpbmcpCisgICAgaWYgKG1f c2Vzc2lvblN0YXRlICE9IFNlc3Npb25TdGF0ZTo6UmVwbGF5aW5nKSB7CiAgICAgICAgIHNldFNl c3Npb25TdGF0ZShTZXNzaW9uU3RhdGU6OlJlcGxheWluZyk7CisgICAgICAgIHNldEZvcmNlRGV0 ZXJtaW5pc3RpY1NldHRpbmdzKHRydWUpOworICAgIH0KIAogICAgIGlmIChtX3NlZ21lbnRTdGF0 ZSA9PSBTZWdtZW50U3RhdGU6OlVubG9hZGVkKQogICAgICAgICBsb2FkU2VnbWVudEF0SW5kZXgo cG9zaXRpb24uc2VnbWVudE9mZnNldCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZXBs YXkvUmVwbGF5Q29udHJvbGxlci5oIGIvU291cmNlL1dlYkNvcmUvcmVwbGF5L1JlcGxheUNvbnRy b2xsZXIuaAppbmRleCBjYThjYmQ2MjAzY2NjMzBkMGM2YjNlMmNhNDhiZDA4ZDZkMWY3NjBlLi4y NmQ3N2JkMzc5YTk2NWYxNzcxOWQyNDdhN2NiMTY1YzMwY2ZjMjllIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZXBsYXkvUmVwbGF5Q29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlcGxheS9SZXBsYXlDb250cm9sbGVyLmgKQEAgLTE1MSw2ICsxNTEsMTcgQEAgcHJpdmF0ZToK ICAgICBFdmVudExvb3BJbnB1dERpc3BhdGNoZXImIGRpc3BhdGNoZXIoKSBjb25zdDsKIAogICAg IHZvaWQgc2V0U2Vzc2lvblN0YXRlKFNlc3Npb25TdGF0ZSk7CisgICAgdm9pZCBzZXRGb3JjZURl dGVybWluaXN0aWNTZXR0aW5ncyhib29sKTsKKworICAgIHN0cnVjdCBTYXZlZFNldHRpbmdzIHsK KyAgICAgICAgYm9vbCB1c2VzUGFnZUNhY2hlOworICAgICAgICBib29sIHVzZXNNZW1vcnlDYWNo ZTsKKworICAgICAgICBTYXZlZFNldHRpbmdzKCkKKyAgICAgICAgICAgIDogdXNlc1BhZ2VDYWNo ZShmYWxzZSkKKyAgICAgICAgICAgICwgdXNlc01lbW9yeUNhY2hlKHRydWUpCisgICAgICAgIHsg fQorICAgIH07CiAKICAgICBQYWdlJiBtX3BhZ2U7CiAKQEAgLTE3MCw2ICsxODEsNyBAQCBwcml2 YXRlOgogICAgIFNlc3Npb25TdGF0ZSBtX3Nlc3Npb25TdGF0ZTsKIAogICAgIERpc3BhdGNoU3Bl ZWQgbV9kaXNwYXRjaFNwZWVkOworICAgIFNhdmVkU2V0dGluZ3MgbV9zYXZlZFNldHRpbmdzOwog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=