130671 2014-03-24 08:29:35 -0700 Fix !ENABLE(VIDEO) build 2014-03-24 09:36:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zsborbely.u-szeged webkit-unassigned achristensen commit-queue darin eric.carlson oldest_to_newest 993811 0 zsborbely.u-szeged 2014-03-24 08:29:35 -0700 http://trac.webkit.org/changeset/166085 added #if ENABLE(VIDEO) guard for the whole Source/WebCore/platform/audio/MediaSession.cpp and its header file. Many functions in Internals.cpp (h/idl) used the newly guarded functions, so they should be guarded too. 993813 1 227646 zsborbely.u-szeged 2014-03-24 08:31:50 -0700 Created attachment 227646 Proposed patch 993840 2 227646 commit-queue 2014-03-24 09:36:07 -0700 Comment on attachment 227646 Proposed patch Clearing flags on attachment: 227646 Committed r166172: <http://trac.webkit.org/changeset/166172> 993841 3 commit-queue 2014-03-24 09:36:10 -0700 All reviewed patches have been landed. Closing bug. 227646 2014-03-24 08:31:50 -0700 2014-03-24 09:36:07 -0700 Proposed patch video.patch text/plain 3255 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZjcxMjlkLi4xNjI5MjcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDMtMjQgIFpzb2x0IEJvcmJlbHkgIDx6c2JvcmJlbHkudS1zemVnZWRAcGFydG5l ci5zYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggIUVOQUJMRShWSURFTykgYnVpbGQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDY3MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5nIEVO QUJMRShWSURFTykgZ3VhcmRzIGJlY2F1c2UgbWFueSBmdW5jdGlvbnMgdXNlCisgICAgICAgIHRo ZSBuZXdseSBndWFyZGVkIGZ1bmN0aW9ucy4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxz LmNwcDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5oOgorICAgICAgICAqIHRlc3Rpbmcv SW50ZXJuYWxzLmlkbDoKKwogMjAxNC0wMy0yNCAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5k ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBVcGRhdGUgbmFtZWQg PGdyaWQtbGluZT4gc3ludGF4IHRvIHRoZSBsYXN0IHZlcnNpb24gb2YgdGhlIHNwZWNzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggMTdmMjI5ZC4uZmNiNDFhMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtMjI0NSw2ICsyMjQ1LDcgQEAgdm9pZCBJ bnRlcm5hbHM6OmluaXRpYWxpemVNb2NrTWVkaWFTb3VyY2UoKQogfQogI2VuZGlmCiAKKyNpZiBF TkFCTEUoVklERU8pCiB2b2lkIEludGVybmFsczo6YmVnaW5NZWRpYVNlc3Npb25JbnRlcnJ1cHRp b24oKQogewogICAgIE1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXIoKS5iZWdpbklu dGVycnVwdGlvbigpOwpAQCAtMjMzMCw1ICsyMzMxLDYgQEAgdm9pZCBJbnRlcm5hbHM6OnBvc3RS ZW1vdGVDb250cm9sQ29tbWFuZChjb25zdCBTdHJpbmcmIGNvbW1hbmRTdHJpbmcsIEV4Y2VwdGlv bkMKICAgICAKICAgICBNZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCkuZGlkUmVj ZWl2ZVJlbW90ZUNvbnRyb2xDb21tYW5kKGNvbW1hbmQpOwogfQotICAgIAorI2VuZGlmIC8vIEVO QUJMRShWSURFTykKKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl cm5hbHMuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKaW5kZXggMWFmZjVm ZS4uNjZhZGRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCkBAIC0zMzEsMTIgKzMz MSwxNCBAQCBwdWJsaWM6CiAgICAgdm9pZCBpbml0aWFsaXplTW9ja01lZGlhU291cmNlKCk7CiAj ZW5kaWYKIAorI2lmIEVOQUJMRShWSURFTykKICAgICB2b2lkIGJlZ2luTWVkaWFTZXNzaW9uSW50 ZXJydXB0aW9uKCk7CiAgICAgdm9pZCBlbmRNZWRpYVNlc3Npb25JbnRlcnJ1cHRpb24oY29uc3Qg U3RyaW5nJik7CiAgICAgdm9pZCBhcHBsaWNhdGlvbldpbGxFbnRlckZvcmVncm91bmQoKSBjb25z dDsKICAgICB2b2lkIGFwcGxpY2F0aW9uV2lsbEVudGVyQmFja2dyb3VuZCgpIGNvbnN0OwogICAg IHZvaWQgc2V0TWVkaWFTZXNzaW9uUmVzdHJpY3Rpb25zKGNvbnN0IFN0cmluZyYgbWVkaWFUeXBl LCBjb25zdCBTdHJpbmcmIHJlc3RyaWN0aW9ucywgRXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQg cG9zdFJlbW90ZUNvbnRyb2xDb21tYW5kKGNvbnN0IFN0cmluZyYsIEV4Y2VwdGlvbkNvZGUmKTsK KyNlbmRpZgogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IEludGVybmFscyhEb2N1bWVudCopOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsIGIvU291cmNl L1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsCmluZGV4IGYzMTFiNGEuLjQzOTQ0ZGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwKQEAgLTI4MCwxMCArMjgwLDEwIEBACiAg ICAgCiAgICAgW0NvbmRpdGlvbmFsPU1FRElBX1NPVVJDRV0gdm9pZCBpbml0aWFsaXplTW9ja01l ZGlhU291cmNlKCk7CiAKLSAgICB2b2lkIGJlZ2luTWVkaWFTZXNzaW9uSW50ZXJydXB0aW9uKCk7 Ci0gICAgdm9pZCBlbmRNZWRpYVNlc3Npb25JbnRlcnJ1cHRpb24oRE9NU3RyaW5nIGZsYWdzKTsK LSAgICB2b2lkIGFwcGxpY2F0aW9uV2lsbEVudGVyRm9yZWdyb3VuZCgpOwotICAgIHZvaWQgYXBw bGljYXRpb25XaWxsRW50ZXJCYWNrZ3JvdW5kKCk7Ci0gICAgW1JhaXNlc0V4Y2VwdGlvbl0gdm9p ZCBzZXRNZWRpYVNlc3Npb25SZXN0cmljdGlvbnMoRE9NU3RyaW5nIG1lZGlhVHlwZSwgRE9NU3Ry aW5nIHJlc3RyaWN0aW9ucyk7Ci0gICAgW1JhaXNlc0V4Y2VwdGlvbl0gdm9pZCBwb3N0UmVtb3Rl Q29udHJvbENvbW1hbmQoRE9NU3RyaW5nIGNvbW1hbmQpOworICAgIFtDb25kaXRpb25hbD1WSURF T10gdm9pZCBiZWdpbk1lZGlhU2Vzc2lvbkludGVycnVwdGlvbigpOworICAgIFtDb25kaXRpb25h bD1WSURFT10gdm9pZCBlbmRNZWRpYVNlc3Npb25JbnRlcnJ1cHRpb24oRE9NU3RyaW5nIGZsYWdz KTsKKyAgICBbQ29uZGl0aW9uYWw9VklERU9dIHZvaWQgYXBwbGljYXRpb25XaWxsRW50ZXJGb3Jl Z3JvdW5kKCk7CisgICAgW0NvbmRpdGlvbmFsPVZJREVPXSB2b2lkIGFwcGxpY2F0aW9uV2lsbEVu dGVyQmFja2dyb3VuZCgpOworICAgIFtDb25kaXRpb25hbD1WSURFTywgUmFpc2VzRXhjZXB0aW9u XSB2b2lkIHNldE1lZGlhU2Vzc2lvblJlc3RyaWN0aW9ucyhET01TdHJpbmcgbWVkaWFUeXBlLCBE T01TdHJpbmcgcmVzdHJpY3Rpb25zKTsKKyAgICBbQ29uZGl0aW9uYWw9VklERU8sIFJhaXNlc0V4 Y2VwdGlvbl0gdm9pZCBwb3N0UmVtb3RlQ29udHJvbENvbW1hbmQoRE9NU3RyaW5nIGNvbW1hbmQp OwogfTsK