130669 2014-03-24 08:11:28 -0700 ENABLE(CSS_GRID_LAYOUT) guard for CSSGridLineNamesValue 2014-03-24 10:13:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhodovan.u-szeged webkit-unassigned commit-queue esprehn+autocc glenn gyuyoung.kim jfernandez macpherson menard rego svillar oldest_to_newest 993802 0 mhodovan.u-szeged 2014-03-24 08:11:28 -0700 https://trac.webkit.org/changeset/166157 added new files related to CSS Grid Layout which should be guarded too: - Source/WebCore/css/CSSGridLineNamesValue.cpp - Source/WebCore/css/CSSGridLineNamesValue.h 993805 1 227645 mhodovan.u-szeged 2014-03-24 08:19:08 -0700 Created attachment 227645 Proposed patch 993808 2 227645 ossy 2014-03-24 08:25:06 -0700 Comment on attachment 227645 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=227645&action=review > Source/WebCore/ChangeLog:9 > + https://trac.webkit.org/changeset/166157 added new files > + related to CSS Grid Layout which should be guarded too: > + - Source/WebCore/css/CSSGridLineNamesValue.cpp > + - Source/WebCore/css/CSSGridLineNamesValue.h There is no need for duplicating file names here and adding this long url for the original changeset. 993821 3 227650 mhodovan.u-szeged 2014-03-24 09:02:38 -0700 Created attachment 227650 Proposed patch 993843 4 227650 svillar 2014-03-24 09:42:27 -0700 Comment on attachment 227650 Proposed patch Thanks! 993861 5 227650 commit-queue 2014-03-24 10:13:33 -0700 Comment on attachment 227650 Proposed patch Clearing flags on attachment: 227650 Committed r166176: <http://trac.webkit.org/changeset/166176> 993862 6 commit-queue 2014-03-24 10:13:38 -0700 All reviewed patches have been landed. Closing bug. 227645 2014-03-24 08:19:08 -0700 2014-03-24 09:02:38 -0700 Proposed patch 0001-ENABLE-CSS_GRID_LAYOUT-guard-for-CSSGridLineNamesVal.patch text/plain 2411 mhodovan.u-szeged RnJvbSBiM2M2NTExZjJmOTA1YzE2YTY0OWJkNjRmNTNlMTc4NWI4NTlmOTc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJ0aW4gPGg5NTQ5OTFAc3R1ZC51LXN6ZWdlZC5odT4KRGF0 ZTogTW9uLCAyNCBNYXIgMjAxNCAxNjoxNToyMiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEVOQUJM RShDU1NfR1JJRF9MQVlPVVQpIGd1YXJkIGZvciBDU1NHcmlkTGluZU5hbWVzVmFsdWUKCi0tLQog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAxNyArKysrKysr KysrKysrKysrKwogU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyaWRMaW5lTmFtZXNWYWx1ZS5jcHAg fCAgMiArKwogU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyaWRMaW5lTmFtZXNWYWx1ZS5oICAgfCAg MiArKwogMyBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDRm NzEyOWQuLmUzMjgwODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNC0wMy0yNCAg TWFydGluIEhvZG92YW4gIDxtaG9kb3ZhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRU5B QkxFKENTU19HUklEX0xBWU9VVCkgZ3VhcmQgZm9yIENTU0dyaWRMaW5lTmFtZXNWYWx1ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNjY5CisKKyAg ICAgICAgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE2NjE1NyBhZGRlZCBuZXcg ZmlsZXMKKyAgICAgICAgcmVsYXRlZCB0byBDU1MgR3JpZCBMYXlvdXQgd2hpY2ggc2hvdWxkIGJl IGd1YXJkZWQgdG9vOgorICAgICAgICAtIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5h bWVzVmFsdWUuY3BwCisgICAgICAgIC0gU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyaWRMaW5lTmFt ZXNWYWx1ZS5oCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiBObyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGNzcy9D U1NHcmlkTGluZU5hbWVzVmFsdWUuY3BwOgorICAgICAgICAqIGNzcy9DU1NHcmlkTGluZU5hbWVz VmFsdWUuaDoKKwogMjAxNC0wMy0yNCAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdh bGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBVcGRhdGUgbmFtZWQgPGdyaWQt bGluZT4gc3ludGF4IHRvIHRoZSBsYXN0IHZlcnNpb24gb2YgdGhlIHNwZWNzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVzVmFsdWUuY3BwCmluZGV4IDQwNjg0ZjEuLjUzZDYw MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVzVmFsdWUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVzVmFsdWUuY3BwCkBA IC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiQ1NTR3JpZExp bmVOYW1lc1ZhbHVlLmgiCiAKKyNpZiBFTkFCTEUoQ1NTX0dSSURfTEFZT1VUKQogbmFtZXNwYWNl IFdlYkNvcmUgewogCiBTdHJpbmcgQ1NTR3JpZExpbmVOYW1lc1ZhbHVlOjpjdXN0b21DU1NUZXh0 KCkgY29uc3QKQEAgLTUwLDMgKzUxLDQgQEAgUGFzc1JlZlB0cjxDU1NHcmlkTGluZU5hbWVzVmFs dWU+IENTU0dyaWRMaW5lTmFtZXNWYWx1ZTo6Y2xvbmVGb3JDU1NPTSgpIGNvbnN0CiAKIH0KIAor I2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JpZExpbmVOYW1lc1Zh bHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVlLmgKaW5kZXgg NmE1YjdiNS4uMWIwZDFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyaWRM aW5lTmFtZXNWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVz VmFsdWUuaApAQCAtMzEsNiArMzEsNyBAQAogI2lmbmRlZiBDU1NHcmlkTGluZU5hbWVzVmFsdWVf aAogI2RlZmluZSBDU1NHcmlkTGluZU5hbWVzVmFsdWVfaAogCisjaWYgRU5BQkxFKENTU19HUklE X0xBWU9VVCkKICNpbmNsdWRlICJDU1NWYWx1ZUxpc3QuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1Jl ZlB0ci5oPgogCkBAIC01NiwzICs1Nyw0IEBAIENTU19WQUxVRV9UWVBFX0NBU1RTKENTU0dyaWRM aW5lTmFtZXNWYWx1ZSwgaXNHcmlkTGluZU5hbWVzVmFsdWUoKSk7CiB9CiAKICNlbmRpZgorI2Vu ZGlmCi0tIAoxLjguMS4yCgo= 227650 2014-03-24 09:02:38 -0700 2014-03-24 10:13:33 -0700 Proposed patch 0001-ENABLE-CSS_GRID_LAYOUT-guard-for-CSSGridLineNamesVal.patch text/plain 2163 mhodovan.u-szeged RnJvbSA4NTA3YTE2ZGQxODA3N2IyNTBlMzI5YTljMTA0Y2NlZGI0Zjg3NThiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJ0aW4gPGg5NTQ5OTFAc3R1ZC51LXN6ZWdlZC5odT4KRGF0 ZTogTW9uLCAyNCBNYXIgMjAxNCAxNjo1ODoyNSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEVOQUJM RShDU1NfR1JJRF9MQVlPVVQpIGd1YXJkIGZvciBDU1NHcmlkTGluZU5hbWVzVmFsdWUKCi0tLQog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysr KysrKysKIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVzVmFsdWUuY3BwIHwgIDIg KysKIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVzVmFsdWUuaCAgIHwgIDIgKysK IDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZjcxMjlk Li5lOWYzMjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDMtMjQgIE1hcnRp biBIb2RvdmFuICA8bWhvZG92YW5AaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIEVOQUJMRShD U1NfR1JJRF9MQVlPVVQpIGd1YXJkIGZvciBDU1NHcmlkTGluZU5hbWVzVmFsdWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDY2OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8g bmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVl LmNwcDoKKyAgICAgICAgKiBjc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVlLmg6CisKIDIwMTQtMDMt MjQgIEphdmllciBGZXJuYW5kZXogIDxqZmVybmFuZGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg W0NTUyBHcmlkIExheW91dF0gVXBkYXRlIG5hbWVkIDxncmlkLWxpbmU+IHN5bnRheCB0byB0aGUg bGFzdCB2ZXJzaW9uIG9mIHRoZSBzcGVjcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0dyaWRMaW5lTmFtZXNWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JpZExp bmVOYW1lc1ZhbHVlLmNwcAppbmRleCA0MDY4NGYxLi41M2Q2MDEwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVlLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2lu Y2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNTU0dyaWRMaW5lTmFtZXNWYWx1ZS5oIgogCisj aWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogU3RyaW5n IENTU0dyaWRMaW5lTmFtZXNWYWx1ZTo6Y3VzdG9tQ1NTVGV4dCgpIGNvbnN0CkBAIC01MCwzICs1 MSw0IEBAIFBhc3NSZWZQdHI8Q1NTR3JpZExpbmVOYW1lc1ZhbHVlPiBDU1NHcmlkTGluZU5hbWVz VmFsdWU6OmNsb25lRm9yQ1NTT00oKSBjb25zdAogCiB9CiAKKyNlbmRpZgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU0dyaWRMaW5lTmFtZXNWYWx1ZS5oIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU0dyaWRMaW5lTmFtZXNWYWx1ZS5oCmluZGV4IDZhNWI3YjUuLjFiMGQxYjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkTGluZU5hbWVzVmFsdWUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JpZExpbmVOYW1lc1ZhbHVlLmgKQEAgLTMxLDYgKzMx LDcgQEAKICNpZm5kZWYgQ1NTR3JpZExpbmVOYW1lc1ZhbHVlX2gKICNkZWZpbmUgQ1NTR3JpZExp bmVOYW1lc1ZhbHVlX2gKIAorI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCiAjaW5jbHVkZSAi Q1NTVmFsdWVMaXN0LmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KIApAQCAtNTYsMyAr NTcsNCBAQCBDU1NfVkFMVUVfVFlQRV9DQVNUUyhDU1NHcmlkTGluZU5hbWVzVmFsdWUsIGlzR3Jp ZExpbmVOYW1lc1ZhbHVlKCkpOwogfQogCiAjZW5kaWYKKyNlbmRpZgotLSAKMS44LjEuMgoK