130666 2014-03-24 07:00:44 -0700 ENABLE(VIDEO_TRACK) guard for CSSParserSelector::parsePseudoCueFunctionSelector 2014-03-24 08:27:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhodovan.u-szeged webkit-unassigned benjamin commit-queue esprehn+autocc glenn gyuyoung.kim kling macpherson menard oldest_to_newest 993786 0 mhodovan.u-szeged 2014-03-24 07:00:44 -0700 The implementation of CSSParserSelector::parsePseudoCueFunctionSelector() was moved from Source/WebCore/css/CSSGrammar.y.in to Source/WebCore/css/CSSParserValues.cpp by http://trac.webkit.org/changeset/166094 . This function should be guarded with ENABLE(VIDEO_TRACK) as it was guarded originally. 993788 1 227641 mhodovan.u-szeged 2014-03-24 07:12:00 -0700 Created attachment 227641 Proposed patch 993798 2 227641 kling 2014-03-24 07:59:11 -0700 Comment on attachment 227641 Proposed patch Okelidoki! r=me 993809 3 227641 commit-queue 2014-03-24 08:27:40 -0700 Comment on attachment 227641 Proposed patch Clearing flags on attachment: 227641 Committed r166167: <http://trac.webkit.org/changeset/166167> 993810 4 commit-queue 2014-03-24 08:27:45 -0700 All reviewed patches have been landed. Closing bug. 227641 2014-03-24 07:12:00 -0700 2014-03-24 08:27:40 -0700 Proposed patch 0001-ENABLE-VIDEO_TRACK-guard-for-CSSParserSelector-parse.patch text/plain 2065 mhodovan.u-szeged RnJvbSA5MTA3MTJjMDQxZjNlMDNmMGIyMmZiYzY5NGY3YTUyOWVlMTZiYzg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJ0aW4gPGg5NTQ5OTFAc3R1ZC51LXN6ZWdlZC5odT4KRGF0 ZTogTW9uLCAyNCBNYXIgMjAxNCAxNTowODo0OSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEVOQUJM RShWSURFT19UUkFDSykgZ3VhcmQgZm9yCiBDU1NQYXJzZXJTZWxlY3Rvcjo6cGFyc2VQc2V1ZG9D dWVGdW5jdGlvblNlbGVjdG9yCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgIHwgMTIgKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyVmFs dWVzLmNwcCB8ICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggNGY3MTI5ZC4uMWQzZjFmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDE0LTAzLTI0ICBNYXJ0aW4gSG9kb3ZhbiAgPG1ob2RvdmFuQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBFTkFCTEUoVklERU9fVFJBQ0spIGd1YXJkIGZvciBDU1NQYXJzZXJTZWxlY3Rvcjo6 cGFyc2VQc2V1ZG9DdWVGdW5jdGlvblNlbGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIG5ldyBmdW5jdGlvbmFsaXR5 LgorCisgICAgICAgICogY3NzL0NTU1BhcnNlclZhbHVlcy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDU1NQYXJzZXJTZWxlY3Rvcjo6cGFyc2VQc2V1ZG9DdWVGdW5jdGlvblNlbGVjdG9yKTogRGVs ZXRlZC4KKwogMjAxNC0wMy0yNCAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlh LmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBVcGRhdGUgbmFtZWQgPGdyaWQtbGlu ZT4gc3ludGF4IHRvIHRoZSBsYXN0IHZlcnNpb24gb2YgdGhlIHNwZWNzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyVmFsdWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXJWYWx1ZXMuY3BwCmluZGV4IGQ5ODUxYzcuLjI5MjIyMGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXJWYWx1ZXMuY3BwCkBAIC0xODUsNiArMTg1LDcgQEAgQ1NTUGFyc2Vy U2VsZWN0b3IqIENTU1BhcnNlclNlbGVjdG9yOjpwYXJzZVBzZXVkb0VsZW1lbnRTZWxlY3RvcihD U1NQYXJzZXJTdHJpbmcKICAgICByZXR1cm4gc2VsZWN0b3IucmVsZWFzZSgpOwogfQogCisjaWYg RU5BQkxFKFZJREVPX1RSQUNLKQogQ1NTUGFyc2VyU2VsZWN0b3IqIENTU1BhcnNlclNlbGVjdG9y OjpwYXJzZVBzZXVkb0N1ZUZ1bmN0aW9uU2VsZWN0b3IoY29uc3QgQ1NTUGFyc2VyU3RyaW5nJiBm dW5jdGlvbklkZW50aWZpZXIsIFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8Q1NTUGFyc2VyU2VsZWN0 b3I+PiogcGFyc2VkU2VsZWN0b3JWZWN0b3IpCiB7CiAgICAgQVNTRVJUX1VOVVNFRChmdW5jdGlv bklkZW50aWZpZXIsIFN0cmluZyhmdW5jdGlvbklkZW50aWZpZXIpID09ICJjdWUoIik7CkBAIC0y MDAsNiArMjAxLDcgQEAgQ1NTUGFyc2VyU2VsZWN0b3IqIENTU1BhcnNlclNlbGVjdG9yOjpwYXJz ZVBzZXVkb0N1ZUZ1bmN0aW9uU2VsZWN0b3IoY29uc3QgQ1NTUGEKICAgICBzZWxlY3Rvci0+YWRv cHRTZWxlY3RvclZlY3Rvcigqc2VsZWN0b3JWZWN0b3IpOwogICAgIHJldHVybiBzZWxlY3Rvci5y ZWxlYXNlKCk7CiB9CisjZW5kaWYKIAogQ1NTUGFyc2VyU2VsZWN0b3I6OkNTU1BhcnNlclNlbGVj dG9yKCkKICAgICA6IG1fc2VsZWN0b3Ioc3RkOjptYWtlX3VuaXF1ZTxDU1NTZWxlY3Rvcj4oKSkK LS0gCjEuOC4xLjIKCg==