130660 2014-03-23 23:18:50 -0700 When the mouse is upped after dragged out of shadowDOM, it should lose :active. 2014-03-25 19:30:57 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sh53.lee webkit-unassigned commit-queue esprehn+autocc kangil.han oldest_to_newest 993723 0 sh53.lee 2014-03-23 23:18:50 -0700 This caused a regression after r165037. When we have to clear :active style of shadow DOM, we should clear host's style. 993727 1 227625 sh53.lee 2014-03-24 00:07:31 -0700 Created attachment 227625 Patch 993730 2 227625 darin 2014-03-24 01:07:00 -0700 Comment on attachment 227625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227625&action=review > Source/WebCore/dom/Document.cpp:5844 > + for (Element* curr = oldActiveElement; curr; curr = curr->parentOrShadowHostElement()) { To set these flags we use the render tree. To clear them we are using the DOM tree. I suspect this inconsistency could cause more problems than just this one. 994465 3 sh53.lee 2014-03-25 18:49:23 -0700 Darin, Thanks for your review. I'll check it and upload another patch. 994468 4 227625 jinwoo7.song 2014-03-25 19:00:37 -0700 Comment on attachment 227625 Patch As Darin pointed out, the inconsistent tree traversing between set and clear phase needs to be investigated, but it may be followed in other bug. So I set cq+ for this patch. 994472 5 227625 commit-queue 2014-03-25 19:30:54 -0700 Comment on attachment 227625 Patch Clearing flags on attachment: 227625 Committed r166277: <http://trac.webkit.org/changeset/166277> 994473 6 commit-queue 2014-03-25 19:30:57 -0700 All reviewed patches have been landed. Closing bug. 227625 2014-03-24 00:07:31 -0700 2014-03-25 19:30:54 -0700 Patch bug-130660-20140324160711.patch text/plain 4919 sh53.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY0MWZlOTljOTVkZjc3 MDY3MjQ3M2Q4M2I2NDFjN2Y5M2U4M2NlNC4uYzg0NzQ1OTQ3OTllNmYzMGQ1ZWFkODk1NTEyNzNj NjU5NDI1NWEwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTIzICBTYW5n aHl1cCBMZWUgIDxzaDUzLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBXaGVuIHRoZSBtb3Vz ZSBpcyB1cHBlZCBhZnRlciBkcmFnZ2VkIG91dCBvZiBzaGFkb3dET00sIGl0IHNob3VsZCBsb3Nl IDphY3RpdmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzA2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNhdXNlZCBhIHJlZ3Jlc3Npb24gYWZ0ZXIgcjE2NTAzNy4KKyAgICAgICAgV2hlbiB3 ZSBoYXZlIHRvIGNsZWFyIDphY3RpdmUgc3R5bGUgb2Ygc2hhZG93IERPTSwgd2Ugc2hvdWxkIGNs ZWFyIGhvc3QncyBzdHlsZS4KKyAgICAgICAgVGhpcyBwYXRjaCByZXBsYWNlcyBwYXJlbnRFbGVt ZW50KCkgYnkgcGFyZW50T3JTaGFkb3dIb3N0RWxlbWVudCgpLgorCisgICAgICAgICogZG9tL0Rv Y3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2 ZVN0YXRlKToKKwogMjAxNC0wMy0yMyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAg ICAgICAgIE1vdmUgSFRNTENvbnZlcnRlciBmcm9tIHBsYXRmb3JtL21hYyB0byBlZGl0aW5nL2Nv Y29hLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggN2M2MmMwNzc5MzA3YTQ1NjVhZjZkZThj OTQ5YTlkMTc5MzQzNTAwYy4uZDg4MmQ2MzAwMzM4MWM3NTZhODVjYjJmNWNhM2Q5NTViZDU0NWNi NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC01ODQxLDcgKzU4NDEsNyBAQCB2b2lkIERv Y3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1 ZXN0LCBFbGVtZW50KiBpbgogICAgIEVsZW1lbnQqIG9sZEFjdGl2ZUVsZW1lbnQgPSBtX2FjdGl2 ZUVsZW1lbnQuZ2V0KCk7CiAgICAgaWYgKG9sZEFjdGl2ZUVsZW1lbnQgJiYgIXJlcXVlc3QuYWN0 aXZlKCkpIHsKICAgICAgICAgLy8gV2UgYXJlIGNsZWFyaW5nIHRoZSA6YWN0aXZlIGNoYWluIGJl Y2F1c2UgdGhlIG1vdXNlIGhhcyBiZWVuIHJlbGVhc2VkLgotICAgICAgICBmb3IgKEVsZW1lbnQq IGN1cnIgPSBvbGRBY3RpdmVFbGVtZW50OyBjdXJyOyBjdXJyID0gY3Vyci0+cGFyZW50RWxlbWVu dCgpKSB7CisgICAgICAgIGZvciAoRWxlbWVudCogY3VyciA9IG9sZEFjdGl2ZUVsZW1lbnQ7IGN1 cnI7IGN1cnIgPSBjdXJyLT5wYXJlbnRPclNoYWRvd0hvc3RFbGVtZW50KCkpIHsKICAgICAgICAg ICAgIGN1cnItPnNldEFjdGl2ZShmYWxzZSk7CiAgICAgICAgICAgICBtX3VzZXJBY3Rpb25FbGVt ZW50cy5zZXRJbkFjdGl2ZUNoYWluKGN1cnIsIGZhbHNlKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUy OTdiOTZhOGU5YjYwODViMGUyOTJmNWFiMzE1M2JjMDAzZGE0MTAuLjhhODAwNTY4MmVkNDQ2MTM3 Njg1MmMzM2EwM2JhNjM5ZTM5MTc5YjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wMy0y MyAgU2FuZ2h5dXAgTGVlICA8c2g1My5sZWVAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgV2hlbiB0 aGUgbW91c2UgaXMgdXBwZWQgYWZ0ZXIgZHJhZ2dlZCBvdXQgb2Ygc2hhZG93RE9NLCBpdCBzaG91 bGQgbG9zZSA6YWN0aXZlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTMwNjYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBmYXN0L2Nzcy9ob3Zlci1hY3RpdmUtZHJhZy1leHBlY3RlZC50eHQ6IEFkZGVk IGEgdGVzdCBmb3IgdGV4dGFyZWEuCisgICAgICAgICogZmFzdC9jc3MvaG92ZXItYWN0aXZlLWRy YWcuaHRtbDogVXBkYXRlZC4KKwogMjAxNC0wMy0yMyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGNvZGUgaW4gSFRNTE9iamVjdEVsZW1lbnQgYXR0cmli dXRlIHBhcnNpbmcgdGhhdCBmb3JjZXMgc3R5bGUgcmVzb2x1dGlvbiBhbmQgbGF5b3V0CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ob3Zlci1hY3RpdmUtZHJhZy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ob3Zlci1hY3RpdmUtZHJhZy1leHBlY3RlZC50eHQK aW5kZXggYjQ1MTE2MTMzNTZhNDVkYTZlYTIyNWIzYzhjOGQ3ZjgyOTRhZWVhNi4uMzJhMmE0ZWVm NDZjZmYzNTQ4Mjg0ZmU0MTk3ZWNhYWYxMzFlODg3YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvaG92ZXItYWN0aXZlLWRyYWctZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzL2hvdmVyLWFjdGl2ZS1kcmFnLWV4cGVjdGVkLnR4dApAQCAtMSwzICsxLDQgQEAK KwogRHJhZ2dpbmcgb3V0IG9mIGFuIGVsZW1lbnQgc2hvdWxkIGNhdXNlIGl0IHRvIGxvc2UgOmhv dmVyCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KQEAgLTEyLDYgKzEzLDEwIEBAIFBBU1Mg YmFja2dyb3VuZCBpcyAicmdiKDAsIDI1NSwgMCkiCiBQQVNTIGJhY2tncm91bmQgaXMgInJnYigw LCAwLCAwKSIKIFBBU1MgYmFja2dyb3VuZCBpcyAicmdiKDAsIDAsIDApIgogUEFTUyBiYWNrZ3Jv dW5kIGlzICJyZ2IoMCwgMCwgMCkiCitQQVNTIGJhY2tncm91bmQgaXMgInJnYigyNTUsIDAsIDAp IgorUEFTUyBiYWNrZ3JvdW5kIGlzICJyZ2IoMjU1LCAyNTUsIDApIgorUEFTUyBiYWNrZ3JvdW5k IGlzICJyZ2IoMCwgMjU1LCAwKSIKK1BBU1MgYmFja2dyb3VuZCBpcyAicmdiKDAsIDAsIDApIgog CiAKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvaG92ZXItYWN0aXZlLWRyYWcu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2hvdmVyLWFjdGl2ZS1kcmFnLmh0bWwKaW5kZXgg NDJmN2FmNjNiNmU1ZTkxMzY0NmU1NzMxZjE0N2ZlZDU4MTdhOTc2ZS4uNjc1ODcxOWM2NTVjZjBj YzA2ZmI3ZDViNTk4MjhkMWMxNzZmNWRlZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9j c3MvaG92ZXItYWN0aXZlLWRyYWcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ob3Zl ci1hY3RpdmUtZHJhZy5odG1sCkBAIC0xLDEwICsxLDEwIEBACiA8IURPQ1RZUEUgaHRtbD4KIDxz dHlsZT4KLSAgZGl2IHsgYmFja2dyb3VuZDogcmdiKDAsIDAsIDApOyB9Ci0gIGRpdjpob3ZlciB7 IGJhY2tncm91bmQ6IHJnYigyNTUsIDAsIDApOyB9Ci0gIGRpdjpob3ZlcjphY3RpdmUgeyBiYWNr Z3JvdW5kOiByZ2IoMjU1LCAyNTUsIDApOyB9Ci0gIGRpdjphY3RpdmUgeyBiYWNrZ3JvdW5kOiBy Z2IoMCwgMjU1LCAwKTsgfQotICBkaXYgeworICBkaXYsIHRleHRhcmVhIHsgYmFja2dyb3VuZDog cmdiKDAsIDAsIDApOyB9CisgIGRpdjpob3ZlciwgdGV4dGFyZWE6aG92ZXIgeyBiYWNrZ3JvdW5k OiByZ2IoMjU1LCAwLCAwKTsgfQorICBkaXY6aG92ZXI6YWN0aXZlLCB0ZXh0YXJlYTpob3Zlcjph Y3RpdmUgeyBiYWNrZ3JvdW5kOiByZ2IoMjU1LCAyNTUsIDApOyB9CisgIGRpdjphY3RpdmUsIHRl eHRhcmVhOmFjdGl2ZSB7IGJhY2tncm91bmQ6IHJnYigwLCAyNTUsIDApOyB9CisgIGRpdiwgdGV4 dGFyZWEgewogICAgIHdpZHRoOiAxMDBweDsKICAgICBoZWlnaHQ6IDEwMHB4OwogICAgIGJvcmRl cjogMnB4IHNvbGlkIHJnYigwLCAwLCAyNTUpOwpAQCAtMTQsNiArMTQsNyBAQAogPGJvZHk+CiAg IDxkaXYgaWQ9ImJveCI+PC9kaXY+CiAgIDxkaXYgaWQ9ImJveDIiPjwvZGl2PgorICA8dGV4dGFy ZWEgaWQ9InRleHRhcmVhIj48L3RleHRhcmVhPgogICA8cHJlIGlkPSJkZXNjcmlwdGlvbiI+PC9k aXY+CiAgIDxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgogPC9ib2R5PgpAQCAtNTksNSArNjAsMTgg QEAKICAgICBldmVudFNlbmRlci5tb3VzZVVwKCkKICAgICBzaG91bGRIYXZlQmFja2dyb3VuZChi b3gsICdyZ2IoMCwgMCwgMCknKQogICAgIHNob3VsZEhhdmVCYWNrZ3JvdW5kKGJveDIsICdyZ2Io MCwgMCwgMCknKQorCisgICAgLy8gTW92ZSBpbnRvIHRoZSB0ZXh0YXJlYS4KKyAgICBldmVudFNl bmRlci5tb3VzZU1vdmVUbyg1MCwgMjUwKQorICAgIHNob3VsZEhhdmVCYWNrZ3JvdW5kKHRleHRh cmVhLCAncmdiKDI1NSwgMCwgMCknKQorCisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCkKKyAg ICBzaG91bGRIYXZlQmFja2dyb3VuZCh0ZXh0YXJlYSwgJ3JnYigyNTUsIDI1NSwgMCknKQorCisg ICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oNDAwLCAyNTApCisgICAgc2hvdWxkSGF2ZUJhY2tn cm91bmQodGV4dGFyZWEsICdyZ2IoMCwgMjU1LCAwKScpCisKKyAgICBldmVudFNlbmRlci5tb3Vz ZVVwKCkKKyAgICBzaG91bGRIYXZlQmFja2dyb3VuZCh0ZXh0YXJlYSwgJ3JnYigwLCAwLCAwKScp CiAgIH0KIDwvc2NyaXB0Pgo=