130651 2014-03-23 07:25:04 -0700 WebKit::resistanceForDelta() truncates 'scaleDistance' to integer value using abs() 2014-03-23 22:30:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin thorton oldest_to_newest 993649 0 ddkilzer 2014-03-23 07:25:04 -0700 Compiling WebKit with trunk clang causes this warning: Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:112:28: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value] double scaleDistance = abs(limit - currentScale); ^ Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:112:28: note: use function 'fabs' instead double scaleDistance = abs(limit - currentScale); ^~~ fabs 1 error generated. 993650 1 227608 ddkilzer 2014-03-23 07:26:41 -0700 Created attachment 227608 Patch v1 993662 2 227608 commit-queue 2014-03-23 09:13:16 -0700 Comment on attachment 227608 Patch v1 Clearing flags on attachment: 227608 Committed r166140: <http://trac.webkit.org/changeset/166140> 993663 3 commit-queue 2014-03-23 09:13:19 -0700 All reviewed patches have been landed. Closing bug. 993722 4 thorton 2014-03-23 22:30:13 -0700 Yikes! Thanks for fixing. 227608 2014-03-23 07:26:41 -0700 2014-03-23 09:13:16 -0700 Patch v1 bug-130651-20140323072620.patch text/plain 2213 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDNjOTUxMDE2MTZkYmU3 YTg0NTExNjdmNTY2ZWFkYTY0OWU2MWVhNi4uMjcxMzk3M2RmNGE5ZjFmNmJlMTIzMWU5YjdjM2Uy N2ZkMWU5OWZmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAzLTIzICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0OjpyZXNpc3Rh bmNlRm9yRGVsdGEoKSB0cnVuY2F0ZXMgJ3NjYWxlRGlzdGFuY2UnIHRvIGludGVnZXIgdmFsdWUg dXNpbmcgYWJzKCkKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTMwNjUxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIHRoZSBmb2xs b3dpbmcgYnVpbGQgZmFpbHVyZSB3aXRoIHRydW5rIGNsYW5nOgorCisgICAgICAgICAgICBXZWJL aXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1tOjExMjoyODogZXJy b3I6IHVzaW5nIGludGVnZXIgYWJzb2x1dGUgdmFsdWUgZnVuY3Rpb24gJ2Ficycgd2hlbiBhcmd1 bWVudCBpcyBvZiBmbG9hdGluZyBwb2ludCB0eXBlIFstV2Vycm9yLC1XYWJzb2x1dGUtdmFsdWVd CisgICAgICAgICAgICAgICAgZG91YmxlIHNjYWxlRGlzdGFuY2UgPSBhYnMobGltaXQgLSBjdXJy ZW50U2NhbGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgorICAg ICAgICAgICAgV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5t bToxMTI6Mjg6IG5vdGU6IHVzZSBmdW5jdGlvbiAnZmFicycgaW5zdGVhZAorICAgICAgICAgICAg ICAgIGRvdWJsZSBzY2FsZURpc3RhbmNlID0gYWJzKGxpbWl0IC0gY3VycmVudFNjYWxlKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZmFicworCisgICAgICAgICogVUlQcm9jZXNzL21hYy9W aWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW06CisgICAgICAgIChXZWJLaXQ6OnJlc2lzdGFuY2VG b3JEZWx0YSk6IFVzZSBmYWJzKCkgaW5zdGVhZCBvZiBhYnMoKS4KKwogMjAxNC0wMy0yMyAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCAj aW5jbHVkZXMgYnkgZ2VvbWV0cnkgY2xhc3NlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQppbmRleCBhZjIxZDc4 OTY3M2JkNjA2MzZmZmRhZGM4ZWFkYWE2MTUwOWY2MGMzLi41YzgxMTJkYTM5ZTZhNGFlN2MwOTYx MmE4OGQxNjUzM2UzNzkyYTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQpAQCAtMTA5LDcgKzEwOSw3IEBA IHN0YXRpYyBkb3VibGUgcmVzaXN0YW5jZUZvckRlbHRhKGRvdWJsZSBkZWx0YVNjYWxlLCBkb3Vi bGUgY3VycmVudFNjYWxlKQogCiAgICAgLy8gT3V0c2lkZSBvZiB0aGUgZXh0cmVtZXMsIHJlc2lz dCBmdXJ0aGVyIHNjYWxpbmcuCiAgICAgZG91YmxlIGxpbWl0ID0gY3VycmVudFNjYWxlIDwgbWlu TWFnbmlmaWNhdGlvbiA/IG1pbk1hZ25pZmljYXRpb24gOiBtYXhNYWduaWZpY2F0aW9uOwotICAg IGRvdWJsZSBzY2FsZURpc3RhbmNlID0gYWJzKGxpbWl0IC0gY3VycmVudFNjYWxlKTsKKyAgICBk b3VibGUgc2NhbGVEaXN0YW5jZSA9IGZhYnMobGltaXQgLSBjdXJyZW50U2NhbGUpOwogICAgIGRv dWJsZSBzY2FsZVBlcmNlbnQgPSBzdGQ6Om1pbihzdGQ6Om1heChzY2FsZURpc3RhbmNlIC8gbGlt aXQsIDAuKSwgMS4pOwogICAgIGRvdWJsZSByZXNpc3RhbmNlID0gem9vbU91dFJlc2lzdGFuY2Ug KyBzY2FsZVBlcmNlbnQgKiAoMC4wMSAtIHpvb21PdXRSZXNpc3RhbmNlKTsKIAo=