130650 2014-03-22 23:38:05 -0700 Gotta grow the locals vectors if we are about to do SetLocals beyond the bytecode's numCalleeRegisters 2014-03-23 11:58:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 993639 0 fpizlo 2014-03-22 23:38:05 -0700 Patch forthcoming. <rdar://problem/16122966> 993640 1 227605 fpizlo 2014-03-22 23:40:36 -0700 Created attachment 227605 the patch 993641 2 227605 msaboff 2014-03-22 23:43:56 -0700 Comment on attachment 227605 the patch r=me 993644 3 227605 fpizlo 2014-03-23 00:15:13 -0700 Comment on attachment 227605 the patch This causes a v8-raytrace regression in FTL. I'm investigating. 993671 4 fpizlo 2014-03-23 11:36:01 -0700 Found the issue. FTL::OSRExitCompiler was unintentionally relying on numLocals() to be aligned. Nobody else makes such an assumption. And FTL::OSRExitCompiler only relied on it because its round-up was done by rounding the stack size in bytes up to stackAlignmentRegisters() [sic]. Changing that the stackAlignmentBytes() fixes the bug. I will land with this fix. 993673 5 fpizlo 2014-03-23 11:58:11 -0700 Landed in http://trac.webkit.org/changeset/166142 227605 2014-03-22 23:40:36 -0700 2014-03-23 00:15:08 -0700 the patch blah.patch text/plain 6233 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MTM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE0LTAzLTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg R290dGEgZ3JvdyB0aGUgbG9jYWxzIHZlY3RvcnMgaWYgd2UgYXJlIGFib3V0IHRvIGRvIFNldExv Y2FscyBiZXlvbmQgdGhlIGJ5dGVjb2RlJ3MgbnVtQ2FsbGVlUmVnaXN0ZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2NTAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFByZXZpb3VzbHks IGl0IHdhcyBvbmx5IGluIHRoZSBjYXNlIG9mIGlubGluaW5nIHRoYXQgd2Ugd291bGQgZG8gU2V0 TG9jYWwncyBiZXlvbmQgdGhlCisgICAgICAgIHByZXZpb3VzbHkgZXN0YWJsaXNoZWQgbnVtTG9j YWxzIGxpbWl0LiBCdXQgdGhlbiB3ZSBhZGRlZCBnZW5lcmFsaXplZCBvcF9jYWxsX3ZhcmFyZ3MK KyAgICAgICAgaGFuZGxpbmcsIHdoaWNoIHJlc3VsdHMgaW4gdXMgZW1pdHRpbmcgU2V0TG9jYWxz IHRoYXQgZGlkbid0IHByZXZpb3VzbHkgZXhpc3QgaW4gdGhlCisgICAgICAgIGJ5dGVjb2RlLgor ICAgICAgICAKKyAgICAgICAgVGhpcyBmYWN0b3JzIG91dCB0aGUgaW5saW5lcidzIGVuc3VyZUxv Y2FscyBsb29wIGFuZCBjYWxscyBpdCBmcm9tIG9wX2NhbGxfdmFyYXJncy4KKworICAgICAgICAq IGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQ YXJzZXI6OmVuc3VyZUxvY2Fscyk6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6 OmhhbmRsZUlubGluaW5nKToKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6cGFy c2VCbG9jayk6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlKToKKyAg ICAgICAgKiBydW50aW1lL09wdGlvbnMuaDoKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvY2FsbC12 YXJhcmdzLWZyb20taW5saW5lZC1jb2RlLmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisgICAg ICAgIChiYXIpOgorICAgICAgICAoYmF6KToKKwogMjAxNC0wMy0yMiAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFkanVzdCBzaXplcyBmb3Ig QVJNNjQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2Vy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2Rl UGFyc2VyLmNwcAkocmV2aXNpb24gMTY2MTM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1Niw2ICsxNTYsMTUg QEAgcHJpdmF0ZToKIAogICAgIC8vIEp1c3QgcGFyc2UgZnJvbSBtX2N1cnJlbnRJbmRleCB0byB0 aGUgZW5kIG9mIHRoZSBjdXJyZW50IENvZGVCbG9jay4KICAgICB2b2lkIHBhcnNlQ29kZUJsb2Nr KCk7CisgICAgCisgICAgdm9pZCBlbnN1cmVMb2NhbHModW5zaWduZWQgbmV3TnVtTG9jYWxzKQor ICAgIHsKKyAgICAgICAgaWYgKG5ld051bUxvY2FscyA8PSBtX251bUxvY2FscykKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgbV9udW1Mb2NhbHMgPSBuZXdOdW1Mb2NhbHM7CisgICAgICAg IGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9ncmFwaC5udW1CbG9ja3MoKTsgKytpKQorICAgICAg ICAgICAgbV9ncmFwaC5ibG9jayhpKS0+ZW5zdXJlTG9jYWxzKG5ld051bUxvY2Fscyk7CisgICAg fQogCiAgICAgLy8gSGVscGVyIGZvciBtaW4gYW5kIG1heC4KICAgICBib29sIGhhbmRsZU1pbk1h eChpbnQgcmVzdWx0T3BlcmFuZCwgTm9kZVR5cGUgb3AsIGludCByZWdpc3Rlck9mZnNldCwgaW50 IGFyZ3VtZW50Q291bnRJbmNsdWRpbmdUaGlzKTsKQEAgLTEzNjUsMTMgKzEzNzQsOSBAQCBib29s IEJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVJbmxpbmluZyhOb2RlCiAgICAgCiAgICAgaW50IGlubGlu ZUNhbGxGcmFtZVN0YXJ0ID0gbV9pbmxpbmVTdGFja1RvcC0+cmVtYXBPcGVyYW5kKFZpcnR1YWxS ZWdpc3RlcihyZWdpc3Rlck9mZnNldCkpLm9mZnNldCgpICsgSlNTdGFjazo6Q2FsbEZyYW1lSGVh ZGVyU2l6ZTsKICAgICAKLSAgICAvLyBNYWtlIHN1cmUgdGhhdCB3ZSBoYXZlIGVub3VnaCBsb2Nh bHMuCi0gICAgdW5zaWduZWQgbmV3TnVtTG9jYWxzID0gVmlydHVhbFJlZ2lzdGVyKGlubGluZUNh bGxGcmFtZVN0YXJ0KS50b0xvY2FsKCkgKyAxICsgSlNTdGFjazo6Q2FsbEZyYW1lSGVhZGVyU2l6 ZSArIGNvZGVCbG9jay0+bV9udW1DYWxsZWVSZWdpc3RlcnM7Ci0gICAgaWYgKG5ld051bUxvY2Fs cyA+IG1fbnVtTG9jYWxzKSB7Ci0gICAgICAgIG1fbnVtTG9jYWxzID0gbmV3TnVtTG9jYWxzOwot ICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fZ3JhcGgubnVtQmxvY2tzKCk7ICsraSkK LSAgICAgICAgICAgIG1fZ3JhcGguYmxvY2soaSktPmVuc3VyZUxvY2FscyhuZXdOdW1Mb2NhbHMp OwotICAgIH0KKyAgICBlbnN1cmVMb2NhbHMoCisgICAgICAgIFZpcnR1YWxSZWdpc3Rlcihpbmxp bmVDYWxsRnJhbWVTdGFydCkudG9Mb2NhbCgpICsgMSArCisgICAgICAgIEpTU3RhY2s6OkNhbGxG cmFtZUhlYWRlclNpemUgKyBjb2RlQmxvY2stPm1fbnVtQ2FsbGVlUmVnaXN0ZXJzKTsKICAgICAK ICAgICBzaXplX3QgYXJndW1lbnRQb3NpdGlvblN0YXJ0ID0gbV9ncmFwaC5tX2FyZ3VtZW50UG9z aXRpb25zLnNpemUoKTsKIApAQCAtMjEyNyw2ICsyMTMyLDkgQEAgYm9vbCBCeXRlQ29kZVBhcnNl cjo6cGFyc2VCbG9jayh1bnNpZ25lZAogICAgICAgICBtX2N1cnJlbnRJbnN0cnVjdGlvbiA9IGN1 cnJlbnRJbnN0cnVjdGlvbjsgLy8gU29tZSBtZXRob2RzIHdhbnQgdG8gdXNlIHRoaXMsIGFuZCB3 ZSdkIHJhdGhlciBub3QgdGhyZWFkIGl0IHRocm91Z2ggY2FsbHMuCiAgICAgICAgIE9wY29kZUlE IG9wY29kZUlEID0gaW50ZXJwcmV0ZXItPmdldE9wY29kZUlEKGN1cnJlbnRJbnN0cnVjdGlvbi0+ dS5vcGNvZGUpOwogICAgICAgICAKKyAgICAgICAgaWYgKE9wdGlvbnM6OnZlcmJvc2VERkdCeXRl Q29kZVBhcnNpbmcoKSkKKyAgICAgICAgICAgIGRhdGFMb2coIiAgICBwYXJzaW5nICIsIGN1cnJl bnRDb2RlT3JpZ2luKCksICJcbiIpOworICAgICAgICAKICAgICAgICAgaWYgKG1fZ3JhcGguY29t cGlsYXRpb24oKSkgewogICAgICAgICAgICAgYWRkVG9HcmFwaChDb3VudEV4ZWN1dGlvbiwgT3BJ bmZvKG1fZ3JhcGguY29tcGlsYXRpb24oKS0+ZXhlY3V0aW9uQ291bnRlckZvcigKICAgICAgICAg ICAgICAgICBQcm9maWxlcjo6T3JpZ2luU3RhY2soKm1fdm0tPm1fcGVyQnl0ZWNvZGVQcm9maWxl ciwgbV9jb2RlQmxvY2ssIGN1cnJlbnRDb2RlT3JpZ2luKCkpKSkpOwpAQCAtMjkxMiw2ICsyOTIw LDEwIEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sodW5zaWduZWQKICAgICAgICAg ICAgIHJlZ2lzdGVyT2Zmc2V0ID0gLVdURjo6cm91bmRVcFRvTXVsdGlwbGVPZigKICAgICAgICAg ICAgICAgICBzdGFja0FsaWdubWVudFJlZ2lzdGVycygpLAogICAgICAgICAgICAgICAgIC1yZWdp c3Rlck9mZnNldCk7CisKKyAgICAgICAgICAgIGVuc3VyZUxvY2FscygKKyAgICAgICAgICAgICAg ICBtX2lubGluZVN0YWNrVG9wLT5yZW1hcE9wZXJhbmQoCisgICAgICAgICAgICAgICAgICAgIFZp cnR1YWxSZWdpc3RlcihyZWdpc3Rlck9mZnNldCkpLnRvTG9jYWwoKSk7CiAgICAgICAgICAgICAK ICAgICAgICAgICAgIC8vIFRoZSBieXRlY29kZSB3b3VsZG4ndCBoYXZlIHNldCB1cCB0aGUgYXJn dW1lbnRzLiBCdXQgd2UnbGwgZG8gaXQgYW5kIG1ha2UgaXQKICAgICAgICAgICAgIC8vIGxvb2sg bGlrZSB0aGUgYnl0ZWNvZGUgaGFkIGRvbmUgaXQuCkBAIC0zNTg1LDYgKzM1OTcsOSBAQCBib29s IEJ5dGVDb2RlUGFyc2VyOjpwYXJzZSgpCiAgICAgLy8gU2V0IGR1cmluZyBjb25zdHJ1Y3Rpb24u CiAgICAgQVNTRVJUKCFtX2N1cnJlbnRJbmRleCk7CiAgICAgCisgICAgaWYgKE9wdGlvbnM6OnZl cmJvc2VERkdCeXRlQ29kZVBhcnNpbmcoKSkKKyAgICAgICAgZGF0YUxvZygiUGFyc2luZyAiLCAq bV9jb2RlQmxvY2ssICJcbiIpOworICAgIAogICAgIG1fZGZnQ29kZUJsb2NrID0gbV9ncmFwaC5t X3BsYW4ucHJvZmlsZWRERkdDb2RlQmxvY2suZ2V0KCk7CiAgICAgaWYgKGlzRlRMKG1fZ3JhcGgu bV9wbGFuLm1vZGUpICYmIG1fZGZnQ29kZUJsb2NrKSB7CiAgICAgICAgIGlmIChPcHRpb25zOjpl bmFibGVQb2x5dmFyaWFudENhbGxJbmxpbmluZygpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT3B0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wdGlvbnMuaAkocmV2aXNpb24gMTY2MTM2KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsNiArMTE3LDcg QEAgdHlwZWRlZiBPcHRpb25SYW5nZSBvcHRpb25SYW5nZTsKICAgICB2KG9wdGlvblJhbmdlLCBi eXRlY29kZVJhbmdlVG9ERkdDb21waWxlLCAwKSBcCiAgICAgdihib29sLCBkdW1wQnl0ZWNvZGVB dERGR1RpbWUsIGZhbHNlKSBcCiAgICAgdihib29sLCBkdW1wR3JhcGhBdEVhY2hQaGFzZSwgZmFs c2UpIFwKKyAgICB2KGJvb2wsIHZlcmJvc2VERkdCeXRlQ29kZVBhcnNpbmcsIGZhbHNlKSBcCiAg ICAgdihib29sLCB2ZXJib3NlQ29tcGlsYXRpb24sIGZhbHNlKSBcCiAgICAgdihib29sLCB2ZXJi b3NlRlRMQ29tcGlsYXRpb24sIGZhbHNlKSBcCiAgICAgdihib29sLCBsb2dDb21waWxhdGlvbkNo YW5nZXMsIGZhbHNlKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNz L2NhbGwtdmFyYXJncy1mcm9tLWlubGluZWQtY29kZS5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2NhbGwtdmFyYXJncy1mcm9tLWlubGluZWQtY29k ZS5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mv Y2FsbC12YXJhcmdzLWZyb20taW5saW5lZC1jb2RlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsMjAgQEAKK2Z1bmN0aW9uIGZvbyhhLCBiLCBjLCBkLCBlLCBmLCBnLCBoLCBpLCBqLCBrLCBs LCBtLCBuLCBvLCBwLCBxLCByLCBzLCB0LCB1LCB2LCB3LCB4LCB5LCB6KSB7CisgICAgcmV0dXJu IGEgKiAyICsgYiAqIDMgKyBjICogNSArIGQgKiA3ICsgZSAqIDExICsgZiAqIDEzICsgZyAqIDE3 ICsgaCAqIDE5ICsgaSAqIDIzICsgaiAqIDI5ICsgayAqIDMxICsgbCAqIDM3ICsgbSAqIDQxICsg biAqIDQzICsgbyAqIDQ3ICsgcCAqIDUzICsgcSAqIDU5ICsgciAqIDYxICsgcyAqIDY3ICsgdCAq IDcxICsgdSAqIDczICsgdiAqIDc5ICsgdyAqIDgzICsgeCAqIDg5ICsgeSAqIDk3ICsgeiAqIDEw MTsKK30KKworZnVuY3Rpb24gYmFyKCkgeworICAgIHJldHVybiBmb28uYXBwbHkodGhpcywgYXJn dW1lbnRzKTsKK30KKworZnVuY3Rpb24gYmF6KCkgeworICAgIHJldHVybiBiYXIoMSwgMiwgMywg NCwgNSwgNiwgNywgOCwgOSwgMTAsIDExLCAxMiwgMTMsIDE0LCAxNSwgMTYsIDE3LCAxOCwgMTks IDIwLCAyMSwgMjIsIDIzLCAyNCwgMjUsIDI2KTsKK30KKworbm9JbmxpbmUoYmF6KTsKKworZm9y ICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgKytpKSB7CisgICAgdmFyIHJlc3VsdCA9IGJheigpOwor ICAgIGlmIChyZXN1bHQgIT0gMjE1ODYpCisgICAgICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3Vs dDogIiArIHJlc3VsdDsKK30KKwo=