130649 2014-03-22 20:57:13 -0700 Protect the silent spiller/filler's desire to fill Int32Constants by making sure that we don't mark something as having a Int32 register format if it's a non-Int32 constant 2014-03-22 21:37:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 993621 0 fpizlo 2014-03-22 20:57:13 -0700 Patch forthcoming. <rdar://problem/16399949> 993622 1 227596 fpizlo 2014-03-22 20:58:29 -0700 Created attachment 227596 the patch 993626 2 227596 kling 2014-03-22 21:33:22 -0700 Comment on attachment 227596 the patch rs=me 993629 3 fpizlo 2014-03-22 21:37:05 -0700 Landed in http://trac.webkit.org/changeset/166136 227596 2014-03-22 20:58:29 -0700 2014-03-22 21:33:21 -0700 the patch blah.patch text/plain 3889 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MTM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAzLTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UHJvdGVjdCB0aGUgc2lsZW50IHNwaWxsZXIvZmlsbGVyJ3MgZGVzaXJlIHRvIGZpbGwgSW50MzJD b25zdGFudHMgYnkgbWFraW5nIHN1cmUgdGhhdCB3ZSBkb24ndCBtYXJrIHNvbWV0aGluZyBhcyBo YXZpbmcgYSBJbnQzMiByZWdpc3RlciBmb3JtYXQgaWYgaXQncyBhIG5vbi1JbnQzMiBjb25zdGFu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNjQ5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjM5OTk0OT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0 LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZmlsbFNwZWN1bGF0ZUlu dDMySW50ZXJuYWwpOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZmlsbFNwZWN1bGF0ZUludDMySW50ZXJu YWwpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9mdXp6LWJ1Zy0xNjM5OTk0OS5qczogQWRkZWQu CisgICAgICAgICh0cnlJdE91dC5mKToKKyAgICAgICAgKHRyeUl0T3V0KToKKwogMjAxNC0wMy0y MiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGZpeCBtaXNwZWxsZWQgdGVzdCBuYW1lLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCShyZXZpc2lvbiAxNjYxMzIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03NDMsOSArNzQzLDE1IEBAIEdQUlJlZyBTcGVjdWxhdGl2ZUpJ VDo6ZmlsbFNwZWN1bGF0ZUludDMKICAgICBWaXJ0dWFsUmVnaXN0ZXIgdmlydHVhbFJlZ2lzdGVy ID0gZWRnZS0+dmlydHVhbFJlZ2lzdGVyKCk7CiAgICAgR2VuZXJhdGlvbkluZm8mIGluZm8gPSBn ZW5lcmF0aW9uSW5mb0Zyb21WaXJ0dWFsUmVnaXN0ZXIodmlydHVhbFJlZ2lzdGVyKTsKIAorICAg IGlmIChlZGdlLT5oYXNDb25zdGFudCgpICYmICFpc0ludDMyQ29uc3RhbnQoZWRnZS5ub2RlKCkp KSB7CisgICAgICAgIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKFVuY291bnRhYmxlLCBK U1ZhbHVlUmVncygpLCAwKTsKKyAgICAgICAgcmV0dXJuRm9ybWF0ID0gRGF0YUZvcm1hdEludDMy OworICAgICAgICByZXR1cm4gYWxsb2NhdGUoKTsKKyAgICB9CisgICAgCiAgICAgc3dpdGNoIChp bmZvLnJlZ2lzdGVyRm9ybWF0KCkpIHsKICAgICBjYXNlIERhdGFGb3JtYXROb25lOiB7Ci0gICAg ICAgIGlmICgoZWRnZS0+aGFzQ29uc3RhbnQoKSAmJiAhaXNJbnQzMkNvbnN0YW50KGVkZ2Uubm9k ZSgpKSkgfHwgaW5mby5zcGlsbEZvcm1hdCgpID09IERhdGFGb3JtYXREb3VibGUpIHsKKyAgICAg ICAgaWYgKGluZm8uc3BpbGxGb3JtYXQoKSA9PSBEYXRhRm9ybWF0RG91YmxlKSB7CiAgICAgICAg ICAgICB0ZXJtaW5hdGVTcGVjdWxhdGl2ZUV4ZWN1dGlvbihVbmNvdW50YWJsZSwgSlNWYWx1ZVJl Z3MoKSwgMCk7CiAgICAgICAgICAgICByZXR1cm5Gb3JtYXQgPSBEYXRhRm9ybWF0SW50MzI7CiAg ICAgICAgICAgICByZXR1cm4gYWxsb2NhdGUoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNpb24gMTY2MTMyKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNzU4LDkgKzc1OCwxOSBAQCBHUFJSZWcgU3BlY3VsYXRpdmVKSVQ6OmZp bGxTcGVjdWxhdGVJbnQzCiAgICAgVmlydHVhbFJlZ2lzdGVyIHZpcnR1YWxSZWdpc3RlciA9IGVk Z2UtPnZpcnR1YWxSZWdpc3RlcigpOwogICAgIEdlbmVyYXRpb25JbmZvJiBpbmZvID0gZ2VuZXJh dGlvbkluZm9Gcm9tVmlydHVhbFJlZ2lzdGVyKHZpcnR1YWxSZWdpc3Rlcik7CiAKKyAgICBpZiAo ZWRnZS0+aGFzQ29uc3RhbnQoKSAmJiAhaXNJbnQzMkNvbnN0YW50KGVkZ2Uubm9kZSgpKSkgewor ICAgICAgICAvLyBQcm90ZWN0IHRoZSBzaWxlbnQgc3BpbGwvZmlsbCBsb2dpYyBieSBmYWlsaW5n IGVhcmx5LiBJZiB3ZSAic3BlY3VsYXRlIiBvbgorICAgICAgICAvLyB0aGUgY29uc3RhbnQgdGhl biB0aGUgc2lsZW50IGZpbGxlciBtYXkgdGhpbmsgdGhhdCB3ZSBoYXZlIGFuIGludDMyIGFuZCBh CisgICAgICAgIC8vIGNvbnN0YW50LCBzbyBpdCB3aWxsIHRyeSB0byBmaWxsIHRoaXMgYXMgYW4g aW50MzIgY29uc3RhbnQuIEJhZCB0aGluZ3Mgd2lsbAorICAgICAgICAvLyBoYXBwZW4uCisgICAg ICAgIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKFVuY291bnRhYmxlLCBKU1ZhbHVlUmVn cygpLCAwKTsKKyAgICAgICAgcmV0dXJuRm9ybWF0ID0gRGF0YUZvcm1hdEludDMyOworICAgICAg ICByZXR1cm4gYWxsb2NhdGUoKTsKKyAgICB9CisgICAgCiAgICAgc3dpdGNoIChpbmZvLnJlZ2lz dGVyRm9ybWF0KCkpIHsKICAgICBjYXNlIERhdGFGb3JtYXROb25lOiB7Ci0gICAgICAgIGlmICgo ZWRnZS0+aGFzQ29uc3RhbnQoKSAmJiAhaXNJbnQzMkNvbnN0YW50KGVkZ2Uubm9kZSgpKSkgfHwg aW5mby5zcGlsbEZvcm1hdCgpID09IERhdGFGb3JtYXREb3VibGUpIHsKKyAgICAgICAgaWYgKGlu Zm8uc3BpbGxGb3JtYXQoKSA9PSBEYXRhRm9ybWF0RG91YmxlKSB7CiAgICAgICAgICAgICB0ZXJt aW5hdGVTcGVjdWxhdGl2ZUV4ZWN1dGlvbihVbmNvdW50YWJsZSwgSlNWYWx1ZVJlZ3MoKSwgMCk7 CiAgICAgICAgICAgICByZXR1cm5Gb3JtYXQgPSBEYXRhRm9ybWF0SW50MzI7CiAgICAgICAgICAg ICByZXR1cm4gYWxsb2NhdGUoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9z dHJlc3MvZnV6ei1idWctMTYzOTk5NDkuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3Rlc3RzL3N0cmVzcy9mdXp6LWJ1Zy0xNjM5OTk0OS5qcwkocmV2aXNpb24gMCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZnV6ei1idWctMTYzOTk5NDkuanMJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw5IEBACitmdW5jdGlvbiB0cnlJdE91dCgpCit7Cisg ICAgZnVuY3Rpb24gZigpIHsKKyAgICAgICAgQXJyYXkoIC94Ly5hID0gdGhpcykgKyAiIjsKKyAg ICB9CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwOyBpKyspCisgICAgICAgIGYoKTsKK30K K3RyeUl0T3V0KCk7Cg==