130634 2014-03-21 23:24:15 -0700 Remove Dead Stores from editing directory 2014-03-23 22:17:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue darin oldest_to_newest 993449 0 jinwoo7.song 2014-03-21 23:24:15 -0700 Remove Dead Stores from editing directory which assigning a value to a variable and never reading that value. 993450 1 227536 jinwoo7.song 2014-03-21 23:25:33 -0700 Created attachment 227536 Patch 993490 2 227536 darin 2014-03-22 07:57:15 -0700 Comment on attachment 227536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227536&action=review > Source/WebCore/editing/CompositeEditCommand.cpp:-843 > - gapEnd = std::min(gapEnd, end); I suspect the dead store here indicates a bug. I think that gapLen needs to be recomputed. Instead of removing this line of code, we should add a line of code: gapLen = gapEnd - gapStart; But of course, we also need to construct a test case to demonstrate that the code is incorrect, which could be difficult. 993491 3 darin 2014-03-22 07:57:45 -0700 (In reply to comment #0) > Remove Dead Stores from editing directory which assigning a value to a variable and never reading that value. I assume you are finding these with a tool or compiler warning. Could you specify what compiler this is and what warning option, or what tool? 993705 4 227536 jinwoo7.song 2014-03-23 19:20:21 -0700 Comment on attachment 227536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227536&action=review >> Source/WebCore/editing/CompositeEditCommand.cpp:-843 >> - gapEnd = std::min(gapEnd, end); > > I suspect the dead store here indicates a bug. I think that gapLen needs to be recomputed. Instead of removing this line of code, we should add a line of code: > > gapLen = gapEnd - gapStart; > > But of course, we also need to construct a test case to demonstrate that the code is incorrect, which could be difficult. Then I'll remain this line and make an another bug to follow up this issue. 993706 5 jinwoo7.song 2014-03-23 19:23:31 -0700 (In reply to comment #3) > (In reply to comment #0) > > Remove Dead Stores from editing directory which assigning a value to a variable and never reading that value. > > I assume you are finding these with a tool or compiler warning. Could you specify what compiler this is and what warning option, or what tool? I just run a static analyzer built into Xcode (on Mac). :) 993712 6 227622 jinwoo7.song 2014-03-23 21:41:02 -0700 Created attachment 227622 Patch Do not remove dead store in CompositeEditCommand.cpp according to Darin's comment. I'll make another bug for tracking this one. 993715 7 227536 jinwoo7.song 2014-03-23 21:47:44 -0700 Comment on attachment 227536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227536&action=review >>> Source/WebCore/editing/CompositeEditCommand.cpp:-843 >>> - gapEnd = std::min(gapEnd, end); >> >> I suspect the dead store here indicates a bug. I think that gapLen needs to be recomputed. Instead of removing this line of code, we should add a line of code: >> >> gapLen = gapEnd - gapStart; >> >> But of course, we also need to construct a test case to demonstrate that the code is incorrect, which could be difficult. > > Then I'll remain this line and make an another bug to follow up this issue. Created a bug, https://bugs.webkit.org/show_bug.cgi?id=130658 993719 8 227622 commit-queue 2014-03-23 22:17:00 -0700 Comment on attachment 227622 Patch Clearing flags on attachment: 227622 Committed r166150: <http://trac.webkit.org/changeset/166150> 993720 9 commit-queue 2014-03-23 22:17:04 -0700 All reviewed patches have been landed. Closing bug. 227536 2014-03-21 23:25:33 -0700 2014-03-23 21:47:44 -0700 Patch bug-130634-20140322152509.patch text/plain 2873 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFjYjQyNDcwODYzYjgy ZDE0NjRiOWVjYjlmM2YyOWNlNWI4ZWZmNS4uMDM2NjZiZGUzNzdjY2UxOTM4Njc4MmJjMzcyNjI4 NDQ5NTRlZTc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTIxICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgRGVh ZCBTdG9yZXMgZnJvbSBlZGl0aW5nIGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIERlYWQgU3RvcmVzIGZyb20gZWRpdGluZyBk aXJlY3Rvcnkgd2hpY2ggYXNzaWduaW5nIGEgdmFsdWUgdG8gYSB2YXJpYWJsZQorICAgICAgICBh bmQgbmV2ZXIgcmVhZGluZyB0aGF0IHZhbHVlLgorCisgICAgICAgICogZWRpdGluZy9BcHBseVN0 eWxlQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBseVN0eWxlQ29tbWFuZDo6bWVy Z2VTdGFydFdpdGhQcmV2aW91c0lmSWRlbnRpY2FsKToKKyAgICAgICAgKiBlZGl0aW5nL0NvbXBv c2l0ZUVkaXRDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0ZUVkaXRDb21t YW5kOjpkZWxldGVJbnNpZ25pZmljYW50VGV4dCk6CisgICAgICAgICogZWRpdGluZy9tYXJrdXAu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlTWFya3VwSW50ZXJuYWwpOgorCiAyMDE0LTAz LTE5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAg QnVpbGQgZml4IGZvciBpT1MgYWZ0ZXIgcjE2NTkyNgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L0FwcGx5U3R5bGVDb21tYW5kLmNwcAppbmRleCA4YmIzZGY2ZTgzM2I5ODA2YTlkYmQ5MTIzYzZk MmU2ZTA3ZmM1YTZjLi41MWRjZmE2NzYzYWM4MjZkMWEwYzdmNDgxZTRmYmYxZDljYjYwNThkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcApAQCAtMTI4 NCw3ICsxMjg0LDYgQEAgYm9vbCBBcHBseVN0eWxlQ29tbWFuZDo6bWVyZ2VTdGFydFdpdGhQcmV2 aW91c0lmSWRlbnRpY2FsKGNvbnN0IFBvc2l0aW9uJiBzdGFydCwKICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgICAgICBzdGFydE5vZGUgPSBzdGFydE5vZGUtPnBhcmVudE5vZGUoKTsK LSAgICAgICAgc3RhcnRPZmZzZXQgPSAwOwogICAgIH0KIAogICAgIGlmICghc3RhcnROb2RlLT5p c0VsZW1lbnROb2RlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBv c2l0ZUVkaXRDb21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRp dENvbW1hbmQuY3BwCmluZGV4IDMwNGMyMmQ3Njg5ODdlNzgxMDUwNDcyY2Q2NjcwNzUxODI3OGU5 YjQuLmQxNDFmM2FhOGM0NzM4ZTM1NjJjMGZmZjAyMjUwYWU4MjlmYWIyZTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCkBAIC04NDAsNyAr ODQwLDYgQEAgdm9pZCBDb21wb3NpdGVFZGl0Q29tbWFuZDo6ZGVsZXRlSW5zaWduaWZpY2FudFRl eHQoUGFzc1JlZlB0cjxUZXh0PiB0ZXh0Tm9kZSwgdW4KICAgICAgICAgaW50IGdhcExlbiA9IGdh cEVuZCAtIGdhcFN0YXJ0OwogICAgICAgICBpZiAoaW5kaWNlc0ludGVyc2VjdCAmJiBnYXBMZW4g PiAwKSB7CiAgICAgICAgICAgICBnYXBTdGFydCA9IHN0ZDo6bWF4KGdhcFN0YXJ0LCBzdGFydCk7 Ci0gICAgICAgICAgICBnYXBFbmQgPSBzdGQ6Om1pbihnYXBFbmQsIGVuZCk7CiAgICAgICAgICAg ICBpZiAoc3RyLmlzTnVsbCgpKQogICAgICAgICAgICAgICAgIHN0ciA9IHRleHROb2RlLT5kYXRh KCkuc3Vic3RyaW5nKHN0YXJ0LCBlbmQgLSBzdGFydCk7CiAgICAgICAgICAgICAvLyByZW1vdmUg dGV4dCBpbiB0aGUgZ2FwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1 cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKaW5kZXggZGFiYjE5MDRi Y2IyNjVhOTc1ZGFhNjQ1ZDQ5YTUyOTU5MTYxODA3Zi4uN2Q2YTdmNmJkYmUwYWU1NTVjYTk0NWJk NTI1MTFjMmEyNzg3MjBmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJr dXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcApAQCAtNjI4LDgg KzYyOCw2IEBAIHN0YXRpYyBTdHJpbmcgY3JlYXRlTWFya3VwSW50ZXJuYWwoRG9jdW1lbnQmIGRv Y3VtZW50LCBjb25zdCBSYW5nZSYgcmFuZ2UsIGNvbnN0CiAgICAgICAgICAgICBpZiAobm9kZXMp CiAgICAgICAgICAgICAgICAgbm9kZXMtPmFwcGVuZChhbmNlc3Rvcik7CiAgICAgICAgICAgICAK LSAgICAgICAgICAgIGxhc3RDbG9zZWQgPSBhbmNlc3RvcjsKLSAgICAgICAgICAgIAogICAgICAg ICAgICAgaWYgKGFuY2VzdG9yID09IHNwZWNpYWxDb21tb25BbmNlc3RvcikKICAgICAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgfQo= 227622 2014-03-23 21:41:02 -0700 2014-03-23 22:17:00 -0700 Patch bug-130634-20140324134040.patch text/plain 2028 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY0MWZlOTljOTVkZjc3 MDY3MjQ3M2Q4M2I2NDFjN2Y5M2U4M2NlNC4uYzY5OTYyODViMTE1ODFhZTA5MjBmN2YwZTNmM2I4 OWM5NGJkNDEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTIzICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgRGVh ZCBTdG9yZXMgZnJvbSBlZGl0aW5nIGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgUmVtb3ZlIERlYWQgU3RvcmVzIGZyb20gZWRpdGluZyBkaXJl Y3Rvcnkgd2hpY2ggYXNzaWduaW5nIGEgdmFsdWUgdG8gYSB2YXJpYWJsZQorICAgICAgICBhbmQg bmV2ZXIgcmVhZGluZyB0aGF0IHZhbHVlLgorCisgICAgICAgICogZWRpdGluZy9BcHBseVN0eWxl Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBseVN0eWxlQ29tbWFuZDo6bWVyZ2VT dGFydFdpdGhQcmV2aW91c0lmSWRlbnRpY2FsKToKKyAgICAgICAgKiBlZGl0aW5nL21hcmt1cC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVNYXJrdXBJbnRlcm5hbCk6CisKIDIwMTQtMDMt MjMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIEhUTUxDb252 ZXJ0ZXIgZnJvbSBwbGF0Zm9ybS9tYWMgdG8gZWRpdGluZy9jb2NvYS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNv cmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAKaW5kZXggOGJiM2RmNmU4MzNiOTgwNmE5 ZGJkOTEyM2M2ZDJlNmUwN2ZjNWE2Yy4uNTFkY2ZhNjc2M2FjODI2ZDFhMGM3ZjQ4MWU0ZmJmMWQ5 Y2I2MDU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29t bWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5j cHAKQEAgLTEyODQsNyArMTI4NCw2IEBAIGJvb2wgQXBwbHlTdHlsZUNvbW1hbmQ6Om1lcmdlU3Rh cnRXaXRoUHJldmlvdXNJZklkZW50aWNhbChjb25zdCBQb3NpdGlvbiYgc3RhcnQsCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgc3RhcnROb2RlID0gc3RhcnROb2RlLT5wYXJl bnROb2RlKCk7Ci0gICAgICAgIHN0YXJ0T2Zmc2V0ID0gMDsKICAgICB9CiAKICAgICBpZiAoIXN0 YXJ0Tm9kZS0+aXNFbGVtZW50Tm9kZSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9tYXJrdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCmluZGV4 IGRhYmIxOTA0YmNiMjY1YTk3NWRhYTY0NWQ0OWE1Mjk1OTE2MTgwN2YuLjdkNmE3ZjZiZGJlMGFl NTU1Y2E5NDViZDUyNTExYzJhMjc4NzIwZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvbWFya3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAK QEAgLTYyOCw4ICs2MjgsNiBAQCBzdGF0aWMgU3RyaW5nIGNyZWF0ZU1hcmt1cEludGVybmFsKERv Y3VtZW50JiBkb2N1bWVudCwgY29uc3QgUmFuZ2UmIHJhbmdlLCBjb25zdAogICAgICAgICAgICAg aWYgKG5vZGVzKQogICAgICAgICAgICAgICAgIG5vZGVzLT5hcHBlbmQoYW5jZXN0b3IpOwogICAg ICAgICAgICAgCi0gICAgICAgICAgICBsYXN0Q2xvc2VkID0gYW5jZXN0b3I7Ci0gICAgICAgICAg ICAKICAgICAgICAgICAgIGlmIChhbmNlc3RvciA9PSBzcGVjaWFsQ29tbW9uQW5jZXN0b3IpCiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K