130633 2014-03-21 22:59:01 -0700 Assertions in WebPage::rangeFromEditingRange when requested range location is NSNotFound 2014-03-22 09:51:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap andersca commit-queue darin enrica mark.lam oldest_to_newest 993447 0 ap 2014-03-21 22:59:01 -0700 We are seeing that firstRectFromCharacterRange is sometimes called with an invalid range. <rdar://problem/16397583> 993448 1 227535 ap 2014-03-21 23:02:01 -0700 Created attachment 227535 proposed fix 993503 2 227535 commit-queue 2014-03-22 09:51:28 -0700 Comment on attachment 227535 proposed fix Clearing flags on attachment: 227535 Committed r166115: <http://trac.webkit.org/changeset/166115> 993504 3 commit-queue 2014-03-22 09:51:31 -0700 All reviewed patches have been landed. Closing bug. 227535 2014-03-21 23:02:01 -0700 2014-03-22 09:51:28 -0700 proposed fix NSNotFound.txt text/plain 2913 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjExMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTIxICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbnMgaW4gV2Vi UGFnZTo6cmFuZ2VGcm9tRWRpdGluZ1JhbmdlIHdoZW4gcmVxdWVzdGVkIHJhbmdlIGxvY2F0aW9u IGlzIE5TTm90Rm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMDYzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYzOTc1ODM+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBmaXJzdFJlY3RGb3JDaGFyYWN0ZXJS YW5nZTpjb21wbGV0aW9uSGFuZGxlcjpdKToKKyAgICAgICAgKC1bV0tWaWV3IGZpcnN0UmVjdEZv ckNoYXJhY3RlclJhbmdlOmFjdHVhbFJhbmdlOl0pOgorICAgICAgICBSZXR1cm4gTlNaZXJvUmVj dCwgbGlrZSBOU1RleHRWaWV3IGRvZXMgZm9yIGFueSBsb2NhdGlvbnMgdGhhdCBhcmUgb3V0IG9m IGJvdW5kcy4KKyAgICAgICAgVGhlcmUgaXMgbm8gbmVlZCBmb3IgYSByb3VuZCB0cmlwIHRvIFdl YlByb2Nlc3MgaW4gdGhpcyBjYXNlLgorCiAyMDE0LTAzLTIxICBCZW5qYW1pbiBQb3VsYWluICA8 YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdW1dLMl0gUmVkdWNlIHRoZSB0aWxp bmcgY292ZXJhZ2UgdG8gdGhlIGN1cnJlbnQgcmVjdCBhbmQgMSB0aWxlIHNpemUgYWhlYWQKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9u IDE2NjExMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQko d29ya2luZyBjb3B5KQpAQCAtMTUxOSwxMSArMTUxOSwxNyBAQCAtICh2b2lkKWZpcnN0UmVjdEZv ckNoYXJhY3RlclJhbmdlOihOU1JhCiAgICAgaWYgKCh0aGVSYW5nZS5sb2NhdGlvbiArIHRoZVJh bmdlLmxlbmd0aCA8IHRoZVJhbmdlLmxvY2F0aW9uKSAmJiAodGhlUmFuZ2UubG9jYXRpb24gKyB0 aGVSYW5nZS5sZW5ndGggIT0gMCkpCiAgICAgICAgIHRoZVJhbmdlLmxlbmd0aCA9IDA7CiAKKyAg ICBpZiAodGhlUmFuZ2UubG9jYXRpb24gPT0gTlNOb3RGb3VuZCkgeworICAgICAgICBMT0coVGV4 dElucHV0LCAiICAgIC0+IE5TWmVyb1JlY3QiKTsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXJQ dHIoTlNaZXJvUmVjdCwgdGhlUmFuZ2UpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAg X2RhdGEtPl9wYWdlLT5maXJzdFJlY3RGb3JDaGFyYWN0ZXJSYW5nZUFzeW5jKHRoZVJhbmdlLCBS ZWN0Rm9yQ2hhcmFjdGVyUmFuZ2VDYWxsYmFjazo6Y3JlYXRlKFtzZWxmLCBjb21wbGV0aW9uSGFu ZGxlcl0oYm9vbCBlcnJvciwgY29uc3QgSW50UmVjdCYgcmVjdCwgY29uc3QgRWRpdGluZ1Jhbmdl JiBhY3R1YWxSYW5nZSkgewogICAgICAgICB2b2lkICheY29tcGxldGlvbkhhbmRsZXJCbG9jayko TlNSZWN0LCBOU1JhbmdlKSA9ICh2b2lkICheKShOU1JlY3QsIE5TUmFuZ2UpKWNvbXBsZXRpb25I YW5kbGVyLmdldCgpOwogICAgICAgICBpZiAoZXJyb3IpIHsKICAgICAgICAgICAgIExPRyhUZXh0 SW5wdXQsICIgICAgLi4uZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UgZmFpbGVkLiIpOwotICAg ICAgICAgICAgY29tcGxldGlvbkhhbmRsZXJCbG9jayhOU01ha2VSZWN0KDAsIDAsIDAsIDApLCBO U01ha2VSYW5nZShOU05vdEZvdW5kLCAwKSk7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxl ckJsb2NrKE5TWmVyb1JlY3QsIE5TTWFrZVJhbmdlKE5TTm90Rm91bmQsIDApKTsKICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC0yMDUyLDcgKzIwNTgsMTQgQEAgLSAoTlNSZWN0 KWZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlOihOUwogICAgIC8vICh0eXBlIHNvbWV0aGluZzsg dHJ5IHJhbmdlcyAoMSwgLTEpIGFuZCAoMiwgLTEpLgogICAgIGlmICgodGhlUmFuZ2UubG9jYXRp b24gKyB0aGVSYW5nZS5sZW5ndGggPCB0aGVSYW5nZS5sb2NhdGlvbikgJiYgKHRoZVJhbmdlLmxv Y2F0aW9uICsgdGhlUmFuZ2UubGVuZ3RoICE9IDApKQogICAgICAgICB0aGVSYW5nZS5sZW5ndGgg PSAwOwotICAgIAorCisgICAgaWYgKHRoZVJhbmdlLmxvY2F0aW9uID09IE5TTm90Rm91bmQpIHsK KyAgICAgICAgaWYgKGFjdHVhbFJhbmdlKQorICAgICAgICAgICAgKmFjdHVhbFJhbmdlID0gdGhl UmFuZ2U7CisgICAgICAgIExPRyhUZXh0SW5wdXQsICJmaXJzdFJlY3RGb3JDaGFyYWN0ZXJSYW5n ZTooTlNOb3RGb3VuZCwgJXUpIC0+IE5TWmVyb1JlY3QiLCB0aGVSYW5nZS5sZW5ndGgpOworICAg ICAgICByZXR1cm4gTlNaZXJvUmVjdDsKKyAgICB9CisKICAgICBOU1JlY3QgcmVzdWx0UmVjdCA9 IF9kYXRhLT5fcGFnZS0+Zmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UodGhlUmFuZ2UpOwogICAg IHJlc3VsdFJlY3QgPSBbc2VsZiBjb252ZXJ0UmVjdDpyZXN1bHRSZWN0IHRvVmlldzpuaWxdOwog ICAgIHJlc3VsdFJlY3QgPSBbc2VsZi53aW5kb3cgY29udmVydFJlY3RUb1NjcmVlbjpyZXN1bHRS ZWN0XTsK