<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>130631</bug_id>
          
          <creation_ts>2014-03-21 20:20:38 -0700</creation_ts>
          <short_desc>[iOS][WK2] Micro-optimize view state updates on the UIProcess side</short_desc>
          <delta_ts>2014-03-24 14:04:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>andersca</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>993428</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2014-03-21 20:20:38 -0700</bug_when>
    <thetext>[iOS][WK2] Micro-optimize view state updates on the UIProcess side</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993431</commentid>
    <comment_count>1</comment_count>
      <attachid>227528</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2014-03-21 20:23:14 -0700</bug_when>
    <thetext>Created attachment 227528
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993494</commentid>
    <comment_count>2</comment_count>
      <attachid>227528</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2014-03-22 08:03:01 -0700</bug_when>
    <thetext>Comment on attachment 227528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227528&amp;action=review

&gt; Source/WebKit2/UIProcess/ios/WKContentView.mm:240
&gt; +    return (FloatRect)FrameView::rectForViewportConstrainedObjects(enclosingLayoutRect(unobscuredRect), roundedLayoutSize(FloatSize(documentSize)), scale, false, StickToViewportBounds);

What is the (FloatRect) here for? Doesn’t this compile without it?

Also, why FloatSize(documentSize)? Doesn’t this compile without the explicit FloatSize()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993927</commentid>
    <comment_count>3</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2014-03-24 12:43:32 -0700</bug_when>
    <thetext>Thanks for the review!

(In reply to comment #2) 
&gt; What is the (FloatRect) here for? Doesn’t this compile without it?

No idea, I&apos;ll try.

&gt; Also, why FloatSize(documentSize)? Doesn’t this compile without the explicit FloatSize()?

The conversions between native types and WebCore types are explicit when they have side effects.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993953</commentid>
    <comment_count>4</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2014-03-24 13:51:40 -0700</bug_when>
    <thetext>Committed r166188: &lt;http://trac.webkit.org/changeset/166188&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993964</commentid>
    <comment_count>5</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-03-24 14:04:12 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 227528 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=227528&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/ios/WKContentView.mm:240
&gt; &gt; +    return (FloatRect)FrameView::rectForViewportConstrainedObjects(enclosingLayoutRect(unobscuredRect), roundedLayoutSize(FloatSize(documentSize)), scale, false, StickToViewportBounds);
&gt; 

Can we put this code somewhere else instead of on FrameView? It&apos;s very awkward to have UI process code call member functions on FrameView.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227528</attachid>
            <date>2014-03-21 20:23:14 -0700</date>
            <delta_ts>2014-03-22 08:03:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130631-20140321202252.patch</filename>
            <type>text/plain</type>
            <size>7519</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTIwNGY3ODhmMzhkMDAz
MmJlOWE1OWQ4N2Y5Y2Q1NGE1MDBhZDlhOS4uNTM5ZTFiZmFmM2IzZjJmOWUyYzdlYzkwM2Y3Njdl
NDVkYTQ0MTBhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTAzLTIxICBCZW5q
YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdW1dLMl0g
TWljcm8tb3B0aW1pemUgdmlldyBzdGF0ZSB1cGRhdGVzIG9uIHRoZSBVSVByb2Nlc3Mgc2lkZQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNjMxCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nl
c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKGNvbnRlbnRab29tU2NhbGUpOgor
ICAgICAgICBbVUlTY3JvbGxWaWV3IHpvb21TY2FsZV0gaXMgbm90IGZhc3QgZW5vdWdoIGZvciAt
W1dLV2ViVmlldyBfdXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0c10uIFNpbmNlIHdlIGtub3cgd2hh
dCB0aGUgem9vbSB2aWV3IGlzLAorICAgICAgICBtYWtlIGEgZmFzdCB2ZXJzaW9uIGhhcmRjb2Rp
bmcgdGhhdC4KKworICAgICAgICAoLVtXS1dlYlZpZXcgX3VwZGF0ZVNjcm9sbFZpZXdCYWNrZ3Jv
dW5kXSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfem9vbVRvUG9pbnQ6V2ViQ29yZTo6YXRTY2Fs
ZTpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zY3JvbGxUb1JlY3Q6V2ViQ29yZTo6b3JpZ2lu
OldlYkNvcmU6Om1pbmltdW1TY3JvbGxEaXN0YW5jZTpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3
IF96b29tVG9SZWN0OldlYkNvcmU6OndpdGhPcmlnaW46V2ViQ29yZTo6Zml0RW50aXJlUmVjdDpt
aW5pbXVtU2NhbGU6bWF4aW11bVNjYWxlOm1pbmltdW1TY3JvbGxEaXN0YW5jZTpdKToKKyAgICAg
ICAgKC1bV0tXZWJWaWV3IF91cGRhdGVWaXNpYmxlQ29udGVudFJlY3RzXSk6CisgICAgICAgICog
VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tOgorICAgICAgICAoZml4ZWRQb3NpdGlvblJl
Y3RGcm9tRXhwb3NlZFJlY3QpOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGRpZFVwZGF0ZVZp
c2libGVSZWN0OnVub2JzY3VyZWRSZWN0OnNjYWxlOmluU3RhYmxlU3RhdGU6XSk6CisKKzIwMTQt
MDMtMjEgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisKICAgICAgICAg
W1dLMl0gTWFrZSB1cGRhdGVzIG9uIFZpZXdVcGRhdGVEaXNwYXRjaGVyIGxlc3MgaGVhdnkKICAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDYyNgogCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t
bSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4
IDYyMTY2MGI3MzM1ZDY5MDNiNmU5MjY4NGE3NDIxZmMyZTlkNDgwMmIuLmZlNmYxMWE1ZTYwMzli
NjZkYTc5MmM4NGQwYzQyMjNlMzg1ZmQ1NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0zODUsMTMgKzM4NSwyOCBAQAogICAgIHJl
dHVybiBbVUlDb2xvciBjb2xvcldpdGhSZWQ6KGNvbG9yLnJlZCgpIC8gMjU1LjApIGdyZWVuOihj
b2xvci5ncmVlbigpIC8gMjU1LjApIGJsdWU6KGNvbG9yLmJsdWUoKSAvIDI1NS4wKSBhbHBoYToo
Y29sb3IuYWxwaGEoKSAvIDI1NS4wKV07CiB9CiAKK3N0YXRpYyBDR0Zsb2F0IGNvbnRlbnRab29t
U2NhbGUoV0tXZWJWaWV3KiB3ZWJWaWV3KQoreworICAgIFVJVmlldyAqem9vbVZpZXc7CisgICAg
aWYgKHdlYlZpZXctPl9jdXN0b21Db250ZW50VmlldykKKyAgICAgICAgem9vbVZpZXcgPSB3ZWJW
aWV3LT5fY3VzdG9tQ29udGVudFZpZXcuZ2V0KCk7CisgICAgZWxzZQorICAgICAgICB6b29tVmll
dyA9IHdlYlZpZXctPl9jb250ZW50Vmlldy5nZXQoKTsKKworICAgIENHRmxvYXQgc2NhbGUgPSBb
W3pvb21WaWV3IGxheWVyXSBhZmZpbmVUcmFuc2Zvcm1dLmE7CisgICAgQVNTRVJUKHNjYWxlID09
IFt3ZWJWaWV3LT5fc2Nyb2xsVmlldyB6b29tU2NhbGVdKTsKKyAgICByZXR1cm4gc2NhbGU7Cit9
CisKIC0gKHZvaWQpX3VwZGF0ZVNjcm9sbFZpZXdCYWNrZ3JvdW5kCiB7CiAgICAgVUlDb2xvciAq
cGFnZUV4dGVuZGVkQmFja2dyb3VuZENvbG9yID0gW3NlbGYgcGFnZUV4dGVuZGVkQmFja2dyb3Vu
ZENvbG9yXTsKIAotICAgIGlmIChbX3Njcm9sbFZpZXcgem9vbVNjYWxlXSA8IFtfc2Nyb2xsVmll
dyBtaW5pbXVtWm9vbVNjYWxlXSkgeworICAgIENHRmxvYXQgem9vbVNjYWxlID0gY29udGVudFpv
b21TY2FsZShzZWxmKTsKKyAgICBDR0Zsb2F0IG1pbmltdW1ab29tU2NhbGUgPSBbX3Njcm9sbFZp
ZXcgbWluaW11bVpvb21TY2FsZV07CisgICAgaWYgKHpvb21TY2FsZSA8IG1pbmltdW1ab29tU2Nh
bGUpIHsKICAgICAgICAgQ0dGbG9hdCBzbG9wZSA9IDEyOwotICAgICAgICBDR0Zsb2F0IG9wYWNp
dHkgPSBzdGQ6Om1heCgxIC0gc2xvcGUgKiAoW19zY3JvbGxWaWV3IG1pbmltdW1ab29tU2NhbGVd
IC0gW19zY3JvbGxWaWV3IHpvb21TY2FsZV0pLCBzdGF0aWNfY2FzdDxDR0Zsb2F0PigwKSk7Cisg
ICAgICAgIENHRmxvYXQgb3BhY2l0eSA9IHN0ZDo6bWF4KDEgLSBzbG9wZSAqIChtaW5pbXVtWm9v
bVNjYWxlIC0gem9vbVNjYWxlKSwgc3RhdGljX2Nhc3Q8Q0dGbG9hdD4oMCkpOwogICAgICAgICBw
YWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IgPSBbcGFnZUV4dGVuZGVkQmFja2dyb3VuZENvbG9y
IGNvbG9yV2l0aEFscGhhQ29tcG9uZW50Om9wYWNpdHldOwogICAgIH0KIApAQCAtNDM4LDkgKzQ1
MywxMCBAQAogICAgIGRvdWJsZSBtaW5pbXVtWm9vbUR1cmF0aW9uID0gMC4xOwogICAgIGRvdWJs
ZSB6b29tRHVyYXRpb25GYWN0b3IgPSAwLjM7CiAKLSAgICBDRlRpbWVJbnRlcnZhbCBkdXJhdGlv
biA9IHN0ZDo6bWluKGZhYnMobG9nKFtfc2Nyb2xsVmlldyB6b29tU2NhbGVdKSAtIGxvZyhzY2Fs
ZSkpICogem9vbUR1cmF0aW9uRmFjdG9yICsgbWluaW11bVpvb21EdXJhdGlvbiwgbWF4aW11bVpv
b21EdXJhdGlvbik7CisgICAgQ0dGbG9hdCB6b29tU2NhbGUgPSBjb250ZW50Wm9vbVNjYWxlKHNl
bGYpOworICAgIENGVGltZUludGVydmFsIGR1cmF0aW9uID0gc3RkOjptaW4oZmFicyhsb2coem9v
bVNjYWxlKSAtIGxvZyhzY2FsZSkpICogem9vbUR1cmF0aW9uRmFjdG9yICsgbWluaW11bVpvb21E
dXJhdGlvbiwgbWF4aW11bVpvb21EdXJhdGlvbik7CiAKLSAgICBpZiAoc2NhbGUgIT0gW19zY3Jv
bGxWaWV3IHpvb21TY2FsZV0pCisgICAgaWYgKHNjYWxlICE9IHpvb21TY2FsZSkKICAgICAgICAg
W19jb250ZW50VmlldyB3aWxsU3RhcnRVc2VyVHJpZ2dlcmVkWm9vbV07CiAKICAgICBbX3Njcm9s
bFZpZXcgX3pvb21Ub0NlbnRlcjpwb2ludCBzY2FsZTpzY2FsZSBkdXJhdGlvbjpkdXJhdGlvbl07
CkBAIC01MDAsNyArNTE2LDcgQEAgc3RhdGljIFdlYkNvcmU6OkZsb2F0UG9pbnQgY29uc3RyYWlu
Q29udGVudE9mZnNldChXZWJDb3JlOjpGbG9hdFBvaW50IGNvbnRlbnRPZmYKICAgICB9CiAKICAg
ICBXZWJDb3JlOjpGbG9hdFNpemUgc2Nyb2xsVmlld09mZnNldERlbHRhID0gbmV3VW5vYnNjdXJl
ZENvbnRlbnRPZmZzZXQgLSB1bm9ic2N1cmVkQ29udGVudE9mZnNldDsKLSAgICBzY3JvbGxWaWV3
T2Zmc2V0RGVsdGEuc2NhbGUoW19zY3JvbGxWaWV3IHpvb21TY2FsZV0pOworICAgIHNjcm9sbFZp
ZXdPZmZzZXREZWx0YS5zY2FsZShjb250ZW50Wm9vbVNjYWxlKHNlbGYpKTsKIAogICAgIGZsb2F0
IHNjcm9sbERpc3RhbmNlID0gc2Nyb2xsVmlld09mZnNldERlbHRhLmRpYWdvbmFsTGVuZ3RoKCk7
CiAgICAgaWYgKHNjcm9sbERpc3RhbmNlIDwgbWluaW11bVNjcm9sbERpc3RhbmNlKQpAQCAtNTE5
LDcgKzUzNSw3IEBAIHN0YXRpYyBXZWJDb3JlOjpGbG9hdFBvaW50IGNvbnN0cmFpbkNvbnRlbnRP
ZmZzZXQoV2ViQ29yZTo6RmxvYXRQb2ludCBjb250ZW50T2ZmCiB7CiAgICAgY29uc3QgZmxvYXQg
bWF4aW11bVNjYWxlRmFjdG9yRGVsdGFGb3JQYW5TY3JvbGwgPSAwLjAyOwogCi0gICAgZG91Ymxl
IGN1cnJlbnRTY2FsZSA9IFtfc2Nyb2xsVmlldyB6b29tU2NhbGVdOworICAgIGRvdWJsZSBjdXJy
ZW50U2NhbGUgPSBjb250ZW50Wm9vbVNjYWxlKHNlbGYpOwogCiAgICAgV2ViQ29yZTo6RmxvYXRT
aXplIHVub2JzY3VyZWRDb250ZW50U2l6ZShbc2VsZiBfY29udGVudFJlY3RGb3JVc2VySW50ZXJh
Y3Rpb25dLnNpemUpOwogICAgIGRvdWJsZSBob3Jpem9udGFsU2NhbGUgPSB1bm9ic2N1cmVkQ29u
dGVudFNpemUud2lkdGgoKSAqIGN1cnJlbnRTY2FsZSAvIHRhcmdldFJlY3Qud2lkdGgoKTsKQEAg
LTY1NCw3ICs2NzAsNyBAQCBzdGF0aWMgV2ViQ29yZTo6RmxvYXRQb2ludCBjb25zdHJhaW5Db250
ZW50T2Zmc2V0KFdlYkNvcmU6OkZsb2F0UG9pbnQgY29udGVudE9mZgogICAgIENHUmVjdCB1bm9i
c2N1cmVkUmVjdCA9IFVJRWRnZUluc2V0c0luc2V0UmVjdChmdWxsVmlld1JlY3QsIF9vYnNjdXJl
ZEluc2V0cyk7CiAgICAgQ0dSZWN0IHVub2JzY3VyZWRSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMg
PSBbc2VsZiBjb252ZXJ0UmVjdDp1bm9ic2N1cmVkUmVjdCB0b1ZpZXc6X2NvbnRlbnRWaWV3Lmdl
dCgpXTsKIAotICAgIENHRmxvYXQgc2NhbGVGYWN0b3IgPSBbX3Njcm9sbFZpZXcgem9vbVNjYWxl
XTsKKyAgICBDR0Zsb2F0IHNjYWxlRmFjdG9yID0gY29udGVudFpvb21TY2FsZShzZWxmKTsKIAog
ICAgIEJPT0wgaXNTdGFibGVTdGF0ZSA9ICEoX2lzQ2hhbmdpbmdPYnNjdXJlZEluc2V0c0ludGVy
YWN0aXZlbHkgfHwgW19zY3JvbGxWaWV3IGlzRHJhZ2dpbmddIHx8IFtfc2Nyb2xsVmlldyBpc0Rl
Y2VsZXJhdGluZ10gfHwgW19zY3JvbGxWaWV3IGlzWm9vbWluZ10gfHwgW19zY3JvbGxWaWV3IGlz
Wm9vbUJvdW5jaW5nXSB8fCBbX3Njcm9sbFZpZXcgX2lzQW5pbWF0aW5nWm9vbV0pOwogICAgIFtf
Y29udGVudFZpZXcgZGlkVXBkYXRlVmlzaWJsZVJlY3Q6dmlzaWJsZVJlY3RJbkNvbnRlbnRDb29y
ZGluYXRlcyB1bm9ic2N1cmVkUmVjdDp1bm9ic2N1cmVkUmVjdEluQ29udGVudENvb3JkaW5hdGVz
IHNjYWxlOnNjYWxlRmFjdG9yIGluU3RhYmxlU3RhdGU6aXNTdGFibGVTdGF0ZV07CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggMGEyMmNhNGU1
NDVkMjdiMzcxYWNhMTRjYjBiNWZlYzFhMTYzMTU5NS4uY2JhMDk2Nzc2NGZhNGJiNDk0MjA3OGI5
ODcxYzE2N2FjMzI4ZGMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv
cy9XS0NvbnRlbnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD
b250ZW50Vmlldy5tbQpAQCAtMjM1LDYgKzIzNSwxMSBAQCBwcml2YXRlOgogICAgIHJldHVybiBb
c2VsZiBpc0VkaXRhYmxlXTsKIH0KIAorc3RhdGljIGlubGluZSBGbG9hdFJlY3QgZml4ZWRQb3Np
dGlvblJlY3RGcm9tRXhwb3NlZFJlY3QoQ0dSZWN0IHVub2JzY3VyZWRSZWN0LCBDR1NpemUgZG9j
dW1lbnRTaXplLCBDR0Zsb2F0IHNjYWxlKQoreworICAgIHJldHVybiAoRmxvYXRSZWN0KUZyYW1l
Vmlldzo6cmVjdEZvclZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzKGVuY2xvc2luZ0xheW91dFJl
Y3QodW5vYnNjdXJlZFJlY3QpLCByb3VuZGVkTGF5b3V0U2l6ZShGbG9hdFNpemUoZG9jdW1lbnRT
aXplKSksIHNjYWxlLCBmYWxzZSwgU3RpY2tUb1ZpZXdwb3J0Qm91bmRzKTsKK30KKwogLSAodm9p
ZClkaWRVcGRhdGVWaXNpYmxlUmVjdDooQ0dSZWN0KXZpc2libGVSZWN0IHVub2JzY3VyZWRSZWN0
OihDR1JlY3QpdW5vYnNjdXJlZFJlY3Qgc2NhbGU6KENHRmxvYXQpem9vbVNjYWxlIGluU3RhYmxl
U3RhdGU6KEJPT0wpaXNTdGFibGVTdGF0ZQogewogICAgIGRvdWJsZSB0aW1lc3RhbXAgPSBtb25v
dG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsKQEAgLTI1Miw3ICsyNTcsNyBAQCBwcml2YXRlOgog
ICAgICAgICBmaWx0ZXJlZFNjYWxlID0gX3BhZ2UtPmRpc3BsYXllZENvbnRlbnRTY2FsZSgpOwog
ICAgIH0KIAotICAgIENHUmVjdCBjdXN0b21GaXhlZFBvc2l0aW9uUmVjdCA9IFtzZWxmIGZpeGVk
UG9zaXRpb25SZWN0RnJvbUV4cG9zZWRSZWN0OnVub2JzY3VyZWRSZWN0IHNjYWxlOnpvb21TY2Fs
ZV07CisgICAgRmxvYXRSZWN0IGN1c3RvbUZpeGVkUG9zaXRpb25SZWN0ID0gZml4ZWRQb3NpdGlv
blJlY3RGcm9tRXhwb3NlZFJlY3QodW5vYnNjdXJlZFJlY3QsIFtzZWxmIGJvdW5kc10uc2l6ZSwg
em9vbVNjYWxlKTsKICAgICBfcGFnZS0+dXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0cyhWaXNpYmxl
Q29udGVudFJlY3RVcGRhdGVJbmZvKF9wYWdlLT5uZXh0VmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRl
SUQoKSwgdmlzaWJsZVJlY3QsIHVub2JzY3VyZWRSZWN0LCBjdXN0b21GaXhlZFBvc2l0aW9uUmVj
dCwgZmlsdGVyZWRTY2FsZSwgaXNTdGFibGVTdGF0ZSwgdGltZXN0YW1wLCB2ZWxvY2l0eS53aWR0
aCwgdmVsb2NpdHkuaGVpZ2h0KSk7CiAgICAgCiAgICAgUmVtb3RlU2Nyb2xsaW5nQ29vcmRpbmF0
b3JQcm94eSogc2Nyb2xsaW5nQ29vcmRpbmF0b3IgPSBfcGFnZS0+c2Nyb2xsaW5nQ29vcmRpbmF0
b3JQcm94eSgpOwpAQCAtMjY3LDExICsyNzIsNiBAQCBwcml2YXRlOgogICAgIF9wYWdlLT5kcmF3
aW5nQXJlYSgpLT5zZXRTaXplKEludFNpemUoc2l6ZSksIEludFNpemUoKSwgSW50U2l6ZSgpKTsK
IH0KIAotLSAoQ0dSZWN0KWZpeGVkUG9zaXRpb25SZWN0RnJvbUV4cG9zZWRSZWN0OihDR1JlY3Qp
dW5vYnNjdXJlZFJlY3Qgc2NhbGU6KENHRmxvYXQpc2NhbGUKLXsKLSAgICByZXR1cm4gKEZsb2F0
UmVjdClGcmFtZVZpZXc6OnJlY3RGb3JWaWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0cyhlbmNsb3Np
bmdMYXlvdXRSZWN0KHVub2JzY3VyZWRSZWN0KSwgcm91bmRlZExheW91dFNpemUoRmxvYXRTaXpl
KFtzZWxmIGJvdW5kc10uc2l6ZSkpLCBzY2FsZSwgZmFsc2UsIFN0aWNrVG9WaWV3cG9ydEJvdW5k
cyk7Ci19Ci0KIC0gKHZvaWQpc2V0TWluaW11bUxheW91dFNpemU6KENHU2l6ZSlzaXplCiB7CiAg
ICAgX3BhZ2UtPnNldFZpZXdwb3J0Q29uZmlndXJhdGlvbk1pbmltdW1MYXlvdXRTaXplKEludFNp
emUoQ0dDZWlsaW5nKHNpemUud2lkdGgpLCBDR0NlaWxpbmcoc2l6ZS5oZWlnaHQpKSk7Cg==
</data>
<flag name="review"
          id="251774"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>