130629 2014-03-21 18:58:02 -0700 Would like the style bot to prohibit #include layering violations 2023-02-28 12:58:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW InRadar P2 Normal --- 1 ggaren webkit-unassigned ossy simon.fraser zan oldest_to_newest 993413 0 ggaren 2014-03-21 18:58:02 -0700 Some #includes are obvious layering violations. For example, no file in WebCore/platform should ever #include any WebCore file outside WebCore/platform. It would be nice to codify this in a simple script. See, for a motivating example, https://bugs.webkit.org/show_bug.cgi?id=130275. 993414 1 ggaren 2014-03-21 18:58:18 -0700 <rdar://problem/16393051> 993689 2 zan 2014-03-23 13:20:07 -0700 Should we start generating separate forwarding headers for the platform layer? Cross-inclusion of <Platform/Header.h> in WebCore would be allowed at first, but it would extremely simplify locating these layering violations. 993692 3 zan 2014-03-23 13:39:57 -0700 (In reply to comment #2) > Cross-inclusion of <Platform/Header.h> in WebCore would be allowed at first, but it would extremely simplify locating these layering violations. I meant the other way around, that is including <WebCore/Header.h> in the platform layer. 994143 4 ossy 2014-03-25 05:09:18 -0700 In my opinion if we could get rid include paths (as blink did it), it's obvious to catch layering violations by anybody without any sophisticated script and style checker. But unfortunately there were many objections against relative includes to Source. 1937509 5 ap 2023-02-28 12:58:57 -0800 *** Bug 252858 has been marked as a duplicate of this bug. ***