130626 2014-03-21 18:10:19 -0700 [WK2] Make updates on ViewUpdateDispatcher less heavy 2014-03-24 13:58:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 993400 0 benjamin 2014-03-21 18:10:19 -0700 [WK2] Make updates on ViewUpdateDispatcher less heavy 993401 1 227520 benjamin 2014-03-21 18:10:36 -0700 Created attachment 227520 Patch 993495 2 227520 darin 2014-03-22 08:06:04 -0700 Comment on attachment 227520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review > Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74 > localCopy.swap(m_latestUpdate); This should really use std::move instead of swap. Swap was the hack for doing this before we had move assignment. Also, the code below uses the word “iterator” strangely. It should be written like this: for (uint64_t pageID : localCopy.keys()) 993496 3 227520 darin 2014-03-22 08:06:55 -0700 Comment on attachment 227520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review >> Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74 >> localCopy.swap(m_latestUpdate); > > This should really use std::move instead of swap. Swap was the hack for doing this before we had move assignment. > > Also, the code below uses the word “iterator” strangely. It should be written like this: > > for (uint64_t pageID : localCopy.keys()) Oops, that was wrong. Obviously we want both keys and values. I just don’t think that “iterator” is the right name for an entry in a HashMap. I suggest the name "slot". 993961 4 benjamin 2014-03-24 13:58:37 -0700 Committed r166191: <http://trac.webkit.org/changeset/166191> 227520 2014-03-21 18:10:36 -0700 2014-03-22 08:06:55 -0700 Patch bug-130626-20140321181014.patch text/plain 3052 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTg1ZGIzN2ZlNDdkMmY4 YjM3ZGNjMzQ0OGU2NGYwMzUxNzY2NjU0MC4uNTIwNGY3ODhmMzhkMDAzMmJlOWE1OWQ4N2Y5Y2Q1 NGE1MDBhZDlhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTAzLTIxICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtXSzJdIE1ha2Ug dXBkYXRlcyBvbiBWaWV3VXBkYXRlRGlzcGF0Y2hlciBsZXNzIGhlYXZ5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2MjYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9W aWV3VXBkYXRlRGlzcGF0Y2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlZpZXdVcGRhdGVEaXNw YXRjaGVyOjp2aXNpYmxlQ29udGVudFJlY3RVcGRhdGUpOgorICAgICAgICAoV2ViS2l0OjpWaWV3 VXBkYXRlRGlzcGF0Y2hlcjo6ZGlzcGF0Y2hWaXNpYmxlQ29udGVudFJlY3RVcGRhdGUpOgorICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5oOgorCisyMDE0 LTAzLTIxICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCiAgICAgICAg IFtpT1NdW1dLMl0gUmVkdWNlIHRoZSB0aWxpbmcgY292ZXJhZ2UgdG8gdGhlIGN1cnJlbnQgcmVj dCBhbmQgMSB0aWxlIHNpemUgYWhlYWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMDU1NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvVmlld1VwZGF0ZURpc3BhdGNoZXIuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL1ZpZXdVcGRhdGVEaXNwYXRjaGVyLmNwcAppbmRleCA3NzBhZjdh OTU4MzlkMmIyNjcyN2E3Yzk5ZjQ4MTYwNGViNGI5MDc0Li5kMmU4NDhiZTZkYzMwOWQ2ZGNlZTg0 NTFkNGZjMmZlNmM3NTMwYzYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvVmlld1VwZGF0ZURpc3BhdGNoZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5jcHAKQEAgLTU2LDE4ICs1Niwy MSBAQCB2b2lkIFZpZXdVcGRhdGVEaXNwYXRjaGVyOjppbml0aWFsaXplQ29ubmVjdGlvbihJUEM6 OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiAKIHZvaWQgVmlld1VwZGF0ZURpc3BhdGNoZXI6OnZp c2libGVDb250ZW50UmVjdFVwZGF0ZSh1aW50NjRfdCBwYWdlSUQsIGNvbnN0IFZpc2libGVDb250 ZW50UmVjdFVwZGF0ZUluZm8mIHZpc2libGVDb250ZW50UmVjdFVwZGF0ZUluZm8pCiB7CisgICAg Ym9vbCB1cGRhdGVMaXN0V2FzRW1wdHk7CiAgICAgewotICAgICAgICBNdXRleExvY2tlciBsb2Nr ZXIobV9kYXRhTXV0ZXgpOworICAgICAgICBTcGluTG9ja0hvbGRlciBsb2NrZXIoJm1fZGF0YU11 dGV4KTsKKyAgICAgICAgdXBkYXRlTGlzdFdhc0VtcHR5ID0gbV9sYXRlc3RVcGRhdGUuaXNFbXB0 eSgpOwogICAgICAgICBtX2xhdGVzdFVwZGF0ZS5zZXQocGFnZUlELCB2aXNpYmxlQ29udGVudFJl Y3RVcGRhdGVJbmZvKTsKICAgICB9Ci0gICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKGJpbmQo JlZpZXdVcGRhdGVEaXNwYXRjaGVyOjpkaXNwYXRjaFZpc2libGVDb250ZW50UmVjdFVwZGF0ZSwg dGhpcykpOworICAgIGlmICh1cGRhdGVMaXN0V2FzRW1wdHkpCisgICAgICAgIFJ1bkxvb3A6Om1h aW4oKS5kaXNwYXRjaChiaW5kKCZWaWV3VXBkYXRlRGlzcGF0Y2hlcjo6ZGlzcGF0Y2hWaXNpYmxl Q29udGVudFJlY3RVcGRhdGUsIHRoaXMpKTsKIH0KIAogdm9pZCBWaWV3VXBkYXRlRGlzcGF0Y2hl cjo6ZGlzcGF0Y2hWaXNpYmxlQ29udGVudFJlY3RVcGRhdGUoKQogewogICAgIEhhc2hNYXA8dWlu dDY0X3QsIFZpc2libGVDb250ZW50UmVjdFVwZGF0ZUluZm8+IGxvY2FsQ29weTsKICAgICB7Ci0g ICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2RhdGFNdXRleCk7CisgICAgICAgIFNwaW5Mb2Nr SG9sZGVyIGxvY2tlcigmbV9kYXRhTXV0ZXgpOwogICAgICAgICBsb2NhbENvcHkuc3dhcChtX2xh dGVzdFVwZGF0ZSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvVmlld1VwZGF0ZURpc3BhdGNoZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5oCmluZGV4IDQ0YzYyNGE2OWVlNzE2 ZDQyYmE2NWNjZTVkNjMwZDM3ZjQxNDFmYjIuLmUyZjNjNmExY2UwY2NiNDUwOTc5YjM2ZWFkY2Y3 MWY0N2U4NWFjZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5oCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVk ZSAiVmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlSW5mby5oIgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFw Lmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWYuaD4KKyNpbmNsdWRlIDx3dGYvVENTcGluTG9jay5o PgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtNTEsNyArNTIsNyBAQCBwcml2YXRlOgogICAg IHZvaWQgZGlzcGF0Y2hWaXNpYmxlQ29udGVudFJlY3RVcGRhdGUoKTsKIAogICAgIFJlZlB0cjxX b3JrUXVldWU+IG1fcXVldWU7Ci0gICAgTXV0ZXggbV9kYXRhTXV0ZXg7CisgICAgU3BpbkxvY2sg bV9kYXRhTXV0ZXg7CiAgICAgSGFzaE1hcDx1aW50NjRfdCwgVmlzaWJsZUNvbnRlbnRSZWN0VXBk YXRlSW5mbz4gbV9sYXRlc3RVcGRhdGU7CiB9OwogCg==