130625 2014-03-21 17:47:25 -0700 Web Inspector: Lazy load source code referred to from the source map 2014-03-24 13:58:03 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 993393 0 timothy 2014-03-21 17:47:25 -0700 We load SourceMapResource when the sidebar is expanded to reveal them. That can be a storm on network requests. <rdar://problem/15986723> 993394 1 227517 timothy 2014-03-21 17:50:40 -0700 Created attachment 227517 Patch 993957 2 227517 joepeck 2014-03-24 13:55:03 -0700 Comment on attachment 227517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227517&action=review r=me > Source/WebInspectorUI/ChangeLog:12 > + dispaly the right icon in the sidebar. Typo: "dispaly" => "display" 993959 3 227517 commit-queue 2014-03-24 13:58:01 -0700 Comment on attachment 227517 Patch Clearing flags on attachment: 227517 Committed r166190: <http://trac.webkit.org/changeset/166190> 993960 4 commit-queue 2014-03-24 13:58:03 -0700 All reviewed patches have been landed. Closing bug. 227517 2014-03-21 17:50:40 -0700 2014-03-24 13:58:00 -0700 Patch bug-130625-20140321175018.patch text/plain 6277 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YjE2Mjg4NzI2N2FhNWQ1ZDI4NDE1M2Y2YWFkNWRjNTNjMmQyOGRkLi5kMjIyNDA1OWU0NjhjYzZm NjU3NTdkMTcxMTQwZTJjNmEyMzFhOTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNC0wMy0yMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgTGF6eSBsb2FkIHNvdXJjZSBjb2RlIHJlZmVycmVkIHRvIGZyb20gdGhl IHNvdXJjZSBtYXAsIGluc3RlYWQgb2Ygd2hlbgorICAgICAgICB0aGUgc291cmNlIGNvZGUgaXMg cmV2ZWFsZWQgaW4gdGhlIFJlc291cmNlcyBzaWRlYmFyLgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJj ZU1hcFJlc291cmNlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZU1hcFJlc291cmNl KTogU2V0IHVwIHRoZSB0eXBlIGluZm8gaGVyZSBzbyBpdCBjYW4gYmUgdXNlZCB0bworICAgICAg ICBkaXNwYWx5IHRoZSByaWdodCBpY29uIGluIHRoZSBzaWRlYmFyLgorICAgICAgICAoV2ViSW5z cGVjdG9yLlNvdXJjZU1hcFJlc291cmNlLnByb3RvdHlwZS5jYW5SZXF1ZXN0Q29udGVudEZyb21C YWNrZW5kKTogVXNlIF9jb250ZW50UmVxdWVzdGVkLgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNv dXJjZU1hcFJlc291cmNlLnByb3RvdHlwZS5yZXF1ZXN0Q29udGVudEZyb21CYWNrZW5kLnNvdXJj ZU1hcFJlc291cmNlTG9hZGVkKToKKyAgICAgICAgUmVzZXQgZmluaXNoZWQgYW5kIHJlbW92ZSB0 aGUgdHlwZSBjaGFuZ2UgZGFuY2Ugd2UgaGFkIGJlZm9yZS4KKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1NvdXJjZU1hcFJlc291cmNlVHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU291cmNlTWFwUmVzb3VyY2VUcmVlRWxlbWVudC5wcm90b3R5cGUub25hdHRhY2gp OiBSZW1vdmVkLiBEb24ndCByZXF1ZXN0IGNvbnRlbnQgaGVyZS4KKwogMjAxNC0wMy0yMSAgSmFt ZXMgQ3JhaWcgIDxqY3JhaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFY STogRXhwb3NlIEFjY2Vzc2liaWxpdHkgVHJlZSBjaGlsZHJlbiBvZiB0aGUgc2VsZWN0ZWQgbm9k ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L1NvdXJjZU1hcFJlc291cmNlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzCmluZGV4IGVjZjZlMWM0NTQ0NTdiYjljNWVj ODFiMzRjZmE2ZTU3OWMxNGUzN2IuLmRjYTUzNzM1ODc2MjE2M2QwMDc4NzkyOTcyMzk3YzM3NzU0 NDBmNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvU291cmNlTWFwUmVzb3VyY2UuanMKQEAgLTMxLDYgKzMxLDIxIEBA IFdlYkluc3BlY3Rvci5Tb3VyY2VNYXBSZXNvdXJjZSA9IGZ1bmN0aW9uKHVybCwgc291cmNlTWFw KQogICAgIGNvbnNvbGUuYXNzZXJ0KHNvdXJjZU1hcCk7CiAKICAgICB0aGlzLl9zb3VyY2VNYXAg PSBzb3VyY2VNYXA7CisgICAgdGhpcy5fY29udGVudFJlcXVlc3RlZCA9IGZhbHNlOworCisgICAg dmFyIGluaGVyaXRlZE1JTUVUeXBlID0gdGhpcy5fc291cmNlTWFwLm9yaWdpbmFsU291cmNlQ29k ZSBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5SZXNvdXJjZSA/IHRoaXMuX3NvdXJjZU1hcC5vcmln aW5hbFNvdXJjZUNvZGUuc3ludGhldGljTUlNRVR5cGUgOiBudWxsOworCisgICAgdmFyIGZpbGVF eHRlbnNpb24gPSBXZWJJbnNwZWN0b3IuZmlsZUV4dGVuc2lvbkZvclVSTCh1cmwpOworICAgIHZh ciBmaWxlRXh0ZW5zaW9uTUlNRVR5cGUgPSBXZWJJbnNwZWN0b3IubWltZVR5cGVGb3JGaWxlRXh0 ZW5zaW9uKGZpbGVFeHRlbnNpb24sIHRydWUpOworCisgICAgLy8gRklYTUU6IFRoaXMgaXMgYSBs YXllcmluZyB2aW9sYXRpb24uIEl0IHNob3VsZCB1c2UgYSBoZWxwZXIgZnVuY3Rpb24gb24gdGhl CisgICAgLy8gUmVzb3VyY2UgYmFzZS1jbGFzcyB0byBzZXQgX21pbWVUeXBlIGFuZCBfdHlwZS4K KyAgICB0aGlzLl9taW1lVHlwZSA9IGZpbGVFeHRlbnNpb25NSU1FVHlwZSB8fCBpbmhlcml0ZWRN SU1FVHlwZSB8fCAidGV4dC9qYXZhc2NyaXB0IjsKKyAgICB0aGlzLl90eXBlID0gV2ViSW5zcGVj dG9yLlJlc291cmNlLlR5cGUuZnJvbU1JTUVUeXBlKHRoaXMuX21pbWVUeXBlKTsKKworICAgIC8v IE1hcmsgdGhlIHJlc291cmNlIGFzIGxvYWRlZCBzbyBpdCBkb2VzIG5vdCBzaG93IGEgc3Bpbm5l ciBpbiB0aGUgc2lkZWJhci4KKyAgICAvLyBXZSB3aWxsIHJlYWxseSBsb2FkIHRoZSByZXNvdXJj ZSB0aGUgZmlyc3QgdGltZSBjb250ZW50IGlzIHJlcXVlc3RlZC4KKyAgICB0aGlzLm1hcmtBc0Zp bmlzaGVkKCk7CiB9OwogCiBXZWJJbnNwZWN0b3IuU291cmNlTWFwUmVzb3VyY2UucHJvdG90eXBl ID0gewpAQCAtNjIsMTggKzc3LDIyIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VNYXBSZXNvdXJjZS5w cm90b3R5cGUgPSB7CiAKICAgICBjYW5SZXF1ZXN0Q29udGVudEZyb21CYWNrZW5kOiBmdW5jdGlv bigpCiAgICAgewotICAgICAgICByZXR1cm4gIXRoaXMuZmluaXNoZWQ7CisgICAgICAgIHJldHVy biAhdGhpcy5fY29udGVudFJlcXVlc3RlZDsKICAgICB9LAogCiAgICAgcmVxdWVzdENvbnRlbnRG cm9tQmFja2VuZDogZnVuY3Rpb24oY2FsbGJhY2spCiAgICAgeworICAgICAgICB0aGlzLl9jb250 ZW50UmVxdWVzdGVkID0gdHJ1ZTsKKworICAgICAgICAvLyBSZXZlcnQgdGhlIG1hcmtBc0Zpbmlz aGVkIHRoYXQgd2FzIGRvbmUgaW4gdGhlIGNvbnN0cnVjdG9yLgorICAgICAgICB0aGlzLnJldmVy dE1hcmtBc0ZpbmlzaGVkKCk7CisKICAgICAgICAgdmFyIGlubGluZUNvbnRlbnQgPSB0aGlzLl9z b3VyY2VNYXAuc291cmNlQ29udGVudCh0aGlzLnVybCk7CiAgICAgICAgIGlmIChpbmxpbmVDb250 ZW50KSB7CiAgICAgICAgICAgICAvLyBGb3JjZSBpbmxpbmUgY29udGVudCB0byBiZSBhc3luY2hy b25vdXMgdG8gbWF0Y2ggdGhlIGV4cGVjdGVkIGxvYWQgcGF0dGVybi4KICAgICAgICAgICAgIHNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICAgLy8gRklYTUU6IFdlIGRvbid0 IGtub3cgdGhlIE1JTUUtdHlwZSBmb3IgaW5saW5lIGNvbnRlbnQuIEd1ZXNzIGJ5IGFuYWx5emlu ZyB0aGUgY29udGVudD8KLSAgICAgICAgICAgICAgICAvLyBHdWVzcyBieSB1c2luZyB0aGUgdHlw ZSBvZiB0aGUgb3JpZ2luYWwgcmVzb3VyY2U/Ci0gICAgICAgICAgICAgICAgc291cmNlTWFwUmVz b3VyY2VMb2FkZWQuY2FsbCh0aGlzLCBudWxsLCBpbmxpbmVDb250ZW50LCAidGV4dC9qYXZhc2Ny aXB0IiwgMjAwKTsKKyAgICAgICAgICAgICAgICBzb3VyY2VNYXBSZXNvdXJjZUxvYWRlZC5jYWxs KHRoaXMsIG51bGwsIGlubGluZUNvbnRlbnQsIHRoaXMubWltZVR5cGUsIDIwMCk7CiAgICAgICAg ICAgICB9LmJpbmQodGhpcykpOwogCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTg5LDI4 ICsxMDgsOCBAQCBXZWJJbnNwZWN0b3IuU291cmNlTWFwUmVzb3VyY2UucHJvdG90eXBlID0gewog ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgdmFy IGZpbGVFeHRlbnNpb24gPSBXZWJJbnNwZWN0b3IuZmlsZUV4dGVuc2lvbkZvclVSTCh0aGlzLnVy bCk7Ci0gICAgICAgICAgICB2YXIgZmlsZUV4dGVuc2lvbk1JTUVUeXBlID0gV2ViSW5zcGVjdG9y Lm1pbWVUeXBlRm9yRmlsZUV4dGVuc2lvbihmaWxlRXh0ZW5zaW9uLCB0cnVlKSB8fCAidGV4dC9q YXZhc2NyaXB0IjsKLQogICAgICAgICAgICAgLy8gRklYTUU6IEFkZCBzdXBwb3J0IGZvciBwaWNr aW5nIHRoZSBiZXN0IE1JTUUtdHlwZS4gUmlnaHQgbm93IHRoZSBmaWxlIGV4dGVuc2lvbiBpcyB0 aGUgYmVzdCBiZXQuCi0gICAgICAgICAgICBtaW1lVHlwZSA9IGZpbGVFeHRlbnNpb25NSU1FVHlw ZTsKLQotICAgICAgICAgICAgdmFyIG9sZFR5cGUgPSB0aGlzLl90eXBlOwotICAgICAgICAgICAg dmFyIG9sZE1JTUVUeXBlID0gdGhpcy5fbWltZVR5cGU7Ci0KLSAgICAgICAgICAgIC8vIEZJWE1F OiBUaGlzIGlzIGEgbGF5ZXJpbmcgdmlvbGF0aW9uLiBJdCBzaG91bGQgdXNlIGEgaGVscGVyIGZ1 bmN0aW9uIG9uIHRoZSBSZXNvdXJjZSBiYXNlLWNsYXNzLgotICAgICAgICAgICAgdGhpcy5fbWlt ZVR5cGUgPSBtaW1lVHlwZTsKLSAgICAgICAgICAgIHRoaXMuX3R5cGUgPSBXZWJJbnNwZWN0b3Iu UmVzb3VyY2UuVHlwZS5mcm9tTUlNRVR5cGUodGhpcy5fbWltZVR5cGUpOwotCi0gICAgICAgICAg ICBpZiAob2xkTUlNRVR5cGUgIT09IG1pbWVUeXBlKSB7Ci0gICAgICAgICAgICAgICAgLy8gRGVs ZXRlIHRoZSBNSU1FLXR5cGUgY29tcG9uZW50cyBzbyB0aGUgTUlNRS10eXBlIGlzIHJlLXBhcnNl ZCB0aGUgbmV4dCB0aW1lIGl0IGlzIHJlcXVlc3RlZC4KLSAgICAgICAgICAgICAgICBkZWxldGUg dGhpcy5fbWltZVR5cGVDb21wb25lbnRzOwotCi0gICAgICAgICAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlJlc291cmNlLkV2ZW50Lk1JTUVUeXBlRGlk Q2hhbmdlLCB7b2xkTUlNRVR5cGU6IG9sZE1JTUVUeXBlfSk7Ci0gICAgICAgICAgICB9Ci0KLSAg ICAgICAgICAgIGlmIChvbGRUeXBlICE9PSB0aGlzLl90eXBlKQotICAgICAgICAgICAgICAgIHRo aXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5FdmVudC5U eXBlRGlkQ2hhbmdlLCB7b2xkVHlwZTogb2xkVHlwZX0pOworICAgICAgICAgICAgLy8gVGhlIGNv bnN0cnVjdG9yIHNldCBNSU1FLXR5cGUgYmFzZWQgb24gdGhlIGZpbGUgZXh0ZW5zaW9uIGFuZCB3 ZSBpZ25vcmUgbWltZVR5cGUgaGVyZS4KIAogICAgICAgICAgICAgdGhpcy5tYXJrQXNGaW5pc2hl ZCgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Tb3VyY2VNYXBSZXNvdXJjZVRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlTWFwUmVzb3VyY2VUcmVlRWxlbWVudC5qcwpp bmRleCA5ZDlkOTA1NzQ1YzZjMTJhNGVhOTI3MjI2Mzc1MTZkZDA2NTgzMDUxLi41ZDFiNDg0NDY3 YmUyYjFmMDFkZWNmNzc0MTc5M2E4YjIxNTljNjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VNYXBSZXNvdXJjZVRyZWVFbGVtZW50 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJj ZU1hcFJlc291cmNlVHJlZUVsZW1lbnQuanMKQEAgLTQxLDE2ICs0MSw2IEBAIFdlYkluc3BlY3Rv ci5Tb3VyY2VNYXBSZXNvdXJjZVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKIAogICAgIC8vIFBy b3RlY3RlZAogCi0gICAgb25hdHRhY2g6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIFdlYklu c3BlY3Rvci5SZXNvdXJjZVRyZWVFbGVtZW50LnByb3RvdHlwZS5vbmF0dGFjaC5jYWxsKHRoaXMp OwotCi0gICAgICAgIC8vIFNvdXJjZU1hcCByZXNvdXJjZXMgbXVzdCBiZSBsb2FkZWQgYnkgdGhl IGZyb250ZW5kLCBhbmQgb25seQotICAgICAgICAvLyB0aGVuIGRvIHRoZXkgZ2V0IHRoZWlyIHR5 cGUgaW5mb3JtYXRpb24uIFNvIGZvcmNlIGEgbG9hZCBhcwotICAgICAgICAvLyBzb29uIGFzIHRo ZXkgYXJlIGF0dGFjaGVkIHRvIHRoZSBzaWRlYmFyLgotICAgICAgICB0aGlzLnJlc291cmNlLnJl cXVlc3RDb250ZW50KGZ1bmN0aW9uKCkge30pOwotICAgIH0sCi0KICAgICBfdXBkYXRlVGl0bGVz OiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIgb2xkTWFpblRpdGxlID0gdGhpcy5tYWlu VGl0bGU7Cg==