130624 2014-03-21 17:38:04 -0700 Pass additional AVFoundation options during iOS playback 2014-03-25 14:01:14 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 993390 0 bfulgham 2014-03-21 17:38:04 -0700 Pass <video> attribute to AVFoundation during playback on iOS devices. 993391 1 227516 bfulgham 2014-03-21 17:43:42 -0700 Created attachment 227516 Patch 993392 2 bfulgham 2014-03-21 17:45:04 -0700 <rdar://problem/16396300> 993492 3 227516 darin 2014-03-22 08:00:06 -0700 Comment on attachment 227516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227516&action=review > Source/WebCore/ChangeLog:3 > + [iOS] Pass additional options to AVFoudnation during playback. Typo: foudnation > Source/WebCore/html/HTMLMediaElement.cpp:6018 > + if (value) > + *value = fastGetAttribute(attributeName); It’s not good for performance to call fastHasAttribute and then fastGetAttribute on the same name. That’s a double hash table lookup. The code should be restructured so it only does one of the two. If you call fastGetAttribute, you can check “has” by checking isNull on the result. > Source/WebCore/html/HTMLMediaElement.h:134 > + virtual bool doesHaveAttribute(const AtomicString&, AtomicString* = 0) const override; Should be nullptr, not 0. Second argument needs a name. Not at all obvious what the AtomicString* is for. > Source/WebCore/platform/graphics/MediaPlayer.h:251 > + virtual bool doesHaveAttribute(const AtomicString&, AtomicString* = 0) const { return false; } Should be nullptr, not 0. Second argument needs a name. Not at all obvious what the AtomicString* is for. > Source/WebCore/platform/graphics/MediaPlayer.h:303 > + bool doesHaveAttribute(const AtomicString&, AtomicString* = 0) const; Should be nullptr, not 0. Second argument needs a name. Not at all obvious what the AtomicString* is for. 994228 4 227516 bfulgham 2014-03-25 10:02:59 -0700 Comment on attachment 227516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227516&action=review >> Source/WebCore/ChangeLog:3 >> + [iOS] Pass additional options to AVFoudnation during playback. > > Typo: foudnation Fixed >> Source/WebCore/html/HTMLMediaElement.cpp:6018 >> + *value = fastGetAttribute(attributeName); > > It’s not good for performance to call fastHasAttribute and then fastGetAttribute on the same name. That’s a double hash table lookup. The code should be restructured so it only does one of the two. If you call fastGetAttribute, you can check “has” by checking isNull on the result. Done. >> Source/WebCore/html/HTMLMediaElement.h:134 >> + virtual bool doesHaveAttribute(const AtomicString&, AtomicString* = 0) const override; > > Should be nullptr, not 0. > > Second argument needs a name. Not at all obvious what the AtomicString* is for. Done. >> Source/WebCore/platform/graphics/MediaPlayer.h:303 >> + bool doesHaveAttribute(const AtomicString&, AtomicString* = 0) const; > > Should be nullptr, not 0. > > Second argument needs a name. Not at all obvious what the AtomicString* is for. Done 994322 5 bfulgham 2014-03-25 14:01:14 -0700 Committed r166250: <http://trac.webkit.org/changeset/166250> 227516 2014-03-21 17:43:42 -0700 2014-03-25 10:02:59 -0700 Patch bug-130624-20140321174321.patch text/plain 6305 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjEwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAzLTIxICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFBhc3MgYWRkaXRp b25hbCBvcHRpb25zIHRvIEFWRm91ZG5hdGlvbiBkdXJpbmcgcGxheWJhY2suCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2MjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpkb2VzSGF2ZUF0 dHJpYnV0ZSk6IFJldHVybiBhdHRyaWJ1dGUgdmFsdWUgaWYgdGhlIHVzZXIKKyAgICAgICAgcGFz c2VzIGEgcG9pbnRlciB0byBmaWxsIGluLgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVu dC5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyOjpkb2VzSGF2ZUF0dHJpYnV0ZSk6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyQ2xpZW50Ojpkb2VzSGF2ZUF0dHJpYnV0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akM6OmNyZWF0ZUFWUGxheWVySXRlbSk6IFBhc3MgYWRkaXRpb25hbAorICAgICAgICBvcHRpb24g aWYgc3VwcGxpZWQgYnkgdXNlci4KKwogMjAxNC0wMy0yMSAgRXJpYyBDYXJsc29uICA8ZXJpYy5j YXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBjbGVhbiB1cCBmdWxsc2NyZWVuIHBs YXllciBjb250cm9sbGVyIHdoZW4gZXhpdGluZyBmdWxsc2NyZWVuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDE2NjEwNCkKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYw MDMsMTYgKzYwMDMsMTkgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpkaWRSZWNlaXZlUmVtb3Rl QwogICAgIH0KIH0KIAotYm9vbCBIVE1MTWVkaWFFbGVtZW50Ojpkb2VzSGF2ZUF0dHJpYnV0ZShj b25zdCBBdG9taWNTdHJpbmcmIGF0dHJpYnV0ZSkgY29uc3QKK2Jvb2wgSFRNTE1lZGlhRWxlbWVu dDo6ZG9lc0hhdmVBdHRyaWJ1dGUoY29uc3QgQXRvbWljU3RyaW5nJiBhdHRyaWJ1dGUsIEF0b21p Y1N0cmluZyogdmFsdWUpIGNvbnN0CiB7CiAgICAgUXVhbGlmaWVkTmFtZSBhdHRyaWJ1dGVOYW1l KG51bGxBdG9tLCBhdHRyaWJ1dGUsIG51bGxBdG9tKTsKICAgICBpZiAoIWZhc3RIYXNBdHRyaWJ1 dGUoYXR0cmlidXRlTmFtZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICBpZiAo U2V0dGluZ3MqIHNldHRpbmdzID0gZG9jdW1lbnQoKS5zZXR0aW5ncygpKSB7Ci0gICAgICAgIGlm IChhdHRyaWJ1dGVOYW1lID09IEhUTUxOYW1lczo6eF9pdHVuZXNfaW5oZXJpdF91cmlfcXVlcnlf Y29tcG9uZW50QXR0cikKLSAgICAgICAgICAgIHJldHVybiBzZXR0aW5ncy0+ZW5hYmxlSW5oZXJp dFVSSVF1ZXJ5Q29tcG9uZW50KCk7CisgICAgICAgIGlmIChhdHRyaWJ1dGVOYW1lID09IEhUTUxO YW1lczo6eF9pdHVuZXNfaW5oZXJpdF91cmlfcXVlcnlfY29tcG9uZW50QXR0ciAmJiAhc2V0dGlu Z3MtPmVuYWJsZUluaGVyaXRVUklRdWVyeUNvbXBvbmVudCgpKQorICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KKworICAgIGlmICh2YWx1ZSkKKyAgICAgICAgKnZhbHVlID0gZmFzdEdl dEF0dHJpYnV0ZShhdHRyaWJ1dGVOYW1lKTsKICAgICAKICAgICByZXR1cm4gdHJ1ZTsKIH0KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCShyZXZpc2lvbiAxNjYxMDQp CisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAkod29ya2luZyBjb3B5 KQpAQCAtMTMxLDcgKzEzMSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNT YXZlKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzU2Nhbm5pbmcoKSBjb25zdCBv dmVycmlkZTsKICAgICAKLSAgICB2aXJ0dWFsIGJvb2wgZG9lc0hhdmVBdHRyaWJ1dGUoY29uc3Qg QXRvbWljU3RyaW5nJikgY29uc3Qgb3ZlcnJpZGU7CisgICAgdmlydHVhbCBib29sIGRvZXNIYXZl QXR0cmlidXRlKGNvbnN0IEF0b21pY1N0cmluZyYsIEF0b21pY1N0cmluZyogPSAwKSBjb25zdCBv dmVycmlkZTsKIAogICAgIFBsYXRmb3JtTWVkaWEgcGxhdGZvcm1NZWRpYSgpIGNvbnN0OwogICAg IFBsYXRmb3JtTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAJKHJldmlzaW9uIDE2 NjEwNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTQxMiwxMiArMTQxMiwxMiBAQCB2b2lkIE1lZGlhUGxheWVy RmFjdG9yeVN1cHBvcnQ6OmNhbGxSZWdpCiAgICAgcmVnaXN0ZXJNZWRpYUVuZ2luZShhZGRNZWRp YUVuZ2luZSk7CiB9CiAKLWJvb2wgTWVkaWFQbGF5ZXI6OmRvZXNIYXZlQXR0cmlidXRlKGNvbnN0 IEF0b21pY1N0cmluZyYgYXR0cmlidXRlKSBjb25zdAorYm9vbCBNZWRpYVBsYXllcjo6ZG9lc0hh dmVBdHRyaWJ1dGUoY29uc3QgQXRvbWljU3RyaW5nJiBhdHRyaWJ1dGUsIEF0b21pY1N0cmluZyog dmFsdWUpIGNvbnN0CiB7CiAgICAgaWYgKCFtX21lZGlhUGxheWVyQ2xpZW50KQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgcmV0dXJuIG1fbWVkaWFQbGF5ZXJDbGllbnQtPmRvZXNI YXZlQXR0cmlidXRlKGF0dHJpYnV0ZSk7CisgICAgcmV0dXJuIG1fbWVkaWFQbGF5ZXJDbGllbnQt PmRvZXNIYXZlQXR0cmlidXRlKGF0dHJpYnV0ZSwgdmFsdWUpOwogfQogCiB9CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgJKHJldmlzaW9u IDE2NjEwNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTI0OCw3ICsyNDgsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCBIb3N0V2luZG93KiBtZWRpYVBsYXllckhvc3RXaW5kb3coKSB7IHJldHVybiAwOyB9CiAgICAg dmlydHVhbCBJbnRSZWN0IG1lZGlhUGxheWVyV2luZG93Q2xpcFJlY3QoKSB7IHJldHVybiBJbnRS ZWN0KCk7IH0KICAgICB2aXJ0dWFsIENhY2hlZFJlc291cmNlTG9hZGVyKiBtZWRpYVBsYXllckNh Y2hlZFJlc291cmNlTG9hZGVyKCkgeyByZXR1cm4gMDsgfQotICAgIHZpcnR1YWwgYm9vbCBkb2Vz SGF2ZUF0dHJpYnV0ZShjb25zdCBBdG9taWNTdHJpbmcmKSBjb25zdCB7IHJldHVybiBmYWxzZTsg fQorICAgIHZpcnR1YWwgYm9vbCBkb2VzSGF2ZUF0dHJpYnV0ZShjb25zdCBBdG9taWNTdHJpbmcm LCBBdG9taWNTdHJpbmcqID0gMCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAogI2lmIEVOQUJM RShWSURFT19UUkFDSykKICAgICB2aXJ0dWFsIHZvaWQgbWVkaWFQbGF5ZXJEaWRBZGRBdWRpb1Ry YWNrKFBhc3NSZWZQdHI8QXVkaW9UcmFja1ByaXZhdGU+KSB7IH0KQEAgLTMwMCw3ICszMDAsNyBA QCBwdWJsaWM6CiAgICAgYm9vbCBzdXBwb3J0c1NhdmUoKSBjb25zdDsKICAgICBib29sIHN1cHBv cnRzU2Nhbm5pbmcoKSBjb25zdDsKICAgICBib29sIHJlcXVpcmVzSW1tZWRpYXRlQ29tcG9zaXRp bmcoKSBjb25zdDsKLSAgICBib29sIGRvZXNIYXZlQXR0cmlidXRlKGNvbnN0IEF0b21pY1N0cmlu ZyYpIGNvbnN0OworICAgIGJvb2wgZG9lc0hhdmVBdHRyaWJ1dGUoY29uc3QgQXRvbWljU3RyaW5n JiwgQXRvbWljU3RyaW5nKiA9IDApIGNvbnN0OwogICAgIFBsYXRmb3JtTWVkaWEgcGxhdGZvcm1N ZWRpYSgpIGNvbnN0OwogICAgIFBsYXRmb3JtTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdDsK ICNpZiBQTEFURk9STShJT1MpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRh dGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0JKHJldmlzaW9u IDE2NjEwNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTkwLDYgKzkwLDEzIEBAIEBpbnRlcmZhY2UgQVZNZWRpYVNlbGVjdGlvbk9wdGlvbiAo T3V0T2YKIEBlbmQKICNlbmRpZgogCisjaWYgUExBVEZPUk0oSU9TKQorQGNsYXNzIEFWUGxheWVy SXRlbTsKK0BpbnRlcmZhY2UgQVZQbGF5ZXJJdGVtIChXZWJLaXRFeHRlbnNpb25zKQorQHByb3Bl cnR5IChub25hdG9taWMsIGNvcHkpIE5TU3RyaW5nKiBkYXRhWW91VHViZUlEOworQGVuZAorI2Vu ZGlmCisKIFNPRlRfTElOS19GUkFNRVdPUktfT1BUSU9OQUwoQVZGb3VuZGF0aW9uKQogU09GVF9M SU5LX0ZSQU1FV09SS19PUFRJT05BTChDb3JlTWVkaWEpCiBTT0ZUX0xJTktfRlJBTUVXT1JLX09Q VElPTkFMKENvcmVJbWFnZSkKQEAgLTY5OSw4ICs3MDYsMTQgQEAgdm9pZCBNZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb25PYmpDOgogICAgIGZvciAoTlNTdHJpbmcgKmtleU5hbWUgaW4gaXRl bUtWT1Byb3BlcnRpZXMoKSkKICAgICAgICAgW21fYXZQbGF5ZXJJdGVtLmdldCgpIGFkZE9ic2Vy dmVyOm1fb2JqY09ic2VydmVyLmdldCgpIGZvcktleVBhdGg6a2V5TmFtZSBvcHRpb25zOm9wdGlv bnMgY29udGV4dDoodm9pZCAqKU1lZGlhUGxheWVyQVZGb3VuZGF0aW9uT2JzZXJ2YXRpb25Db250 ZXh0UGxheWVySXRlbV07CiAKLSAgICBpZiAobV9hdlBsYXllcikKKyAgICBpZiAobV9hdlBsYXll cikgewogICAgICAgICBbbV9hdlBsYXllci5nZXQoKSByZXBsYWNlQ3VycmVudEl0ZW1XaXRoUGxh eWVySXRlbTptX2F2UGxheWVySXRlbS5nZXQoKV07CisjaWYgUExBVEZPUk0oSU9TKQorICAgICAg ICBBdG9taWNTdHJpbmcgdmFsdWU7CisgICAgICAgIGlmIChwbGF5ZXIoKS0+ZG9lc0hhdmVBdHRy aWJ1dGUoImRhdGEteW91dHViZS1pZCIsICZ2YWx1ZSkpCisgICAgICAgICAgICBbbV9hdlBsYXll ckl0ZW0uZ2V0KCkgc2V0RGF0YVlvdVR1YmVJRDogdmFsdWVdOworI2VuZGlmCisgICAgfQogCiAj aWYgSEFWRShBVkZPVU5EQVRJT05fTUVESUFfU0VMRUNUSU9OX0dST1VQKSAmJiBIQVZFKEFWRk9V TkRBVElPTl9MRUdJQkxFX09VVFBVVF9TVVBQT1JUKQogICAgIGNvbnN0IE5TVGltZUludGVydmFs IGxlZ2libGVPdXRwdXRBZHZhbmNlSW50ZXJ2YWwgPSAyOwo=