130621 2014-03-21 15:52:29 -0700 [iOS] clean up fullscreen player controller when exiting fullscreen 2014-03-21 16:20:40 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 993350 0 eric.carlson 2014-03-21 15:52:29 -0700 The fullscreen video layer's WebAVPlayerController is retained by the player view controller and can outlive the layer, so clear the view controller's delegate and player controller when we exit from fullscreen. 993353 1 227502 eric.carlson 2014-03-21 15:56:34 -0700 Created attachment 227502 Proposed patch. 993355 2 webkit-bug-importer 2014-03-21 15:58:09 -0700 <rdar://problem/16396567> 993357 3 webkit-bug-importer 2014-03-21 15:59:24 -0700 <rdar://problem/16396588> 993360 4 227502 jer.noble 2014-03-21 16:07:28 -0700 Comment on attachment 227502 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=227502&action=review r=me with nits. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:207 > + if (_avPlayerController && [_avPlayerController delegate]) This should be unnecessary. If _avPlayerController is nil, [_avPlayerController delegate] will return nil as well. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:215 > + if (!_avPlayerController || ![_avPlayerController delegate]) Ditto. 993370 5 eric.carlson 2014-03-21 16:20:28 -0700 Committed r166106: https://trac.webkit.org/r166106 227502 2014-03-21 15:56:34 -0700 2014-03-21 16:20:40 -0700 Proposed patch. patch_1.txt text/plain 2387 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjEwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTIxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGNsZWFuIHVw IGZ1bGxzY3JlZW4gcGxheWVyIGNvbnRyb2xsZXIgd2hlbiBleGl0aW5nIGZ1bGxzY3JlZW4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDYyMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v aW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoLVtXZWJB VlZpZGVvTGF5ZXIgc2V0Qm91bmRzOl0pOiBEbyBub3RoaW5nIGlmIF9hdlBsYXllckNvbnRyb2xs ZXIgaXMgbmlsLgorICAgICAgICAoLVtXZWJBVlZpZGVvTGF5ZXIgc2V0VmlkZW9MYXllckdyYXZp dHk6XSk6IERpdHRvLgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OmV4aXRGdWxsc2NyZWVuKTogU2V0IG1fcGxheWVyVmlld0NvbnRyb2xsZXIgZGVsZWdhdGUKKyAg ICAgICAgICAgIGFuZCBwbGF5ZXIgY29udHJvbGxlciB0byBuaWwuCisKIDIwMTQtMDMtMjEgIEVy aWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gcmVt b3RlIGNvbW1hbmQgY2FsbGJhY2tzIG11c3QgaGFwcGVuIG9uIHRoZSBXZWJUaHJlYWQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0JKHJldmlzaW9uIDE2NjA4OSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5t bQkod29ya2luZyBjb3B5KQpAQCAtMjA0LDcgKzIwNCw3IEBAIC0gKHZvaWQpc2V0UGxheWVyQ29u dHJvbGxlcjooQVZQbGF5ZXJDb24KIC0gKHZvaWQpc2V0Qm91bmRzOihDR1JlY3QpYm91bmRzCiB7 CiAgICAgW3N1cGVyIHNldEJvdW5kczpib3VuZHNdOwotICAgIGlmIChbX2F2UGxheWVyQ29udHJv bGxlciBkZWxlZ2F0ZV0pCisgICAgaWYgKF9hdlBsYXllckNvbnRyb2xsZXIgJiYgW19hdlBsYXll ckNvbnRyb2xsZXIgZGVsZWdhdGVdKQogICAgICAgICBbX2F2UGxheWVyQ29udHJvbGxlciBkZWxl Z2F0ZV0tPnNldFZpZGVvTGF5ZXJGcmFtZShGbG9hdFJlY3QoMCwgMCwgYm91bmRzLnNpemUud2lk dGgsIGJvdW5kcy5zaXplLmhlaWdodCkpOwogfQogCkBAIC0yMTIsNyArMjEyLDcgQEAgLSAodm9p ZClzZXRWaWRlb0xheWVyR3Jhdml0eTooQVZWaWRlb0xheQogewogICAgIF92aWRlb0xheWVyR3Jh dml0eSA9IHZpZGVvTGF5ZXJHcmF2aXR5OwogICAgIAotICAgIGlmICghW19hdlBsYXllckNvbnRy b2xsZXIgZGVsZWdhdGVdKQorICAgIGlmICghX2F2UGxheWVyQ29udHJvbGxlciB8fCAhW19hdlBs YXllckNvbnRyb2xsZXIgZGVsZWdhdGVdKQogICAgICAgICByZXR1cm47CiAKICAgICBXZWJDb3Jl OjpXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbDo6VmlkZW9HcmF2aXR5IGdyYXZpdHkgPSBXZWJDb3Jl OjpXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbDo6VmlkZW9HcmF2aXR5UmVzaXplQXNwZWN0OwpAQCAt MzU5LDYgKzM1OSw4IEBAIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmUK ICAgICAgICAgW21fdmlld0NvbnRyb2xsZXIgZGlzbWlzc1ZpZXdDb250cm9sbGVyQW5pbWF0ZWQ6 WUVTIGNvbXBsZXRpb246XnsKICAgICAgICAgICAgIFttX3dpbmRvdyBzZXRIaWRkZW46WUVTXTsK ICAgICAgICAgICAgIFttX3dpbmRvdyBzZXRSb290Vmlld0NvbnRyb2xsZXI6bmlsXTsKKyAgICAg ICAgICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIHNldERlbGVnYXRlOm5pbF07CisgICAgICAg ICAgICBbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciBzZXRQbGF5ZXJDb250cm9sbGVyOm5pbF07CiAg ICAgICAgICAgICBtX3BsYXllclZpZXdDb250cm9sbGVyID0gbmlsOwogICAgICAgICAgICAgbV92 aWV3Q29udHJvbGxlciA9IG5pbDsKICAgICAgICAgICAgIG1fd2luZG93ID0gbmlsOwo=