130619 2014-03-21 14:59:48 -0700 REGRESSION (r165356): Predictive Chinese input is broken 2014-03-21 15:59:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 ap ap andersca darin enrica oldest_to_newest 993335 0 ap 2014-03-21 14:59:48 -0700 Predictive Chinese input is very special - it doesn't have an inline input area, but critically depends on us calling -discardMarkedText at exactly the right times. Changes in when editor state is updated resulted in us calling it too eagerly. Updating editor state was and remains hopelessly broken, thankfully, we will not depend on it as much with async input. Steps to reproduce: 1. Enable Cangjie input. 2. Type "sina" 3. Press "1" several times. Expected results: each time "1" is pressed, something is inserted, and a new suggestion popup appears. Actual results: After the first time, there is no suggestion popup. 993336 1 227495 ap 2014-03-21 15:02:39 -0700 Created attachment 227495 proposed patch 993352 2 227495 enrica 2014-03-21 15:54:05 -0700 Comment on attachment 227495 proposed patch Looks good. 993356 3 ap 2014-03-21 15:59:07 -0700 Committed <http://trac.webkit.org/r166105>. 227495 2014-03-21 15:02:39 -0700 2014-03-21 15:54:04 -0700 proposed patch PredictiveChinese.txt text/plain 1455 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjA5OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTIxICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNjUz NTYpOiBQcmVkaWN0aXZlIENoaW5lc2UgaW5wdXQgaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA2MTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViUGFnZVBy b3h5TWFjLm1tOiAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmV4ZWN1dGVLZXlwcmVzc0NvbW1hbmRz KToKKyAgICAgICAgTGlrZSBhZnRlciBpbnNlcnRUZXh0LCB3ZSBhcmUgbm8gbG9uZ2VyIGluIGFu IGludGVybWVkaWF0ZSBzdGF0ZSBhZnRlciBleGVjdXRlS2V5cHJlc3NDb21tYW5kcy4KKyAgICAg ICAgTWFrZSBzdXJlIHRoYXQgd2UgZG9uJ3QgY2FsbCAtZGlzY2FyZE1hcmtlZFRleHQgdGhlIG5l eHQgdGltZSB3ZSBnZXQgYSBub24taW50ZXJtZWRpYXRlCisgICAgICAgIHN0YXRlIHdpdGggY2xv c2VkIGNvbXBvc2l0aW9uLgorCiAyMDE0LTAzLTIxICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFsd2F5cyByZXRyaWV2ZSB0aGUgc2NyZWVuIHNjYWxl IGZhY3RvciBmcm9tIFdLU0kKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2Vi UGFnZVByb3h5TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9t YWMvV2ViUGFnZVByb3h5TWFjLm1tCShyZXZpc2lvbiAxNjYwNzQpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1dlYlBhZ2VQcm94eU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjcw LDYgKzI3MCw3IEBAIGJvb2wgV2ViUGFnZVByb3h5OjpleGVjdXRlS2V5cHJlc3NDb21tYW4KIAog ICAgIGJvb2wgcmVzdWx0ID0gZmFsc2U7CiAgICAgcHJvY2VzcygpLnNlbmRTeW5jKE1lc3NhZ2Vz OjpXZWJQYWdlOjpFeGVjdXRlS2V5cHJlc3NDb21tYW5kcyhjb21tYW5kcyksIE1lc3NhZ2VzOjpX ZWJQYWdlOjpFeGVjdXRlS2V5cHJlc3NDb21tYW5kczo6UmVwbHkocmVzdWx0LCBtX2VkaXRvclN0 YXRlKSwgbV9wYWdlSUQpOworICAgIG1fdGVtcG9yYXJpbHlDbG9zZWRDb21wb3NpdGlvbiA9IGZh bHNlOwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAK