130617 2014-03-21 14:22:57 -0700 6% SunSpider commandline regression due to r165940 2014-04-29 15:33:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121074 1 mhahnenberg mhahnenberg oldest_to_newest 993319 0 mhahnenberg 2014-03-21 14:22:57 -0700 From profiling stanford-crypto-sha256-iterative with Instruments, it looks like we're spending > 10% of our time calling CFRunLoopTimerSetNextFireDate inside of Heap::reportExtraMemoryCost. It's a shame this function is so expensive. We have code that tries to avoid calling it too much, but it looks like it's either not working at all or it's not aggressive enough in its mitigation. 993320 1 mhahnenberg 2014-03-21 14:23:12 -0700 <rdar://problem/16394074> 993321 2 mhahnenberg 2014-03-21 14:26:05 -0700 In GCActivityCallback::didAllocate, lastGCLength() returns 0 if we've never collected before. Some of the benchmarks are never running a single EdenCollection, which causes them to repeatedly call scheduleTimer with a newDelay of 0. This defeats our timer slop heuristic, causing us to invoke CFRunLoopTimerSetNextFireDate a couple orders of magnitude more than we normally would. The fix is to seed the last GC lengths in Heap with a non-zero length so that our heuristic works. 993325 3 227491 mhahnenberg 2014-03-21 14:32:09 -0700 Created attachment 227491 Patch 993331 4 227491 msaboff 2014-03-21 14:47:37 -0700 Comment on attachment 227491 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227491&action=review r=me > Source/JavaScriptCore/heap/Heap.cpp:284 > + // schedule the timer if we've never done a collction. *collection* 993332 5 mhahnenberg 2014-03-21 14:53:57 -0700 Committed r166099: <http://trac.webkit.org/changeset/166099> 227491 2014-03-21 14:32:09 -0700 2014-03-21 14:47:37 -0700 Patch bug-130617-20140321143146.patch text/plain 1945 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTAzLTIxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgNiUgU3VuU3BpZGVyIGNvbW1hbmRsaW5lIHJlZ3Jlc3Npb24gZHVlIHRvIHIxNjU5 NDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDYx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEdD QWN0aXZpdHlDYWxsYmFjazo6ZGlkQWxsb2NhdGUsIGxhc3RHQ0xlbmd0aCgpIHJldHVybnMgMCBp ZiB3ZSd2ZSBuZXZlciBjb2xsZWN0ZWQgCisgICAgICAgIGJlZm9yZS4gU29tZSBvZiB0aGUgYmVu Y2htYXJrcyBhcmUgbmV2ZXIgcnVubmluZyBhIHNpbmdsZSBFZGVuQ29sbGVjdGlvbiwgd2hpY2gg Y2F1c2VzIAorICAgICAgICB0aGVtIHRvIHJlcGVhdGVkbHkgY2FsbCBzY2hlZHVsZVRpbWVyIHdp dGggYSBuZXdEZWxheSBvZiAwLiBUaGlzIGRlZmVhdHMgb3VyIHRpbWVyIAorICAgICAgICBzbG9w IGhldXJpc3RpYywgY2F1c2luZyB1cyB0byBpbnZva2UgQ0ZSdW5Mb29wVGltZXJTZXROZXh0Rmly ZURhdGUgYSBjb3VwbGUgb3JkZXJzIG9mIAorICAgICAgICBtYWduaXR1ZGUgbW9yZSB0aGFuIHdl IG5vcm1hbGx5IHdvdWxkLgorCisgICAgICAgIFRoZSBmaXggaXMgdG8gc2VlZCB0aGUgbGFzdCBH QyBsZW5ndGhzIGluIEhlYXAgd2l0aCBhIG5vbi16ZXJvIGxlbmd0aCBzbyB0aGF0IG91ciBoZXVy aXN0aWMgd29ya3MuCisKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpI ZWFwOjpIZWFwKToKKwogMjAxNC0wMy0yMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIENvbnN0YW50cyBmb2xkZWQgYnkgREZHOjpCeXRlQ29kZVBhcnNlciBzaG91 bGQgbm90IGJlIGRlYWQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2 aXNpb24gMTY1OTQwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI4MCw4ICsyODAsMTAgQEAgSGVhcDo6SGVhcChWTSogdm0sIEhlYXBU eXBlIGhlYXBUeXBlKQogICAgICwgbV9pc1NhZmVUb0NvbGxlY3QoZmFsc2UpCiAgICAgLCBtX3dy aXRlQmFycmllckJ1ZmZlcigyNTYpCiAgICAgLCBtX3ZtKHZtKQotICAgICwgbV9sYXN0RnVsbEdD TGVuZ3RoKDApCi0gICAgLCBtX2xhc3RFZGVuR0NMZW5ndGgoMCkKKyAgICAvLyBXZSBzZWVkIHdp dGggMTBtcyBzbyB0aGF0IEdDQWN0aXZpdHlDYWxsYmFjazo6ZGlkQWxsb2NhdGUgZG9lc24ndCBj b250aW51b3VzbHkgCisgICAgLy8gc2NoZWR1bGUgdGhlIHRpbWVyIGlmIHdlJ3ZlIG5ldmVyIGRv bmUgYSBjb2xsY3Rpb24uCisgICAgLCBtX2xhc3RGdWxsR0NMZW5ndGgoMC4wMSkKKyAgICAsIG1f bGFzdEVkZW5HQ0xlbmd0aCgwLjAxKQogICAgICwgbV9sYXN0Q29kZURpc2NhcmRUaW1lKFdURjo6 bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkpCiAgICAgLCBtX2Z1bGxBY3Rpdml0eUNhbGxi YWNrKEdDQWN0aXZpdHlDYWxsYmFjazo6Y3JlYXRlRnVsbFRpbWVyKHRoaXMpKQogI2lmIEVOQUJM RShHR0MpCg==