130597 2014-03-21 09:08:47 -0700 Windows doesn't build with video disabled 2014-03-21 12:04:55 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Minor --- 1 alex.christensen webkit-unassigned commit-queue eric.carlson glenn jer.noble philipj sergio oldest_to_newest 993123 0 alex.christensen 2014-03-21 09:08:47 -0700 Here are some compile fixes from WinCairo without video enabled. 993128 1 227442 alex.christensen 2014-03-21 09:12:32 -0700 Created attachment 227442 Patch 993228 2 eric.carlson 2014-03-21 11:27:18 -0700 Those missing #if ENABLE(VIDEO)s were my fault, sorry! 993247 3 227442 commit-queue 2014-03-21 12:04:50 -0700 Comment on attachment 227442 Patch Clearing flags on attachment: 227442 Committed r166085: <http://trac.webkit.org/changeset/166085> 993248 4 commit-queue 2014-03-21 12:04:55 -0700 All reviewed patches have been landed. Closing bug. 227442 2014-03-21 09:12:32 -0700 2014-03-21 12:04:50 -0700 Patch bug-130597-20140321101214.patch text/plain 5269 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjA2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTIxICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbl0gQ29t cGlsZSBmaXhlcyB3aXRoIHZpZGVvIG5vdCBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5tYWtlOgorICAgICAg ICBPbmx5IGdlbmVyYXRlIFVzZXJBZ2VudFNjcmlwdHMuaCBpZiBuZWVkZWQuCisgICAgICAgICog cGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRp by9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcDoKKyAgICAgICAgT25seSBjb21waWxlIGlmIHZpZGVv IGlzIGVuYWJsZWQuCisKIDIwMTQtMDMtMjEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFN0b3AgdXNpbmcgZGVwcmVjYXRlZENoYXJhY3RlcnMgaW4gV2ViQ29yZS9w bGF0Zm9ybS93aW4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQkocmV2aXNpb24g MTY2MDY0KQorKysgU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQkod29ya2luZyBj b3B5KQpAQCAtNzUyLDcgKzc1Miw2IEBAIGFsbCA6IFwKICAgICBTVkdFbGVtZW50RmFjdG9yeS5j cHAgXAogICAgIFNWR05hbWVzLmNwcCBcCiAgICAgU2VsZWN0b3JQc2V1ZG9UeXBlTWFwLmNwcCBc Ci0gICAgVXNlckFnZW50U2NyaXB0cy5oIFwKICAgICBVc2VyQWdlbnRTdHlsZVNoZWV0cy5oIFwK ICAgICBXZWJLaXRGb250RmFtaWx5TmFtZXMuY3BwIFwKICAgICBXZWJLaXRGb250RmFtaWx5TmFt ZXMuaCBcCkBAIC05MTQsNiArOTEzLDggQEAgaWZlcSAoJChPUyksTUFDT1MpCiBlbmRpZgogCiBp ZmRlZiBVU0VSX0FHRU5UX1NDUklQVFMKK2FsbCA6IFVzZXJBZ2VudFNjcmlwdHMuaAorCiBVc2Vy QWdlbnRTY3JpcHRzLmggOiBTY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkgJChVU0VSX0FH RU5UX1NDUklQVFMpCiAJUFlUSE9OUEFUSD0kKEluc3BlY3RvclNjcmlwdHMpIHB5dGhvbiAkPCAk QCBVc2VyQWdlbnRTY3JpcHRzRGF0YS5jcHAgJChVU0VSX0FHRU5UX1NDUklQVFMpCiBlbmRpZgpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVkaWFTZXNzaW9uLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb24uY3Bw CShyZXZpc2lvbiAxNjYwNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRp YVNlc3Npb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAi Y29uZmlnLmgiCiAjaW5jbHVkZSAiTWVkaWFTZXNzaW9uLmgiCiAKKyNpZiBFTkFCTEUoVklERU8p CiAjaW5jbHVkZSAiSFRNTE1lZGlhRWxlbWVudC5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNp bmNsdWRlICJNZWRpYVBsYXllci5oIgpAQCAtMTc1LDMgKzE3Niw0IEBAIGRvdWJsZSBNZWRpYVNl c3Npb25DbGllbnQ6Om1lZGlhU2Vzc2lvbkMKIH0KIAogfQorI2VuZGlmCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NZWRpYVNlc3Npb25NYW5hZ2VyLmNw cAkocmV2aXNpb24gMTY2MDY0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTWVk aWFTZXNzaW9uTWFuYWdlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDggQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJNZWRpYVNlc3Npb25NYW5hZ2VyLmgiCiAKKyNp ZiBFTkFCTEUoVklERU8pCisKICNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTWVkaWFT ZXNzaW9uLmgiCiAKQEAgLTMwMCwzICszMDIsNSBAQCB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXI6 OnJlbW92ZUNsaWVudChNCiB9CiAKIH0KKworI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0L0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24g MTY2MDY0KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0wMy0yMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgorCisgICAgICAgIFtXaW5dIENvbXBpbGUgZml4ZXMgd2l0aCB2aWRlbyBub3Qg ZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMDU5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVm LmluOgorICAgICAgICBPbmx5IGluY2x1ZGUgTWVkaWFTZXNzaW9uTWFuYWdlciBzeW1ib2xzIGlm IHZpZGVvIGlzIGVuYWJsZWQuCisKIDIwMTQtMDMtMjEgIFByYXRpayBTb2xhbmtpICA8cHNvbGFu a2lAYXBwbGUuY29tPgogCiAgICAgICAgIENoZWNrIGZvciBpbmFwcHJvcHJpYXRlIG1hY3JvcyBp biBwcml2YXRlIGhlYWRlcnMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2Vi S2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4cG9ydHMuZGVmLmluCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktpdEV4 cG9ydHMuZGVmLmluCShyZXZpc2lvbiAxNjYwNjQpCisrKyBTb3VyY2UvV2ViS2l0L1dlYktpdC52 Y3hwcm9qL1dlYktpdEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBvcnRzLmRlZi5pbgkod29ya2lu ZyBjb3B5KQpAQCAtMjQzLDYgKzI0Myw3IEBAIEVYUE9SVFMKICAgICAgICAgc3ltYm9sV2l0aFBv aW50ZXIoP21hcmtlclRleHRGb3JMaXN0SXRlbUBXZWJDb3JlQEBZQT9BVlN0cmluZ0BXVEZAQFBB VkVsZW1lbnRAMUBAWiwgP21hcmtlclRleHRGb3JMaXN0SXRlbUBXZWJDb3JlQEBZQT9BVlN0cmlu Z0BXVEZAQFBFQVZFbGVtZW50QDFAQFopCiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9sZW5n dGhAU3RhdGljTm9kZUxpc3RAV2ViQ29yZUBAVUJFSVhaLCA/bGVuZ3RoQFN0YXRpY05vZGVMaXN0 QFdlYkNvcmVAQFVFQkFJWFopCiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9zaGFkb3dSb290 QEVsZW1lbnRAV2ViQ29yZUBAUUJFUEFWU2hhZG93Um9vdEAyQFhaLCA/c2hhZG93Um9vdEBFbGVt ZW50QFdlYkNvcmVAQFFFQkFQRUFWU2hhZG93Um9vdEAyQFhaKQorI2lmIEVOQUJMRShWSURFTykK ICAgICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoP3NoYXJlZE1hbmFnZXJATWVkaWFTZXNzaW9uTWFu YWdlckBXZWJDb3JlQEBTQUFBVjEyQFhaLCA/c2hhcmVkTWFuYWdlckBNZWRpYVNlc3Npb25NYW5h Z2VyQFdlYkNvcmVAQFNBQUVBVjEyQFhaKQogICAgICAgICBzeW1ib2xXaXRoUG9pbnRlcig/YmVn aW5JbnRlcnJ1cHRpb25ATWVkaWFTZXNzaW9uTWFuYWdlckBXZWJDb3JlQEBRQUVYWFosID9iZWdp bkludGVycnVwdGlvbkBNZWRpYVNlc3Npb25NYW5hZ2VyQFdlYkNvcmVAQFFFQUFYWFopCiAgICAg ICAgIHN5bWJvbFdpdGhQb2ludGVyKD9lbmRJbnRlcnJ1cHRpb25ATWVkaWFTZXNzaW9uTWFuYWdl ckBXZWJDb3JlQEBRQUVYVzRFbmRJbnRlcnJ1cHRpb25GbGFnc0BNZWRpYVNlc3Npb25AMkBAWiwg P2VuZEludGVycnVwdGlvbkBNZWRpYVNlc3Npb25NYW5hZ2VyQFdlYkNvcmVAQFFFQUFYVzRFbmRJ bnRlcnJ1cHRpb25GbGFnc0BNZWRpYVNlc3Npb25AMkBAWikKQEAgLTI1MSw2ICsyNTIsNyBAQCBF WFBPUlRTCiAgICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9yZXN0cmljdGlvbnNATWVkaWFTZXNz aW9uTWFuYWdlckBXZWJDb3JlQEBRQUVJVzRNZWRpYVR5cGVATWVkaWFTZXNzaW9uQDJAQFosID9y ZXN0cmljdGlvbnNATWVkaWFTZXNzaW9uTWFuYWdlckBXZWJDb3JlQEBRRUFBSVc0TWVkaWFUeXBl QE1lZGlhU2Vzc2lvbkAyQEBaKQogICAgICAgICBzeW1ib2xXaXRoUG9pbnRlcig/YXBwbGljYXRp b25XaWxsRW50ZXJGb3JlZ3JvdW5kQE1lZGlhU2Vzc2lvbk1hbmFnZXJAV2ViQ29yZUBAUUJFWFha LCA/YXBwbGljYXRpb25XaWxsRW50ZXJGb3JlZ3JvdW5kQE1lZGlhU2Vzc2lvbk1hbmFnZXJAV2Vi Q29yZUBAUUVCQVhYWikKICAgICAgICAgc3ltYm9sV2l0aFBvaW50ZXIoP2FwcGxpY2F0aW9uV2ls bEVudGVyQmFja2dyb3VuZEBNZWRpYVNlc3Npb25NYW5hZ2VyQFdlYkNvcmVAQFFCRVhYWiwgP2Fw cGxpY2F0aW9uV2lsbEVudGVyQmFja2dyb3VuZEBNZWRpYVNlc3Npb25NYW5hZ2VyQFdlYkNvcmVA QFFFQkFYWFopCisgI2VuZGlmCiAgICAgICAgID9sb2NhbFVzZXJTcGVjaWZpY1N0b3JhZ2VEaXJl Y3RvcnlAV2ViQ29yZUBAWUE/QVZTdHJpbmdAV1RGQEBYWgogICAgICAgICBzeW1ib2xXaXRoUG9p bnRlcig/bmFtZWRJdGVtQFN0YXRpY05vZGVMaXN0QFdlYkNvcmVAQFVCRVBBVk5vZGVAMkBBQlZB dG9taWNTdHJpbmdAV1RGQEBAWiwgP25hbWVkSXRlbUBTdGF0aWNOb2RlTGlzdEBXZWJDb3JlQEBV RUJBUEVBVk5vZGVAMkBBRUJWQXRvbWljU3RyaW5nQFdURkBAQFopCiAgICAgICAgID9udW1iZXJA U3RyaW5nQFdURkBAU0E/QVYxMkBfSkBaCg==