130589 2014-03-21 06:42:18 -0700 [webkitpy] Fix has_valid_reviewer() 2014-03-21 07:50:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evab.u-szeged webkit-unassigned commit-queue evab.u-szeged glenn ossy rgabor oldest_to_newest 993059 0 evab.u-szeged 2014-03-21 06:42:18 -0700 has_valid_reviewer() in Tools/Scripts/webkitpy/common/checkout/changelog.py returns with true for committers too, not only for reviewers 993061 1 227427 evab.u-szeged 2014-03-21 06:46:02 -0700 Created attachment 227427 Patch 993067 2 ossy 2014-03-21 07:04:02 -0700 It's so ugly bug. :) The patch looks good to me. Gábor do you permit us to use your name in the unittest? Unfortunately this test should be updated once you become a reviewer. ;) 993072 3 rgabor 2014-03-21 07:11:05 -0700 (In reply to comment #2) > It's so ugly bug. :) The patch looks good to me. Gábor do you permit > us to use your name in the unittest? Unfortunately this test should > be updated once you become a reviewer. ;) Of course, I'm honored :) 993078 4 227427 ossy 2014-03-21 07:17:14 -0700 Comment on attachment 227427 Patch OK, r=me 993095 5 227427 commit-queue 2014-03-21 07:50:02 -0700 Comment on attachment 227427 Patch Clearing flags on attachment: 227427 Committed r166062: <http://trac.webkit.org/changeset/166062> 993096 6 commit-queue 2014-03-21 07:50:05 -0700 All reviewed patches have been landed. Closing bug. 227427 2014-03-21 06:46:02 -0700 2014-03-21 07:50:02 -0700 Patch bug-130589-20140321144539.patch text/plain 3915 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGVhZTAwYzJjMGVmZWIzYTQ4N2ZlM2QxMzFmMGFlYjNh OGVmNGQxOC4uOTIzNTg5MDYzYmY1NjFmYjBkZTdlMjhlZjgzMTU2N2M0ZDI4N2FmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE0LTAzLTIxICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW3dlYmtpdHB5XSBGaXggaGFzX3ZhbGlkX3Jldmlld2Vy KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDU4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5OgorICAgICAgICAoQ2hh bmdlTG9nRW50cnkuaGFzX3ZhbGlkX3Jldmlld2VyKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2dfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0 X2hhc192YWxpZF9yZXZpZXdlcik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2NvbW1pdHRlcnMucHk6CisgICAgICAgIChDb21taXR0ZXJMaXN0Ll9yZXZpZXdlcl9v bmx5KToKKyAgICAgICAgKENvbW1pdHRlckxpc3QuY29tbWl0dGVyX2J5X25hbWUpOgorICAgICAg ICAoQ29tbWl0dGVyTGlzdC5yZXZpZXdlcl9ieV9lbWFpbCk6CisgICAgICAgIChDb21taXR0ZXJM aXN0KToKKyAgICAgICAgKENvbW1pdHRlckxpc3QucmV2aWV3ZXJfYnlfbmFtZSk6CisKIDIwMTQt MDMtMjEgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbQ01ha2VdIEFkZCBzdXBwb3J0IGZvciBNQVhfQ1BVX0xPQUQgdHJhbnNsYXRlZCB0 byAtbCBpbiBuaW5qYSBhbmQgbWFrZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5CmluZGV4IDQwMjYwYjNlYmRjY2Y1Mzg3MTIwZTIy ZDc0YmVhNjgzZGFhNGJmOGQuLjUzZmE1Yjg2ODE2ZGJjYzEwYjk2MmRkNDY2MDA0MDQxMmNmOGVj ZmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2No YW5nZWxvZy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9j aGFuZ2Vsb2cucHkKQEAgLTI1Nyw3ICsyNTcsNyBAQCBjbGFzcyBDaGFuZ2VMb2dFbnRyeShvYmpl Y3QpOgogICAgIGRlZiBoYXNfdmFsaWRfcmV2aWV3ZXIoc2VsZik6CiAgICAgICAgIGlmIHNlbGYu X3Jldmlld2Vyc190ZXh0X2xpc3Q6CiAgICAgICAgICAgICBmb3IgcmV2aWV3ZXIgaW4gc2VsZi5f cmV2aWV3ZXJzX3RleHRfbGlzdDoKLSAgICAgICAgICAgICAgICByZXZpZXdlciA9IHNlbGYuX2Nv bW1pdHRlcl9saXN0LmNvbW1pdHRlcl9ieV9uYW1lKHJldmlld2VyKQorICAgICAgICAgICAgICAg IHJldmlld2VyID0gc2VsZi5fY29tbWl0dGVyX2xpc3QucmV2aWV3ZXJfYnlfbmFtZShyZXZpZXdl cikKICAgICAgICAgICAgICAgICBpZiByZXZpZXdlcjoKICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIFRydWUKICAgICAgICAgcmV0dXJuIGJvb2wocmUuc2VhcmNoKCJ1bnJldmlld2VkIiwgc2Vs Zi5fY29udGVudHMsIHJlLklHTk9SRUNBU0UpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5CmluZGV4 IDk4ZmM5OWU5ZDJlZTU5ZDE4Y2M3Y2Q1YWE3OGY2MGViMzFhYTljYTIuLjIwMjYxOTI3YTE4Y2U4 YzAzYTIxZjUzYzA2MTRhOGFkNjNlMDg3MzQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkKQEAg LTQ3MSw2ICs0NzEsNyBAQCBjbGFzcyBDaGFuZ2VMb2dUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK ICAgICAgICAgc2VsZi5fYXNzZXJ0X2hhc192YWxpZF9yZXZpZXdlcigiUnViYmVyIHN0YW1wZWQg YnkgRXJpYy4iLCBGYWxzZSkKICAgICAgICAgc2VsZi5fYXNzZXJ0X2hhc192YWxpZF9yZXZpZXdl cigiUnViYmVyIHN0YW1wZWQgYnkgRXJpYyBTZWlkZWwuIiwgVHJ1ZSkKICAgICAgICAgc2VsZi5f YXNzZXJ0X2hhc192YWxpZF9yZXZpZXdlcigiVW5yZXZpZXdlZCBidWlsZCBmaXguIiwgVHJ1ZSkK KyAgICAgICAgc2VsZi5fYXNzZXJ0X2hhc192YWxpZF9yZXZpZXdlcigiUmV2aWV3ZWQgYnkgR2Fi b3IgUmFwY3NhbnlpLiIsIEZhbHNlKQogCiAgICAgZGVmIHRlc3RfaXNfdG91Y2hlZF9maWxlc190 ZXh0X2NsZWFuKHNlbGYpOgogICAgICAgICB0ZXN0cyA9IFsKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkKaW5kZXggNjJhMDkzMjllOTE1 N2Q1NjY2ZmExMmQ0MmRlZWIwZmZhMTI4ZWM0YS4uNmVhZWRmYWFmOWEzZTFhNjZjOThlODQ3ODMw OGIyYWI3N2ZjYzg0NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2NvbW1pdHRlcnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2NvbW1pdHRlcnMucHkKQEAgLTE4NCw5ICsxODQsNiBAQCBjbGFzcyBDb21taXR0ZXJM aXN0KG9iamVjdCk6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQogICAgICAgICByZXR1cm4gcmVj b3JkCiAKLSAgICBkZWYgY29tbWl0dGVyX2J5X25hbWUoc2VsZiwgbmFtZSk6Ci0gICAgICAgIHJl dHVybiBzZWxmLl9jb21taXR0ZXJfb25seShzZWxmLmNvbnRyaWJ1dG9yX2J5X25hbWUobmFtZSkp Ci0KICAgICBkZWYgY29udHJpYnV0b3JfYnlfaXJjX25pY2tuYW1lKHNlbGYsIGlyY19uaWNrbmFt ZSk6CiAgICAgICAgIGZvciBjb250cmlidXRvciBpbiBzZWxmLmNvbnRyaWJ1dG9ycygpOgogICAg ICAgICAgICAgIyBGSVhNRTogVGhpcyBzaG91bGQgZG8gY2FzZS1pbnNlbnNpdGl2ZSBjb21wYXJp c29uIG9yIGFzc2VydCB0aGF0IGFsbCBJUkMgbmlja25hbWVzIGFyZSBpbiBsb3dlcmNhc2UKQEAg LTI2OSw1ICsyNjYsMTEgQEAgY2xhc3MgQ29tbWl0dGVyTGlzdChvYmplY3QpOgogICAgIGRlZiBj b21taXR0ZXJfYnlfZW1haWwoc2VsZiwgZW1haWwpOgogICAgICAgICByZXR1cm4gc2VsZi5fY29t bWl0dGVyX29ubHkoc2VsZi5jb250cmlidXRvcl9ieV9lbWFpbChlbWFpbCkpCiAKKyAgICBkZWYg Y29tbWl0dGVyX2J5X25hbWUoc2VsZiwgbmFtZSk6CisgICAgICAgIHJldHVybiBzZWxmLl9jb21t aXR0ZXJfb25seShzZWxmLmNvbnRyaWJ1dG9yX2J5X25hbWUobmFtZSkpCisKICAgICBkZWYgcmV2 aWV3ZXJfYnlfZW1haWwoc2VsZiwgZW1haWwpOgogICAgICAgICByZXR1cm4gc2VsZi5fcmV2aWV3 ZXJfb25seShzZWxmLmNvbnRyaWJ1dG9yX2J5X2VtYWlsKGVtYWlsKSkKKworICAgIGRlZiByZXZp ZXdlcl9ieV9uYW1lKHNlbGYsIGVtYWlsKToKKyAgICAgICAgcmV0dXJuIHNlbGYuX3Jldmlld2Vy X29ubHkoc2VsZi5jb250cmlidXRvcl9ieV9uYW1lKGVtYWlsKSkK