<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>130585</bug_id>
          
          <creation_ts>2014-03-21 05:58:56 -0700</creation_ts>
          <short_desc>[GTK] [EFL] Build fails with GCC &lt; 4.8.x</short_desc>
          <delta_ts>2014-04-08 00:38:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>130078</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Andres Gomez Garcia">agomez</reporter>
          <assigned_to name="Andres Gomez Garcia">agomez</assigned_to>
          <cc>agomez</cc>
    
    <cc>andersca</cc>
    
    <cc>benjamin</cc>
    
    <cc>berto</cc>
    
    <cc>bunhere</cc>
    
    <cc>calvaris</cc>
    
    <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>dpino</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>eric</cc>
    
    <cc>glenn</cc>
    
    <cc>gustavo</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jer.noble</cc>
    
    <cc>kling</cc>
    
    <cc>menard</cc>
    
    <cc>mrobinson</cc>
    
    <cc>philipj</cc>
    
    <cc>pnormand</cc>
    
    <cc>rakuco</cc>
    
    <cc>sergio</cc>
    
    <cc>vjaquez</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>993040</commentid>
    <comment_count>0</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 05:58:56 -0700</bug_when>
    <thetext>(webkit)tanty@pomeron:~/webkit/WebKit.git (git::master)$ Tools/Scripts/build-webkit --release --gtk --update-gtk --cmakeargs=&quot;-GNinja -j8&quot; --makeargs=&quot;-j8&quot;
...
[77/5629] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/MainThreadGtk.cpp.o
FAILED: /usr/lib/ccache/c++   -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DDATA_DIR=\&quot;share\&quot; -DENABLE_3D_RENDERING=1 -DGETTEXT_PACKAGE=\&quot;WebKitGTK-3.0\&quot; -DHAVE_CONFIG_H=1 -DMOZ_X11 -DUSER_AGENT_GTK_MAJOR_VERSION=537 -DUSER_AGENT_GTK_MINOR_VERSION=30 -DWEBKITGTK_API_VERSION_STRING=\&quot;3.0\&quot; -DWTF_PLATFORM_X11=1 -DWTF_USE_3D_GRAPHICS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DWTF_USE_EGL=1 -DWTF_USE_GLX=1 -DWTF_USE_GSTREAMER -DWTF_USE_LEVELDB=1 -DWTF_USE_OPENGL=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_WEBAUDIO_GSTREAMER -DXP_UNIX -std=c++11 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-omit-frame-pointer -fno-tree-dce -O3 -DNDEBUG -I../../Source/WTF -I../../Source/WTF/wtf -I../../Source/WTF/wtf/dtoa -I../../Source/WTF/wtf/threads -I../../Source/WTF/wtf/unicode -I../../Source/ThirdParty -I. -I../Dependencies/Root/include/glib-2.0 -I../Dependencies/Root/lib64/glib-2.0/include    -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -fPIC -MMD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/MainThreadGtk.cpp.o -MF &quot;Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/MainThreadGtk.cpp.o.d&quot; -o Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/MainThreadGtk.cpp.o -c ../../Source/WTF/wtf/gtk/MainThreadGtk.cpp
../../Source/WTF/wtf/gtk/MainThreadGtk.cpp: In function ‘void WTF::scheduleDispatchFunctionsOnMainThread()’:
../../Source/WTF/wtf/gtk/MainThreadGtk.cpp:43:133: error: call of overloaded ‘schedule(const char [41], void (&amp;)())’ is ambiguous
../../Source/WTF/wtf/gtk/MainThreadGtk.cpp:43:133: note: candidates are:
In file included from ../../Source/WTF/wtf/gtk/MainThreadGtk.cpp:33:0:
../../Source/WTF/wtf/gobject/GMainLoopSource.h:53:10: note: void WTF::GMainLoopSource::schedule(const char*, std::function&lt;void()&gt;, int, std::function&lt;void()&gt;, GMainContext*)
In file included from ../../Source/WTF/wtf/gtk/MainThreadGtk.cpp:33:0:
../../Source/WTF/wtf/gobject/GMainLoopSource.h:54:10: note: void WTF::GMainLoopSource::schedule(const char*, std::function&lt;bool()&gt;, int, std::function&lt;void()&gt;, GMainContext*)
[77/5629] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/RunLoopGtk.cpp.o
FAILED: /usr/lib/ccache/c++   -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DDATA_DIR=\&quot;share\&quot; -DENABLE_3D_RENDERING=1 -DGETTEXT_PACKAGE=\&quot;WebKitGTK-3.0\&quot; -DHAVE_CONFIG_H=1 -DMOZ_X11 -DUSER_AGENT_GTK_MAJOR_VERSION=537 -DUSER_AGENT_GTK_MINOR_VERSION=30 -DWEBKITGTK_API_VERSION_STRING=\&quot;3.0\&quot; -DWTF_PLATFORM_X11=1 -DWTF_USE_3D_GRAPHICS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DWTF_USE_EGL=1 -DWTF_USE_GLX=1 -DWTF_USE_GSTREAMER -DWTF_USE_LEVELDB=1 -DWTF_USE_OPENGL=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_WEBAUDIO_GSTREAMER -DXP_UNIX -std=c++11 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-omit-frame-pointer -fno-tree-dce -O3 -DNDEBUG -I../../Source/WTF -I../../Source/WTF/wtf -I../../Source/WTF/wtf/dtoa -I../../Source/WTF/wtf/threads -I../../Source/WTF/wtf/unicode -I../../Source/ThirdParty -I. -I../Dependencies/Root/include/glib-2.0 -I../Dependencies/Root/lib64/glib-2.0/include    -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -fPIC -MMD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/RunLoopGtk.cpp.o -MF &quot;Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/RunLoopGtk.cpp.o.d&quot; -o Source/WTF/wtf/CMakeFiles/WTF.dir/gtk/RunLoopGtk.cpp.o -c ../../Source/WTF/wtf/gtk/RunLoopGtk.cpp
../../Source/WTF/wtf/gtk/RunLoopGtk.cpp: In member function ‘void WTF::RunLoop::wakeUp()’:
../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:104:31: error: call of overloaded ‘schedule(const char [22], std::_Bind_helper&lt;false, void (WTF::RunLoop::*)(), WTF::RunLoop* const&gt;::type, int, WTF::RunLoop::wakeUp()::&lt;lambda()&gt;)’ is ambiguous
../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:104:31: note: candidates are:
In file included from ../../Source/WTF/wtf/RunLoop.h:40:0,
                 from ../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:28:
../../Source/WTF/wtf/gobject/GMainLoopSource.h:53:10: note: void WTF::GMainLoopSource::schedule(const char*, std::function&lt;void()&gt;, int, std::function&lt;void()&gt;, GMainContext*)
In file included from ../../Source/WTF/wtf/RunLoop.h:40:0,
                 from ../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:28:
../../Source/WTF/wtf/gobject/GMainLoopSource.h:54:10: note: void WTF::GMainLoopSource::schedule(const char*, std::function&lt;bool()&gt;, int, std::function&lt;void()&gt;, GMainContext*)
[77/5629] Building CXX object Source/WebCore/CMakeFiles/ANGLESupport.dir/__/ThirdParty/ANGLE/src/compiler/translator/SearchSymbol.cpp.o
ninja: build stopped: subcommand failed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993041</commentid>
    <comment_count>1</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:00:12 -0700</bug_when>
    <thetext>This error happens after fixing bug 130027:
http://trac.webkit.org/changeset/165952</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993042</commentid>
    <comment_count>2</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:01:41 -0700</bug_when>
    <thetext>(webkit)tanty@pomeron:~/webkit/WebKit.git (git::master)$ gcc --version
gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993044</commentid>
    <comment_count>3</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:03:09 -0700</bug_when>
    <thetext>The behavior is explained at:
http://stackoverflow.com/questions/22146749/overload-resolution-with-stdfunction

And seems to be related to:
http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2132

Possible options are:
 * Provide a explicit cast for the failing overloads
 * Bump the mimum GCC version up to 4.8.x</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993046</commentid>
    <comment_count>4</comment_count>
      <attachid>227423</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:10:48 -0700</bug_when>
    <thetext>Created attachment 227423
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993055</commentid>
    <comment_count>5</comment_count>
      <attachid>227425</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:39:25 -0700</bug_when>
    <thetext>Created attachment 227425
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993056</commentid>
    <comment_count>6</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:40:10 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Created an attachment (id=227425) [details]
&gt; Patch

This is an alternative patch just bumping GCC version to 4.8.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993060</commentid>
    <comment_count>7</comment_count>
      <attachid>227423</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-03-21 06:43:58 -0700</bug_when>
    <thetext>Comment on attachment 227423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227423&amp;action=review

&gt; Source/WTF/wtf/gtk/MainThreadGtk.cpp:43
&gt; -    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] dispatchFunctionsFromMainThread&quot;, dispatchFunctionsFromMainThread);
&gt; +    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] dispatchFunctionsFromMainThread&quot;, (std::function&lt;void()&gt;) dispatchFunctionsFromMainThread);

Using the std::function&lt;void ()&gt; constructor would be more in line with the coding style than the C-style cast:

    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] dispatchFunctionsFromMainThread&quot;, std::function&lt;void ()&gt;(dispatchFunctionsFromMainThread));

&gt; Source/WTF/wtf/gtk/RunLoopGtk.cpp:103
&gt; -    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, std::bind(&amp;RunLoop::performWork, this),
&gt; +    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, (std::function&lt;void()&gt;) std::bind(&amp;RunLoop::performWork, this),

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993062</commentid>
    <comment_count>8</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-21 06:46:29 -0700</bug_when>
    <thetext>I prefer to bump the gcc requirements than adding unnecessary casts to workaround the issue, even more considering that it doesn&apos;t fail to compile with clang either.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993063</commentid>
    <comment_count>9</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-03-21 06:47:46 -0700</bug_when>
    <thetext>I&apos;m of indifferent opinion here. We&apos;ll bump to GCC 4.8.0 at some point, so we might as well do it now if there&apos;s consent for that. If EFL can&apos;t yet commit to bumping, we can only deploy this requirement for the GTK port.

But I&apos;m fine with the changes in attachment #227423 as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993065</commentid>
    <comment_count>10</comment_count>
      <attachid>227428</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 06:59:41 -0700</bug_when>
    <thetext>Created attachment 227428
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993069</commentid>
    <comment_count>11</comment_count>
      <attachid>227429</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 07:05:47 -0700</bug_when>
    <thetext>Created attachment 227429
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993071</commentid>
    <comment_count>12</comment_count>
      <attachid>227423</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 07:09:52 -0700</bug_when>
    <thetext>Comment on attachment 227423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227423&amp;action=review

&gt;&gt; Source/WTF/wtf/gtk/MainThreadGtk.cpp:43
&gt;&gt; +    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] dispatchFunctionsFromMainThread&quot;, (std::function&lt;void()&gt;) dispatchFunctionsFromMainThread);
&gt; 
&gt; Using the std::function&lt;void ()&gt; constructor would be more in line with the coding style than the C-style cast:
&gt; 
&gt;     GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] dispatchFunctionsFromMainThread&quot;, std::function&lt;void ()&gt;(dispatchFunctionsFromMainThread));

You are right, I just messed up because of reading http://www.stroustrup.com/C++11FAQ.html#std-function and the examples for expliciting the overloaded functions in the std::bind examples O:)

&gt;&gt; Source/WTF/wtf/gtk/RunLoopGtk.cpp:103
&gt;&gt; +    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, (std::function&lt;void()&gt;) std::bind(&amp;RunLoop::performWork, this),
&gt; 
&gt; Ditto.

Done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993080</commentid>
    <comment_count>13</comment_count>
      <attachid>227428</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 07:18:02 -0700</bug_when>
    <thetext>Comment on attachment 227428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227428&amp;action=review

&gt; Source/cmake/OptionsGTK.cmake:311
&gt; +        message(FATAL_ERROR &quot;You need at least GCC 4.8.0 and current version is ${CMAKE_CXX_COMPILER_VERSION}&quot;)

Modified the previous patch so this error condition only happens for the GTK port.

Now, it seems that there is shared GStreamer code with the EFL port that would fail also because of the same reason:
https://bugs.webkit.org/show_bug.cgi?id=130078

Hence, I suppose the original patch was actually better than this, now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993081</commentid>
    <comment_count>14</comment_count>
      <attachid>227428</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-21 07:20:41 -0700</bug_when>
    <thetext>Comment on attachment 227428
Patch

We cannot bump our dependencies until the next major release. Seems silly to do it for something that has a trivial workaround too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993087</commentid>
    <comment_count>15</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-03-21 07:36:22 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; (From update of attachment 227428 [details])
&gt; We cannot bump our dependencies until the next major release. Seems silly to do it for something that has a trivial workaround too.

This is a building dependency, not a running one, so I&apos;m not sure it would then be a reason to wait until a major release.

In any case, I&apos;m all for going with explicit casts :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993089</commentid>
    <comment_count>16</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-21 07:42:47 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #14)
&gt; &gt; (From update of attachment 227428 [details] [details])
&gt; &gt; We cannot bump our dependencies until the next major release. Seems silly to do it for something that has a trivial workaround too.
&gt; 
&gt; This is a building dependency, not a running one, so I&apos;m not sure it would then be a reason to wait until a major release.

Exactly.
 
&gt; In any case, I&apos;m all for going with explicit casts :)

I would add a FIXME or something, since it&apos;s a workaround that works with newer gcc and clang. I prefer to keep the code clone and less confusing and bump the gcc requirements.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993090</commentid>
    <comment_count>17</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-21 07:44:15 -0700</bug_when>
    <thetext>(In reply to comment #16)

&gt; &gt; This is a building dependency, not a running one, so I&apos;m not sure it would then be a reason to wait until a major release.
&gt; 
&gt; Exactly.

My understanding is that if you cannot build it on old Debian, you cannot ship it on old Debian. Perhaps that&apos;s not how it works though?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993599</commentid>
    <comment_count>18</comment_count>
      <attachid>227429</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-03-22 17:49:55 -0700</bug_when>
    <thetext>Comment on attachment 227429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227429&amp;action=review

&gt; Source/WTF/wtf/gtk/RunLoopGtk.cpp:104
&gt; +    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, std::function&lt;void()&gt;(std::bind(&amp;RunLoop::performWork, this)),
&gt;          G_PRIORITY_DEFAULT, [this] { deref(); });

Please use a lambda with a RefPtr capture here instead of calling ref and deref.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993768</commentid>
    <comment_count>19</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-24 03:10:41 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; (From update of attachment 227429 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=227429&amp;action=review
&gt; 
&gt; &gt; Source/WTF/wtf/gtk/RunLoopGtk.cpp:104
&gt; &gt; +    GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, std::function&lt;void()&gt;(std::bind(&amp;RunLoop::performWork, this)),
&gt; &gt;          G_PRIORITY_DEFAULT, [this] { deref(); });
&gt; 
&gt; Please use a lambda with a RefPtr capture here instead of calling ref and deref.

I thought about it, but then the lambda does nothing and it looked more confusing to me, is that preferred?

I guess it would be something like

RefPtr&lt;RunLoop&gt; protector(this);
GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, std::function&lt;void()&gt;(std::bind(&amp;RunLoop::performWork, this)), [protector] {});

right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993769</commentid>
    <comment_count>20</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-03-24 03:20:10 -0700</bug_when>
    <thetext>(In reply to comment #17)
&gt; My understanding is that if you cannot build it on old Debian, you
&gt; cannot ship it on old Debian. Perhaps that&apos;s not how it works
&gt; though?

I don&apos;t think there&apos;s any problem from the Debian side since we
already switched to gcc 4.8 in both the 2.2 and the 2.4 branches.

The problem would be in Debian stable, but I think there are other
dependencies missing, so I wouldn&apos;t bother too much.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993775</commentid>
    <comment_count>21</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-24 03:38:13 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; (In reply to comment #17)
&gt; &gt; My understanding is that if you cannot build it on old Debian, you
&gt; &gt; cannot ship it on old Debian. Perhaps that&apos;s not how it works
&gt; &gt; though?
&gt; 
&gt; I don&apos;t think there&apos;s any problem from the Debian side since we
&gt; already switched to gcc 4.8 in both the 2.2 and the 2.4 branches.
&gt; 
&gt; The problem would be in Debian stable, but I think there are other
&gt; dependencies missing, so I wouldn&apos;t bother too much.

And EFL guys already agreed on upgrading their bots to use gcc 4.8, they are working on it, so it will happen soon. I still prefer to bump the gcc requirements instead of adding unnecessary casts as a workaround.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994178</commentid>
    <comment_count>22</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-03-25 08:11:02 -0700</bug_when>
    <thetext>&gt; 
&gt; I guess it would be something like
&gt; 
&gt; RefPtr&lt;RunLoop&gt; protector(this);
&gt; GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, std::function&lt;void()&gt;(std::bind(&amp;RunLoop::performWork, this)), [protector] {});

Why is the second parameter even needed? Can&apos;t you do something like

RefPtr&lt;RunLoop&gt; runLoop(this);
GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, [runLoop] {
    runLoop-&gt;performWork();
});

As long as the function object is destroyed at the right time, no extra parameter is needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994181</commentid>
    <comment_count>23</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-03-25 08:20:26 -0700</bug_when>
    <thetext>(In reply to comment #22)
&gt; &gt; 
&gt; &gt; I guess it would be something like
&gt; &gt; 
&gt; &gt; RefPtr&lt;RunLoop&gt; protector(this);
&gt; &gt; GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, std::function&lt;void()&gt;(std::bind(&amp;RunLoop::performWork, this)), [protector] {});
&gt; 
&gt; Why is the second parameter even needed? Can&apos;t you do something like
&gt; 
&gt; RefPtr&lt;RunLoop&gt; runLoop(this);
&gt; GMainLoopSource::createAndDeleteOnDestroy().schedule(&quot;[WebKit] RunLoop work&quot;, [runLoop] {
&gt;     runLoop-&gt;performWork();
&gt; });
&gt; 
&gt; As long as the function object is destroyed at the right time, no extra parameter is needed.

Yes, this would work for this particular case, since the function is detroyed right before the destroy callback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994186</commentid>
    <comment_count>24</comment_count>
    <who name="Víctor M. Jáquez L.">vjaquez</who>
    <bug_when>2014-03-25 08:40:55 -0700</bug_when>
    <thetext>Not only GMainLoopSource::createAndDeleteOnDestroy().schedule() fails at casting when gcc is less than 4.8, but also, in r163536, the function std::chrono::steady_clock::now() is used and it is only supported since gcc 4.8. So either EFL and GTK ports need  gcc 4.8</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994411</commentid>
    <comment_count>25</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-03-25 15:40:11 -0700</bug_when>
    <thetext>(In reply to comment #20)

&gt; I don&apos;t think there&apos;s any problem from the Debian side since we
&gt; already switched to gcc 4.8 in both the 2.2 and the 2.4 branches.
&gt; 
&gt; The problem would be in Debian stable, but I think there are other
&gt; dependencies missing, so I wouldn&apos;t bother too much.

Can we guarantee this for all downstreams though?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994551</commentid>
    <comment_count>26</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-03-26 04:44:29 -0700</bug_when>
    <thetext>(In reply to comment #25)
&gt; &gt; I don&apos;t think there&apos;s any problem from the Debian side since we
&gt; &gt; already switched to gcc 4.8 in both the 2.2 and the 2.4 branches.

&gt; Can we guarantee this for all downstreams though?

I was checking a bit the status of gcc 4.8 on some major
distributions, and it seems to be available in all of them:

ubuntu: since 13.10 (saucy)
packages.ubuntu.com/gcc-4.8

fedora: since F9 (july 2013)
https://admin.fedoraproject.org/updates/gcc?_csrf_token=5612f8b4909851d73b973c8196fa79957fcf32b7

opensuse:
http://software.opensuse.org/package/gcc48

gentoo:
http://packages.gentoo.org/package/sys-devel/gcc

freebsd:
http://svnweb.freebsd.org/ports/head/lang/gcc48/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>996717</commentid>
    <comment_count>27</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-04-02 08:23:37 -0700</bug_when>
    <thetext>gcc 4.9 will be released soon (see http://gcc.gnu.org/ml/gcc/2014-03/msg00190.html) so I would say let&apos;s support 4.7 for the time being and require 4.8 once the new version is available.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>997517</commentid>
    <comment_count>28</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-04 02:43:01 -0700</bug_when>
    <thetext>(In reply to comment #24)
&gt; Not only GMainLoopSource::createAndDeleteOnDestroy().schedule() fails at casting when gcc is less than 4.8, but also, in r163536, the function std::chrono::steady_clock::now() is used and it is only supported since gcc 4.8. So either EFL and GTK ports need  gcc 4.8

Reading the documentation for libstdc++, not really ... steady_clock was the same than system_clock and since 4.8.1 they are different classes.

However, not having any bot with GCC &lt; 4.8.x will make it difficult to detect when new code that is not supported is added.

I think if we want to keep supporting GCC 4.7.x we need a bot using it or we will just keep chasing changes that may break the compilation.

Anyway, I&apos;m double checking just not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998150</commentid>
    <comment_count>29</comment_count>
      <attachid>228738</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-07 08:53:14 -0700</bug_when>
    <thetext>Created attachment 228738
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998151</commentid>
    <comment_count>30</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-07 08:54:52 -0700</bug_when>
    <thetext>(In reply to comment #29)
&gt; Created an attachment (id=228738) [details]
&gt; Patch

The problem is spreading to many other places in the code.

If we really want to keep compatibility with GCC &lt; 4.8 we will *need* a buildbot in the waterfall that would be compiliing with that version of GCC. Otherwise, new changes will get into the trunk unnoticed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998152</commentid>
    <comment_count>31</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-07 08:57:49 -0700</bug_when>
    <thetext>(In reply to comment #28)
&gt; (In reply to comment #24)
&gt; &gt; Not only GMainLoopSource::createAndDeleteOnDestroy().schedule() fails at casting when gcc is less than 4.8, but also, in r163536, the function std::chrono::steady_clock::now() is used and it is only supported since gcc 4.8. So either EFL and GTK ports need  gcc 4.8
&gt; 
&gt; Reading the documentation for libstdc++, not really ... steady_clock was the same than system_clock and since 4.8.1 they are different classes.

Double checked: this is NOT a problem with GCC 4.7.x</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998153</commentid>
    <comment_count>32</comment_count>
      <attachid>228739</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-07 08:58:41 -0700</bug_when>
    <thetext>Created attachment 228739
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998154</commentid>
    <comment_count>33</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-07 09:01:48 -0700</bug_when>
    <thetext>(In reply to comment #32)
&gt; Created an attachment (id=228739) [details]
&gt; Patch

I think we only have the option of bumping GCC version without a gatekeeper to check when new code not compatible with GCC 4.7.x is added.

I&apos;m upgrading GCC to 4.8 myself now so I won&apos;t know any more ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998163</commentid>
    <comment_count>34</comment_count>
      <attachid>228738</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-04-07 09:37:21 -0700</bug_when>
    <thetext>Comment on attachment 228738
Patch

We can do this or simply rename on of the schedule functions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998470</commentid>
    <comment_count>35</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-04-07 23:58:26 -0700</bug_when>
    <thetext>(In reply to comment #34)
&gt; (From update of attachment 228738 [details])
&gt; We can do this or simply rename on of the schedule functions.

Please, don&apos;t rename the functions, I&apos;m fine adding workarounds for broken compiler versions, but not changing an API for that if not required.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998485</commentid>
    <comment_count>36</comment_count>
      <attachid>228738</attachid>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-08 00:38:08 -0700</bug_when>
    <thetext>Comment on attachment 228738
Patch

Clearing flags on attachment: 228738

Committed r166916: &lt;http://trac.webkit.org/changeset/166916&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998486</commentid>
    <comment_count>37</comment_count>
    <who name="Andres Gomez Garcia">agomez</who>
    <bug_when>2014-04-08 00:38:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227423</attachid>
            <date>2014-03-21 06:10:48 -0700</date>
            <delta_ts>2014-03-21 07:09:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130585-20140321151025.patch</filename>
            <type>text/plain</type>
            <size>2352</size>
            <attacher name="Andres Gomez Garcia">agomez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBiZGNlN2E3MTRkNzYzNWVmMjEzYWYw
MTFkZWRlMWZkMzhlYzk4ODEuLjQ0OWJjODkzN2M1MGQwNTVlZWZiMDk4NDA1YjM4ZjkzYTllNjRk
YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMDMtMjEgIEFuZHJlcyBHb21leiAgPGFnb21l
ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtFRkxdIEJ1aWxkIGZhaWxzIHdpdGggR0ND
IDwgNC44LngKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTEzMDU4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFRoZSBiZWhhdmlvciBpbiBsb3dlciB2ZXJzaW9ucyBvZiBHQ0Mgc2VlbSB0byBiZSByZWxhdGVk
IHRvCisgICAgICAgIGh0dHA6Ly93d3cub3Blbi1zdGQub3JnL2p0YzEvc2MyMi93ZzIxL2RvY3Mv
bHdnLWFjdGl2ZS5odG1sIzIxMzIuCisKKyAgICAgICAgUHJvdmlkZWQgZXhwbGljaXQgY2FzdHMg
Zm9yIHRoZSBmYWlsaW5nIGFtYmlndW91cyBvdmVybG9hZHMuCisKKyAgICAgICAgKiB3dGYvZ3Rr
L01haW5UaHJlYWRHdGsuY3BwOgorICAgICAgICAoV1RGOjpzY2hlZHVsZURpc3BhdGNoRnVuY3Rp
b25zT25NYWluVGhyZWFkKToKKyAgICAgICAgKiB3dGYvZ3RrL1J1bkxvb3BHdGsuY3BwOgorICAg
ICAgICAoV1RGOjpSdW5Mb29wOjp3YWtlVXApOgorCiAyMDE0LTAzLTIwICBEYXJpbiBBZGxlciAg
PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYSBoZWFkZXIgZ3VhcmQgbWlzdGFrZSAo
aGFybWxlc3MgYnV0IGNsZWFybHkgd3JvbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9n
dGsvTWFpblRocmVhZEd0ay5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9ndGsvTWFpblRocmVhZEd0ay5j
cHAKaW5kZXggMDEzNGY1OTFjZTI2YzYyMTJiMGRjMjY3Nzc4YTM5MTBjMjA1ZGY1MC4uMmZlNzA4
ZjdjZmFjNGFlMmZjNzhhNzc3YmVlYmI1MjVkM2ZhMDI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dU
Ri93dGYvZ3RrL01haW5UaHJlYWRHdGsuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2d0ay9NYWlu
VGhyZWFkR3RrLmNwcApAQCAtNDAsNyArNDAsNyBAQCB2b2lkIGluaXRpYWxpemVNYWluVGhyZWFk
UGxhdGZvcm0oKQogCiB2b2lkIHNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQo
KQogewotICAgIEdNYWluTG9vcFNvdXJjZTo6Y3JlYXRlQW5kRGVsZXRlT25EZXN0cm95KCkuc2No
ZWR1bGUoIltXZWJLaXRdIGRpc3BhdGNoRnVuY3Rpb25zRnJvbU1haW5UaHJlYWQiLCBkaXNwYXRj
aEZ1bmN0aW9uc0Zyb21NYWluVGhyZWFkKTsKKyAgICBHTWFpbkxvb3BTb3VyY2U6OmNyZWF0ZUFu
ZERlbGV0ZU9uRGVzdHJveSgpLnNjaGVkdWxlKCJbV2ViS2l0XSBkaXNwYXRjaEZ1bmN0aW9uc0Zy
b21NYWluVGhyZWFkIiwgKHN0ZDo6ZnVuY3Rpb248dm9pZCgpPikgZGlzcGF0Y2hGdW5jdGlvbnNG
cm9tTWFpblRocmVhZCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdURgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dURi93dGYvZ3RrL1J1bkxvb3BHdGsuY3BwIGIvU291cmNlL1dURi93dGYvZ3RrL1J1bkxv
b3BHdGsuY3BwCmluZGV4IGJmYTY2OGViNjY2YjllNTY5ZTUzZjk4NTdjMzg4NTdjYjg0MDcxMmUu
LmQ0OTExNTcwMWFmNTA3OGI3YTYwZTFmZDVkZmJlMmE3MDc0ZTljZWEgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XVEYvd3RmL2d0ay9SdW5Mb29wR3RrLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9ndGsv
UnVuTG9vcEd0ay5jcHAKQEAgLTEwMCw3ICsxMDAsNyBAQCB2b2lkIFJ1bkxvb3A6OnN0b3AoKQog
dm9pZCBSdW5Mb29wOjp3YWtlVXAoKQogewogICAgIHJlZigpOwotICAgIEdNYWluTG9vcFNvdXJj
ZTo6Y3JlYXRlQW5kRGVsZXRlT25EZXN0cm95KCkuc2NoZWR1bGUoIltXZWJLaXRdIFJ1bkxvb3Ag
d29yayIsIHN0ZDo6YmluZCgmUnVuTG9vcDo6cGVyZm9ybVdvcmssIHRoaXMpLAorICAgIEdNYWlu
TG9vcFNvdXJjZTo6Y3JlYXRlQW5kRGVsZXRlT25EZXN0cm95KCkuc2NoZWR1bGUoIltXZWJLaXRd
IFJ1bkxvb3Agd29yayIsIChzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4pIHN0ZDo6YmluZCgmUnVuTG9v
cDo6cGVyZm9ybVdvcmssIHRoaXMpLAogICAgICAgICBHX1BSSU9SSVRZX0RFRkFVTFQsIFt0aGlz
XSB7IGRlcmVmKCk7IH0pOwogICAgIGdfbWFpbl9jb250ZXh0X3dha2V1cChtX3J1bkxvb3BDb250
ZXh0LmdldCgpKTsKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227425</attachid>
            <date>2014-03-21 06:39:25 -0700</date>
            <delta_ts>2014-03-21 07:07:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130585-20140321153902.patch</filename>
            <type>text/plain</type>
            <size>1787</size>
            <attacher name="Andres Gomez Garcia">agomez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4
IDQwMjEwOWZhMjRmN2FkOTgwOTljNTJjODI2MWMwYjBlMWY5YTQ2MjkuLjY0NGVhMmE5MTFmYjg0
NTgxMDU1NWJjNTIxYzcxYzY0YzVkNjE4ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp
b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA
IC01OCw2ICs1OCwxNiBAQCBpZiAoTk9UIFBPUlQgU1RSRVFVQUwgIkdUSyIpCiAgICAgc2V0KExJ
QkVYRUNfSU5TVEFMTF9ESVIgImJpbiIgQ0FDSEUgUEFUSCAiV2hlcmUgdG8gaW5zdGFsbCBleGVj
dXRhYmxlcyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiBlbmRpZiAoKQogCisjIFdlIG5lZWQg
R0NDID49IDQuOC4wIHRvIGF2b2lkIGFtYmlndW91cyBlcnJvcnMgb24gb3ZlcmxvYWRlZCBmdW5j
dGlvbnMgdXNpbmcgc3RkOjpmdW5jdGlvbgorIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTEzMDU4NQoraWYgKFVOSVggQU5EIE5PVCBBUFBMRSkKKyAgICBpZiAo
Q01BS0VfQ09NUElMRVJfSVNfR05VQ1hYKQorICAgICAgICBpZiAoQ01BS0VfQ1hYX0NPTVBJTEVS
X1ZFUlNJT04gVkVSU0lPTl9MRVNTICI0LjguMCIpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFM
X0VSUk9SICJZb3UgbmVlZCBhdCBsZWFzdCBHQ0MgNC44LjAiKQorICAgICAgICBlbmRpZiAoKQor
ICAgIGVuZGlmICgpCitlbmRpZiAoKQorCiAjIFRoZSBOaW5qYSBnZW5lcmF0b3IgZG9lcyBub3Qg
eWV0IGtub3cgaG93IHRvIGJ1aWxkIGFyY2hpdmVzIGluIHBpZWNlcywgYW5kIHNvIHJlc3BvbnNl
CiAjIGZpbGVzIG11c3QgYmUgdXNlZCB0byBkZWFsIHdpdGggdmVyeSBsb25nIGxpbmtlciBjb21t
YW5kIGxpbmVzLgogIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTEyOTc3MQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGExNzcyMmJk
YjMwNzUwY2ZlOGQwN2IxMzJiOTFiMzk1NGExNDMyMGEuLmE2NjllMDZkZTcwNzc4MDUwNmNjYTE1
Nzc0NDE2NGRmYzk4ZTkwYmQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNyBAQAorMjAxNC0wMy0yMSAgQW5kcmVzIEdvbWV6ICA8YWdvbWV6QGlnYWxp
YS5jb20+CisKKyAgICAgICAgW0dUS10gW0VGTF0gQnVpbGQgZmFpbHMgd2l0aCBHQ0MgPCA0Ljgu
eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNTg1
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJl
aGF2aW9yIGluIGxvd2VyIHZlcnNpb25zIG9mIEdDQyBzZWVtIHRvIGJlIHJlbGF0ZWQgdG8KKyAg
ICAgICAgaHR0cDovL3d3dy5vcGVuLXN0ZC5vcmcvanRjMS9zYzIyL3dnMjEvZG9jcy9sd2ctYWN0
aXZlLmh0bWwjMjEzMi4KKworICAgICAgICBCdW1wZWQgbWluaW11bSBuZWVkZWQgR0NDIHZlcnNp
b24gdG8gNC44LjAuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFr
ZToKKwogMjAxNC0wMy0yMCAgVGhpYWdvIGRlIEJhcnJvcyBMYWNlcmRhICA8dGhpYWdvLmxhY2Vy
ZGFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbRUZMXVtHVEtdIEdldCBDTWFrZSB0byBmaW5k
IEZyZWV0eXBlMiBwcm9wZXJseQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227428</attachid>
            <date>2014-03-21 06:59:41 -0700</date>
            <delta_ts>2014-04-07 08:45:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130585-20140321155919.patch</filename>
            <type>text/plain</type>
            <size>1638</size>
            <attacher name="Andres Gomez Garcia">agomez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGZkYTFk
NjA5NGRkNjJiZmJmYzg0ZDcxODcxYTEwY2JkNDkxZGVlNDUuLmFjNDkxZDEwMjNlNTVkMTdjOGI0
ODEyNWU3NjUzODU4MjNlODJmNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL
LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0zMDQsNiArMzA0
LDE0IEBAIGlmIChVTklYIEFORCBOT1QgQVBQTEUpCiAgICAgZW5kaWYgKCkKIGVuZGlmICgpCiAK
KyMgV2UgbmVlZCBHQ0MgPj0gNC44LjAgdG8gYXZvaWQgYW1iaWd1b3VzIGVycm9ycyBvbiBvdmVy
bG9hZGVkIGZ1bmN0aW9ucyB1c2luZyBzdGQ6OmZ1bmN0aW9uCisjIFNlZSBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNTg1CitpZiAoQ01BS0VfQ09NUElMRVJfSVNf
R05VQ1hYKQorICAgIGlmIChDTUFLRV9DWFhfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0xFU1Mg
IjQuOC4wIikKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiWW91IG5lZWQgYXQgbGVhc3Qg
R0NDIDQuOC4wIGFuZCBjdXJyZW50IHZlcnNpb24gaXMgJHtDTUFLRV9DWFhfQ09NUElMRVJfVkVS
U0lPTn0iKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCiAjIEFkZCBhIHR5cGVsaWIgZmlsZSB0
byB0aGUgbGlzdCBvZiBhbGwgdHlwZWxpYiBkZXBlbmRlbmNpZXMuIFRoaXMgbWFrZXMgaXQgZWFz
eSB0bwogIyBleHBvc2UgYSAnZ2lyJyB0YXJnZXQgd2l0aCBhbGwgZ29iamVjdC1pbnRyb3NwZWN0
aW9uIGZpbGVzLgogbWFjcm8oQUREX1RZUEVMSUIgdHlwZWxpYikKZGlmZiAtLWdpdCBhL0NoYW5n
ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhMTc3MjJiZGIzMDc1MGNmZThkMDdiMTMyYjkxYjM5NTRh
MTQzMjBhLi5kODdhMDVhZjQyYzY2MjA2ZjkwNjgyNzU3OWIyMTUwZmU0NmIxMDFmIDEwMDY0NAot
LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDMt
MjEgIEFuZHJlcyBHb21leiAgPGFnb21lekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEJ1
aWxkIGZhaWxzIHdpdGggR0NDIDwgNC44LngKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEzMDU4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFRoZSBiZWhhdmlvciBpbiBsb3dlciB2ZXJzaW9ucyBvZiBHQ0Mg
c2VlbSB0byBiZSByZWxhdGVkIHRvCisgICAgICAgIGh0dHA6Ly93d3cub3Blbi1zdGQub3JnL2p0
YzEvc2MyMi93ZzIxL2RvY3MvbHdnLWFjdGl2ZS5odG1sIzIxMzIuCisKKyAgICAgICAgQnVtcGVk
IG1pbmltdW0gbmVlZGVkIEdDQyB2ZXJzaW9uIHRvIDQuOC4wLgorCisgICAgICAgICogU291cmNl
L2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTQtMDMtMjAgIFRoaWFnbyBkZSBCYXJyb3Mg
TGFjZXJkYSAgPHRoaWFnby5sYWNlcmRhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW0VGTF1b
R1RLXSBHZXQgQ01ha2UgdG8gZmluZCBGcmVldHlwZTIgcHJvcGVybHkK
</data>
<flag name="review"
          id="251677"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227429</attachid>
            <date>2014-03-21 07:05:47 -0700</date>
            <delta_ts>2014-04-07 08:45:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130585-20140321160524.patch</filename>
            <type>text/plain</type>
            <size>2344</size>
            <attacher name="Andres Gomez Garcia">agomez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBiZGNlN2E3MTRkNzYzNWVmMjEzYWYw
MTFkZWRlMWZkMzhlYzk4ODEuLjkwNTZmOGQxNTgyNzAwZWY2MTMxMmJkNTgwNWY2YzBkODk0MDU1
NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMDMtMjEgIEFuZHJlcyBHb21leiAgPGFnb21l
ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEJ1aWxkIGZhaWxzIHdpdGggR0NDIDwgNC44
LngKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDU4
NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBi
ZWhhdmlvciBpbiBsb3dlciB2ZXJzaW9ucyBvZiBHQ0Mgc2VlbSB0byBiZSByZWxhdGVkIHRvCisg
ICAgICAgIGh0dHA6Ly93d3cub3Blbi1zdGQub3JnL2p0YzEvc2MyMi93ZzIxL2RvY3MvbHdnLWFj
dGl2ZS5odG1sIzIxMzIuCisKKyAgICAgICAgUHJvdmlkZWQgZXhwbGljaXQgY2FzdHMgZm9yIHRo
ZSBmYWlsaW5nIGFtYmlndW91cyBvdmVybG9hZHMuCisKKyAgICAgICAgKiB3dGYvZ3RrL01haW5U
aHJlYWRHdGsuY3BwOgorICAgICAgICAoV1RGOjpzY2hlZHVsZURpc3BhdGNoRnVuY3Rpb25zT25N
YWluVGhyZWFkKToKKyAgICAgICAgKiB3dGYvZ3RrL1J1bkxvb3BHdGsuY3BwOgorICAgICAgICAo
V1RGOjpSdW5Mb29wOjp3YWtlVXApOgorCiAyMDE0LTAzLTIwICBEYXJpbiBBZGxlciAgPGRhcmlu
QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYSBoZWFkZXIgZ3VhcmQgbWlzdGFrZSAoaGFybWxl
c3MgYnV0IGNsZWFybHkgd3JvbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9ndGsvTWFp
blRocmVhZEd0ay5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9ndGsvTWFpblRocmVhZEd0ay5jcHAKaW5k
ZXggMDEzNGY1OTFjZTI2YzYyMTJiMGRjMjY3Nzc4YTM5MTBjMjA1ZGY1MC4uNmYzYzlhYWExZTMw
YTZhYjViMTE1NTNlMWMxNWVjMGNmODkwODk2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv
Z3RrL01haW5UaHJlYWRHdGsuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2d0ay9NYWluVGhyZWFk
R3RrLmNwcApAQCAtNDAsNyArNDAsNyBAQCB2b2lkIGluaXRpYWxpemVNYWluVGhyZWFkUGxhdGZv
cm0oKQogCiB2b2lkIHNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQoKQogewot
ICAgIEdNYWluTG9vcFNvdXJjZTo6Y3JlYXRlQW5kRGVsZXRlT25EZXN0cm95KCkuc2NoZWR1bGUo
IltXZWJLaXRdIGRpc3BhdGNoRnVuY3Rpb25zRnJvbU1haW5UaHJlYWQiLCBkaXNwYXRjaEZ1bmN0
aW9uc0Zyb21NYWluVGhyZWFkKTsKKyAgICBHTWFpbkxvb3BTb3VyY2U6OmNyZWF0ZUFuZERlbGV0
ZU9uRGVzdHJveSgpLnNjaGVkdWxlKCJbV2ViS2l0XSBkaXNwYXRjaEZ1bmN0aW9uc0Zyb21NYWlu
VGhyZWFkIiwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+KGRpc3BhdGNoRnVuY3Rpb25zRnJvbU1haW5U
aHJlYWQpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV1RGCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG
L3d0Zi9ndGsvUnVuTG9vcEd0ay5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9ndGsvUnVuTG9vcEd0ay5j
cHAKaW5kZXggYmZhNjY4ZWI2NjZiOWU1NjllNTNmOTg1N2MzODg1N2NiODQwNzEyZS4uMzVkYjgy
NTc1MzRkZDBjNjJkODFiZDY2Mjc2MTFmOGY0MTBiNDA2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dU
Ri93dGYvZ3RrL1J1bkxvb3BHdGsuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL2d0ay9SdW5Mb29w
R3RrLmNwcApAQCAtMTAwLDcgKzEwMCw3IEBAIHZvaWQgUnVuTG9vcDo6c3RvcCgpCiB2b2lkIFJ1
bkxvb3A6Ondha2VVcCgpCiB7CiAgICAgcmVmKCk7Ci0gICAgR01haW5Mb29wU291cmNlOjpjcmVh
dGVBbmREZWxldGVPbkRlc3Ryb3koKS5zY2hlZHVsZSgiW1dlYktpdF0gUnVuTG9vcCB3b3JrIiwg
c3RkOjpiaW5kKCZSdW5Mb29wOjpwZXJmb3JtV29yaywgdGhpcyksCisgICAgR01haW5Mb29wU291
cmNlOjpjcmVhdGVBbmREZWxldGVPbkRlc3Ryb3koKS5zY2hlZHVsZSgiW1dlYktpdF0gUnVuTG9v
cCB3b3JrIiwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+KHN0ZDo6YmluZCgmUnVuTG9vcDo6cGVyZm9y
bVdvcmssIHRoaXMpKSwKICAgICAgICAgR19QUklPUklUWV9ERUZBVUxULCBbdGhpc10geyBkZXJl
ZigpOyB9KTsKICAgICBnX21haW5fY29udGV4dF93YWtldXAobV9ydW5Mb29wQ29udGV4dC5nZXQo
KSk7CiB9Cg==
</data>
<flag name="review"
          id="251678"
          type_id="1"
          status="+"
          setter="andersca"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>228738</attachid>
            <date>2014-04-07 08:53:14 -0700</date>
            <delta_ts>2014-04-08 00:38:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130585-20140407185252.patch</filename>
            <type>text/plain</type>
            <size>12533</size>
            <attacher name="Andres Gomez Garcia">agomez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhmNjRiMjQ1MzFkOGU1NDBkNDZiNTU0
YjFlNmM2NzJjMWJkNzI3NDMuLmM0NDdiNDgzN2RjZWNjNzc0ZTIzMzllN2RlZWJjZmY4Y2ViMGVi
Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTQtMDQtMDcgIEFuZHJlcyBHb21leiAgPGFnb21l
ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtFRkxdIEJ1aWxkIGZhaWxzIHdpdGggR0ND
IDwgNC44LngKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTEzMDU4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFRoZSBiZWhhdmlvciBpbiBsb3dlciB2ZXJzaW9ucyBvZiBHQ0Mgc2VlbSB0byBiZSByZWxhdGVk
IHRvCisgICAgICAgIGh0dHA6Ly93d3cub3Blbi1zdGQub3JnL2p0YzEvc2MyMi93ZzIxL2RvY3Mv
bHdnLWFjdGl2ZS5odG1sIzIxMzIuCisKKyAgICAgICAgUHJvdmlkZWQgZXhwbGljaXQgY2FzdHMg
Zm9yIHRoZSBmYWlsaW5nIGFtYmlndW91cyBvdmVybG9hZHMuCisKKyAgICAgICAgKiB3dGYvZ3Rr
L01haW5UaHJlYWRHdGsuY3BwOgorICAgICAgICAoV1RGOjpzY2hlZHVsZURpc3BhdGNoRnVuY3Rp
b25zT25NYWluVGhyZWFkKToKKyAgICAgICAgKiB3dGYvZ3RrL1J1bkxvb3BHdGsuY3BwOgorICAg
ICAgICAoV1RGOjpSdW5Mb29wOjp3YWtlVXApOiBQcm92aWRlZCBsYW1iZGEgd2l0aCBhIFJlZlB0
ciBpbnN0ZWFkIG9mCisgICAgICAgIHJlZiBhbmQgZGUtcmVmZXJyaW5nLgorCiAyMDE0LTA0LTAz
ICBac29sdCBCb3JiZWx5ICA8enNib3JiZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+
CiAKICAgICAgICAgW0VGTF0gRW5hYmxlIENTUyBKSVQgYWdhaW4sIGl0IHdvcmtzIGZpbmUgYWZ0
ZXIgcjE2NjY2Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzZjg5YmI2NGQ1ZWJlNmM4ZWRmY2I0MDkyMGMwNDk0
NGY3MGNlYzBlLi42NmY3ZTQyZDc3YmI2NDc1NGQxNDYwZDQzYTEwMWIyZTcwZmZiMDVhIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTQtMDQtMDcgIEFuZHJlcyBHb21leiAgPGFnb21l
ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtFRkxdIEJ1aWxkIGZhaWxzIHdpdGggR0ND
IDwgNC44LngKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTEzMDU4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFRoZSBiZWhhdmlvciBpbiBsb3dlciB2ZXJzaW9ucyBvZiBHQ0Mgc2VlbSB0byBiZSByZWxhdGVk
IHRvCisgICAgICAgIGh0dHA6Ly93d3cub3Blbi1zdGQub3JnL2p0YzEvc2MyMi93ZzIxL2RvY3Mv
bHdnLWFjdGl2ZS5odG1sIzIxMzIuCisKKyAgICAgICAgUHJvdmlkZWQgZXhwbGljaXQgY2FzdHMg
Zm9yIHRoZSBmYWlsaW5nIGFtYmlndW91cyBvdmVybG9hZHMuCisKKyAgICAgICAgKiBwbGF0Zm9y
bS9hdWRpby9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkF1ZGlvRmlsZVJlYWRlcjo6Y3JlYXRlQnVzKToKKyAgICAgICAgKiBwbGF0Zm9y
bS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAg
ICAgICAod2ViS2l0TWVkaWFTcmNDaGFuZ2VTdGF0ZSk6CisgICAgICAgICh3ZWJLaXRNZWRpYVZp
ZGVvU3JjTmVlZERhdGFDYik6CisgICAgICAgICh3ZWJLaXRNZWRpYUF1ZGlvU3JjTmVlZERhdGFD
Yik6CisgICAgICAgICh3ZWJLaXRNZWRpYVZpZGVvU3JjRW5vdWdoRGF0YUNiKToKKyAgICAgICAg
KHdlYktpdE1lZGlhQXVkaW9TcmNFbm91Z2hEYXRhQ2IpOgorICAgICAgICAod2ViS2l0TWVkaWFW
aWRlb1NyY1NlZWtEYXRhQ2IpOgorICAgICAgICAod2ViS2l0TWVkaWFBdWRpb1NyY1NlZWtEYXRh
Q2IpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9HdGtEcmFnQW5kRHJvcEhlbHBlci5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpHdGtEcmFnQW5kRHJvcEhlbHBlcjo6aGFuZGxlRHJhZ0xlYXZlKToK
KyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJHdGsuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6c2V0U2hhcmVkVGltZXJGaXJlSW50ZXJ2YWwpOgorCiAyMDE0LTA0LTAzICBBbmRyZWFz
IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBGYXN0LXBhdGggZm9yIGNhc3Rp
bmcgSlMgd3JhcHBlcnMgdG8gSlNFbGVtZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv
Z3RrL01haW5UaHJlYWRHdGsuY3BwIGIvU291cmNlL1dURi93dGYvZ3RrL01haW5UaHJlYWRHdGsu
Y3BwCmluZGV4IDAxMzRmNTkxY2UyNmM2MjEyYjBkYzI2Nzc3OGEzOTEwYzIwNWRmNTAuLjZmM2M5
YWFhMWUzMGE2YWI1YjExNTUzZTFjMTVlYzBjZjg5MDg5NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
VEYvd3RmL2d0ay9NYWluVGhyZWFkR3RrLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9ndGsvTWFp
blRocmVhZEd0ay5jcHAKQEAgLTQwLDcgKzQwLDcgQEAgdm9pZCBpbml0aWFsaXplTWFpblRocmVh
ZFBsYXRmb3JtKCkKIAogdm9pZCBzY2hlZHVsZURpc3BhdGNoRnVuY3Rpb25zT25NYWluVGhyZWFk
KCkKIHsKLSAgICBHTWFpbkxvb3BTb3VyY2U6OmNyZWF0ZUFuZERlbGV0ZU9uRGVzdHJveSgpLnNj
aGVkdWxlKCJbV2ViS2l0XSBkaXNwYXRjaEZ1bmN0aW9uc0Zyb21NYWluVGhyZWFkIiwgZGlzcGF0
Y2hGdW5jdGlvbnNGcm9tTWFpblRocmVhZCk7CisgICAgR01haW5Mb29wU291cmNlOjpjcmVhdGVB
bmREZWxldGVPbkRlc3Ryb3koKS5zY2hlZHVsZSgiW1dlYktpdF0gZGlzcGF0Y2hGdW5jdGlvbnNG
cm9tTWFpblRocmVhZCIsIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPihkaXNwYXRjaEZ1bmN0aW9uc0Zy
b21NYWluVGhyZWFkKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdURgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dURi93dGYvZ3RrL1J1bkxvb3BHdGsuY3BwIGIvU291cmNlL1dURi93dGYvZ3RrL1J1bkxv
b3BHdGsuY3BwCmluZGV4IGJmYTY2OGViNjY2YjllNTY5ZTUzZjk4NTdjMzg4NTdjYjg0MDcxMmUu
LmQwZDJlOGVjYzViMzU1NjY3ZTljNDI0OTlmN2M3NTk1ZDQzN2YzZjcgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XVEYvd3RmL2d0ay9SdW5Mb29wR3RrLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9ndGsv
UnVuTG9vcEd0ay5jcHAKQEAgLTk5LDkgKzk5LDEwIEBAIHZvaWQgUnVuTG9vcDo6c3RvcCgpCiAK
IHZvaWQgUnVuTG9vcDo6d2FrZVVwKCkKIHsKLSAgICByZWYoKTsKLSAgICBHTWFpbkxvb3BTb3Vy
Y2U6OmNyZWF0ZUFuZERlbGV0ZU9uRGVzdHJveSgpLnNjaGVkdWxlKCJbV2ViS2l0XSBSdW5Mb29w
IHdvcmsiLCBzdGQ6OmJpbmQoJlJ1bkxvb3A6OnBlcmZvcm1Xb3JrLCB0aGlzKSwKLSAgICAgICAg
R19QUklPUklUWV9ERUZBVUxULCBbdGhpc10geyBkZXJlZigpOyB9KTsKKyAgICBSZWZQdHI8UnVu
TG9vcD4gcnVuTG9vcCh0aGlzKTsKKyAgICBHTWFpbkxvb3BTb3VyY2U6OmNyZWF0ZUFuZERlbGV0
ZU9uRGVzdHJveSgpLnNjaGVkdWxlKCJbV2ViS2l0XSBSdW5Mb29wIHdvcmsiLCBzdGQ6OmZ1bmN0
aW9uPHZvaWQoKT4oW3J1bkxvb3BdIHsKKyAgICAgICAgcnVuTG9vcC0+cGVyZm9ybVdvcmsoKTsK
KyAgICB9KSk7CiAgICAgZ19tYWluX2NvbnRleHRfd2FrZXVwKG1fcnVuTG9vcENvbnRleHQuZ2V0
KCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry
ZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwCmluZGV4IGYw
ZTQ4OWU5MTc4NGViNGY4YmFjM2Y0ZDdjMTYyNWU1ZTY1NWQxYTQuLjg1YWQ2YjdjOTdiYzFhZDU0
ZjZkMDA2NTg4MjdlOWM0NThjYzcwOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFkZXJHU3Ry
ZWFtZXIuY3BwCkBAIC0zMzUsNyArMzM1LDcgQEAgUGFzc1JlZlB0cjxBdWRpb0J1cz4gQXVkaW9G
aWxlUmVhZGVyOjpjcmVhdGVCdXMoZmxvYXQgc2FtcGxlUmF0ZSwgYm9vbCBtaXhUb01vbm8KIAog
ICAgIC8vIFN0YXJ0IHRoZSBwaXBlbGluZSBwcm9jZXNzaW5nIGp1c3QgYWZ0ZXIgdGhlIGxvb3Ag
aXMgc3RhcnRlZC4KICAgICBHTWFpbkxvb3BTb3VyY2Ugc291cmNlOwotICAgIHNvdXJjZS5zY2hl
ZHVsZSgiW1dlYktpdF0gQXVkaW9GaWxlUmVhZGVyOjpkZWNvZGVBdWRpb0ZvckJ1c0NyZWF0aW9u
Iiwgc3RkOjpiaW5kKCZBdWRpb0ZpbGVSZWFkZXI6OmRlY29kZUF1ZGlvRm9yQnVzQ3JlYXRpb24s
IHRoaXMpLCBHX1BSSU9SSVRZX0RFRkFVTFQsIG51bGxwdHIsIGNvbnRleHQuZ2V0KCkpOworICAg
IHNvdXJjZS5zY2hlZHVsZSgiW1dlYktpdF0gQXVkaW9GaWxlUmVhZGVyOjpkZWNvZGVBdWRpb0Zv
ckJ1c0NyZWF0aW9uIiwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+KHN0ZDo6YmluZCgmQXVkaW9GaWxl
UmVhZGVyOjpkZWNvZGVBdWRpb0ZvckJ1c0NyZWF0aW9uLCB0aGlzKSksIEdfUFJJT1JJVFlfREVG
QVVMVCwgbnVsbHB0ciwgY29udGV4dC5nZXQoKSk7CiAKICAgICBnX21haW5fbG9vcF9ydW4obV9s
b29wLmdldCgpKTsKICAgICBnX21haW5fY29udGV4dF9wb3BfdGhyZWFkX2RlZmF1bHQoY29udGV4
dC5nZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n
c3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNw
cAppbmRleCBhYTcyMWM4MmM1MzIyN2YxNmZjN2RmZThjMjNlNWU1NjQ5NGNiNDJhLi5iOGFlMmYx
OTNjYjYyOWEyZDc5MWRkOTdjN2I3NjBhZmUwMjI2ZWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFt
ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9X
ZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTM2NiwxMSArMzY2LDExIEBAIHN0YXRp
YyBHc3RTdGF0ZUNoYW5nZVJldHVybiB3ZWJLaXRNZWRpYVNyY0NoYW5nZVN0YXRlKEdzdEVsZW1l
bnQqIGVsZW1lbnQsIEdzdFN0CiAgICAgICAgIEdTVF9PQkpFQ1RfTE9DSyhzcmMpOwogCiAgICAg
ICAgIGdzdF9vYmplY3RfcmVmKHNyYyk7Ci0gICAgICAgIHByaXYtPnNvdXJjZVZpZGVvLnN0YXJ0
LnNjaGVkdWxlKCJbV2ViS2l0XSB3ZWJLaXRNZWRpYVZpZGVvU3JjU3RhcnQiLCBzdGQ6OmJpbmQo
d2ViS2l0TWVkaWFWaWRlb1NyY1N0YXJ0LCBzcmMpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCisgICAg
ICAgIHByaXYtPnNvdXJjZVZpZGVvLnN0YXJ0LnNjaGVkdWxlKCJbV2ViS2l0XSB3ZWJLaXRNZWRp
YVZpZGVvU3JjU3RhcnQiLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oc3RkOjpiaW5kKHdlYktpdE1l
ZGlhVmlkZW9TcmNTdGFydCwgc3JjKSksIEdfUFJJT1JJVFlfREVGQVVMVCwKICAgICAgICAgICAg
IFtzcmNdIHsgZ3N0X29iamVjdF91bnJlZihzcmMpOyB9KTsKIAogICAgICAgICBnc3Rfb2JqZWN0
X3JlZihzcmMpOwotICAgICAgICBwcml2LT5zb3VyY2VBdWRpby5zdGFydC5zY2hlZHVsZSgiW1dl
YktpdF0gd2ViS2l0TWVkaWFBdWRpb1NyY1N0YXJ0Iiwgc3RkOjpiaW5kKHdlYktpdE1lZGlhQXVk
aW9TcmNTdGFydCwgc3JjKSwgR19QUklPUklUWV9ERUZBVUxULAorICAgICAgICBwcml2LT5zb3Vy
Y2VBdWRpby5zdGFydC5zY2hlZHVsZSgiW1dlYktpdF0gd2ViS2l0TWVkaWFBdWRpb1NyY1N0YXJ0
Iiwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+KHN0ZDo6YmluZCh3ZWJLaXRNZWRpYUF1ZGlvU3JjU3Rh
cnQsIHNyYykpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCiAgICAgICAgICAgICBbc3JjXSB7IGdzdF9v
YmplY3RfdW5yZWYoc3JjKTsgfSk7CiAKICAgICAgICAgR1NUX09CSkVDVF9VTkxPQ0soc3JjKTsK
QEAgLTM4MCwxMSArMzgwLDExIEBAIHN0YXRpYyBHc3RTdGF0ZUNoYW5nZVJldHVybiB3ZWJLaXRN
ZWRpYVNyY0NoYW5nZVN0YXRlKEdzdEVsZW1lbnQqIGVsZW1lbnQsIEdzdFN0CiAgICAgICAgIEdT
VF9PQkpFQ1RfTE9DSyhzcmMpOwogCiAgICAgICAgIGdzdF9vYmplY3RfcmVmKHNyYyk7Ci0gICAg
ICAgIHByaXYtPnNvdXJjZVZpZGVvLnN0b3Auc2NoZWR1bGUoIltXZWJLaXRdIHdlYktpdE1lZGlh
VmlkZW9TcmNTdG9wIiwgc3RkOjpiaW5kKHdlYktpdE1lZGlhVmlkZW9TcmNTdG9wLCBzcmMpLCBH
X1BSSU9SSVRZX0RFRkFVTFQsCisgICAgICAgIHByaXYtPnNvdXJjZVZpZGVvLnN0b3Auc2NoZWR1
bGUoIltXZWJLaXRdIHdlYktpdE1lZGlhVmlkZW9TcmNTdG9wIiwgc3RkOjpmdW5jdGlvbjx2b2lk
KCk+KHN0ZDo6YmluZCh3ZWJLaXRNZWRpYVZpZGVvU3JjU3RvcCwgc3JjKSksIEdfUFJJT1JJVFlf
REVGQVVMVCwKICAgICAgICAgICAgIFtzcmNdIHsgZ3N0X29iamVjdF91bnJlZihzcmMpOyB9KTsK
IAogICAgICAgICBnc3Rfb2JqZWN0X3JlZihzcmMpOwotICAgICAgICBwcml2LT5zb3VyY2VBdWRp
by5zdG9wLnNjaGVkdWxlKCJbV2ViS2l0XSB3ZWJLaXRNZWRpYUF1ZGlvU3JjU3RvcCIsIHN0ZDo6
YmluZCh3ZWJLaXRNZWRpYUF1ZGlvU3JjU3RvcCwgc3JjKSwgR19QUklPUklUWV9ERUZBVUxULAor
ICAgICAgICBwcml2LT5zb3VyY2VBdWRpby5zdG9wLnNjaGVkdWxlKCJbV2ViS2l0XSB3ZWJLaXRN
ZWRpYUF1ZGlvU3JjU3RvcCIsIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPihzdGQ6OmJpbmQod2ViS2l0
TWVkaWFBdWRpb1NyY1N0b3AsIHNyYykpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCiAgICAgICAgICAg
ICBbc3JjXSB7IGdzdF9vYmplY3RfdW5yZWYoc3JjKTsgfSk7CiAKICAgICAgICAgR1NUX09CSkVD
VF9VTkxPQ0soc3JjKTsKQEAgLTUyNCw3ICs1MjQsNyBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRNZWRp
YVZpZGVvU3JjTmVlZERhdGFDYihHc3RBcHBTcmMqLCBndWludCBsZW5ndGgsIGdwb2ludGVyIHVz
ZQogICAgIH0KIAogICAgIGdzdF9vYmplY3RfcmVmKHNyYyk7Ci0gICAgcHJpdi0+c291cmNlVmlk
ZW8ubmVlZERhdGEuc2NoZWR1bGUoIltXZWJLaXRdIHdlYktpdE1lZGlhVmlkZW9TcmNOZWVkRGF0
YU1haW5DYiIsIHN0ZDo6YmluZCh3ZWJLaXRNZWRpYVZpZGVvU3JjTmVlZERhdGFNYWluQ2IsIHNy
YyksIEdfUFJJT1JJVFlfREVGQVVMVCwKKyAgICBwcml2LT5zb3VyY2VWaWRlby5uZWVkRGF0YS5z
Y2hlZHVsZSgiW1dlYktpdF0gd2ViS2l0TWVkaWFWaWRlb1NyY05lZWREYXRhTWFpbkNiIiwgc3Rk
OjpmdW5jdGlvbjx2b2lkKCk+KHN0ZDo6YmluZCh3ZWJLaXRNZWRpYVZpZGVvU3JjTmVlZERhdGFN
YWluQ2IsIHNyYykpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCiAgICAgICAgIFtzcmNdIHsgZ3N0X29i
amVjdF91bnJlZihzcmMpOyB9KTsKICAgICBHU1RfT0JKRUNUX1VOTE9DSyhzcmMpOwogfQpAQCAt
NTQzLDcgKzU0Myw3IEBAIHN0YXRpYyB2b2lkIHdlYktpdE1lZGlhQXVkaW9TcmNOZWVkRGF0YUNi
KEdzdEFwcFNyYyosIGd1aW50IGxlbmd0aCwgZ3BvaW50ZXIgdXNlCiAgICAgfQogCiAgICAgZ3N0
X29iamVjdF9yZWYoc3JjKTsKLSAgICBwcml2LT5zb3VyY2VBdWRpby5uZWVkRGF0YS5zY2hlZHVs
ZSgiW1dlYktpdF0gd2ViS2l0TWVkaWFBdWRpb1NyY05lZWREYXRhTWFpbkNiIiwgc3RkOjpiaW5k
KHdlYktpdE1lZGlhQXVkaW9TcmNOZWVkRGF0YU1haW5DYiwgc3JjKSwgR19QUklPUklUWV9ERUZB
VUxULAorICAgIHByaXYtPnNvdXJjZUF1ZGlvLm5lZWREYXRhLnNjaGVkdWxlKCJbV2ViS2l0XSB3
ZWJLaXRNZWRpYUF1ZGlvU3JjTmVlZERhdGFNYWluQ2IiLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4o
c3RkOjpiaW5kKHdlYktpdE1lZGlhQXVkaW9TcmNOZWVkRGF0YU1haW5DYiwgc3JjKSksIEdfUFJJ
T1JJVFlfREVGQVVMVCwKICAgICAgICAgW3NyY10geyBnc3Rfb2JqZWN0X3VucmVmKHNyYyk7IH0p
OwogICAgIEdTVF9PQkpFQ1RfVU5MT0NLKHNyYyk7CiB9CkBAIC01ODAsNyArNTgwLDcgQEAgc3Rh
dGljIHZvaWQgd2ViS2l0TWVkaWFWaWRlb1NyY0Vub3VnaERhdGFDYihHc3RBcHBTcmMqLCBncG9p
bnRlciB1c2VyRGF0YSkKICAgICB9CiAKICAgICBnc3Rfb2JqZWN0X3JlZihzcmMpOwotICAgIHBy
aXYtPnNvdXJjZVZpZGVvLmVub3VnaERhdGEuc2NoZWR1bGUoIltXZWJLaXRdIHdlYktpdE1lZGlh
VmlkZW9TcmNFbm91Z2hEYXRhTWFpbkNiIiwgc3RkOjpiaW5kKHdlYktpdE1lZGlhVmlkZW9TcmNF
bm91Z2hEYXRhTWFpbkNiLCBzcmMpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCisgICAgcHJpdi0+c291
cmNlVmlkZW8uZW5vdWdoRGF0YS5zY2hlZHVsZSgiW1dlYktpdF0gd2ViS2l0TWVkaWFWaWRlb1Ny
Y0Vub3VnaERhdGFNYWluQ2IiLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oc3RkOjpiaW5kKHdlYktp
dE1lZGlhVmlkZW9TcmNFbm91Z2hEYXRhTWFpbkNiLCBzcmMpKSwgR19QUklPUklUWV9ERUZBVUxU
LAogICAgICAgICBbc3JjXSB7IGdzdF9vYmplY3RfdW5yZWYoc3JjKTsgfSk7CiAKICAgICBHU1Rf
T0JKRUNUX1VOTE9DSyhzcmMpOwpAQCAtNjAwLDcgKzYwMCw3IEBAIHN0YXRpYyB2b2lkIHdlYktp
dE1lZGlhQXVkaW9TcmNFbm91Z2hEYXRhQ2IoR3N0QXBwU3JjKiwgZ3BvaW50ZXIgdXNlckRhdGEp
CiAgICAgfQogCiAgICAgZ3N0X29iamVjdF9yZWYoc3JjKTsKLSAgICBwcml2LT5zb3VyY2VBdWRp
by5lbm91Z2hEYXRhLnNjaGVkdWxlKCJbV2ViS2l0XSB3ZWJLaXRNZWRpYUF1ZGlvU3JjRW5vdWdo
RGF0YU1haW5DYiIsIHN0ZDo6YmluZCh3ZWJLaXRNZWRpYUF1ZGlvU3JjRW5vdWdoRGF0YU1haW5D
Yiwgc3JjKSwgR19QUklPUklUWV9ERUZBVUxULAorICAgIHByaXYtPnNvdXJjZUF1ZGlvLmVub3Vn
aERhdGEuc2NoZWR1bGUoIltXZWJLaXRdIHdlYktpdE1lZGlhQXVkaW9TcmNFbm91Z2hEYXRhTWFp
bkNiIiwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+KHN0ZDo6YmluZCh3ZWJLaXRNZWRpYUF1ZGlvU3Jj
RW5vdWdoRGF0YU1haW5DYiwgc3JjKSksIEdfUFJJT1JJVFlfREVGQVVMVCwKICAgICAgICAgW3Ny
Y10geyBnc3Rfb2JqZWN0X3VucmVmKHNyYyk7IH0pOwogCiAgICAgR1NUX09CSkVDVF9VTkxPQ0so
c3JjKTsKQEAgLTY0Miw3ICs2NDIsNyBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2ViS2l0TWVkaWFWaWRl
b1NyY1NlZWtEYXRhQ2IoR3N0QXBwU3JjKiwgZ3VpbnQ2NCBvZmZzZXQsIGdwb2ludAogICAgIHBy
aXYtPnNvdXJjZVZpZGVvLnJlcXVlc3RlZE9mZnNldCA9IG9mZnNldDsKIAogICAgIGdzdF9vYmpl
Y3RfcmVmKHNyYyk7Ci0gICAgcHJpdi0+c291cmNlVmlkZW8uc2Vlay5zY2hlZHVsZSgiW1dlYktp
dF0gd2ViS2l0TWVkaWFWaWRlb1NyY1NlZWtNYWluQ2IiLCBzdGQ6OmJpbmQod2ViS2l0TWVkaWFW
aWRlb1NyY1NlZWtNYWluQ2IsIHNyYyksIEdfUFJJT1JJVFlfREVGQVVMVCwKKyAgICBwcml2LT5z
b3VyY2VWaWRlby5zZWVrLnNjaGVkdWxlKCJbV2ViS2l0XSB3ZWJLaXRNZWRpYVZpZGVvU3JjU2Vl
a01haW5DYiIsIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPihzdGQ6OmJpbmQod2ViS2l0TWVkaWFWaWRl
b1NyY1NlZWtNYWluQ2IsIHNyYykpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCiAgICAgICAgIFtzcmNd
IHsgZ3N0X29iamVjdF91bnJlZihzcmMpOyB9KTsKIAogICAgIEdTVF9PQkpFQ1RfVU5MT0NLKHNy
Yyk7CkBAIC02NzUsNyArNjc1LDcgQEAgc3RhdGljIGdib29sZWFuIHdlYktpdE1lZGlhQXVkaW9T
cmNTZWVrRGF0YUNiKEdzdEFwcFNyYyosIGd1aW50NjQgb2Zmc2V0LCBncG9pbnQKICAgICBwcml2
LT5zb3VyY2VBdWRpby5yZXF1ZXN0ZWRPZmZzZXQgPSBvZmZzZXQ7CiAKICAgICBnc3Rfb2JqZWN0
X3JlZihzcmMpOwotICAgIHByaXYtPnNvdXJjZUF1ZGlvLnNlZWsuc2NoZWR1bGUoIltXZWJLaXRd
IHdlYktpdE1lZGlhQXVkaW9TcmNTZWVrTWFpbkNiIiwgc3RkOjpiaW5kKHdlYktpdE1lZGlhQXVk
aW9TcmNTZWVrTWFpbkNiLCBzcmMpLCBHX1BSSU9SSVRZX0RFRkFVTFQsCisgICAgcHJpdi0+c291
cmNlQXVkaW8uc2Vlay5zY2hlZHVsZSgiW1dlYktpdF0gd2ViS2l0TWVkaWFBdWRpb1NyY1NlZWtN
YWluQ2IiLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oc3RkOjpiaW5kKHdlYktpdE1lZGlhQXVkaW9T
cmNTZWVrTWFpbkNiLCBzcmMpKSwgR19QUklPUklUWV9ERUZBVUxULAogICAgICAgICBbc3JjXSB7
IGdzdF9vYmplY3RfdW5yZWYoc3JjKTsgfSk7CiAKICAgICBHU1RfT0JKRUNUX1VOTE9DSyhzcmMp
OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a0RyYWdBbmREcm9w
SGVscGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtEcmFnQW5kRHJvcEhl
bHBlci5jcHAKaW5kZXggZmM3ODFlNzBjZDQ2MzIxZjVkMTkwM2Y1YjQwZTFmZTllMGM0ZmYxNi4u
MjZjNmRiZmVhMTI2NWRiNzQ5NzllYzUzOWIzMGI1NTQ5YzQwNjY1MiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a0RyYWdBbmREcm9wSGVscGVyLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrRHJhZ0FuZERyb3BIZWxwZXIuY3BwCkBAIC05
OSw3ICs5OSw3IEBAIHZvaWQgR3RrRHJhZ0FuZERyb3BIZWxwZXI6OmhhbmRsZURyYWdMZWF2ZShH
ZGtEcmFnQ29udGV4dCogZ2RrQ29udGV4dCwgRHJhZ0V4aXRlCiAgICAgLy8gdGhlIGRyYWctZHJv
cCBzaWduYWwuIFdlIHdhbnQgdGhlIGFjdGlvbnMgZm9yIGRyYWctbGVhdmUgdG8gaGFwcGVuIGFm
dGVyCiAgICAgLy8gdGhvc2UgZm9yIGRyYWctZHJvcCwgc28gc2NoZWR1bGUgdGhlbSB0byBoYXBw
ZW4gYXN5bmNocm9ub3VzbHkgaGVyZS4KICAgICBjb250ZXh0LT5leGl0ZWRDYWxsYmFjayA9IGV4
aXRlZENhbGxiYWNrOwotICAgIEdNYWluTG9vcFNvdXJjZTo6Y3JlYXRlQW5kRGVsZXRlT25EZXN0
cm95KCkuc2NoZWR1bGUoIltXZWJLaXRdIGhhbmRsZURyYWdMZWF2ZUxhdGVyIiwgc3RkOjpiaW5k
KCZHdGtEcmFnQW5kRHJvcEhlbHBlcjo6aGFuZGxlRHJhZ0xlYXZlTGF0ZXIsIHRoaXMsIGNvbnRl
eHQpKTsKKyAgICBHTWFpbkxvb3BTb3VyY2U6OmNyZWF0ZUFuZERlbGV0ZU9uRGVzdHJveSgpLnNj
aGVkdWxlKCJbV2ViS2l0XSBoYW5kbGVEcmFnTGVhdmVMYXRlciIsIHN0ZDo6ZnVuY3Rpb248dm9p
ZCgpPihzdGQ6OmJpbmQoJkd0a0RyYWdBbmREcm9wSGVscGVyOjpoYW5kbGVEcmFnTGVhdmVMYXRl
ciwgdGhpcywgY29udGV4dCkpKTsKIH0KIAogc3RhdGljIHZvaWQgcXVlcnlOZXdEcm9wQ29udGV4
dERhdGEoRHJvcHBpbmdDb250ZXh0KiBkcm9wQ29udGV4dCwgR3RrV2lkZ2V0KiB3aWRnZXQsIGd1
aW50IHRpbWUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVk
VGltZXJHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1NoYXJlZFRpbWVyR3Rr
LmNwcAppbmRleCAxOGFjZWMwODg5N2Q5MTJiYzExODFiNzM1ZDUwNGRlMDFmZmFjZmU3Li5lYzkw
ZmQ0MzJkZGM2NTc1ODM1MTYyMTU2MWU5MmQ4Yzg3NWM3MWNkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2d0ay9TaGFyZWRUaW1lckd0ay5jcHAKQEAgLTQ3LDcgKzQ3LDcgQEAgdm9p
ZCBzZXRTaGFyZWRUaW1lckZpcmVJbnRlcnZhbChkb3VibGUgaW50ZXJ2YWwpCiB7CiAgICAgQVNT
RVJUKHNoYXJlZFRpbWVyRmlyZWRGdW5jdGlvbik7CiAKLSAgICBnU2hhcmVkVGltZXIuc2NoZWR1
bGVBZnRlckRlbGF5KCJbV2ViS2l0XSBzaGFyZWRUaW1lclRpbWVvdXRDYWxsYmFjayIsIHNoYXJl
ZFRpbWVyRmlyZWRGdW5jdGlvbiwKKyAgICBnU2hhcmVkVGltZXIuc2NoZWR1bGVBZnRlckRlbGF5
KCJbV2ViS2l0XSBzaGFyZWRUaW1lclRpbWVvdXRDYWxsYmFjayIsIHN0ZDo6ZnVuY3Rpb248dm9p
ZCgpPihzaGFyZWRUaW1lckZpcmVkRnVuY3Rpb24pLAogICAgICAgICBzdGQ6OmNocm9ubzo6ZHVy
YXRpb25fY2FzdDxzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzPihzdGQ6OmNocm9ubzo6ZHVyYXRp
b248ZG91YmxlPihpbnRlcnZhbCkpLCBHREtfUFJJT1JJVFlfUkVEUkFXKTsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>228739</attachid>
            <date>2014-04-07 08:58:41 -0700</date>
            <delta_ts>2014-04-08 00:35:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130585-20140407185819.patch</filename>
            <type>text/plain</type>
            <size>1843</size>
            <attacher name="Andres Gomez Garcia">agomez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0
aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4
IDQwMjEwOWZhMjRmN2FkOTgwOTljNTJjODI2MWMwYjBlMWY5YTQ2MjkuLmY0OTUzOWU2Y2Q5MDBh
ZGFmYWU3ZDJiNjJhNzFmNTQ5YzdlNTBlYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp
b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA
IC01OCw2ICs1OCwxNiBAQCBpZiAoTk9UIFBPUlQgU1RSRVFVQUwgIkdUSyIpCiAgICAgc2V0KExJ
QkVYRUNfSU5TVEFMTF9ESVIgImJpbiIgQ0FDSEUgUEFUSCAiV2hlcmUgdG8gaW5zdGFsbCBleGVj
dXRhYmxlcyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiBlbmRpZiAoKQogCisjIFdlIG5lZWQg
R0NDID49IDQuOC4wIHRvIGF2b2lkIGFtYmlndW91cyBlcnJvcnMgb24gb3ZlcmxvYWRlZCBmdW5j
dGlvbnMgdXNpbmcgc3RkOjpmdW5jdGlvbgorIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTEzMDU4NQoraWYgKFVOSVggQU5EIE5PVCBBUFBMRSkKKyAgICBpZiAo
Q01BS0VfQ09NUElMRVJfSVNfR05VQ1hYKQorICAgICAgICBpZiAoQ01BS0VfQ1hYX0NPTVBJTEVS
X1ZFUlNJT04gVkVSU0lPTl9MRVNTICI0LjguMCIpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFM
X0VSUk9SICJZb3UgbmVlZCBhdCBsZWFzdCBHQ0MgNC44LjAgYW5kIGN1cnJlbnQgdmVyc2lvbiBp
cyAke0NNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OfSIpCisgICAgICAgIGVuZGlmICgpCisgICAg
ZW5kaWYgKCkKK2VuZGlmICgpCisKICMgVGhlIE5pbmphIGdlbmVyYXRvciBkb2VzIG5vdCB5ZXQg
a25vdyBob3cgdG8gYnVpbGQgYXJjaGl2ZXMgaW4gcGllY2VzLCBhbmQgc28gcmVzcG9uc2UKICMg
ZmlsZXMgbXVzdCBiZSB1c2VkIHRvIGRlYWwgd2l0aCB2ZXJ5IGxvbmcgbGlua2VyIGNvbW1hbmQg
bGluZXMuCiAjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI5
NzcxCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNjAwMDMwZGZmY2Mz
NWFhZTI2ZTk4YTQ4NTE4N2UxMDljNDk4NTgwOC4uYWQyZGQyMzNiNzAwZmVlYTMyMzgzM2EyZTI4
ZTYxNDJjNzYyMTZiMSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE3IEBACisyMDE0LTA0LTA3ICBBbmRyZXMgR29tZXogIDxhZ29tZXpAaWdhbGlhLmNv
bT4KKworICAgICAgICBbR1RLXSBbRUZMXSBCdWlsZCBmYWlscyB3aXRoIEdDQyA8IDQuOC54Cisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1ODUKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYmVoYXZp
b3IgaW4gbG93ZXIgdmVyc2lvbnMgb2YgR0NDIHNlZW0gdG8gYmUgcmVsYXRlZCB0bworICAgICAg
ICBodHRwOi8vd3d3Lm9wZW4tc3RkLm9yZy9qdGMxL3NjMjIvd2cyMS9kb2NzL2x3Zy1hY3RpdmUu
aHRtbCMyMTMyLgorCisgICAgICAgIEJ1bXBlZCBtaW5pbXVtIG5lZWRlZCBHQ0MgdmVyc2lvbiB0
byA0LjguMC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgor
CiAyMDE0LTA0LTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29z
dGFAaW50ZWwuY29tPgogCiAgICAgICAgIFtHVEtdW0NNYWtlXSBMb29rIGZvciBnbHguaCBpbiBP
UEVOR0xfSU5DTFVERV9ESVIuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>