130566 2014-03-20 22:58:12 -0700 StackLayoutPhase should find the union'ed calleeVariable before accessing its machineLocal 2014-03-21 09:07:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo oldest_to_newest 992917 0 mark.lam 2014-03-20 22:58:12 -0700 Patch coming. 992918 1 mark.lam 2014-03-20 22:59:06 -0700 <rdar://problem/16386914> 992936 2 227388 mark.lam 2014-03-20 23:44:40 -0700 Created attachment 227388 the patch. 993098 3 227388 mark.lam 2014-03-21 08:04:51 -0700 Comment on attachment 227388 the patch. Thanks for the review. 993102 4 227388 mark.lam 2014-03-21 08:29:30 -0700 Comment on attachment 227388 the patch. There appear to be some discrepancy with the layout test results. Will rerun the test to confirm that the results are correct. 993113 5 mark.lam 2014-03-21 09:00:16 -0700 The issue is that DumpRenderTree renders 2 consecutive spaces in the test description string as 1 space while jsc renders it literally as 2. I fixed this by only using 1 space in the test description string. Preparing to land the patch. 993120 6 227388 mark.lam 2014-03-21 09:07:14 -0700 Comment on attachment 227388 the patch. Clearing flags. Patch landed in r166064: <http://trac.webkit.org/r166064>. 227388 2014-03-20 23:44:40 -0700 2014-03-21 09:07:14 -0700 the patch. bug-130566.patch text/plain 4191 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MDQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAzLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT dGFja0xheW91dFBoYXNlIHNob3VsZCBmaW5kIHRoZSB1bmlvbidlZCBjYWxsZWVWYXJpYWJsZSBi ZWZvcmUgYWNjZXNzaW5nIGl0cyBtYWNoaW5lTG9jYWwuCisgICAgICAgIDxodHRwczovL3dlYmtp dC5vcmcvYi8xMzA1NjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBkZmcvREZHU3RhY2tMYXlvdXRQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRG Rzo6U3RhY2tMYXlvdXRQaGFzZTo6cnVuKToKKwogMjAxNC0wMy0yMCAgQnJpYW4gQnVyZyAgPGJi dXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgZnJvbnRlbmQgY29u dHJvbGxlciBhbmQgbW9kZWxzIGZvciByZXBsYXkgc2Vzc2lvbnMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3RhY2tMYXlvdXRQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdGFja0xheW91dFBoYXNlLmNwcAkocmV2aXNpb24g MTY2MDQxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdGFja0xheW91dFBoYXNl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk3LDkgKzE5NywxMCBAQCBwdWJsaWM6CiAgICAgICAg ICAgICAKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGlubGluZUNhbGxGcmFtZS0+aXNDbG9z dXJlQ2FsbCA9PSAhIWRhdGEuY2FsbGVlVmFyaWFibGUpOwogICAgICAgICAgICAgaWYgKGlubGlu ZUNhbGxGcmFtZS0+aXNDbG9zdXJlQ2FsbCkgeworICAgICAgICAgICAgICAgIFZhcmlhYmxlQWNj ZXNzRGF0YSogdmFyaWFibGUgPSBkYXRhLmNhbGxlZVZhcmlhYmxlLT5maW5kKCk7CiAgICAgICAg ICAgICAgICAgVmFsdWVTb3VyY2Ugc291cmNlID0gVmFsdWVTb3VyY2U6OmZvckZsdXNoRm9ybWF0 KAotICAgICAgICAgICAgICAgICAgICBkYXRhLmNhbGxlZVZhcmlhYmxlLT5tYWNoaW5lTG9jYWwo KSwKLSAgICAgICAgICAgICAgICAgICAgZGF0YS5jYWxsZWVWYXJpYWJsZS0+Zmx1c2hGb3JtYXQo KSk7CisgICAgICAgICAgICAgICAgICAgIHZhcmlhYmxlLT5tYWNoaW5lTG9jYWwoKSwKKyAgICAg ICAgICAgICAgICAgICAgdmFyaWFibGUtPmZsdXNoRm9ybWF0KCkpOwogICAgICAgICAgICAgICAg IGlubGluZUNhbGxGcmFtZS0+Y2FsbGVlUmVjb3ZlcnkgPSBzb3VyY2UudmFsdWVSZWNvdmVyeSgp OwogICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoaW5s aW5lQ2FsbEZyYW1lLT5jYWxsZWVSZWNvdmVyeS5pc0NvbnN0YW50KCkpOwpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gMTY2MDQxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTQtMDMtMjAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgorCisgICAgICAgIFN0YWNrTGF5b3V0UGhhc2Ugc2hvdWxkIGZpbmQgdGhlIHVuaW9uJ2VkIGNh bGxlZVZhcmlhYmxlIGJlZm9yZSBhY2Nlc3NpbmcgaXRzIG1hY2hpbmVMb2NhbC4KKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzMDU2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL3JlZ3Jlc3MtMTMwNTY2LWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICoganMvcmVncmVzcy0xMzA1NjYuaHRtbDogQWRkZWQuCisgICAgICAg ICoganMvc2NyaXB0LXRlc3RzL3JlZ3Jlc3MtMTMwNTY2LmpzOiBBZGRlZC4KKyAgICAgICAgKHRl c3QuZG9UZXN0KToKKyAgICAgICAgKHRlc3QuZm9yKToKKyAgICAgICAgKHRlc3QpOgorCiAyMDE0 LTAzLTIwICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGFkZCBmcm9udGVuZCBjb250cm9sbGVyIGFuZCBtb2RlbHMgZm9yIHJlcGxheSBzZXNz aW9ucwpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVncmVzcy0xMzA1NjYtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3JlZ3Jlc3MtMTMwNTY2LWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3MtMTMwNTY2LWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDkgQEAKK1RoaXMgdGVzdHMgZW5zdXJlcyB0aGF0 IHRoZSBERkcgU3RhY2tMYXlvdXRQaGFzZSBpcyBvbmx5IGFjY2Vzc2luZyBhIHVuaW9uJ2VkIGNh bGxlZVZhcmlhYmxlLiBUaGlzIHRlc3Qgc2hvdWxkIG5vdCBjcmFzaC4KKworT24gc3VjY2Vzcywg eW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRF U1QgQ09NUExFVEUiLgorCisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT VCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzLTEzMDU2Ni5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3JlZ3Jlc3MtMTMwNTY2Lmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzLTEzMDU2Ni5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhU TUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9InNjcmlw dC10ZXN0cy9yZWdyZXNzLTEzMDU2Ni5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcmVncmVzcy0xMzA1NjYuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3JlZ3Jlc3MtMTMwNTY2LmpzCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3JlZ3Jlc3MtMTMwNTY2Lmpz CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjQgQEAKK2Rlc2NyaXB0aW9uKAorIlRoaXMgdGVz dHMgZW5zdXJlcyB0aGF0IHRoZSBERkcgU3RhY2tMYXlvdXRQaGFzZSBpcyBvbmx5IGFjY2Vzc2lu ZyBhIHVuaW9uJ2VkIGNhbGxlZVZhcmlhYmxlLiAgVGhpcyB0ZXN0IHNob3VsZCBub3QgY3Jhc2gu IgorKTsKKworLy8gUmVncmVzc2lvbiB0ZXN0IGZvciA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMw NTY2Pi4KK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIGZ1bmN0aW9uIGRvVGVzdCgpIHsKKyAgICAg ICAgKGZ1bmN0aW9uIGZvbyhhKSB7CisgICAgICAgICAgICBpZiAoYSA+IDApIHsKKyAgICAgICAg ICAgICAgICBmb28oYSAgLSAxKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSkgKDQyNCk7Cisg ICAgfQorCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwOyBpKyspIHsKKyAgICAgICAgdHJ5 IHsKKyAgICAgICAgICAgIGRvVGVzdCgpOworICAgICAgICB9IGNhdGNoKHJ1bkVycm9yKSB7Cisg ICAgICAgIH0KKyAgICB9Cit9CisKK3Rlc3QoKTsK