<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>130564</bug_id>
          
          <creation_ts>2014-03-20 22:28:15 -0700</creation_ts>
          <short_desc>Check for inappropriate macros in private headers</short_desc>
          <delta_ts>2014-03-21 00:25:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Pratik Solanki">psolanki</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>992908</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2014-03-20 22:28:15 -0700</bug_when>
    <thetext>Check for inappropriate macros in private headers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>992909</commentid>
    <comment_count>1</comment_count>
      <attachid>227384</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2014-03-20 22:29:28 -0700</bug_when>
    <thetext>Created attachment 227384
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>992947</commentid>
    <comment_count>2</comment_count>
      <attachid>227384</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-03-21 00:25:32 -0700</bug_when>
    <thetext>Comment on attachment 227384
Patch

Clearing flags on attachment: 227384

Committed r166048: &lt;http://trac.webkit.org/changeset/166048&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>992948</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-03-21 00:25:35 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227384</attachid>
            <date>2014-03-20 22:29:28 -0700</date>
            <delta_ts>2014-03-21 00:25:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130564-20140320222906.patch</filename>
            <type>text/plain</type>
            <size>1780</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM4MjU5NWQwNTFjYmNmNTc5
NTQxZDg3NzFlNjQwYmMyZmU1ZjUwNmEuLjQzNmEyZWVhYTA2MzU5YjA2OTM2ZDA1YWEwMGRhOGE3
Zjc3ZGY1NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDMtMjAgIFByYXRpayBT
b2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIGZvciBpbmFwcHJv
cHJpYXRlIG1hY3JvcyBpbiBwcml2YXRlIGhlYWRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDU2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIFByaXZhdGVIZWFkZXJzIGZvciBpbmFwcHJv
cHJpYXRlIG1hY3JvcyBhcyB3ZWxsIHNvIHRoYXQgd2UgYXZvaWQgYnVpbGQgYnJlYWthZ2VzIGxp
a2UKKyAgICAgICAgdGhlIG9uZSBkdWUgdG8gdGhlIG9yaWdpbmFsIGNvbW1pdCBmb3IgYnVnIDEz
MDE0Mi4KKworICAgICAgICAqIFdlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAy
MDE0LTAzLTIwICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGVj
dWxhdGl2ZSBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29k
ZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3By
b2plY3QucGJ4cHJvagppbmRleCBhZDdjZmExNWVlYzE5MDFiNDJmMWQ5YTE0MzBmMGRiNzk0OWNi
YjE5Li4zZjdlNjVhMjViYTYwMmQ0MjlkYTQ5NDNkYjhlMzczZjYzZTZiODU4IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1Nv
dXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTIyMjcsNyAr
MjIyNyw3IEBACiAJCQkpOwogCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9
IDA7CiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwotCQkJc2hlbGxTY3JpcHQgPSAiaWYgWyBcIiR7
QUNUSU9OfVwiID0gXCJpbnN0YWxsaGRyc1wiIF07IHRoZW5cbiAgICBleGl0IDA7XG5maVxuXG5p
ZiBbIC1mIC4uLy4uL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLWluYXBwcm9wcmlhdGUtbWFjcm9z
LWluLWV4dGVybmFsLWhlYWRlcnMgXTsgdGhlblxuICAgIC4uLy4uL1Rvb2xzL1NjcmlwdHMvY2hl
Y2stZm9yLWluYXBwcm9wcmlhdGUtbWFjcm9zLWluLWV4dGVybmFsLWhlYWRlcnMgSGVhZGVycyB8
fCBleGl0ICQ/XG5maSI7CisJCQlzaGVsbFNjcmlwdCA9ICJpZiBbIFwiJHtBQ1RJT059XCIgPSBc
Imluc3RhbGxoZHJzXCIgXTsgdGhlblxuICAgIGV4aXQgMDtcbmZpXG5cbmlmIFsgLWYgLi4vLi4v
VG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItaW5hcHByb3ByaWF0ZS1tYWNyb3MtaW4tZXh0ZXJuYWwt
aGVhZGVycyBdOyB0aGVuXG4gICAgLi4vLi4vVG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItaW5hcHBy
b3ByaWF0ZS1tYWNyb3MtaW4tZXh0ZXJuYWwtaGVhZGVycyBIZWFkZXJzIFByaXZhdGVIZWFkZXJz
IHx8IGV4aXQgJD9cbmZpIjsKIAkJfTsKIC8qIEVuZCBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2Ug
c2VjdGlvbiAqLwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>