130557 2014-03-20 21:06:22 -0700 [WK2] Make Connection::sendMessage a little less heavy 2016-03-14 11:48:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 benjamin benjamin andersca darin oldest_to_newest 992883 0 benjamin 2014-03-20 21:06:22 -0700 [WK2] Make Connection::sendMessage a little less heavy 992886 1 227376 benjamin 2014-03-20 21:11:45 -0700 Created attachment 227376 Patch 993076 2 227376 andersca 2014-03-21 07:13:14 -0700 Comment on attachment 227376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227376&action=review > Source/WebKit2/ChangeLog:8 > + Dispatching messages on the main thread takes a long time. This reduces the overhead a bit. This is not true though, we're not dispatching messages on the main thread. 993148 3 benjamin 2014-03-21 09:41:51 -0700 (In reply to comment #2) > > Source/WebKit2/ChangeLog:8 > > + Dispatching messages on the main thread takes a long time. This reduces the overhead a bit. > > This is not true though, we're not dispatching messages on the main thread. You are thinking dispatching messages to the other process... What takes lots of time here on the main thread is dispatching the messages to the dispatch queue for the secondary thread. 993172 4 andersca 2014-03-21 10:12:24 -0700 (In reply to comment #3) > (In reply to comment #2) > > > Source/WebKit2/ChangeLog:8 > > > + Dispatching messages on the main thread takes a long time. This reduces the overhead a bit. > > > > This is not true though, we're not dispatching messages on the main thread. > > You are thinking dispatching messages to the other process... What takes lots of time here on the main thread is dispatching the messages to the dispatch queue for the secondary thread. Then the ChangeLog should make that clear. I don't think this patch is right either, but I'd have to look closer at the code. 993386 5 benjamin 2014-03-21 17:20:01 -0700 (In reply to comment #4) > > > This is not true though, we're not dispatching messages on the main thread. > > > > You are thinking dispatching messages to the other process... What takes lots of time here on the main thread is dispatching the messages to the dispatch queue for the secondary thread. > > Then the ChangeLog should make that clear. The ChangeLog never said anything about dispatching messages between processes :) > I don't think this patch is right either, but I'd have to look closer at the code. Can you please check? 1022019 6 darin 2014-07-12 16:50:52 -0700 Anders, could do either review+ or review- on this? It’s been sitting around for a few months now. 1174545 7 227376 bfulgham 2016-03-14 11:14:44 -0700 Comment on attachment 227376 Patch Marking patch r- due to its age. Ben, can you update for current sources and we can sit and stare at Anders until he reviews the patch? ;-) 1174582 8 andersca 2016-03-14 11:48:13 -0700 I think that using Lock instead of Mutex makes this patch unnecessary actually. 227376 2014-03-20 21:11:45 -0700 2016-03-14 11:14:44 -0700 Patch bug-130557-20140320211123.patch text/plain 3962 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmE0YjQ0NzBiZDFlMWJm YjBlZTY1ZWEwOWY1ZDU0NTFmMmRiZDc3ZC4uNzlkZDc0ZTk5M2QzNjAxZjhiN2FlNDM5ODY2MDky Zjc4MjQ5OTZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE0LTAzLTIwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtXSzJdIE1ha2Ug Q29ubmVjdGlvbjo6c2VuZE1lc3NhZ2UgYSBsaXR0bGUgbGVzcyBoZWF2eQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNTU3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzcGF0Y2hpbmcgbWVzc2FnZXMg b24gdGhlIG1haW4gdGhyZWFkIHRha2VzIGEgbG9uZyB0aW1lLiBUaGlzIHJlZHVjZXMgdGhlIG92 ZXJoZWFkIGEgYml0LgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwOgor ICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpDb25uZWN0aW9uKToKKyAgICAgICAgVXNlIGEgc3Bp biBsb2NrIHNpbmNlIHRoZSBjb250ZW50aW9uIGlzIHVuY29tbW9uIGFuZCBvZiBzaG9ydCBkdXJh dGlvbi4KKworICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpzZW5kTWVzc2FnZSk6CisgICAgICAg IChJUEM6OkNvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2VzKToKKyAgICAgICAgQ29ubmVj dGlvbjo6c2VuZE91dGdvaW5nTWVzc2FnZXMoKSBkaXNwYXRjaCBtZXNzYWdlcyBhcyBsb25nIGFz IHRoZSBtZXNzYWdlIHF1ZXVlIGlzIG5vdCBlbXB0eS4KKyAgICAgICAgVXNlIHRoYXQgY29uZGl0 aW9uIGZyb20gQ29ubmVjdGlvbjo6c2VuZE1lc3NhZ2UoKSB0byBkZWNpZGUgaWYgYSBuZXcgc2Vu ZE91dGdvaW5nTWVzc2FnZXMgbmVlZHMgdG8gYmUgc2NoZWR1bGVkIG9yIG5vdC4KKworICAgICAg ICAqIFBsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmg6CisKKzIwMTQtMDMtMjAgIEJlbmphbWluIFBv dWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisKICAgICAgICAgW2lPU11bV0syXSBSZWR1Y2Ug dGhlIHRpbGluZyBjb3ZlcmFnZSB0byB0aGUgY3VycmVudCByZWN0IGFuZCAxIHRpbGUgc2l6ZSBh aGVhZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMw NTU1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9u LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcAppbmRleCBl M2JkZWQ2ZDA0OGNhNWFiNWI3ZTVlNmI5YTRmYzQxMGRmYWZlNDgyLi4wMjcyZmFhOTZkMTYzZGFj OTIyMjEzMDMzNjlhNTZiOTY0NjlmYWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBD L0Nvbm5lY3Rpb24uY3BwCkBAIC0yMjQsNiArMjI0LDcgQEAgQ29ubmVjdGlvbjo6Q29ubmVjdGlv bihJZGVudGlmaWVyIGlkZW50aWZpZXIsIGJvb2wgaXNTZXJ2ZXIsIENsaWVudCogY2xpZW50LCBS dW4KICAgICAsIG1faW5EaXNwYXRjaE1lc3NhZ2VDb3VudCgwKQogICAgICwgbV9pbkRpc3BhdGNo TWVzc2FnZU1hcmtlZERpc3BhdGNoV2hlbldhaXRpbmdGb3JTeW5jUmVwbHlDb3VudCgwKQogICAg ICwgbV9kaWRSZWNlaXZlSW52YWxpZE1lc3NhZ2UoZmFsc2UpCisgICAgLCBtX291dGdvaW5nTWVz c2FnZXNMb2NrKFNQSU5MT0NLX0lOSVRJQUxJWkVSKQogICAgICwgbV9zeW5jTWVzc2FnZVN0YXRl KFN5bmNNZXNzYWdlU3RhdGU6OmdldE9yQ3JlYXRlKGNsaWVudFJ1bkxvb3ApKQogICAgICwgbV9z aG91bGRXYWl0Rm9yU3luY1JlcGxpZXModHJ1ZSkKIHsKQEAgLTM2MSwxMiArMzYyLDEzIEBAIGJv b2wgQ29ubmVjdGlvbjo6c2VuZE1lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1lc3NhZ2VFbmNvZGVy PiBlbmNvZGVyLCB1bnNpZ25lZCBtCiAgICAgICAgIGVuY29kZXItPnNldFNob3VsZERpc3BhdGNo TWVzc2FnZVdoZW5XYWl0aW5nRm9yU3luY1JlcGx5KHRydWUpOwogCiAgICAgewotICAgICAgICBN dXRleExvY2tlciBsb2NrZXIobV9vdXRnb2luZ01lc3NhZ2VzTG9jayk7CisgICAgICAgIFNwaW5M b2NrSG9sZGVyIGxvY2tlcigmbV9vdXRnb2luZ01lc3NhZ2VzTG9jayk7CisgICAgICAgIGJvb2wg b3V0Z29pbmdNZXNzYWdlc1dhc0VtcHR5ID0gbV9vdXRnb2luZ01lc3NhZ2VzLmlzRW1wdHkoKTsK ICAgICAgICAgbV9vdXRnb2luZ01lc3NhZ2VzLmFwcGVuZChzdGQ6Om1vdmUoZW5jb2RlcikpOwor ICAgICAgICBpZiAob3V0Z29pbmdNZXNzYWdlc1dhc0VtcHR5KQorICAgICAgICAgICAgbV9jb25u ZWN0aW9uUXVldWUtPmRpc3BhdGNoKFdURjo6YmluZCgmQ29ubmVjdGlvbjo6c2VuZE91dGdvaW5n TWVzc2FnZXMsIHRoaXMpKTsKICAgICB9Ci0gICAgCi0gICAgLy8gRklYTUU6IFdlIHNob3VsZCBh ZGQgYSBib29sZWFuIGZsYWcgc28gd2UgZG9uJ3QgY2FsbCB0aGlzIHdoZW4gd29yayBoYXMgYWxy ZWFkeSBiZWVuIHNjaGVkdWxlZC4KLSAgICBtX2Nvbm5lY3Rpb25RdWV1ZS0+ZGlzcGF0Y2goV1RG OjpiaW5kKCZDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlcywgdGhpcykpOworCiAgICAg cmV0dXJuIHRydWU7CiB9CiAKQEAgLTcwOSw3ICs3MTEsNyBAQCB2b2lkIENvbm5lY3Rpb246OnNl bmRPdXRnb2luZ01lc3NhZ2VzKCkKICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPE1lc3NhZ2VFbmNv ZGVyPiBtZXNzYWdlOwogCiAgICAgICAgIHsKLSAgICAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tl cihtX291dGdvaW5nTWVzc2FnZXNMb2NrKTsKKyAgICAgICAgICAgIFNwaW5Mb2NrSG9sZGVyIGxv Y2tlcigmbV9vdXRnb2luZ01lc3NhZ2VzTG9jayk7CiAgICAgICAgICAgICBpZiAobV9vdXRnb2lu Z01lc3NhZ2VzLmlzRW1wdHkoKSkKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg IG1lc3NhZ2UgPSBtX291dGdvaW5nTWVzc2FnZXMudGFrZUZpcnN0KCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaAppbmRleCAyODY2OTAwOWI3Yjc3MzZlYzAwNDE4ZGIx YjVkM2FmZmJmZDJkNDg5Li5jOTc4MjY0YjZlM2Y2NmFhMDFhOWMzZDMxMGEzMDNlNjk2ZWI3Njlj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmgKQEAgLTM5LDYgKzM5 LDcgQEAKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRy Lmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgorI2luY2x1ZGUgPHd0Zi9UQ1NwaW5Mb2NrLmg+ CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCiAjaWYgT1MoREFSV0lOKQpAQCAtMjM3 LDcgKzIzOCw3IEBAIHByaXZhdGU6CiAgICAgRGVxdWU8c3RkOjp1bmlxdWVfcHRyPE1lc3NhZ2VE ZWNvZGVyPj4gbV9pbmNvbWluZ01lc3NhZ2VzOwogCiAgICAgLy8gT3V0Z29pbmcgbWVzc2FnZXMu Ci0gICAgTXV0ZXggbV9vdXRnb2luZ01lc3NhZ2VzTG9jazsKKyAgICBTcGluTG9jayBtX291dGdv aW5nTWVzc2FnZXNMb2NrOwogICAgIERlcXVlPHN0ZDo6dW5pcXVlX3B0cjxNZXNzYWdlRW5jb2Rl cj4+IG1fb3V0Z29pbmdNZXNzYWdlczsKICAgICAKICAgICBzdGQ6OmNvbmRpdGlvbl92YXJpYWJs ZSBtX3dhaXRGb3JNZXNzYWdlQ29uZGl0aW9uOwo=