130547 2014-03-20 17:11:57 -0700 WindowFeatures.{x|y|width|height} are not initialized 2014-03-21 10:37:27 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue oldest_to_newest 992813 0 ddkilzer 2014-03-20 17:11:57 -0700 Uninit Error reported from write at IPC::Channel::ChannelImpl::ProcessOutgoingMessages <https://code.google.com/p/chromium/issues/detail?id=342591> Code Review: <https://codereview.chromium.org/177633011/> 992814 1 ddkilzer 2014-03-20 17:12:13 -0700 <rdar://problem/16383151> 993103 2 227436 ddkilzer 2014-03-21 08:30:19 -0700 Created attachment 227436 Patch v1 993167 3 227436 darin 2014-03-21 10:04:19 -0700 Comment on attachment 227436 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review I’m saying review+ but this change doesn’t seem to have much benefit. > Source/WebCore/ChangeLog:13 > + - Initialize x, y, width, height in String constructor. Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug? 993184 4 ddkilzer 2014-03-21 10:25:43 -0700 (In reply to comment #3) > (From update of attachment 227436 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review > > I’m saying review+ but this change doesn’t seem to have much benefit. > > > Source/WebCore/ChangeLog:13 > > + - Initialize x, y, width, height in String constructor. > > Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug? It's to make code analysis tools happy. 993191 5 227436 commit-queue 2014-03-21 10:37:24 -0700 Comment on attachment 227436 Patch v1 Clearing flags on attachment: 227436 Committed r166072: <http://trac.webkit.org/changeset/166072> 993192 6 commit-queue 2014-03-21 10:37:27 -0700 All reviewed patches have been landed. Closing bug. 227436 2014-03-21 08:30:19 -0700 2014-03-21 10:37:24 -0700 Patch v1 bug-130547-20140321082956.patch text/plain 3230 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZkZTZjMmY2NzVjMGU1 MDY1Mzc1YjgzMDMwZmIwYzk4M2VjMjAxYi4uZjM3OGYwZmYzOTM3MjAxY2IzNGUxZmY3MDcxZWQx ZTYzM2E4ZWMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAzLTIxICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2luZG93RmVhdHVyZXMu e3h8eXx3aWR0aHxoZWlnaHR9IGFyZSBub3QgaW5pdGlhbGl6ZWQKKyAgICAgICAgPGh0dHA6Ly93 ZWJraXQub3JnL2IvMTMwNTQ3PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYzODMxNTE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24g YSBCbGluayBwYXRjaCBpbiBDUkJ1ZyAzNDI1OTEgYnkgemhhb3Fpbi4KKworICAgICAgICAqIHBh Z2UvV2luZG93RmVhdHVyZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2luZG93RmVhdHVyZXM6 OldpbmRvd0ZlYXR1cmVzKToKKyAgICAgICAgLSBJbml0aWFsaXplIHgsIHksIHdpZHRoLCBoZWln aHQgaW4gU3RyaW5nIGNvbnN0cnVjdG9yLgorICAgICAgICAtIE1vdmUgJ3Jlc2l6ZWFibGUnIHZh cmlhYmxlIHRvIHNob3J0LWhhbmQgaW5pdGlhbGl6YXRpb24gc2luY2UKKyAgICAgICAgICBpdCBp cyB0cnVlIGluIGJvdGggY2FzZXMuCisgICAgICAgIC0gVXNlIFN0cmluZzo6aXNFbXB0eSgpIGlu c3RlYWQgb2YgY2hlY2tpbmcgaXRzIGxlbmd0aC4KKyAgICAgICAgKiBwYWdlL1dpbmRvd0ZlYXR1 cmVzLmg6CisgICAgICAgIChXZWJDb3JlOjpXaW5kb3dGZWF0dXJlczo6V2luZG93RmVhdHVyZXMp OiBJbml0aWFsaXplIHgsIHksCisgICAgICAgIHdpZHRoLCBoZWlnaHQgaW4gbm8tYXJndW1lbnQg Y29uc3RydWN0b3IuCisKIDIwMTQtMDMtMjEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBTdWJwaXhlbCByZW5kZXJpbmc6IFJlbmRlckJveCBpcyBwb3NpdGlvbmVk IG9mZiBieSBvbmUgd2hlbiBub24tY29tcG9zaXRpbmcgdHJhbnNmb3JtIGlzIHByZXNlbnQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dpbmRvd0ZlYXR1cmVzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvV2luZG93RmVhdHVyZXMuY3BwCmluZGV4IGQ5MzQyMDE2MWExMDNlMGYz NWY3ZWMxMzMwYmRiODU1ODI4YzUyMTMuLjA1MTdiZGI0YTVkZTAzYTFlYWYyMWVmMDVjMzEyMDkx MmU4MTcxOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvV2luZG93RmVhdHVyZXMu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvV2luZG93RmVhdHVyZXMuY3BwCkBAIC0zNywx MCArMzcsMTUgQEAgc3RhdGljIGJvb2wgaXNXaW5kb3dGZWF0dXJlc1NlcGFyYXRvcihVQ2hhciBj KQogfQogCiBXaW5kb3dGZWF0dXJlczo6V2luZG93RmVhdHVyZXMoY29uc3QgU3RyaW5nJiBmZWF0 dXJlcykKLSAgICA6IHhTZXQoZmFsc2UpCisgICAgOiB4KDApCisgICAgLCB4U2V0KGZhbHNlKQor ICAgICwgeSgwKQogICAgICwgeVNldChmYWxzZSkKKyAgICAsIHdpZHRoKDApCiAgICAgLCB3aWR0 aFNldChmYWxzZSkKKyAgICAsIGhlaWdodCgwKQogICAgICwgaGVpZ2h0U2V0KGZhbHNlKQorICAg ICwgcmVzaXphYmxlKHRydWUpCiAgICAgLCBmdWxsc2NyZWVuKGZhbHNlKQogICAgICwgZGlhbG9n KGZhbHNlKQogewpAQCAtNTMsMTMgKzU4LDEyIEBAIFdpbmRvd0ZlYXR1cmVzOjpXaW5kb3dGZWF0 dXJlcyhjb25zdCBTdHJpbmcmIGZlYXR1cmVzKQogICAgICBXZSBhbHdheXMgYWxsb3cgYSB3aW5k b3cgdG8gYmUgcmVzaXplZCwgd2hpY2ggaXMgY29uc2lzdGVudCB3aXRoIEZpcmVmb3guCiAgICAg ICovCiAKLSAgICBpZiAoZmVhdHVyZXMubGVuZ3RoKCkgPT0gMCkgeworICAgIGlmIChmZWF0dXJl cy5pc0VtcHR5KCkpIHsKICAgICAgICAgbWVudUJhclZpc2libGUgPSB0cnVlOwogICAgICAgICBz dGF0dXNCYXJWaXNpYmxlID0gdHJ1ZTsKICAgICAgICAgdG9vbEJhclZpc2libGUgPSB0cnVlOwog ICAgICAgICBsb2NhdGlvbkJhclZpc2libGUgPSB0cnVlOwogICAgICAgICBzY3JvbGxiYXJzVmlz aWJsZSA9IHRydWU7Ci0gICAgICAgIHJlc2l6YWJsZSA9IHRydWU7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKQEAgLTY4LDcgKzcyLDYgQEAgV2luZG93RmVhdHVyZXM6OldpbmRvd0ZlYXR1cmVz KGNvbnN0IFN0cmluZyYgZmVhdHVyZXMpCiAgICAgdG9vbEJhclZpc2libGUgPSBmYWxzZTsKICAg ICBsb2NhdGlvbkJhclZpc2libGUgPSBmYWxzZTsKICAgICBzY3JvbGxiYXJzVmlzaWJsZSA9IGZh bHNlOwotICAgIHJlc2l6YWJsZSA9IHRydWU7CiAKICAgICAvLyBUcmVhZCBsaWdodGx5IGluIHRo aXMgY29kZSAtLSBpdCB3YXMgc3BlY2lmaWNhbGx5IGRlc2lnbmVkIHRvIG1pbWljIFdpbiBJRSdz IHBhcnNpbmcgYmVoYXZpb3IuCiAgICAgaW50IGtleUJlZ2luLCBrZXlFbmQ7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dpbmRvd0ZlYXR1cmVzLmggYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1dpbmRvd0ZlYXR1cmVzLmgKaW5kZXggMWZjZWVlNTU1MTU1YTIyZDk0MzhiMWUyNzQwM2Q4 ZGE2ZTEwMGU1Ni4uNmM4NzJlMjI2YThmZmM1YjFmMmE4YWFkNzVhMjAyNzE2NDM1NmEyYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9XaW5kb3dGZWF0dXJlcy5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvV2luZG93RmVhdHVyZXMuaApAQCAtMzgsOSArMzgsMTMgQEAgY2xhc3Mg RmxvYXRSZWN0OwogCiBzdHJ1Y3QgV2luZG93RmVhdHVyZXMgewogICAgIFdpbmRvd0ZlYXR1cmVz KCkKLSAgICAgICAgOiB4U2V0KGZhbHNlKQorICAgICAgICA6IHgoMCkKKyAgICAgICAgLCB4U2V0 KGZhbHNlKQorICAgICAgICAsIHkoMCkKICAgICAgICAgLCB5U2V0KGZhbHNlKQorICAgICAgICAs IHdpZHRoKDApCiAgICAgICAgICwgd2lkdGhTZXQoZmFsc2UpCisgICAgICAgICwgaGVpZ2h0KDAp CiAgICAgICAgICwgaGVpZ2h0U2V0KGZhbHNlKQogICAgICAgICAsIG1lbnVCYXJWaXNpYmxlKHRy dWUpCiAgICAgICAgICwgc3RhdHVzQmFyVmlzaWJsZSh0cnVlKQo=