130546 2014-03-20 16:55:21 -0700 FTL ValueToInt32 mishandles the constant case, and by the way, there is a constant case that the FTL sees 2014-03-20 17:33:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough commit-queue ggaren mark.lam mhahnenberg mmirman msaboff oliver sam oldest_to_newest 992801 0 fpizlo 2014-03-20 16:55:21 -0700 Patch forthcoming. 992803 1 227356 fpizlo 2014-03-20 17:01:17 -0700 Created attachment 227356 the patch 992805 2 commit-queue 2014-03-20 17:04:04 -0700 Attachment 227356 did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3904: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3906: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3908: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3912: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3921: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3925: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3927: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3929: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3936: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 9 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 992806 3 227356 mhahnenberg 2014-03-20 17:04:15 -0700 Comment on attachment 227356 the patch r=me 992807 4 mhahnenberg 2014-03-20 17:05:09 -0700 (In reply to comment #2) > Attachment 227356 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3904: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3906: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3908: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3912: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3921: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3925: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3927: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3929: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3936: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > Total errors found: 9 in 5 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Modulo style. 992809 5 fpizlo 2014-03-20 17:07:07 -0700 (In reply to comment #4) > (In reply to comment #2) > > Attachment 227356 [details] [details] did not pass style-queue: > > > > > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3904: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3906: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3908: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3912: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3921: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3925: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3927: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3929: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3936: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > > Total errors found: 9 in 5 files > > > > > > If any of these errors are false positives, please file a bug against check-webkit-style. > > Modulo style. Yup. :-) 992817 6 fpizlo 2014-03-20 17:33:22 -0700 Landed in http://trac.webkit.org/changeset/166030 227356 2014-03-20 17:01:17 -0700 2014-03-20 17:04:14 -0700 the patch blah.patch text/plain 9896 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MDIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDE0LTAzLTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIFZhbHVlVG9JbnQzMiBtaXNoYW5kbGVzIHRoZSBjb25zdGFudCBjYXNlLCBhbmQgYnkgdGhl IHdheSwgdGhlcmUgaXMgYSBjb25zdGFudCBjYXNlIHRoYXQgdGhlIEZUTCBzZWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1NDYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE2MzgzMzA4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgTWFrZSBBSSBkbyBhIGJldHRlciBqb2Igb2YgZm9s ZGluZyB0aGlzLgorICAgICAgICAKKyAgICAgICAgQWxzbyBtYWRlIHRoZSBGVEwgYmFja2VuZCBi ZSBtb3JlIHRvbGVyYW50IG9mIGRhdGEgcmVwcmVzZW50YXRpb25zLiBJbiB0aGlzIGNhc2UgaXQK KyAgICAgICAgZGlkbid0IGtub3cgdGhhdCAiY29uc3RhbnQiIHdhcyBhIHZhbGlkIHJlcHJlc2Vu dGF0aW9uLiBUaGVyZSBpcyBhIGZpbml0ZSBzZXQgb2YKKyAgICAgICAgcG9zc2libGUgcmVwcmVz ZW50YXRpb25zLCBidXQgYnJvYWRseSwgd2UgZG9uJ3Qgd3JpdGUgY29kZSB0aGF0IHByZXN1bWVz IGFueXRoaW5nCisgICAgICAgIGFib3V0IHRoZSByZXByZXNlbnRhdGlvbiBvZiBhbiBpbnB1dDsg dGhhdCdzIHdoYXQgbWV0aG9kcyBsaWtlIGxvd0pTVmFsdWUoKSBhcmUgZm9yLgorICAgICAgICBW YWx1ZVRvSW50MzIgd2FzIHByZXZpb3VzbHkgbm90IHJlbHlpbmcgb24gdGhvc2UgbWV0aG9kcyBh dCBhbGwgYmVjYXVzZSBpdCBoYWQgc29tZQorICAgICAgICBoYWNrcy4gTm93LCB0aG9zZSBoYWNr cyBhcmUganVzdCBhIGZhc3QtcGF0aCBvcHRpbWl6YXRpb24gYnV0IHVsdGltYXRlbHkgd2UgZmFs bCBkb3duCisgICAgICAgIHRvIGxvd0pTVmFsdWUoKS4KKworICAgICAgICAqIGRmZy9ERkdBYnN0 cmFjdEludGVycHJldGVySW5saW5lcy5oOgorICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0SW50 ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5cGU+OjpleGVjdXRlRWZmZWN0cyk6CisgICAgICAgICog ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1Rv TExWTTo6Y29tcGlsZVZhbHVlVG9JbnQzMik6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdU b0xMVk06Om51bWJlck9yTm90Q2VsbFRvSW50MzIpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy92 YWx1ZS10by1pbnQzMi11bmRlZmluZWQtY29uc3RhbnQuanM6IEFkZGVkLgorICAgICAgICAoZm9v KToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvdmFsdWUtdG8taW50MzItdW5kZWZpbmVkLmpzOiBB ZGRlZC4KKyAgICAgICAgKGZvbyk6CisKIDIwMTQtMDMtMjAgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc3RhY2ttYXAgaGVhZGVyIHZlcnNpb24g Y2hlY2sgYW5kIHN1cHBvcnQgbmV3IHN0YWNrbWFwIGZvcm1hdHMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxp bmVzLmgJKHJldmlzaW9uIDE2NTk5NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH QWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMjk3LDYgKzI5 NywxMCBAQCBib29sIEFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5CiAgICAgICAg ICAgICAgICAgc2V0Q29uc3RhbnQobm9kZSwgSlNWYWx1ZShjaGlsZC5hc0Jvb2xlYW4oKSkpOwog ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKGNo aWxkLmlzVW5kZWZpbmVkT3JOdWxsKCkpIHsKKyAgICAgICAgICAgICAgICBzZXRDb25zdGFudChu b2RlLCBqc051bWJlcigwKSk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9 CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIGZvck5vZGUobm9kZSkuc2V0VHlwZShTcGVj SW50MzIpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExW TS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRG R1RvTExWTS5jcHAJKHJldmlzaW9uIDE2NTk5NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NTEsNTkgKzY1MSw3 IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAKICAgICAgICAgICAgIHZhbHVlID0gbV9qc1ZhbHVl VmFsdWVzLmdldChtX25vZGUtPmNoaWxkMSgpLm5vZGUoKSk7CiAgICAgICAgICAgICBpZiAoaXNW YWxpZCh2YWx1ZSkpIHsKLSAgICAgICAgICAgICAgICBMQmFzaWNCbG9jayBpbnRDYXNlID0gRlRM X05FV19CTE9DSyhtX291dCwgKCJWYWx1ZVRvSW50MzIgaW50IGNhc2UiKSk7Ci0gICAgICAgICAg ICAgICAgTEJhc2ljQmxvY2sgbm90SW50Q2FzZSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiVmFs dWVUb0ludDMyIG5vdCBpbnQgY2FzZSIpKTsKLSAgICAgICAgICAgICAgICBMQmFzaWNCbG9jayBk b3VibGVDYXNlID0gMDsKLSAgICAgICAgICAgICAgICBMQmFzaWNCbG9jayBub3ROdW1iZXJDYXNl ID0gMDsKLSAgICAgICAgICAgICAgICBpZiAobV9ub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgPT0g Tm90Q2VsbFVzZSkgewotICAgICAgICAgICAgICAgICAgICBkb3VibGVDYXNlID0gRlRMX05FV19C TE9DSyhtX291dCwgKCJWYWx1ZVRvSW50MzIgZG91YmxlIGNhc2UiKSk7Ci0gICAgICAgICAgICAg ICAgICAgIG5vdE51bWJlckNhc2UgPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIlZhbHVlVG9JbnQz MiBub3QgbnVtYmVyIGNhc2UiKSk7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAg IExCYXNpY0Jsb2NrIGNvbnRpbnVhdGlvbiA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiVmFsdWVU b0ludDMyIGNvbnRpbnVhdGlvbiIpKTsKLSAgICAgICAgICAgICAgICAKLSAgICAgICAgICAgICAg ICBWZWN0b3I8VmFsdWVGcm9tQmxvY2s+IHJlc3VsdHM7Ci0gICAgICAgICAgICAgICAgCi0gICAg ICAgICAgICAgICAgbV9vdXQuYnJhbmNoKAotICAgICAgICAgICAgICAgICAgICBpc05vdEludDMy KHZhbHVlLnZhbHVlKCkpLCB1bnN1cmUobm90SW50Q2FzZSksIHVuc3VyZShpbnRDYXNlKSk7Ci0g ICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgTEJhc2ljQmxvY2sgbGFzdE5leHQgPSBt X291dC5hcHBlbmRUbyhpbnRDYXNlLCBub3RJbnRDYXNlKTsKLSAgICAgICAgICAgICAgICByZXN1 bHRzLmFwcGVuZChtX291dC5hbmNob3IodW5ib3hJbnQzMih2YWx1ZS52YWx1ZSgpKSkpOwotICAg ICAgICAgICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0aW9uKTsKLSAgICAgICAgICAgICAgICAK LSAgICAgICAgICAgICAgICBpZiAobV9ub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgPT0gTnVtYmVy VXNlKSB7Ci0gICAgICAgICAgICAgICAgICAgIG1fb3V0LmFwcGVuZFRvKG5vdEludENhc2UsIGNv bnRpbnVhdGlvbik7Ci0gICAgICAgICAgICAgICAgICAgIEZUTF9UWVBFX0NIRUNLKAotICAgICAg ICAgICAgICAgICAgICAgICAganNWYWx1ZVZhbHVlKHZhbHVlLnZhbHVlKCkpLCBtX25vZGUtPmNo aWxkMSgpLCBTcGVjRnVsbE51bWJlciwKLSAgICAgICAgICAgICAgICAgICAgICAgIGlzQ2VsbE9y TWlzYyh2YWx1ZS52YWx1ZSgpKSk7Ci0gICAgICAgICAgICAgICAgICAgIHJlc3VsdHMuYXBwZW5k KG1fb3V0LmFuY2hvcihkb3VibGVUb0ludDMyKHVuYm94RG91YmxlKHZhbHVlLnZhbHVlKCkpKSkp OwotICAgICAgICAgICAgICAgICAgICBtX291dC5qdW1wKGNvbnRpbnVhdGlvbik7Ci0gICAgICAg ICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgbV9vdXQuYXBwZW5kVG8obm90 SW50Q2FzZSwgZG91YmxlQ2FzZSk7Ci0gICAgICAgICAgICAgICAgICAgIG1fb3V0LmJyYW5jaCgK LSAgICAgICAgICAgICAgICAgICAgICAgIGlzQ2VsbE9yTWlzYyh2YWx1ZS52YWx1ZSgpKSwKLSAg ICAgICAgICAgICAgICAgICAgICAgIHVuc3VyZShub3ROdW1iZXJDYXNlKSwgdW5zdXJlKGRvdWJs ZUNhc2UpKTsKLSAgICAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgIG1fb3V0 LmFwcGVuZFRvKGRvdWJsZUNhc2UsIG5vdE51bWJlckNhc2UpOwotICAgICAgICAgICAgICAgICAg ICByZXN1bHRzLmFwcGVuZChtX291dC5hbmNob3IoZG91YmxlVG9JbnQzMih1bmJveERvdWJsZSh2 YWx1ZS52YWx1ZSgpKSkpKTsKLSAgICAgICAgICAgICAgICAgICAgbV9vdXQuanVtcChjb250aW51 YXRpb24pOwotICAgICAgICAgICAgICAgICAgICAKLSAgICAgICAgICAgICAgICAgICAgbV9vdXQu YXBwZW5kVG8obm90TnVtYmVyQ2FzZSwgY29udGludWF0aW9uKTsKLSAgICAgICAgICAgICAgICAg ICAgCi0gICAgICAgICAgICAgICAgICAgIEZUTF9UWVBFX0NIRUNLKAotICAgICAgICAgICAgICAg ICAgICAgICAganNWYWx1ZVZhbHVlKHZhbHVlLnZhbHVlKCkpLCBtX25vZGUtPmNoaWxkMSgpLCB+ U3BlY0NlbGwsCi0gICAgICAgICAgICAgICAgICAgICAgICBpc0NlbGwodmFsdWUudmFsdWUoKSkp OwotICAgICAgICAgICAgICAgICAgICAKLSAgICAgICAgICAgICAgICAgICAgTFZhbHVlIHNwZWNp YWxSZXN1bHQgPSBtX291dC5zZWxlY3QoCi0gICAgICAgICAgICAgICAgICAgICAgICBtX291dC5l cXVhbCgKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZS52YWx1ZSgpLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1fb3V0LmNvbnN0SW50NjQoSlNWYWx1ZTo6ZW5jb2RlKGpz Qm9vbGVhbih0cnVlKSkpKSwKLSAgICAgICAgICAgICAgICAgICAgICAgIG1fb3V0LmludDMyT25l LCBtX291dC5pbnQzMlplcm8pOwotICAgICAgICAgICAgICAgICAgICByZXN1bHRzLmFwcGVuZCht X291dC5hbmNob3Ioc3BlY2lhbFJlc3VsdCkpOwotICAgICAgICAgICAgICAgICAgICBtX291dC5q dW1wKGNvbnRpbnVhdGlvbik7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIAot ICAgICAgICAgICAgICAgIG1fb3V0LmFwcGVuZFRvKGNvbnRpbnVhdGlvbiwgbGFzdE5leHQpOwot ICAgICAgICAgICAgICAgIHNldEludDMyKG1fb3V0LnBoaShtX291dC5pbnQzMiwgcmVzdWx0cykp OworICAgICAgICAgICAgICAgIHNldEludDMyKG51bWJlck9yTm90Q2VsbFRvSW50MzIobV9ub2Rl LT5jaGlsZDEoKSwgdmFsdWUudmFsdWUoKSkpOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICAgICAgfQogICAgICAgICAgICAgCkBAIC03MTMsNyArNjYxLDEyIEBAIHByaXZhdGU6CiAg ICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAKLSAgICAg ICAgICAgIHRlcm1pbmF0ZShVbmNvdW50YWJsZSk7CisgICAgICAgICAgICAvLyBXZSdsbCBiYXNp Y2FsbHkganVzdCBnZXQgaGVyZSBmb3IgY29uc3RhbnRzLiBCdXQgaXQncyBnb29kIHRvIGhhdmUg dGhpcworICAgICAgICAgICAgLy8gY2F0Y2gtYWxsIHNpbmNlIHdlIG9mdGVuIGFkZCBuZXcgcmVw cmVzZW50YXRpb25zIGludG8gdGhlIG1peC4KKyAgICAgICAgICAgIHNldEludDMyKAorICAgICAg ICAgICAgICAgIG51bWJlck9yTm90Q2VsbFRvSW50MzIoCisgICAgICAgICAgICAgICAgICAgIG1f bm9kZS0+Y2hpbGQxKCksCisgICAgICAgICAgICAgICAgICAgIGxvd0pTVmFsdWUobV9ub2RlLT5j aGlsZDEoKSwgTWFudWFsT3BlcmFuZFNwZWN1bGF0aW9uKSkpOwogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIH0KICAgICAgICAgICAgIApAQCAtMzkzNyw2ICszODkwLDU0IEBAIHByaXZhdGU6 CiAgICAgICAgIHJldHVybiBtX291dC5ib29sZWFuRmFsc2U7CiAgICAgfQogICAgIAorICAgIExW YWx1ZSBudW1iZXJPck5vdENlbGxUb0ludDMyKEVkZ2UgZWRnZSwgTFZhbHVlIHZhbHVlKQorICAg IHsKKyAgICAgICAgTEJhc2ljQmxvY2sgaW50Q2FzZSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgi VmFsdWVUb0ludDMyIGludCBjYXNlIikpOworICAgICAgICBMQmFzaWNCbG9jayBub3RJbnRDYXNl ID0gRlRMX05FV19CTE9DSyhtX291dCwgKCJWYWx1ZVRvSW50MzIgbm90IGludCBjYXNlIikpOwor ICAgICAgICBMQmFzaWNCbG9jayBkb3VibGVDYXNlID0gMDsKKyAgICAgICAgTEJhc2ljQmxvY2sg bm90TnVtYmVyQ2FzZSA9IDA7CisgICAgICAgIGlmIChlZGdlLnVzZUtpbmQoKSA9PSBOb3RDZWxs VXNlKSB7CisgICAgICAgICAgICBkb3VibGVDYXNlID0gRlRMX05FV19CTE9DSyhtX291dCwgKCJW YWx1ZVRvSW50MzIgZG91YmxlIGNhc2UiKSk7CisgICAgICAgICAgICBub3ROdW1iZXJDYXNlID0g RlRMX05FV19CTE9DSyhtX291dCwgKCJWYWx1ZVRvSW50MzIgbm90IG51bWJlciBjYXNlIikpOwor ICAgICAgICB9CisgICAgICAgIExCYXNpY0Jsb2NrIGNvbnRpbnVhdGlvbiA9IEZUTF9ORVdfQkxP Q0sobV9vdXQsICgiVmFsdWVUb0ludDMyIGNvbnRpbnVhdGlvbiIpKTsKKyAgICAgICAgICAgICAg ICAKKyAgICAgICAgVmVjdG9yPFZhbHVlRnJvbUJsb2NrPiByZXN1bHRzOworICAgICAgICAgICAg ICAgIAorICAgICAgICBtX291dC5icmFuY2goaXNOb3RJbnQzMih2YWx1ZSksIHVuc3VyZShub3RJ bnRDYXNlKSwgdW5zdXJlKGludENhc2UpKTsKKyAgICAgICAgICAgICAgICAKKyAgICAgICAgTEJh c2ljQmxvY2sgbGFzdE5leHQgPSBtX291dC5hcHBlbmRUbyhpbnRDYXNlLCBub3RJbnRDYXNlKTsK KyAgICAgICAgcmVzdWx0cy5hcHBlbmQobV9vdXQuYW5jaG9yKHVuYm94SW50MzIodmFsdWUpKSk7 CisgICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0aW9uKTsKKyAgICAgICAgICAgICAgICAKKyAg ICAgICAgaWYgKGVkZ2UudXNlS2luZCgpID09IE51bWJlclVzZSkgeworICAgICAgICAgICAgbV9v dXQuYXBwZW5kVG8obm90SW50Q2FzZSwgY29udGludWF0aW9uKTsKKyAgICAgICAgICAgIEZUTF9U WVBFX0NIRUNLKGpzVmFsdWVWYWx1ZSh2YWx1ZSksIGVkZ2UsIFNwZWNGdWxsTnVtYmVyLCBpc0Nl bGxPck1pc2ModmFsdWUpKTsKKyAgICAgICAgICAgIHJlc3VsdHMuYXBwZW5kKG1fb3V0LmFuY2hv cihkb3VibGVUb0ludDMyKHVuYm94RG91YmxlKHZhbHVlKSkpKTsKKyAgICAgICAgICAgIG1fb3V0 Lmp1bXAoY29udGludWF0aW9uKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIG1fb3V0 LmFwcGVuZFRvKG5vdEludENhc2UsIGRvdWJsZUNhc2UpOworICAgICAgICAgICAgbV9vdXQuYnJh bmNoKGlzQ2VsbE9yTWlzYyh2YWx1ZSksIHVuc3VyZShub3ROdW1iZXJDYXNlKSwgdW5zdXJlKGRv dWJsZUNhc2UpKTsKKyAgICAgICAgICAgICAgICAgICAgCisgICAgICAgICAgICBtX291dC5hcHBl bmRUbyhkb3VibGVDYXNlLCBub3ROdW1iZXJDYXNlKTsKKyAgICAgICAgICAgIHJlc3VsdHMuYXBw ZW5kKG1fb3V0LmFuY2hvcihkb3VibGVUb0ludDMyKHVuYm94RG91YmxlKHZhbHVlKSkpKTsKKyAg ICAgICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0aW9uKTsKKyAgICAgICAgICAgICAgICAgICAg CisgICAgICAgICAgICBtX291dC5hcHBlbmRUbyhub3ROdW1iZXJDYXNlLCBjb250aW51YXRpb24p OworICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgIEZUTF9UWVBFX0NIRUNLKGpzVmFs dWVWYWx1ZSh2YWx1ZSksIGVkZ2UsIH5TcGVjQ2VsbCwgaXNDZWxsKHZhbHVlKSk7CisgICAgICAg ICAgICAgICAgICAgIAorICAgICAgICAgICAgTFZhbHVlIHNwZWNpYWxSZXN1bHQgPSBtX291dC5z ZWxlY3QoCisgICAgICAgICAgICAgICAgbV9vdXQuZXF1YWwodmFsdWUsIG1fb3V0LmNvbnN0SW50 NjQoSlNWYWx1ZTo6ZW5jb2RlKGpzQm9vbGVhbih0cnVlKSkpKSwKKyAgICAgICAgICAgICAgICBt X291dC5pbnQzMk9uZSwgbV9vdXQuaW50MzJaZXJvKTsKKyAgICAgICAgICAgIHJlc3VsdHMuYXBw ZW5kKG1fb3V0LmFuY2hvcihzcGVjaWFsUmVzdWx0KSk7CisgICAgICAgICAgICBtX291dC5qdW1w KGNvbnRpbnVhdGlvbik7CisgICAgICAgIH0KKyAgICAgICAgICAgICAgICAKKyAgICAgICAgbV9v dXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0TmV4dCk7CisgICAgICAgIHJldHVybiBtX291 dC5waGkobV9vdXQuaW50MzIsIHJlc3VsdHMpOworICAgIH0KKyAgICAKICAgICBMVmFsdWUgbG9h ZFByb3BlcnR5KExWYWx1ZSBzdG9yYWdlLCB1bnNpZ25lZCBpZGVudGlmaWVyTnVtYmVyLCBQcm9w ZXJ0eU9mZnNldCBvZmZzZXQpCiAgICAgewogICAgICAgICByZXR1cm4gbV9vdXQubG9hZDY0KGFk ZHJlc3NPZlByb3BlcnR5KHN0b3JhZ2UsIGlkZW50aWZpZXJOdW1iZXIsIG9mZnNldCkpOwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy92YWx1ZS10by1pbnQzMi11bmRl ZmluZWQtY29uc3RhbnQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rl c3RzL3N0cmVzcy92YWx1ZS10by1pbnQzMi11bmRlZmluZWQtY29uc3RhbnQuanMJKHJldmlzaW9u IDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3ZhbHVlLXRvLWludDMy LXVuZGVmaW5lZC1jb25zdGFudC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEyIEBACitm dW5jdGlvbiBmb28oKSB7CisgICAgcmV0dXJuICh2b2lkIDApIHwgMDsKK30KKworbm9JbmxpbmUo Zm9vKTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgKytpKSB7CisgICAgdmFyIHJlc3Vs dCA9IGZvbygpOworICAgIGlmIChyZXN1bHQgIT0gMCkKKyAgICAgICAgdGhyb3cgIkVycm9yOiBi YWQgcmVzdWx0OiAiICsgcmVzdWx0OworfQorCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv dGVzdHMvc3RyZXNzL3ZhbHVlLXRvLWludDMyLXVuZGVmaW5lZC5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3ZhbHVlLXRvLWludDMyLXVuZGVmaW5l ZC5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mv dmFsdWUtdG8taW50MzItdW5kZWZpbmVkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTIg QEAKK2Z1bmN0aW9uIGZvbyhhKSB7CisgICAgcmV0dXJuIGEgfCAwOworfQorCitub0lubGluZShm b28oKSk7CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgeworICAgIHZhciByZXN1 bHQgPSBmb28odm9pZCAwKTsKKyAgICBpZiAocmVzdWx0ICE9IDApCisgICAgICAgIHRocm93ICJF cnJvcjogYmFkIHJlc3VsdDogIiArIHJlc3VsdDsKK30KKwo=