130531 2014-03-20 13:03:42 -0700 Add some assertions back 2014-03-20 17:11:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 992674 0 mhahnenberg 2014-03-20 13:03:42 -0700 We removed a useful set of assertions for verifying that MarkedBlocks were in the state that we expected them to be in after clearing marks in the Heap. We should add these back to catch bugs earlier. 992676 1 227322 mhahnenberg 2014-03-20 13:05:17 -0700 Created attachment 227322 Patch 992772 2 227322 ggaren 2014-03-20 15:52:50 -0700 Comment on attachment 227322 Patch r=me 992811 3 227322 commit-queue 2014-03-20 17:11:22 -0700 Comment on attachment 227322 Patch Clearing flags on attachment: 227322 Committed r166028: <http://trac.webkit.org/changeset/166028> 992812 4 commit-queue 2014-03-20 17:11:24 -0700 All reviewed patches have been landed. Closing bug. 227322 2014-03-20 13:05:17 -0700 2014-03-20 17:11:21 -0700 Patch bug-130531-20140320130456.patch text/plain 2574 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1OTkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAzLTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQWRkIHNvbWUgYXNzZXJ0aW9ucyBiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSByZW1vdmVkIGEgdXNlZnVsIHNldCBvZiBhc3Nl cnRpb25zIGZvciB2ZXJpZnlpbmcgdGhhdCBNYXJrZWRCbG9ja3Mgd2VyZSAKKyAgICAgICAgaW4g dGhlIHN0YXRlIHRoYXQgd2UgZXhwZWN0ZWQgdGhlbSB0byBiZSBpbiBhZnRlciBjbGVhcmluZyBt YXJrcyBpbiB0aGUgSGVhcC4gCisgICAgICAgIFdlIHNob3VsZCBhZGQgdGhlc2UgYmFjayB0byBj YXRjaCBidWdzIGVhcmxpZXIuCisKKyAgICAgICAgKiBoZWFwL01hcmtlZEJsb2NrLmg6CisgICAg ICAgICogaGVhcC9NYXJrZWRTcGFjZS5jcHA6CisgICAgICAgIChKU0M6OlZlcmlmeU1hcmtlZE9y UmV0aXJlZDo6b3BlcmF0b3IoKSk6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjpjbGVhck1h cmtzKToKKwogMjAxNC0wMy0yMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIEluY29ycmVjdCBiZWhhdmlvciB3aGVuIG11dGF0aW5nIGEgdHlwZWQgYXJyYXkgZHVy aW5nIHNldC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suaAko cmV2aXNpb24gMTY1OTY5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxv Y2suaAkod29ya2luZyBjb3B5KQpAQCAtNzEsNyArNzEsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIAog ICAgIGNsYXNzIE1hcmtlZEJsb2NrIDogcHVibGljIEhlYXBCbG9jazxNYXJrZWRCbG9jaz4gewog ICAgICAgICBmcmllbmQgY2xhc3MgTExJbnRPZmZzZXRzRXh0cmFjdG9yOwotCisgICAgICAgIGZy aWVuZCBzdHJ1Y3QgVmVyaWZ5TWFya2VkT3JSZXRpcmVkOwogICAgIHB1YmxpYzoKICAgICAgICAg c3RhdGljIGNvbnN0IHNpemVfdCBhdG9tU2l6ZSA9IDE2OyAvLyBieXRlcwogICAgICAgICBzdGF0 aWMgY29uc3Qgc2l6ZV90IGF0b21TaGlmdEFtb3VudCA9IDQ7IC8vIGxvZ18yKGF0b21TaXplKSBG SVhNRTogQ2hhbmdlIGF0b21TaXplIHRvIDE2LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya2VkU3BhY2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL01hcmtlZFNwYWNlLmNwcAkocmV2aXNpb24gMTY1OTY5KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvTWFya2VkU3BhY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTcsNiAr MzE3LDIxIEBAIHZvaWQgTWFya2VkU3BhY2U6OmNsZWFyTmV3bHlBbGxvY2F0ZWQoKQogI2VuZGlm CiB9CiAKKyNpZm5kZWYgTkRFQlVHIAorc3RydWN0IFZlcmlmeU1hcmtlZE9yUmV0aXJlZCA6IE1h cmtlZEJsb2NrOjpWb2lkRnVuY3RvciB7IAorICAgIHZvaWQgb3BlcmF0b3IoKShNYXJrZWRCbG9j ayogYmxvY2spCisgICAgeworICAgICAgICBzd2l0Y2ggKGJsb2NrLT5tX3N0YXRlKSB7CisgICAg ICAgIGNhc2UgTWFya2VkQmxvY2s6Ok1hcmtlZDoKKyAgICAgICAgY2FzZSBNYXJrZWRCbG9jazo6 UmV0aXJlZDoKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAg ICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIH0KKyAgICB9Cit9OyAK KyNlbmRpZiAKKwogdm9pZCBNYXJrZWRTcGFjZTo6Y2xlYXJNYXJrcygpCiB7CiAgICAgaWYgKG1f aGVhcC0+b3BlcmF0aW9uSW5Qcm9ncmVzcygpID09IEVkZW5Db2xsZWN0aW9uKSB7CkBAIC0zMjQs NiArMzM5LDExIEBAIHZvaWQgTWFya2VkU3BhY2U6OmNsZWFyTWFya3MoKQogICAgICAgICAgICAg bV9ibG9ja3NXaXRoTmV3T2JqZWN0c1tpXS0+Y2xlYXJNYXJrcygpOwogICAgIH0gZWxzZQogICAg ICAgICBmb3JFYWNoQmxvY2s8Q2xlYXJNYXJrcz4oKTsKKworI2lmbmRlZiBOREVCVUcKKyAgICBW ZXJpZnlNYXJrZWRPclJldGlyZWQgdmVyaWZ5RnVuY3RvcjsKKyAgICBmb3JFYWNoQmxvY2sodmVy aWZ5RnVuY3Rvcik7CisjZW5kaWYKIH0KIAogdm9pZCBNYXJrZWRTcGFjZTo6d2lsbFN0YXJ0SXRl cmF0aW5nKCkK