130527 2014-03-20 12:16:38 -0700 Web Inspector: DebuggerDashboardView looks scrunched debugging JSContext 2014-03-20 12:59:56 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 992643 0 joepeck 2014-03-20 12:16:38 -0700 When hitting a breakpoint in a JSContext debug session the dashboard view is scrunched instead of showing its collapsed content. When debugging JSContext actually use the "collapsed" style class instead of piggy backing on "body.javascript". 992647 1 227317 joepeck 2014-03-20 12:19:35 -0700 Created attachment 227317 [PATCH] Proposed Fix 992649 2 joepeck 2014-03-20 12:19:58 -0700 We need a better default dashboard view for a JS debuggable. But this helps in the meantime. 992650 3 timothy 2014-03-20 12:21:22 -0700 (In reply to comment #2) > We need a better default dashboard view for a JS debuggable. But this helps in the meantime. Yeah, and now we have the infrastructure to have a different view! 992653 4 webkit-bug-importer 2014-03-20 12:27:03 -0700 <rdar://problem/16381937> 992669 5 227317 commit-queue 2014-03-20 12:59:53 -0700 Comment on attachment 227317 [PATCH] Proposed Fix Clearing flags on attachment: 227317 Committed r165988: <http://trac.webkit.org/changeset/165988> 992670 6 commit-queue 2014-03-20 12:59:56 -0700 All reviewed patches have been landed. Closing bug. 227317 2014-03-20 12:19:35 -0700 2014-03-20 12:59:53 -0700 [PATCH] Proposed Fix collapse.patch text/plain 2388 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU2NDE5MjguLmYzNzQ5MjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdn ZXJEYXNoYm9hcmRWaWV3IGxvb2tzIHNjcnVuY2hlZCBkZWJ1Z2dpbmcgSlNDb250ZXh0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1MjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHVz aW5nIGJvZHkuamF2YXNjcmlwdCB0byBmb3JjZSBhIGNvbGxhcHNlZCBzdHlsZSwKKyAgICAgICAg YWN0dWFsbHkgdXNlIHRoZSB0b29sYmFyJ3MgY29sbGFwc2VkIGNsYXNzLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9EYXNoYm9hcmRDb250YWluZXJWaWV3LmNzczoKKyAgICAgICAg KC50b29sYmFyLmNvbGxhcHNlZCAuZGFzaGJvYXJkLWNvbnRhaW5lcik6CisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9Ub29sYmFyLmpzOgorCiAyMDE0LTAzLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSB1 cGRhdGUtSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiIG9ubHkgdXBkYXRlIGxlZ2FjeSBwcm90 b2NvbCB2ZXJzaW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvRGFzaGJvYXJkQ29udGFpbmVyVmlldy5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXNoYm9hcmRDb250YWluZXJWaWV3LmNzcwppbmRl eCA5NzkyNWMxLi4wMzI0ZjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9EYXNoYm9hcmRDb250YWluZXJWaWV3LmNzcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXNoYm9hcmRDb250YWluZXJWaWV3 LmNzcwpAQCAtNDMsOCArNDMsNyBAQCBib2R5LndpbmRvdy1pbmFjdGl2ZSAudG9vbGJhciAuZGFz aGJvYXJkLWNvbnRhaW5lciB7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiKDIzOSwgMjM5LCAy MzkpOwogfQogCi0udG9vbGJhci5jb2xsYXBzZWQgLmRhc2hib2FyZC1jb250YWluZXIsCi1ib2R5 LmphdmFzY3JpcHQgLnRvb2xiYXIgLmRhc2hib2FyZC1jb250YWluZXIgeworLnRvb2xiYXIuY29s bGFwc2VkIC5kYXNoYm9hcmQtY29udGFpbmVyIHsKICAgICB3aWR0aDogMTc1cHg7CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rvb2xi YXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Ub29sYmFy LmpzCmluZGV4IDY0M2ZkYjQuLjVlYmZjNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rvb2xiYXIuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVG9vbGJhci5qcwpAQCAtMTQzLDYgKzE0MywxMiBA QCBXZWJJbnNwZWN0b3IuVG9vbGJhci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghdGhpcy5f bGVmdFNlY3Rpb25FbGVtZW50IHx8ICF0aGlzLl9jZW50ZXJTZWN0aW9uRWxlbWVudCB8fCAhdGhp cy5fcmlnaHRTZWN0aW9uRWxlbWVudCkKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICAv LyBGb3JjZSBjb2xsYXBzZWQgc3R5bGUgZm9yIEphdmFTY3JpcHQgZGVidWdnYWJsZXMuCisgICAg ICAgIGlmIChXZWJJbnNwZWN0b3IuZGVidWdnYWJsZVR5cGUgPT09IFdlYkluc3BlY3Rvci5EZWJ1 Z2dhYmxlVHlwZS5KYXZhU2NyaXB0KSB7CisgICAgICAgICAgICB0aGlzLl9lbGVtZW50LmNsYXNz TGlzdC5hZGQoV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25CYXIuQ29sbGFwc2VkU3R5bGVDbGFzc05h bWUpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwogICAgICAgICAvLyBSZW1vdmUg dGhlIGNvbGxhcHNlZCBzdHlsZSBjbGFzcyB0byB0ZXN0IGlmIHRoZSBpdGVtcyBjYW4gZml0IGF0 IGZ1bGwgd2lkdGguCiAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LnJlbW92ZShXZWJJ bnNwZWN0b3IuTmF2aWdhdGlvbkJhci5Db2xsYXBzZWRTdHlsZUNsYXNzTmFtZSk7CiAK