130526 2014-03-20 12:11:08 -0700 ASSERTION FAILED: event == [NSApp currentEvent] hitting Command-+ 2014-03-20 14:12:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue darin enrica simon.fraser oldest_to_newest 992641 0 ap 2014-03-20 12:11:08 -0700 <rdar://problem/16371612> 992644 1 ap 2014-03-20 12:16:48 -0700 Before r165356, it worked in a different way: this check wasn't an assertion, but a runtime one: if (!eventWasSentToWebCore && event == [NSApp currentEvent] && self == [[self window] firstResponder]) { _data->_page->handleKeyboardEvent(NativeWebKeyboardEvent(event, self)); The old approach was fragile, it relied on the fact that AppKit sends the synthesized event without updating [NSApp currentEvent], which is a very questionable behavior. 992646 2 227316 ap 2014-03-20 12:19:03 -0700 Created attachment 227316 proposed fix 992686 3 227316 commit-queue 2014-03-20 13:30:59 -0700 Comment on attachment 227316 proposed fix Rejecting attachment 227316 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/TestController.o TestController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/PlatformWebViewMac.o mac/PlatformWebViewMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (2 failures) Full output: http://webkit-queues.appspot.com/results/5080808234680320 992721 4 227316 commit-queue 2014-03-20 14:12:27 -0700 Comment on attachment 227316 proposed fix Clearing flags on attachment: 227316 Committed r166000: <http://trac.webkit.org/changeset/166000> 992722 5 commit-queue 2014-03-20 14:12:32 -0700 All reviewed patches have been landed. Closing bug. 227316 2014-03-20 12:19:03 -0700 2014-03-20 14:12:27 -0700 proposed fix CmdPlus.txt text/plain 2129 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTk4MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTIwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6 IGV2ZW50ID09IFtOU0FwcCBjdXJyZW50RXZlbnRdIGhpdHRpbmcgQ29tbWFuZC0rCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1MjYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzE2MzcxNjEyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOiAoLVtXS1Zp ZXcgcGVyZm9ybUtleUVxdWl2YWxlbnQ6XSk6IEN1dCBjdXN0b20KKyAgICAgICAgcHJvY2Vzc2lu ZyBzaG9ydCB3aGVuZXZlciB3ZSBhcmUgcmVkaXNwYXRjaGluZyBhbiBldmVudCwgbm90IGp1c3Qg d2hlbiB0aGUgZXZlbnQKKyAgICAgICAgd2UgYXJlIGhhbmRsaW5nIGlzIHRoZSBvbmUgYmVpbmcg cmVkaXNwYXRjaGVkLiBUaGVyZSBzaG91bGRuJ3QgYmUgYW55IG90aGVyIHVucmVsYXRlZAorICAg ICAgICBldmVudHMgaGVyZSwganVzdCB0aGUgb25lIGJlaW5nIHJlZGlzcGF0Y2hlZCBhbmQgc3lu dGhldGljIG9uZXMgZ2VuZXJhdGVkIGZyb20gaXQgYnkgQXBwS2l0LgorCiAyMDE0LTAzLTE5ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIFN1cHBv cnQgYXN5bmNocm9ub3VzIE5TVGV4dElucHV0Q2xpZW50CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiAxNjU5NzIpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTIw NzcsMTAgKzIwNzcsMTIgQEAgLSAoQk9PTClwZXJmb3JtS2V5RXF1aXZhbGVudDooTlNFdmVudCAq KQogICAgIGlmIChbW2V2ZW50IGNoYXJhY3RlcnNJZ25vcmluZ01vZGlmaWVyc10gaXNFcXVhbFRv U3RyaW5nOkAiXGUiXSAmJiAhKFtldmVudCBtb2RpZmllckZsYWdzXSAmIE5TRGV2aWNlSW5kZXBl bmRlbnRNb2RpZmllckZsYWdzTWFzaykpCiAgICAgICAgIHJldHVybiBbc3VwZXIgcGVyZm9ybUtl eUVxdWl2YWxlbnQ6ZXZlbnRdOwogCi0gICAgLy8gSWYgd2UgYXJlIGFscmVhZHkgcmUtc2VuZGlu ZyB0aGUgZXZlbnQsIHRoZW4gV2ViQ29yZSBoYXMgYWxyZWFkeSBzZWVuIGl0LCBubyBuZWVkIGZv ciBjdXN0b20gcHJvY2Vzc2luZy4KLSAgICBCT09MIGV2ZW50V2FzU2VudFRvV2ViQ29yZSA9IChf ZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVzZW50ID09IGV2ZW50KTsKLSAgICBpZiAoZXZlbnRX YXNTZW50VG9XZWJDb3JlKQorICAgIGlmIChfZGF0YS0+X2tleURvd25FdmVudEJlaW5nUmVzZW50 KSB7CisgICAgICAgIC8vIFdlYkNvcmUgaGFzIGFscmVhZHkgc2VlbiB0aGUgZXZlbnQsIG5vIG5l ZWQgZm9yIGN1c3RvbSBwcm9jZXNzaW5nLgorICAgICAgICAvLyBOb3RlIHRoYXQgd2UgY2FuIGdl dCBtdWx0aXBsZSBldmVudHMgZm9yIGVhY2ggZXZlbnQgYmVpbmcgcmUtc2VudC4gRm9yIGV4YW1w bGUsIGZvciBDbWQrJz0nIEFwcEtpdAorICAgICAgICAvLyBmaXJzdCBwZXJmb3JtcyB0aGUgb3Jp Z2luYWwga2V5IGVxdWl2YWxlbnQsIGFuZCBpZiB0aGF0IGlzbid0IGhhbmRsZWQsIGl0IGRpc3Bh dGNoZXMgYSBzeW50aGV0aWMgQ21kKycrJy4KICAgICAgICAgcmV0dXJuIFtzdXBlciBwZXJmb3Jt S2V5RXF1aXZhbGVudDpldmVudF07CisgICAgfQogCiAgICAgQVNTRVJUKGV2ZW50ID09IFtOU0Fw cCBjdXJyZW50RXZlbnRdKTsKIAo=