130517 2014-03-20 09:49:40 -0700 [GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave 2014-03-20 20:01:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson berto cgarcia commit-queue gustavo oldest_to_newest 992550 0 mrobinson 2014-03-20 09:49:40 -0700 These errors are false positives, since we actually need to use the APIs. 992557 1 227298 mrobinson 2014-03-20 09:59:07 -0700 Created attachment 227298 Patch 992560 2 commit-queue 2014-03-20 10:01:30 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 992614 3 berto 2014-03-20 11:34:50 -0700 (In reply to comment #1) > Created an attachment (id=227298) [details] > Patch lgtm, thanks! 992622 4 227298 svillar 2014-03-20 11:43:51 -0700 Comment on attachment 227298 Patch r=me. Consider adding a FIXME to the comments mentioning that all the deprecation warnings will be suppresed. 992623 5 227298 svillar 2014-03-20 11:44:18 -0700 Comment on attachment 227298 Patch errrr 992869 6 mrobinson 2014-03-20 20:01:25 -0700 Committed r166035: <http://trac.webkit.org/changeset/166035> 227298 2014-03-20 09:59:07 -0700 2014-03-20 11:44:18 -0700 Patch bug-130517-20140320095845.patch text/plain 3367 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ2ZTU3N2U2OTE3OGJi YzFhZDVjMGM4NGRhYjY3YjVkYjc5MDllMC4uYjhmZWNmZDliM2UxZjQ2MzQwY2Y5NzY4MGNkNzU1 ZWQwNGQxNGE5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE0LTAzLTIwICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBTdXBw cmVzcyBlcnJvcnMgYWJvdXQgdXNpbmcgZ2RrX3RocmVhZHNfZW50ZXIgZ2RrX3RocmVhZHNfbGVh dmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDUx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGx1 Z2lucy9ndGsvZ3RrMnh0YmluLmM6IFVzZSBHQ0Mgc3VwcHJlc3Npb24gdG8gc3VwcHJlc3MgZXJy b3JzIGFib3V0IGRlcHJlY2F0aW9ucy4KKworMjAxNC0wMy0yMCAgTWFydGluIFJvYmluc29uICA8 bXJvYmluc29uQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gW0NNYWtlXSBEbyBub3QgY29t cGlsZSBQcm94eVJlc29sdmVyU291cC5jcHAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMDUxNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTQ4NzZhODBiMDZlMTdj NmYxYTBhNDQyNDkyNGI4ZWQ4MGQwM2I0OC4uMDEyYTYyOWRlN2Q5NzZjMTlhNWQ3YjI1NWJjN2Ex ZDdjYjE0YzJiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAzLTIwICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTdXBw cmVzcyBlcnJvcnMgYWJvdXQgdXNpbmcgZ2RrX3RocmVhZHNfZW50ZXIgZ2RrX3RocmVhZHNfbGVh dmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDUx NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6IFVzZSBHQ0Mgc3VwcHJlc3Npb24gdG8g c3VwcHJlc3MgZXJyb3JzIGFib3V0IGRlcHJlY2F0aW9ucy4KKyAgICAgICAgKiBVSVByb2Nlc3Mv Z3RrL1dlYlBvcHVwTWVudVByb3h5R3RrLmNwcDogRGl0dG8uCisKIDIwMTQtMDMtMTggIFRpbSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bV2ViS2l0 Ml0gUHJvdmlkZSBnZW5lcmljIHNvZnR3YXJlLXNuYXBzaG90dGluZyBBUEkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5jIGIvU291cmNlL1dlYkNvcmUv cGx1Z2lucy9ndGsvZ3RrMnh0YmluLmMKaW5kZXggZGVlM2Y3OGY5NDAzZTAwZTMzZDE3NjFiOTUz MjQxZTBmNzI0NjNjZi4uYWZlNDE1YzBiM2VkMjllZTIwMDlmMTIxZWU4NDQ2NjRlY2Y3Y2RkMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmMKKysrIGIv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmMKQEAgLTY1LDYgKzY1LDkgQEAK ICNpbmNsdWRlIDxYMTEvSW50cmluc2ljLmg+CiAjaW5jbHVkZSA8WDExL1N0cmluZ0RlZnMuaD4K IAorLy8gVGhpcyBpcyB0byBzdXBwcmVzcyB3YXJuaW5ncyBhYm91dCBnZGtfdGhyZWFkc19sZWF2 ZSBhbmQgZ2RrX3RocmVhZHNfZW50ZXIuCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQg Ii1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCisKIC8qIHVuY29tbWVudCB0aGlzIGlmIHlvdSB3 YW50IGRlYnVnZ2luZyBpbmZvcm1hdGlvbiBhYm91dCB3aWRnZXQKICAgIGNyZWF0aW9uIGFuZCBk ZXN0cnVjdGlvbiAqLwogI3VuZGVmIERFQlVHX1hUQklOCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IGJkNmI1Yzk0YzI3NzQ1 YWRkNDM2MmIxYWNlMzBhYTU5NDU5ZjUxZmMuLjFiYzE2ZDVmODIxN2Q4NjI1ZjFmNmY1YTYzY2M3 OGQzNjBhMjkzMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXcuY3BwCkBAIC02OSw2ICs2OSw5IEBACiAjaW5jbHVkZSA8d3RmL2dvYmpl Y3QvR1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAorLy8gVGhpcyBp cyB0byBzdXBwcmVzcyB3YXJuaW5ncyBhYm91dCBnZGtfdGhyZWFkc19sZWF2ZSBhbmQgZ2RrX3Ro cmVhZHNfZW50ZXIuCisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRl ZC1kZWNsYXJhdGlvbnMiCisKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3Bh Y2UgV2ViQ29yZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9X ZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dl YlBvcHVwTWVudVByb3h5R3RrLmNwcAppbmRleCBlNTAzN2I2M2Q4YWJiNzY2MGQ0NGIzMmY3YWY3 YzRiOGQ3ZTAyZDY0Li44MGEwMTllY2NhNmJjZGVhMTI2NmJhMzdjNGUyYzljZDcxN2U5ODI0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlBvcHVwTWVudVByb3h5 R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlBvcHVwTWVudVBy b3h5R3RrLmNwcApAQCAtMzMsNiArMzMsOSBAQAogI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dVbmlx dWVQdHIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKKy8vIFRoaXMgaXMgdG8g c3VwcHJlc3Mgd2FybmluZ3MgYWJvdXQgZ2RrX3RocmVhZHNfbGVhdmUgYW5kIGdka190aHJlYWRz X2VudGVyLgorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkICItV2RlcHJlY2F0ZWQtZGVj bGFyYXRpb25zIgorCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktp dCB7Cg==