130506 2014-03-20 05:59:27 -0700 [EFL] Add ARM64 build support 2014-03-26 00:29:34 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 130453 130454 130500 130502 1 rgabor webkit-unassigned benjamin bunhere cmarcelo commit-queue dbates gyuyoung.kim gyuyoung.kim lucas.de.marchi ossy rakuco sergio zherczeg oldest_to_newest 992486 0 rgabor 2014-03-20 05:59:27 -0700 Add ARM64 build support to EFL port. 992490 1 227285 rgabor 2014-03-20 06:35:24 -0700 Created attachment 227285 proposed patch 994023 2 227285 gyuyoung.kim 2014-03-24 16:38:36 -0700 Comment on attachment 227285 proposed patch rs=me. However, it would be nicer if JS guys take a final look before landing. 994151 3 227285 zherczeg 2014-03-25 05:46:49 -0700 Comment on attachment 227285 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=227285&action=review > Source/WTF/wtf/Platform.h:155 > +#if defined(__arm64__) && defined(__APPLE__) || defined(__aarch64__) I would put a bracket around the && part. 994154 4 rgabor 2014-03-25 06:14:29 -0700 Thanks for the review, I changed what Zoltan suggested. Patch landed: http://trac.webkit.org/changeset/166232 994497 5 gyuyoung.kim 2014-03-25 22:45:40 -0700 Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture. 994511 6 rgabor 2014-03-26 00:28:08 -0700 (In reply to comment #5) > Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture. Yes, the EFL port is now building for ARM64 and also we have an EFL ARM64 builder bot here: http://build.webkit.sed.hu/waterfall We have some problems with the dependencies so they are built by hand now. If we can solve this in the future we can connect this bot to the Apple master. 994512 7 gyuyoung.kim 2014-03-26 00:29:34 -0700 (In reply to comment #6) > (In reply to comment #5) > > Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture. > > Yes, the EFL port is now building for ARM64 and also we have an EFL ARM64 builder bot here: http://build.webkit.sed.hu/waterfall > > We have some problems with the dependencies so they are built by hand now. If we can solve this in the future we can connect this bot to the Apple master. Nice. I hope to see it on build.webkit.org in near future. Thanks a lot ! 227285 2014-03-20 06:35:24 -0700 2014-03-25 06:14:46 -0700 proposed patch efl_arm64.patch text/plain 4278 rgabor SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTk2 MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAz LTIwICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBbRUZM XSBBZGQgQVJNNjQgYnVpbGQgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogU2V0IFdURl9DUFVfQVJNNjQgd2hl biBhYXJjaDY0IGlzIGRlZmluZWQuCisKIDIwMTQtMDMtMTcgIEJyZW5kYW4gTG9uZyAgPGIubG9u Z0BjYWJsZWxhYnMuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIGh1bWFuIHJlYWRhYmxlIGxh bmd1YWdlIGNvZGUgZm9yIHRyYWNrcwpJbmRleDogQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDE2NTgwOCkKKysrIENNYWtlTGlzdHMudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC03Nyw2ICs3Nyw4IEBAIGVsc2UgKCkKIGVuZGlmICgpCiBpZiAoTE9X RVJDQVNFX0NNQUtFX1NZU1RFTV9QUk9DRVNTT1IgTUFUQ0hFUyAiXmFybSIpCiAgICAgc2V0KFdU Rl9DUFVfQVJNIDEpCitlbHNlaWYgKExPV0VSQ0FTRV9DTUFLRV9TWVNURU1fUFJPQ0VTU09SIE1B VENIRVMgIl5hYXJjaDY0IikKKyAgICBzZXQoV1RGX0NQVV9BUk02NCAxKQogZWxzZWlmIChMT1dF UkNBU0VfQ01BS0VfU1lTVEVNX1BST0NFU1NPUiBNQVRDSEVTICJebWlwcyIpCiAgICAgc2V0KFdU Rl9DUFVfTUlQUyAxKQogZWxzZWlmIChMT1dFUkNBU0VfQ01BS0VfU1lTVEVNX1BST0NFU1NPUiBN QVRDSEVTICJzaDQiKQpJbmRleDogU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwkocmV2aXNpb24gMTY1OTYwKQorKysg U291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDMtMjAgIEdhYm9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgorCisg ICAgICAgIFtFRkxdIEFkZCBBUk02NCBidWlsZCBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1MDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxldmVsZGIvcG9ydC9hdG9taWNfcG9pbnRl ci5oOiBTZXQgQVJDSF9DUFVfQVJNX0ZBTUlMWSB3aGVuIF9fYWFyY2g2NF9fIGlzIGRlZmluZWQu CisKIDIwMTQtMDMtMTQgIExhbmRyeSBCcmV1aWwgIDxsYW5kcnlAb3BlbmJzZC5vcmc+CiAKICAg ICAgICAgRml4IGxldmVsZGIgYnVpbGQgb24gT3BlbkJTRC9OZXRCU0QgYnkgdXNpbmcgdGhlIEZy ZWVCU0QgY29kZXBhdGhzLgpJbmRleDogU291cmNlL1RoaXJkUGFydHkvbGV2ZWxkYi9wb3J0L2F0 b21pY19wb2ludGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1RoaXJkUGFydHkvbGV2ZWxkYi9w b3J0L2F0b21pY19wb2ludGVyLmgJKHJldmlzaW9uIDE2NTgwOCkKKysrIFNvdXJjZS9UaGlyZFBh cnR5L2xldmVsZGIvcG9ydC9hdG9taWNfcG9pbnRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw3 ICszNCw3IEBACiAjZGVmaW5lIEFSQ0hfQ1BVX1g4Nl9GQU1JTFkgMQogI2VsaWYgZGVmaW5lZChf TV9JWDg2KSB8fCBkZWZpbmVkKF9faTM4Nl9fKSB8fCBkZWZpbmVkKF9faTM4NikKICNkZWZpbmUg QVJDSF9DUFVfWDg2X0ZBTUlMWSAxCi0jZWxpZiBkZWZpbmVkKF9fQVJNRUxfXykKKyNlbGlmIGRl ZmluZWQoX19BUk1FTF9fKSB8fCBkZWZpbmVkKF9fYWFyY2g2NF9fKQogI2RlZmluZSBBUkNIX0NQ VV9BUk1fRkFNSUxZIDEKICNlbGlmIGRlZmluZWQoX19wcGNfXykgfHwgZGVmaW5lZChfX3Bvd2Vy cGNfXykgfHwgZGVmaW5lZChfX3Bvd2VycGM2NF9fKQogI2RlZmluZSBBUkNIX0NQVV9QUENfRkFN SUxZIDEKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjU5NjApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAzLTIwICBHYWJvciBSYXBjc2Fu eWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXSBBZGQgQVJNNjQgYnVpbGQg c3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMwNTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvUGxhdGZvcm0uaDogU2V0IFdURl9DUFVfQVJNNjQgd2hlbiBfX2FhcmNoNjRfXyBpcyBk ZWZpbmVkLgorCiAyMDE0LTAzLTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR0xJQl0gQWRkIEdNYWluTG9vcFNvdXJjZSBjbGFzcyB0byB3 cmFwIGlkbGUgYW5kIHRpbWVvdXQgc291cmNlcwpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZv cm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAx NjU4MDgpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0x NTIsNyArMTUyLDcgQEAKICNlbmRpZgogCiAvKiBDUFUoQVJNNjQpIC0gQXBwbGUgKi8KLSNpZiBk ZWZpbmVkKF9fYXJtNjRfXykgJiYgZGVmaW5lZChfX0FQUExFX18pCisjaWYgZGVmaW5lZChfX2Fy bTY0X18pICYmIGRlZmluZWQoX19BUFBMRV9fKSB8fCBkZWZpbmVkKF9fYWFyY2g2NF9fKQogI2Rl ZmluZSBXVEZfQ1BVX0FSTTY0IDEKICNlbmRpZgogCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjU5NjApCisrKyBUb29scy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wMy0yMCAgR2Fi b3IgUmFwY3NhbnlpICA8cmdhYm9yQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF0gQWRkIEFS TTY0IGJ1aWxkIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoaXNBUk0pOiBEZXRl Y3QgYWFyY2g2NCBhcyBBUk0uCisKIDIwMTQtMDMtMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3NlIHRleHQgYW5kIHBhZ2Ugem9vbSBpbiBX SzIgU1BJLCBhbmQgaG9vayB0aGVtIHVwIGluIE1pbmlCcm93c2VyCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCShyZXZpc2lvbiAxNjU4MDgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHdv cmtpbmcgY29weSkKQEAgLTEwOTIsNyArMTA5Miw3IEBAIHN1YiBpc0JTRCgpCiAKIHN1YiBpc0FS TSgpCiB7Ci0gICAgcmV0dXJuICRDb25maWd7YXJjaG5hbWV9ID1+IC9eYXJtW3ZcLV0vOworICAg IHJldHVybiAoJENvbmZpZ3thcmNobmFtZX0gPX4gL15hcm1bdlwtXS8pIHx8ICgkQ29uZmlne2Fy Y2huYW1lfSA9fiAvXmFhcmNoNjRbdlwtXS8pOwogfQogCiBzdWIgaXNDcm9zc0NvbXBpbGF0aW9u KCkK