130502 2014-03-20 03:43:50 -0700 [ARM64] Fix assembler build issues and add cacheFlush support for Linux 2014-03-20 07:04:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 108645 130506 1 rgabor webkit-unassigned commit-queue fpizlo oliver ossy zherczeg oldest_to_newest 992468 0 rgabor 2014-03-20 03:43:50 -0700 JavaScript Assembler build issues: * error: ‘INT_MIN’ was not declared in this scope * error: ‘bool shouldBlindForSpecificArch(uint64_t)’ previously defined here static bool shouldBlindForSpecificArch(uint64_t value) { return value >= 0x00ffffff; } * #error "The cacheFlush support is missing on this platform." 992471 1 227280 rgabor 2014-03-20 03:50:17 -0700 Created attachment 227280 proposed fix 992489 2 227280 msaboff 2014-03-20 06:32:31 -0700 Comment on attachment 227280 proposed fix r=me 992498 3 227280 commit-queue 2014-03-20 07:04:15 -0700 Comment on attachment 227280 proposed fix Clearing flags on attachment: 227280 Committed r165961: <http://trac.webkit.org/changeset/165961> 992499 4 commit-queue 2014-03-20 07:04:18 -0700 All reviewed patches have been landed. Closing bug. 227280 2014-03-20 03:50:17 -0700 2014-03-20 07:04:14 -0700 proposed fix assembler.patch text/plain 3273 rgabor SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1OTU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTAzLTIwICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAg ICAgICBbQVJNNjRdIEZpeCBhc3NlbWJsZXIgYnVpbGQgaXNzdWVzIGFuZCBhZGQgY2FjaGVGbHVz aCBzdXBwb3J0IGZvciBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMwNTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGxpbWl0cy5oIGZvciBJTlRfTUlOIGluIEFSTTY0QXNzZW1ibGVyKCku IERlbGV0ZSBzaG91bGRCbGluZEZvclNwZWNpZmljQXJjaCh1aW50cHRyX3QpCisgICAgICAgIGJl Y2F1c2Ugb24gQVJNNjQgdWludDY0X3QgYW5kIHVpbnRwdHJfdCBpcyB0aGUgc2FtZSB3aXRoIEdD QyBhbmQgQ2xhbmcgYXMgd2VsbC4KKyAgICAgICAgQWRkIGNhY2hlRmx1c2ggc3VwcG9ydCBmb3Ig TGludXguCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaDoKKyAgICAgICAg KEpTQzo6QVJNNjRBc3NlbWJsZXI6OmxpbnV4UGFnZUZsdXNoKToKKyAgICAgICAgKEpTQzo6QVJN NjRBc3NlbWJsZXI6OmNhY2hlRmx1c2gpOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2Vt YmxlckFSTTY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OnNob3VsZEJs aW5kRm9yU3BlY2lmaWNBcmNoKToKKwogMjAxNC0wMy0xOSAgR2F2aW4gQmFycmFjbG91Z2ggIDxi YXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMDQ5NApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9BUk02NEFzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaAkocmV2aXNpb24gMTY1ODA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkp CkBAIC0yOSw2ICsyOSw3IEBACiAjaWYgRU5BQkxFKEFTU0VNQkxFUikgJiYgQ1BVKEFSTTY0KQog CiAjaW5jbHVkZSAiQXNzZW1ibGVyQnVmZmVyLmgiCisjaW5jbHVkZSA8bGltaXRzLmg+CiAjaW5j bHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVk ZSA8c3RkaW50Lmg+CkBAIC0yODQxLDEwICsyODQyLDM0IEBAIHB1YmxpYzoKIAogICAgIHVuc2ln bmVkIGRlYnVnT2Zmc2V0KCkgeyByZXR1cm4gbV9idWZmZXIuZGVidWdPZmZzZXQoKTsgfQogCisj aWYgT1MoTElOVVgpICYmIENPTVBJTEVSKEdDQykKKyAgICBzdGF0aWMgaW5saW5lIHZvaWQgbGlu dXhQYWdlRmx1c2godWludHB0cl90IGJlZ2luLCB1aW50cHRyX3QgZW5kKQorICAgIHsKKyAgICAg ICAgX19idWlsdGluX19fY2xlYXJfY2FjaGUocmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oYmVnaW4p LCByZWludGVycHJldF9jYXN0PHZvaWQqPihlbmQpKTsKKyAgICB9CisjZW5kaWYKKwogICAgIHN0 YXRpYyB2b2lkIGNhY2hlRmx1c2godm9pZCogY29kZSwgc2l6ZV90IHNpemUpCiAgICAgewogI2lm IE9TKElPUykKICAgICAgICAgc3lzX2NhY2hlX2NvbnRyb2woa0NhY2hlRnVuY3Rpb25QcmVwYXJl Rm9yRXhlY3V0aW9uLCBjb2RlLCBzaXplKTsKKyNlbGlmIE9TKExJTlVYKQorICAgICAgICBzaXpl X3QgcGFnZSA9IHBhZ2VTaXplKCk7CisgICAgICAgIHVpbnRwdHJfdCBjdXJyZW50ID0gcmVpbnRl cnByZXRfY2FzdDx1aW50cHRyX3Q+KGNvZGUpOworICAgICAgICB1aW50cHRyX3QgZW5kID0gY3Vy cmVudCArIHNpemU7CisgICAgICAgIHVpbnRwdHJfdCBmaXJzdFBhZ2VFbmQgPSAoY3VycmVudCAm IH4ocGFnZSAtIDEpKSArIHBhZ2U7CisKKyAgICAgICAgaWYgKGVuZCA8PSBmaXJzdFBhZ2VFbmQp IHsKKyAgICAgICAgICAgIGxpbnV4UGFnZUZsdXNoKGN1cnJlbnQsIGVuZCk7CisgICAgICAgICAg ICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBsaW51eFBhZ2VGbHVzaChjdXJyZW50LCBm aXJzdFBhZ2VFbmQpOworCisgICAgICAgIGZvciAoY3VycmVudCA9IGZpcnN0UGFnZUVuZDsgY3Vy cmVudCArIHBhZ2UgPCBlbmQ7IGN1cnJlbnQgKz0gcGFnZSkKKyAgICAgICAgICAgIGxpbnV4UGFn ZUZsdXNoKGN1cnJlbnQsIGN1cnJlbnQgKyBwYWdlKTsKKworICAgICAgICBsaW51eFBhZ2VGbHVz aChjdXJyZW50LCBlbmQpOwogI2Vsc2UKICNlcnJvciAiVGhlIGNhY2hlRmx1c2ggc3VwcG9ydCBp cyBtaXNzaW5nIG9uIHRoaXMgcGxhdGZvcm0uIgogI2VuZGlmCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAkocmV2 aXNpb24gMTY1ODA4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEyOSw3ICsxMjksNiBAQCBwdWJsaWM6 CiAgICAgLy8gRklYTUU6IEdldCByZWFzb25hYmxlIGltcGxlbWVudGF0aW9ucyBmb3IgdGhlc2UK ICAgICBzdGF0aWMgYm9vbCBzaG91bGRCbGluZEZvclNwZWNpZmljQXJjaCh1aW50MzJfdCB2YWx1 ZSkgeyByZXR1cm4gdmFsdWUgPj0gMHgwMGZmZmZmZjsgfQogICAgIHN0YXRpYyBib29sIHNob3Vs ZEJsaW5kRm9yU3BlY2lmaWNBcmNoKHVpbnQ2NF90IHZhbHVlKSB7IHJldHVybiB2YWx1ZSA+PSAw eDAwZmZmZmZmOyB9Ci0gICAgc3RhdGljIGJvb2wgc2hvdWxkQmxpbmRGb3JTcGVjaWZpY0FyY2go dWludHB0cl90IHZhbHVlKSB7IHJldHVybiB2YWx1ZSA+PSAweDAwZmZmZmZmOyB9CiAKICAgICAv LyBJbnRlZ2VyIG9wZXJhdGlvbnM6CiAK