130500 2014-03-20 02:28:12 -0700 [ARM64] GCC generates wrong code with -O2 flag in WTF::weakCompareAndSwap 2015-06-15 06:08:23 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 108645 130506 1 rgabor webkit-unassigned benjamin cmarcelo commit-queue fpizlo oliver ossy zherczeg oldest_to_newest 992452 0 rgabor 2014-03-20 02:28:12 -0700 /tmp/cc2M6EGp.s:23: Error: the optional immediate offset can only be 0 at operand 2 -- `ldxr w3,[x29,28]' /tmp/cc2M6EGp.s:26: Error: the optional immediate offset can only be 0 at operand 3 -- `stxr w2,w1,[x29,28]' 992453 1 rgabor 2014-03-20 02:37:55 -0700 Tried with: gcc-linaro 4.8 (Aarch64) 4.8-2014.02 14.02 (http://www.linaro.org/downloads/) 992454 2 227276 rgabor 2014-03-20 02:38:35 -0700 Created attachment 227276 proposed fix 992455 3 commit-queue 2014-03-20 02:40:21 -0700 Attachment 227276 did not pass style-queue: ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:165: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:165: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:165: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:165: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 10 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 993738 4 zherczeg 2014-03-24 01:38:52 -0700 This refactor is also ok. I think all of these patches can be landed, if nobody has an objection. 993794 5 227276 fpizlo 2014-03-24 07:52:05 -0700 Comment on attachment 227276 proposed fix Since the new constraints are incorrect and are just there to appease gcc, I would put them behind some #if's and keep the original code around. My recollection is that not using +m in a cas can also lead to code gen bugs in some compilers because the "memory" constraint isn't enough to make them see what's going on. 994120 6 227731 rgabor 2014-03-25 02:50:24 -0700 Created attachment 227731 proposed patch v2 I put the changes between GCC guards. 994121 7 commit-queue 2014-03-25 02:53:22 -0700 Attachment 227731 did not pass style-queue: ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:125: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:179: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:180: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:179: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:180: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:179: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:180: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:179: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:180: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WTF/wtf/Atomics.h:180: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 22 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 994162 8 227731 commit-queue 2014-03-25 07:13:34 -0700 Comment on attachment 227731 proposed patch v2 Clearing flags on attachment: 227731 Committed r166234: <http://trac.webkit.org/changeset/166234> 994163 9 commit-queue 2014-03-25 07:13:38 -0700 All reviewed patches have been landed. Closing bug. 1101913 10 schwab 2015-06-15 06:08:23 -0700 The correct constraint is "Q". 227276 2014-03-20 02:38:35 -0700 2014-03-25 02:50:24 -0700 proposed fix atomics_arm64.patch text/plain 1890 rgabor SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjU4OTQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTE5ICBHYWJvciBSYXBjc2FueWkgIDxy Z2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBbQVJNNjRdIEdDQyBnZW5lcmF0ZXMgd3Jvbmcg Y29kZSB3aXRoIC1PMiBmbGFnIGluIFdURjo6d2Vha0NvbXBhcmVBbmRTd2FwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1MDAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdGhlIGZpcnN0IG9w ZXJhbmQgdG8gdGhlIGV4YWN0IHJlZ2lzdGVyIGluIHRoZSBpbmxpbmUgYXNzZW1ibHkuCisKKyAg ICAgICAgKiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGOjp3ZWFrQ29tcGFyZUFuZFN3YXAp OiAKKwogMjAxNC0wMy0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVkdWNlIHVzZSBvZiBkZXByZWNhdGVkQ2hhcmFjdGVycyBpbiBXZWJDb3JlCkluZGV4OiBT b3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQXRv bWljcy5oCShyZXZpc2lvbiAxNjU4MDgpCisrKyBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgJKHdv cmtpbmcgY29weSkKQEAgLTExNywxMiArMTE3LDEyIEBAIGlubGluZSBib29sIHdlYWtDb21wYXJl QW5kU3dhcCh2b2xhdGlsZQogICAgIHVuc2lnbmVkIHJlc3VsdDsKICAgICBhc20gdm9sYXRpbGUo CiAgICAgICAgICJtb3YgJXcxLCAjMVxuXHQiCi0gICAgICAgICJsZHhyICV3MiwgJTBcblx0Igor ICAgICAgICAibGR4ciAldzIsIFsleDBdXG5cdCIKICAgICAgICAgImNtcCAldzMsICV3MlxuXHQi CiAgICAgICAgICJiLm5lIDBmXG5cdCIKLSAgICAgICAgInN0eHIgJXcxLCAldzQsICUwXG5cdCIK KyAgICAgICAgInN0eHIgJXcxLCAldzQsIFsleDBdXG5cdCIKICAgICAgICAgIjA6IgotICAgICAg ICA6ICIrbSIoKmxvY2F0aW9uKSwgIj0mciIocmVzdWx0KSwgIj0mciIodG1wKQorICAgICAgICA6 ICIrciIobG9jYXRpb24pLCAiPSZyIihyZXN1bHQpLCAiPSZyIih0bXApCiAgICAgICAgIDogInIi KGV4cGVjdGVkKSwgInIiKG5ld1ZhbHVlKQogICAgICAgICA6ICJtZW1vcnkiKTsKICAgICByZXN1 bHQgPSAhcmVzdWx0OwpAQCAtMTU3LDEyICsxNTcsMTIgQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBh cmVBbmRTd2FwKHZvaWQqdm9sYQogICAgIHZvaWQqIHRtcDsKICAgICBhc20gdm9sYXRpbGUoCiAg ICAgICAgICJtb3YgJXcxLCAjMVxuXHQiCi0gICAgICAgICJsZHhyICV4MiwgJTBcblx0IgorICAg ICAgICAibGR4ciAleDIsIFsleDBdXG5cdCIKICAgICAgICAgImNtcCAleDMsICV4MlxuXHQiCiAg ICAgICAgICJiLm5lIDBmXG5cdCIKLSAgICAgICAgInN0eHIgJXcxLCAleDQsICUwXG5cdCIKKyAg ICAgICAgInN0eHIgJXcxLCAleDQsIFsleDBdXG5cdCIKICAgICAgICAgIjA6IgotICAgICAgICA6 ICIrbSIoKmxvY2F0aW9uKSwgIj0mciIocmVzdWx0KSwgIj0mciIodG1wKQorICAgICAgICA6ICIr ciIobG9jYXRpb24pLCAiPSZyIihyZXN1bHQpLCAiPSZyIih0bXApCiAgICAgICAgIDogInIiKGV4 cGVjdGVkKSwgInIiKG5ld1ZhbHVlKQogICAgICAgICA6ICJtZW1vcnkiKTsKICAgICByZXR1cm4g IXJlc3VsdDsK 227731 2014-03-25 02:50:24 -0700 2014-03-25 07:13:33 -0700 proposed patch v2 weak_compare_arm64.patch text/plain 1987 rgabor SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjYyMjcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTI1ICBHYWJvciBSYXBjc2FueWkgIDxy Z2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBbQVJNNjRdIEdDQyBnZW5lcmF0ZXMgd3Jvbmcg Y29kZSB3aXRoIC1PMiBmbGFnIGluIFdURjo6d2Vha0NvbXBhcmVBbmRTd2FwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA1MDAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgdGhlIGZpcnN0IG9wZXJh bmQgdG8gdGhlIGV4YWN0IHJlZ2lzdGVyIGluIHRoZSBpbmxpbmUgYXNzZW1ibHkgd2l0aCBHQ0Mu CisKKyAgICAgICAgKiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGOjp3ZWFrQ29tcGFyZUFu ZFN3YXApOgorCiAyMDE0LTAzLTI0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXggdGhlIGlPUyBidWlsZC4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0F0b21pY3Mu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgJKHJldmlzaW9uIDE2NjIy NykKKysrIFNvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDYg KzExMiwyMCBAQCBpbmxpbmUgYm9vbCB3ZWFrQ29tcGFyZUFuZFN3YXAodm9sYXRpbGUKICAgICAg ICAgOiAiciIoZXhwZWN0ZWQpLCAiciIobmV3VmFsdWUpCiAgICAgICAgIDogIm1lbW9yeSIpOwog ICAgIHJlc3VsdCA9ICFyZXN1bHQ7CisjZWxpZiBDUFUoQVJNNjQpICYmIENPTVBJTEVSKEdDQykK KyAgICB1bnNpZ25lZCB0bXA7CisgICAgdW5zaWduZWQgcmVzdWx0OworICAgIGFzbSB2b2xhdGls ZSgKKyAgICAgICAgIm1vdiAldzEsICMxXG5cdCIKKyAgICAgICAgImxkeHIgJXcyLCBbJTBdXG5c dCIKKyAgICAgICAgImNtcCAldzMsICV3MlxuXHQiCisgICAgICAgICJiLm5lIDBmXG5cdCIKKyAg ICAgICAgInN0eHIgJXcxLCAldzQsIFslMF1cblx0IgorICAgICAgICAiMDoiCisgICAgICAgIDog IityIihsb2NhdGlvbiksICI9JnIiKHJlc3VsdCksICI9JnIiKHRtcCkKKyAgICAgICAgOiAiciIo ZXhwZWN0ZWQpLCAiciIobmV3VmFsdWUpCisgICAgICAgIDogIm1lbW9yeSIpOworICAgIHJlc3Vs dCA9ICFyZXN1bHQ7CiAjZWxpZiBDUFUoQVJNNjQpCiAgICAgdW5zaWduZWQgdG1wOwogICAgIHVu c2lnbmVkIHJlc3VsdDsKQEAgLTE1Miw2ICsxNjYsMjAgQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBh cmVBbmRTd2FwKHZvaWQqdm9sYQogICAgICAgICA6ICJtZW1vcnkiCiAgICAgICAgICk7CiAgICAg cmV0dXJuIHJlc3VsdDsKKyNlbGlmIENQVShBUk02NCkgJiYgQ09NUElMRVIoR0NDKQorICAgIGJv b2wgcmVzdWx0OworICAgIHZvaWQqIHRtcDsKKyAgICBhc20gdm9sYXRpbGUoCisgICAgICAgICJt b3YgJXcxLCAjMVxuXHQiCisgICAgICAgICJsZHhyICV4MiwgWyUwXVxuXHQiCisgICAgICAgICJj bXAgJXgzLCAleDJcblx0IgorICAgICAgICAiYi5uZSAwZlxuXHQiCisgICAgICAgICJzdHhyICV3 MSwgJXg0LCBbJTBdXG5cdCIKKyAgICAgICAgIjA6IgorICAgICAgICA6ICIrciIobG9jYXRpb24p LCAiPSZyIihyZXN1bHQpLCAiPSZyIih0bXApCisgICAgICAgIDogInIiKGV4cGVjdGVkKSwgInIi KG5ld1ZhbHVlKQorICAgICAgICA6ICJtZW1vcnkiKTsKKyAgICByZXR1cm4gIXJlc3VsdDsKICNl bGlmIENQVShBUk02NCkKICAgICBib29sIHJlc3VsdDsKICAgICB2b2lkKiB0bXA7Cg==