130490 2014-03-19 17:59:52 -0700 media/video-remote-control-playpause.html frequently fails on the bots 2023-08-18 11:04:51 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 eric.carlson aestes aestes webkit-bug-importer oldest_to_newest 992343 0 eric.carlson 2014-03-19 17:59:52 -0700 This test passes on my machines with --iterations=10000 but frequently fails on the bots. 992344 1 eric.carlson 2014-03-19 18:06:47 -0700 Marked as flakey in https://trac.webkit.org/r165937 while I try to reproduce it. 1972089 2 aestes 2023-08-18 10:50:16 -0700 Looks like this test is no longer marked flaky in TestExpectations, but the test still flakily crashes and times out according to https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-remote-control-playpause.html 1972090 3 webkit-bug-importer 2023-08-18 10:52:56 -0700 <rdar://problem/114097537> 1972091 4 aestes 2023-08-18 10:53:54 -0700 Pull request: https://github.com/WebKit/WebKit/pull/16840 1972095 5 ews-feeder 2023-08-18 11:03:41 -0700 Committed 267046@main (662d6eb482e6): <https://commits.webkit.org/267046@main> Reviewed commits have been landed. Closing PR #16840 and removing active labels. 1972096 6 aestes 2023-08-18 11:04:36 -0700 I don't know what causes the test to time out, but I think I understand why it crashes sometimes. In VideoFullscreenManager::removeContext, videoElement can be null here: ``` RefPtr<HTMLVideoElement> videoElement = model->videoElement(); ... m_videoElements.remove(*videoElement); ``` 1972097 7 aestes 2023-08-18 11:04:51 -0700 Reopening