130480 2014-03-19 15:01:07 -0700 Allow media engine to update HTMLMediaElement state when playing to external device 2014-03-19 15:43:13 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson calvaris commit-queue esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 992281 0 eric.carlson 2014-03-19 15:01:07 -0700 When media is playing to an external device, playback state changes made on the device (eg. with a remote control) happen without HTMLMediaElement input, so its state can get out of sync. These changes are reported to MediaPlayerPrivate by AVFoundation, but we don't have a mechanism for the media engine to update HTMLMediaElement state. 992286 1 227224 eric.carlson 2014-03-19 15:07:42 -0700 Created attachment 227224 Proposed patch 992289 2 227224 jer.noble 2014-03-19 15:09:54 -0700 Comment on attachment 227224 Proposed patch r=me 992297 3 227224 commit-queue 2014-03-19 15:43:09 -0700 Comment on attachment 227224 Proposed patch Clearing flags on attachment: 227224 Committed r165928: <http://trac.webkit.org/changeset/165928> 992298 4 commit-queue 2014-03-19 15:43:13 -0700 All reviewed patches have been landed. Closing bug. 227224 2014-03-19 15:07:42 -0700 2014-03-19 15:43:08 -0700 Proposed patch avf_patch_3.txt text/plain 4183 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTkyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAzLTE5ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IG1lZGlhIGVu Z2luZSB0byB1cGRhdGUgSFRNTE1lZGlhRWxlbWVudCBzdGF0ZSB3aGVuIHBsYXlpbmcgdG8gZXh0 ZXJuYWwgZGV2aWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzA0ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOiBBZGQgbWVkaWFQbGF5ZXJIYW5kbGVQbGF5 YmFja0NvbW1hbmQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllcjo6aGFuZGxlUGxheWJhY2tDb21tYW5k KTogTmV3LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmg6CisgICAg ICAgIChXZWJDb3JlOjpNZWRpYVBsYXllckNsaWVudDo6bWVkaWFQbGF5ZXJIYW5kbGVQbGF5YmFj a0NvbW1hbmQpOgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01l ZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRp YVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246OnJhdGVDaGFuZ2VkKTogU2VuZCBQbGF5IGFuZCBQ YXVzZSBjb21tYW5kcyB3aGVuCisgICAgICAgICAgICBwbGF5aW5nIHRvIGFuIGV4dGVybmFsIGRl dmljZS4KKwogMjAxNC0wMy0xOSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAK ICAgICAgICAgQ3Jhc2ggd2l0aCBsb25nIHNlbGVjdG9yIGxpc3QKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCShyZXZpc2lvbiAxNjU5MTYpCisrKyBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNTg1LDYgKzU4 NSw3IEBAIHByaXZhdGU6CiAjZW5kaWYKIAogICAgIHZpcnR1YWwgYm9vbCBtZWRpYVBsYXllclNo b3VsZFdhaXRGb3JSZXNwb25zZVRvQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgQXV0aGVu dGljYXRpb25DaGFsbGVuZ2UmKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgbWVkaWFQbGF5 ZXJIYW5kbGVQbGF5YmFja0NvbW1hbmQoTWVkaWFTZXNzaW9uOjpSZW1vdGVDb250cm9sQ29tbWFu ZFR5cGUgY29tbWFuZCkgb3ZlcnJpZGUgeyBkaWRSZWNlaXZlUmVtb3RlQ29udHJvbENvbW1hbmQo Y29tbWFuZCk7IH0KIAogICAgIHZvaWQgbG9hZFRpbWVyRmlyZWQoVGltZXI8SFRNTE1lZGlhRWxl bWVudD4mKTsKICAgICB2b2lkIHByb2dyZXNzRXZlbnRUaW1lckZpcmVkKFRpbWVyPEhUTUxNZWRp YUVsZW1lbnQ+Jik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRp YVBsYXllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvTWVkaWFQbGF5ZXIuY3BwCShyZXZpc2lvbiAxNjU5MTYpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOTgs NiArMTM5OCwxNCBAQCBib29sIE1lZGlhUGxheWVyOjpzaG91bGRXYWl0Rm9yUmVzcG9uc2VUCiAK ICAgICByZXR1cm4gbV9tZWRpYVBsYXllckNsaWVudC0+bWVkaWFQbGF5ZXJTaG91bGRXYWl0Rm9y UmVzcG9uc2VUb0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNoYWxsZW5nZSk7CiB9CisgICAgCit2 b2lkIE1lZGlhUGxheWVyOjpoYW5kbGVQbGF5YmFja0NvbW1hbmQoTWVkaWFTZXNzaW9uOjpSZW1v dGVDb250cm9sQ29tbWFuZFR5cGUgY29tbWFuZCkKK3sKKyAgICBpZiAoIW1fbWVkaWFQbGF5ZXJD bGllbnQpCisgICAgICAgIHJldHVybjsKKyAgICAKKyAgICBtX21lZGlhUGxheWVyQ2xpZW50LT5t ZWRpYVBsYXllckhhbmRsZVBsYXliYWNrQ29tbWFuZChjb21tYW5kKTsKK30KIAogdm9pZCBNZWRp YVBsYXllckZhY3RvcnlTdXBwb3J0OjpjYWxsUmVnaXN0ZXJNZWRpYUVuZ2luZShNZWRpYUVuZ2lu ZVJlZ2lzdGVyIHJlZ2lzdGVyTWVkaWFFbmdpbmUpCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgJKHJldmlzaW9uIDE2NTkxNikKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgJKHdvcmtpbmcg Y29weSkKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJJbnRSZWN0LmgiCiAjaW5jbHVkZSAi VVJMLmgiCiAjaW5jbHVkZSAiTGF5b3V0UmVjdC5oIgorI2luY2x1ZGUgIk1lZGlhU2Vzc2lvbi5o IgogI2luY2x1ZGUgIk5hdGl2ZUltYWdlUHRyLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1MYXllci5o IgogI2luY2x1ZGUgIlRpbWVyLmgiCkBAIC0yNjQsNiArMjY1LDcgQEAgcHVibGljOgogI2VuZGlm CiAKICAgICB2aXJ0dWFsIGJvb2wgbWVkaWFQbGF5ZXJTaG91bGRXYWl0Rm9yUmVzcG9uc2VUb0F1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJikgeyBy ZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIHZvaWQgbWVkaWFQbGF5ZXJIYW5kbGVQbGF5YmFj a0NvbW1hbmQoTWVkaWFTZXNzaW9uOjpSZW1vdGVDb250cm9sQ29tbWFuZFR5cGUpIHsgfQogfTsK IAogY2xhc3MgTWVkaWFQbGF5ZXJTdXBwb3J0c1R5cGVDbGllbnQgewpAQCAtNTczLDYgKzU3NSw3 IEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAgYm9vbCBzaG91bGRXYWl0Rm9yUmVzcG9uc2VUb0F1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJik7Cisg ICAgdm9pZCBoYW5kbGVQbGF5YmFja0NvbW1hbmQoTWVkaWFTZXNzaW9uOjpSZW1vdGVDb250cm9s Q29tbWFuZFR5cGUpOwogCiBwcml2YXRlOgogICAgIE1lZGlhUGxheWVyKE1lZGlhUGxheWVyQ2xp ZW50Kik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uLmNwcAkocmV2aXNpb24gMTY1OTE2KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxNiw2ICs2MTYsMTEgQEAgdm9pZCBNZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb246Om1ldAogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbjo6cmF0ZUNoYW5nZWQoKQogeworI2lmIEVOQUJMRShJT1NfQUlSUExBWSkKKyAg ICBpZiAoaXNDdXJyZW50UGxheWJhY2tUYXJnZXRXaXJlbGVzcygpKQorICAgICAgICBtX3BsYXll ci0+aGFuZGxlUGxheWJhY2tDb21tYW5kKHJhdGUoKSA/IE1lZGlhU2Vzc2lvbjo6UGxheUNvbW1h bmQgOiBNZWRpYVNlc3Npb246OlBhdXNlQ29tbWFuZCk7CisjZW5kaWYKKwogICAgIG1fcGxheWVy LT5yYXRlQ2hhbmdlZCgpOwogfQogCg==