130469 2014-03-19 10:43:46 -0700 Build fails when 3d rendering is disabled 2022-03-01 01:41:33 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 tomeu webkit-unassigned aperez bugs-noreply commit-queue dino kondapallykalyan roger_fong oldest_to_newest 992171 0 tomeu 2014-03-19 10:43:46 -0700 Because of missing USE(3D_GRAPHICS) guards. 992173 1 227197 tomeu 2014-03-19 10:45:33 -0700 Created attachment 227197 Patch 1174543 2 227197 bfulgham 2016-03-14 11:13:14 -0700 Comment on attachment 227197 Patch This patch seems reasonable. However, it's a few years out of date. Can this be updated so that it applies and works with current sources? 1846952 3 aperez 2022-03-01 01:41:33 -0800 The files referenced by the patch are long gone, and IIUC the replacement is GraphicsContextGL.h and friends, which do have guards covering the whole file, for example ENABLE(WEBGL) for GraphicsContextGL.h 227197 2014-03-19 10:45:33 -0700 2022-02-28 04:02:24 -0800 Patch bug-130469-20140319184508.patch text/plain 2039 tomeu U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ5NzMyMDM4ZmQzYmRm ZjhkYmM0MGE2OWRmMzAyN2YwYjBlMDYyNC4uMzlkM2YyYjhmZWVjYTAyNzM4ODI1NGQ5NTk3YWZk YTk5MTEyYzJlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTE5ICBUb21l dSBWaXpvc28gIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KKworICAgICAgICBHdWFyZCBo ZWFkZXIgY29udGVudHMgd2l0aCBVU0UoM0RfR1JBUEhJQ1MpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA0NjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDoKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuaDoKKwogMjAxNC0wMy0x OCAgQW5kcmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lv bnNdIFN0cmFuZ2UgbGF5b3V0IGZvciBjb250ZW50IHdpdGggcmVnaW9uIGJyZWFrcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0Qu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgK aW5kZXggMjUyNTM5MjFlNDdjODc5Y2U0MzFkYWVmYWNkOGJlMzAzNGQ2MTFlMi4uYTBjZmNjYTg4 MzBjMjgwNjY1NDJiZmIwODBmMDVmMmRhNWM4ZGFlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCkBAIC0yNiw2ICsyNiw4 IEBACiAjaWZuZGVmIEdyYXBoaWNzQ29udGV4dDNEX2gKICNkZWZpbmUgR3JhcGhpY3NDb250ZXh0 M0RfaAogCisjaWYgVVNFKDNEX0dSQVBISUNTKQorCiAjaW5jbHVkZSAiQU5HTEVXZWJLaXRCcmlk Z2UuaCIKICNpbmNsdWRlICJHcmFwaGljc1R5cGVzM0QuaCIKICNpbmNsdWRlICJJbWFnZS5oIgpA QCAtMTE0Nyw0ICsxMTQ5LDYgQEAgcHJpdmF0ZToKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQog CisjZW5kaWYgLy8gVVNFKDNEX0dSQVBISUNTKQorCiAjZW5kaWYgLy8gR3JhcGhpY3NDb250ZXh0 M0RfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NDb250ZXh0M0RQcml2YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQzRFByaXZhdGUuaAppbmRleCBiNmZkNDQ4Mjc2NDJlMWY5MmY5Nzc3ZjU5 OWRkZWQ2ZDQzZThiMmE4Li42NmFmMzNlYzEwYzNjZGQyMzRkZWIyZjhkODAwZTJjZDdlZWE5MDU4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQzRFByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQzRFByaXZhdGUuaApAQCAtMjAsNiArMjAsOCBAQAogI2lmbmRlZiBHcmFw aGljc0NvbnRleHQzRFByaXZhdGVfaAogI2RlZmluZSBHcmFwaGljc0NvbnRleHQzRFByaXZhdGVf aAogCisjaWYgVVNFKDNEX0dSQVBISUNTKQorCiAjaW5jbHVkZSAiR0xDb250ZXh0LmgiCiAjaW5j bHVkZSAiR3JhcGhpY3NDb250ZXh0M0QuaCIKICNpbmNsdWRlIDx3dGYvUGFzc093blB0ci5oPgpA QCAtNTcsNCArNTksNiBAQCBwcml2YXRlOgogCiB9CiAKKyNlbmRpZiAvLyBVU0UoM0RfR1JBUEhJ Q1MpCisKICNlbmRpZiAvLyBHcmFwaGljc0NvbnRleHQzRFByaXZhdGVfaAo=