130468 2014-03-19 10:34:04 -0700 Webkit2 builds are forced with CMake, if Gtk+3 is used 2014-09-16 10:18:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 tomeu webkit-unassigned bunhere cgarcia commit-queue gyuyoung.kim mrobinson rakuco sergio oldest_to_newest 992165 0 tomeu 2014-03-19 10:34:04 -0700 Maybe I'm missing something, because I don't see the logic behind this. 992169 1 227196 tomeu 2014-03-19 10:41:20 -0700 Created attachment 227196 Patch 993619 2 227196 mrobinson 2014-03-22 20:44:50 -0700 Comment on attachment 227196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227196&action=review > Source/cmake/OptionsGTK.cmake:114 > + if (ENABLE_WEBKIT2) > + set(ENABLE_PLUGIN_PROCESS ON) > + endif () Small nit. This doesn't need to be inside the if (NOT USE_GTK2) block 1035494 3 mrobinson 2014-09-16 10:18:54 -0700 WebKit1 is gone now. 227196 2014-03-19 10:41:20 -0700 2014-03-22 20:44:49 -0700 Patch bug-130468-20140319184057.patch text/plain 1233 tomeu U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGRkMWZj NWU1ZTM0N2ZlYWY5Y2M5YmI2Mzc5MjQ4NjQzYWU2MmIxMTguLjgzMDFlMDc0YjcxYjkyNmVkMTIy OWJhYWI2YjM1MmUzZjc0ZTMwNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMDcsOSArMTA3 LDEyIEBAIHNldChFTkFCTEVfV0VCS0lUIE9OKQogaWYgKE5PVCBVU0VfR1RLMikKICAgICBzZXQo V0VCS0lUR1RLX0FQSV9WRVJTSU9OIDMuMCkKICAgICBzZXQoR1RLX0FQSV9WRVJTSU9OIDMuMCkK LSAgICBzZXQoRU5BQkxFX1BMVUdJTl9QUk9DRVNTIE9OKQotICAgIHNldChFTkFCTEVfV0VCS0lU MiBPTikKICAgICBzZXQoR0RLX1ZFUlNJT05fTUlOX1JFUVVJUkVEIEdES19WRVJTSU9OXzNfNikK KworICAgIGlmIChFTkFCTEVfV0VCS0lUMikKKyAgICAgICAgc2V0KEVOQUJMRV9QTFVHSU5fUFJP Q0VTUyBPTikKKyAgICBlbmRpZiAoKQorCiBlbHNlICgpCiAgICAgc2V0KFdFQktJVEdUS19BUElf VkVSU0lPTiAyLjApCiAgICAgc2V0KEdUS19BUElfVkVSU0lPTiAyLjApCmRpZmYgLS1naXQgYS9D aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZDQ2NzRiZjhlMmE4NDZlOTZiMTg2MzM1MGQzOGQw N2M0MmE0MzA0My4uZWI5Y2E3NmQ4YjUwNTQ5MWViZjlmMmM0MTM1ZDU0YzYzZThkYWJlMyAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0 LTAzLTE5ICBUb21ldSBWaXpvc28gIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KKworICAg ICAgICBbR1RLXVtDTWFrZV0gRG9uJ3QgZm9yY2UgV2ViS2l0MiBidWlsZHMganVzdCBiZWNhdXNl IG9mIEd0ayszCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzA0NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCiAyMDE0LTAzLTE3ICBCcmVuZGFu IExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBodW1h biByZWFkYWJsZSBsYW5ndWFnZSBjb2RlIGZvciB0cmFja3MK