130466 2014-03-19 10:24:23 -0700 [GTK][CMake] CMake build fails to link TestNetscapePlugIn 2016-01-03 17:15:49 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 tomeu webkit-unassigned bunhere cgarcia commit-queue gyuyoung.kim mcatanzaro mrobinson rakuco sergio zan oldest_to_newest 992153 0 tomeu 2014-03-19 10:24:23 -0700 Because of missing -lX11 992157 1 tomeu 2014-03-19 10:27:10 -0700 *** Bug 130462 has been marked as a duplicate of this bug. *** 992159 2 tomeu 2014-03-19 10:27:25 -0700 *** Bug 130465 has been marked as a duplicate of this bug. *** 992161 3 227192 tomeu 2014-03-19 10:30:02 -0700 Created attachment 227192 Patch 992163 4 commit-queue 2014-03-19 10:32:58 -0700 Attachment 227192 did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 992176 5 227199 tomeu 2014-03-19 10:50:57 -0700 Created attachment 227199 Patch 993620 6 227199 mrobinson 2014-03-22 20:45:42 -0700 Comment on attachment 227199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review > Source/cmake/OptionsGTK.cmake:169 > +# FIXME: This is needed just for TestNetscapePlugIn, which calls X directly. > +find_package(X11 REQUIRED) > + Why is this necessary? CMake already looks for X11 libraries by default. 1152196 7 227199 mcatanzaro 2016-01-03 17:15:38 -0800 Comment on attachment 227199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review Sorry this went unreviewed for so long. :( >> Source/cmake/OptionsGTK.cmake:169 >> + > > Why is this necessary? CMake already looks for X11 libraries by default. We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so.... > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41 > + ${X11_X11_LIB} And DRT is no longer used by the GTK+ port, so I think this patch is obsolete. 227192 2014-03-19 10:30:02 -0700 2014-03-19 10:50:46 -0700 Patch bug-130466-20140319182939.patch text/plain 2098 tomeu U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGRkMWZj NWU1ZTM0N2ZlYWY5Y2M5YmI2Mzc5MjQ4NjQzYWU2MmIxMTguLjdkOTIxMmJjMDMxODM2ZjQ5MjA2 NDU5MjcwZGVhYjliNGNmYmNkYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNjQsNiArMTY0 LDkgQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQogICAgIGZpbmRfcGFj a2FnZShHU3RyZWFtZXIgMS4wLjMgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dTVFJFQU1FUl9DT01Q T05FTlRTfSkKIGVuZGlmICgpCiAKKyMgRklYTUU6IFRoaXMgaXMgbmVlZGVkIGp1c3QgZm9yIFRl c3ROZXRzY2FwZVBsdWdJbiwgd2hpY2ggY2FsbHMgWCBkaXJlY3RseS4KK2ZpbmRfcGFja2FnZShY MTEgUkVRVUlSRUQpCisKICMgRklYTUU6IFRoZXNlIG5lZWQgdG8gYmUgY29uZmlndXJhYmxlLgog YWRkX2RlZmluaXRpb25zKC1EV1RGX1BMQVRGT1JNX1gxMT0xKQogYWRkX2RlZmluaXRpb25zKC1E TU9aX1gxMSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCBjOTBmYTMyMjEzNzJmZTcwYmU4MmI4MGRjZDg2NDY0NGFkZGJhYmE2Li5mZDViYTA3Y2Zl MDliMzQyNDQxODhkNTA1MjFjNjQzZWM2NWNjYzEzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDMtMTkgIFRv bWV1IFZpem9zbyAgPHRvbWV1LnZpem9zb0Bjb2xsYWJvcmEuY29tPgorCisgICAgICAgIFtHVEtd W0NNYWtlXSBMb29rIGZvciBYMTEgbGlicmFyaWVzCisKKyAgICAgICAgTmVlZCB0aGUgYnVnIFVS TCAoT09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgaXMgbmVlZGVkIGp1c3QgZm9yIFRlc3ROZXRzY2FwZVBsdWdJbiwgd2hpY2ggY2Fs bHMgWCBkaXJlY3RseS4KKyAgICAgICAgU2hvdWxkIGJlIG1hZGUgY29uZmlndXJhYmxlIHRvIGFs bG93IHBlb3BsZSBkbyBYMTEtbGVzcyBidWlsZHMsIGJ1dCB0aGVyZSdzCisgICAgICAgIG5vdyB0 YXJnZXQgb3B0aW9uIGFueSBtb3JlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5l dHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0OgorCiAyMDE0LTAzLTE4ICBTYW11ZWwgV2hpdGUg IDxzYW11ZWxfd2hpdGVAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBOb3QgYWJsZSB0byB1c2Ug YXJyb3cga2V5cyB0byByZWFkIHRleHQgd2l0aCBWb2ljZU92ZXIgYmVmb3JlIHNlbGVjdGlvbiBp cyBzZXQgc29tZXBsYWNlIChhbnlwbGFjZSkuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQKaW5kZXggNTEyMDMyMzU5M2Zl MjQwM2ZlNzVmOWU0ZWEwMTRkOGM5NmQwZTAxNi4uMWY5ZDlmMzc3ZDAwNWE5NGI2NWE1MGRiYmNi ZTYyMTA4MzE2YTM4MyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNj YXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3RO ZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dApAQCAtMzgsNyArMzgsNyBAQCBzZXQoV2ViS2l0 VGVzdE5ldHNjYXBlUGx1Z2luX0lOQ0xVREVfRElSRUNUT1JJRVMKIGluY2x1ZGVfZGlyZWN0b3Jp ZXMoJHtXZWJLaXRUZXN0TmV0c2NhcGVQbHVnaW5fSU5DTFVERV9ESVJFQ1RPUklFU30pCiAKIHNl dChXZWJLaXRUZXN0TmV0c2NhcGVQbHVnaW5fTElCUkFSSUVTCi0gICAgJHtYMTFfTElCUkFSSUVT fQorICAgICR7WDExX1gxMV9MSUJ9CiApCiAKIGFkZF9saWJyYXJ5KFRlc3ROZXRzY2FwZVBsdWdp biBTSEFSRUQgJHtXZWJLaXRUZXN0TmV0c2NhcGVQbHVnaW5fU09VUkNFU30pCg== 227199 2014-03-19 10:50:57 -0700 2016-01-03 17:15:38 -0800 Patch bug-130466-20140319185034.patch text/plain 2117 tomeu U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGRkMWZj NWU1ZTM0N2ZlYWY5Y2M5YmI2Mzc5MjQ4NjQzYWU2MmIxMTguLjdkOTIxMmJjMDMxODM2ZjQ5MjA2 NDU5MjcwZGVhYjliNGNmYmNkYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNjQsNiArMTY0 LDkgQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQogICAgIGZpbmRfcGFj a2FnZShHU3RyZWFtZXIgMS4wLjMgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dTVFJFQU1FUl9DT01Q T05FTlRTfSkKIGVuZGlmICgpCiAKKyMgRklYTUU6IFRoaXMgaXMgbmVlZGVkIGp1c3QgZm9yIFRl c3ROZXRzY2FwZVBsdWdJbiwgd2hpY2ggY2FsbHMgWCBkaXJlY3RseS4KK2ZpbmRfcGFja2FnZShY MTEgUkVRVUlSRUQpCisKICMgRklYTUU6IFRoZXNlIG5lZWQgdG8gYmUgY29uZmlndXJhYmxlLgog YWRkX2RlZmluaXRpb25zKC1EV1RGX1BMQVRGT1JNX1gxMT0xKQogYWRkX2RlZmluaXRpb25zKC1E TU9aX1gxMSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCBjOTBmYTMyMjEzNzJmZTcwYmU4MmI4MGRjZDg2NDY0NGFkZGJhYmE2Li40NDVmODcyODhl MDZiYjM3MmU4M2U5NTAwNmM4NDQ4YTg2YTE0Y2Y2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDMtMTkgIFRv bWV1IFZpem9zbyAgPHRvbWV1LnZpem9zb0Bjb2xsYWJvcmEuY29tPgorCisgICAgICAgIFtHVEtd W0NNYWtlXSBMb29rIGZvciBYMTEgbGlicmFyaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA0NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIG5lZWRlZCBqdXN0IGZvciBUZXN0TmV0c2Nh cGVQbHVnSW4sIHdoaWNoIGNhbGxzIFggZGlyZWN0bHkuCisgICAgICAgIFNob3VsZCBiZSBtYWRl IGNvbmZpZ3VyYWJsZSB0byBhbGxvdyBwZW9wbGUgZG8gWDExLWxlc3MgYnVpbGRzLCBidXQgdGhl cmUncworICAgICAgICBub3cgdGFyZ2V0IG9wdGlvbiBhbnkgbW9yZS4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dDoKKwogMjAxNC0w My0xOCAgU2FtdWVsIFdoaXRlICA8c2FtdWVsX3doaXRlQGFwcGxlLmNvbT4KIAogICAgICAgICBB WDogTm90IGFibGUgdG8gdXNlIGFycm93IGtleXMgdG8gcmVhZCB0ZXh0IHdpdGggVm9pY2VPdmVy IGJlZm9yZSBzZWxlY3Rpb24gaXMgc2V0IHNvbWVwbGFjZSAoYW55cGxhY2UpLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0 IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0 CmluZGV4IDUxMjAzMjM1OTNmZTI0MDNmZTc1ZjllNGVhMDE0ZDhjOTZkMGUwMTYuLjFmOWQ5ZjM3 N2QwMDVhOTRiNjVhNTBkYmJjYmU2MjEwODMxNmEzODMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dAorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQKQEAgLTM4LDcg KzM4LDcgQEAgc2V0KFdlYktpdFRlc3ROZXRzY2FwZVBsdWdpbl9JTkNMVURFX0RJUkVDVE9SSUVT CiBpbmNsdWRlX2RpcmVjdG9yaWVzKCR7V2ViS2l0VGVzdE5ldHNjYXBlUGx1Z2luX0lOQ0xVREVf RElSRUNUT1JJRVN9KQogCiBzZXQoV2ViS2l0VGVzdE5ldHNjYXBlUGx1Z2luX0xJQlJBUklFUwot ICAgICR7WDExX0xJQlJBUklFU30KKyAgICAke1gxMV9YMTFfTElCfQogKQogCiBhZGRfbGlicmFy eShUZXN0TmV0c2NhcGVQbHVnaW4gU0hBUkVEICR7V2ViS2l0VGVzdE5ldHNjYXBlUGx1Z2luX1NP VVJDRVN9KQo=