130433 2014-03-18 16:55:08 -0700 Add new functionality that will be required by the history item decoding 2014-03-19 10:37:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 991951 0 andersca 2014-03-18 16:55:08 -0700 Add new functionality that will be required by the history item decoding 991954 1 227132 andersca 2014-03-18 16:56:43 -0700 Created attachment 227132 Patch 991998 2 227132 sam 2014-03-18 19:36:35 -0700 Comment on attachment 227132 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227132&action=review > Source/WebCore/platform/KeyedCoding.h:79 > + // FIXME: This doesn't distinguish between a missing object dictionary or a value of a different type. This took me a bit to parse. I would add a little bit more information about how its beginObject() doesn't distinguish and why return true. 992166 3 andersca 2014-03-19 10:37:02 -0700 Committed r165900: <http://trac.webkit.org/changeset/165900> 227132 2014-03-18 16:56:43 -0700 2014-03-18 20:04:56 -0700 Patch bug-130433-20140318165621.patch text/plain 5260 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRjYmFjYWM5ZTQ4ZGZl NjE5OWZhZjNiN2E2YWM3N2JlNWJmNDI3OC4uNzdhODU1NmFlNjllMmU2OTFiZDAzOGZmM2UwZDVh NDdlMmFkYTY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE0LTAzLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIG5ldyBmdW5j dGlvbmFsaXR5IHRoYXQgd2lsbCBiZSByZXF1aXJlZCBieSB0aGUgaGlzdG9yeSBpdGVtIGRlY29k aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA0 MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL0tleWVkQ29kaW5nLmg6CisgICAgICAgIChXZWJDb3JlOjpLZXllZERlY29kZXI6OmRl Y29kZUNvbmRpdGlvbmFsT2JqZWN0KToKKworMjAxNC0wMy0xOCAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEZpeCBhIHRyaXZpYWwgRklYTUUKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDQzMgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKaW5kZXggNzgyZDA1OTY4ODg3OWE4ZjkwN2Q3NDBhM2MyMWJjMTUzZWRiYmY5MS4uOGU1Mzk1 NWU2YWYwYjEyYmZiODIzYjk5MDVkMDZlOWEwNjUwYzQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE4IEBACiAyMDE0LTAzLTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKKyAgICAgICAgQWRkIG5ldyBmdW5jdGlvbmFsaXR5IHRoYXQgd2lsbCBiZSByZXF1aXJlZCBi eSB0aGUgaGlzdG9yeSBpdGVtIGRlY29kaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA0MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9jZi9LZXllZERlY29kZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpLZXllZERlY29kZXI6OmRlY29kZVVJbnQzMik6CisgICAgICAgIChXZWJLaXQ6 OktleWVkRGVjb2Rlcjo6ZGVjb2RlSW50MzIpOgorICAgICAgICAoV2ViS2l0OjpLZXllZERlY29k ZXI6OmRlY29kZUZsb2F0KToKKyAgICAgICAgKiBTaGFyZWQvY2YvS2V5ZWREZWNvZGVyLmg6CisK KzIwMTQtMDMtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAg ICAgICBCZWdpbiBjbGVhbmluZyB1cCBLZXllZERlY29kZXIgYW5kIEtleWVkRW5jb2RlcgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNDMxCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tleWVkQ29kaW5nLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9LZXllZENvZGluZy5oCmluZGV4IDE1MWJmZDk4OGQxMTNmZDE5MjRi MjA5MTNiY2Y3NmRjYmNhMzhiMzguLjRlM2U5NDgxNmZiNDUxMzYzOGJjYmY5YTcyYTgxMDg3NzZk YmY2NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tleWVkQ29kaW5nLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS2V5ZWRDb2RpbmcuaApAQCAtNDEsNyArNDEs OSBAQCBwcm90ZWN0ZWQ6CiBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGRlY29kZUJvb2woY29u c3QgU3RyaW5nJiBrZXksIGJvb2wmKSA9IDA7CiAgICAgdmlydHVhbCBib29sIGRlY29kZVVJbnQz Mihjb25zdCBTdHJpbmcmIGtleSwgdWludDMyX3QmKSA9IDA7CisgICAgdmlydHVhbCBib29sIGRl Y29kZUludDMyKGNvbnN0IFN0cmluZyYga2V5LCBpbnQzMl90JikgPSAwOwogICAgIHZpcnR1YWwg Ym9vbCBkZWNvZGVJbnQ2NChjb25zdCBTdHJpbmcmIGtleSwgaW50NjRfdCYpID0gMDsKKyAgICB2 aXJ0dWFsIGJvb2wgZGVjb2RlRmxvYXQoY29uc3QgU3RyaW5nJiBrZXksIGZsb2F0JikgPSAwOwog ICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVEb3VibGUoY29uc3QgU3RyaW5nJiBrZXksIGRvdWJsZSYp ID0gMDsKICAgICB2aXJ0dWFsIGJvb2wgZGVjb2RlU3RyaW5nKGNvbnN0IFN0cmluZyYga2V5LCBT dHJpbmcmKSA9IDA7CiAKQEAgLTcyLDYgKzc0LDE4IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICB0 ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBGPgorICAgIGJvb2wgZGVjb2RlQ29uZGl0aW9u YWxPYmplY3QoY29uc3QgU3RyaW5nJiBrZXksIFQmIG9iamVjdCwgRiYmIGZ1bmN0aW9uKQorICAg IHsKKyAgICAgICAgLy8gRklYTUU6IFRoaXMgZG9lc24ndCBkaXN0aW5ndWlzaCBiZXR3ZWVuIGEg bWlzc2luZyBvYmplY3QgZGljdGlvbmFyeSBvciBhIHZhbHVlIG9mIGEgZGlmZmVyZW50IHR5cGUu CisgICAgICAgIGlmICghYmVnaW5PYmplY3Qoa2V5KSkKKyAgICAgICAgICAgIHJldHVybiB0cnVl OworCisgICAgICAgIGJvb2wgcmVzdWx0ID0gZnVuY3Rpb24oKnRoaXMsIG9iamVjdCk7CisgICAg ICAgIGVuZE9iamVjdCgpOworICAgICAgICByZXR1cm4gcmVzdWx0OworICAgIH0KKworICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIEY+CiAgICAgYm9vbCBkZWNvZGVPYmplY3RzKGNv bnN0IFN0cmluZyYga2V5LCBWZWN0b3I8VD4mIG9iamVjdHMsIEYmJiBmdW5jdGlvbikKICAgICB7 CiAgICAgICAgIGlmICghYmVnaW5BcnJheShrZXkpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvU2hhcmVkL2NmL0tleWVkRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2Yv S2V5ZWREZWNvZGVyLmNwcAppbmRleCA3MTFkZTkzZGU4NTJhN2VhZDgxNGZiMmZjN2M1OWJjNzgw YTk3OGQzLi40NmJkNzYyNmZhNjM4OTBmNzA1NzliZGI5ZTRjMGEwMTczYmViMGI5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvS2V5ZWREZWNvZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvY2YvS2V5ZWREZWNvZGVyLmNwcApAQCAtNjIsNiArNjIsMTEgQEAg Ym9vbCBLZXllZERlY29kZXI6OmRlY29kZUJvb2woY29uc3QgU3RyaW5nJiBrZXksIGJvb2wmIHJl c3VsdCkKIAogYm9vbCBLZXllZERlY29kZXI6OmRlY29kZVVJbnQzMihjb25zdCBTdHJpbmcmIGtl eSwgdWludDMyX3QmIHJlc3VsdCkKIHsKKyAgICByZXR1cm4gZGVjb2RlSW50MzIoa2V5LCByZWlu dGVycHJldF9jYXN0PGludDMyX3QmPihyZXN1bHQpKTsKK30KKworYm9vbCBLZXllZERlY29kZXI6 OmRlY29kZUludDMyKGNvbnN0IFN0cmluZyYga2V5LCBpbnQzMl90JiByZXN1bHQpCit7CiAgICAg Q0ZOdW1iZXJSZWYgbnVtYmVyID0gc3RhdGljX2Nhc3Q8Q0ZOdW1iZXJSZWY+KENGRGljdGlvbmFy eUdldFZhbHVlKG1fZGljdGlvbmFyeVN0YWNrLmxhc3QoKSwga2V5LmNyZWF0ZUNGU3RyaW5nKCku Z2V0KCkpKTsKICAgICBpZiAoIW51bWJlciB8fCBDRkdldFR5cGVJRChudW1iZXIpICE9IENGTnVt YmVyR2V0VHlwZUlEKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTc4LDYgKzgzLDE1IEBA IGJvb2wgS2V5ZWREZWNvZGVyOjpkZWNvZGVJbnQ2NChjb25zdCBTdHJpbmcmIGtleSwgaW50NjRf dCYgcmVzdWx0KQogICAgIHJldHVybiBDRk51bWJlckdldFZhbHVlKG51bWJlciwga0NGTnVtYmVy U0ludDY0VHlwZSwgJnJlc3VsdCk7CiB9CiAKK2Jvb2wgS2V5ZWREZWNvZGVyOjpkZWNvZGVGbG9h dChjb25zdCBTdHJpbmcmIGtleSwgZmxvYXQmIHJlc3VsdCkKK3sKKyAgICBDRk51bWJlclJlZiBu dW1iZXIgPSBzdGF0aWNfY2FzdDxDRk51bWJlclJlZj4oQ0ZEaWN0aW9uYXJ5R2V0VmFsdWUobV9k aWN0aW9uYXJ5U3RhY2subGFzdCgpLCBrZXkuY3JlYXRlQ0ZTdHJpbmcoKS5nZXQoKSkpOworICAg IGlmICghbnVtYmVyIHx8IENGR2V0VHlwZUlEKG51bWJlcikgIT0gQ0ZOdW1iZXJHZXRUeXBlSUQo KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgcmV0dXJuIENGTnVtYmVyR2V0VmFsdWUo bnVtYmVyLCBrQ0ZOdW1iZXJGbG9hdFR5cGUsICZyZXN1bHQpOworfQorCiBib29sIEtleWVkRGVj b2Rlcjo6ZGVjb2RlRG91YmxlKGNvbnN0IFN0cmluZyYga2V5LCBkb3VibGUmIHJlc3VsdCkKIHsK ICAgICBDRk51bWJlclJlZiBudW1iZXIgPSBzdGF0aWNfY2FzdDxDRk51bWJlclJlZj4oQ0ZEaWN0 aW9uYXJ5R2V0VmFsdWUobV9kaWN0aW9uYXJ5U3RhY2subGFzdCgpLCBrZXkuY3JlYXRlQ0ZTdHJp bmcoKS5nZXQoKSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0tleWVk RGVjb2Rlci5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0tleWVkRGVjb2Rlci5oCmluZGV4 IDA5OWRiNjdhOTMxYjRiNjM5MmRmYmU3NjU0NGI0YmNlNTViNmM3NzAuLjBhMWQ2NzQ4YzE5NmE3 ZGEwNTNkOWQxMzYzZjE5ODM1Yzk3MzY4OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9jZi9LZXllZERlY29kZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvY2YvS2V5 ZWREZWNvZGVyLmgKQEAgLTQwLDcgKzQwLDkgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICB2aXJ0 dWFsIGJvb2wgZGVjb2RlQm9vbChjb25zdCBTdHJpbmcmIGtleSwgYm9vbCYpIG92ZXJyaWRlOwog ICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVVSW50MzIoY29uc3QgU3RyaW5nJiBrZXksIHVpbnQzMl90 Jikgb3ZlcnJpZGU7CisgICAgdmlydHVhbCBib29sIGRlY29kZUludDMyKGNvbnN0IFN0cmluZyYg a2V5LCBpbnQzMl90Jikgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBib29sIGRlY29kZUludDY0KGNv bnN0IFN0cmluZyYga2V5LCBpbnQ2NF90Jikgb3ZlcnJpZGU7CisgICAgdmlydHVhbCBib29sIGRl Y29kZUZsb2F0KGNvbnN0IFN0cmluZyYga2V5LCBmbG9hdCYpIG92ZXJyaWRlOwogICAgIHZpcnR1 YWwgYm9vbCBkZWNvZGVEb3VibGUoY29uc3QgU3RyaW5nJiBrZXksIGRvdWJsZSYpIG92ZXJyaWRl OwogICAgIHZpcnR1YWwgYm9vbCBkZWNvZGVTdHJpbmcoY29uc3QgU3RyaW5nJiBrZXksIFN0cmlu ZyYpIG92ZXJyaWRlOwogCg==