130419 2014-03-18 13:34:09 -0700 REGRESSION: Visited link coloring seems to be completely broken in tip of tree 2014-05-20 05:01:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 131037 131675 1 andersca andersca andersca mitz ossy oldest_to_newest 991843 0 andersca 2014-03-18 13:34:09 -0700 REGRESSION: Visited link coloring seems to be completely broken in tip of tree 991849 1 227100 andersca 2014-03-18 13:37:10 -0700 Created attachment 227100 Patch 991857 2 andersca 2014-03-18 13:45:51 -0700 Committed r165841: <http://trac.webkit.org/changeset/165841> 1010459 3 ossy 2014-05-20 05:01:56 -0700 (In reply to comment #2) > Committed r165841: <http://trac.webkit.org/changeset/165841> Dan, Anders, could you possibly review the patch in Bug131675 which fixes the serious regression this patch caused? 227100 2014-03-18 13:37:10 -0700 2014-03-18 13:39:43 -0700 Patch bug-130419-20140318133647.patch text/plain 1922 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTk1OWU5MDIyNjU2YmE3 NTFkOWVhYTA3MmNjMmQ0ZGNlOWYxN2U2Mi4uMmUyNDkyMTM3YWMyOTFlMzhlMzY1ZTQzNGUwOWNi NWE4Zjk4YzhjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAzLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjog VmlzaXRlZCBsaW5rIGNvbG9yaW5nIHNlZW1zIHRvIGJlIGNvbXBsZXRlbHkgYnJva2VuIGluIHRp cCBvZiB0cmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzA0MTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MzM3ODUwPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSB0byBzZW5kIGFu eSBxdWV1ZWQgdXAgbWVzc2FnZXMgYmVmb3JlIGNhbGxpbmcgY29ubmVjdGlvbldpbGxPcGVuIHNv IHdlJ2xsIGVuc3VyZQorICAgICAgICBGSUZPIG9yZGVyaW5nIGlmIGFueSBtZXNzYWdlcyBhcmUg c2VudCBmcm9tIHdpdGhpbiBjb25uZWN0aW9uV2lsbE9wZW4uCisKKyAgICAgICAgKiBTaGFyZWQv Q2hpbGRQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaGlsZFByb2Nlc3NQcm94 eTo6ZGlkRmluaXNoTGF1bmNoaW5nKToKKwogMjAxNC0wMy0xOCAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBEYW4gc2F5cyB0aGF0IG9wdGlvbnMgc2hv dWxkIGJlIHVuc2lnbmVkLCBhbmQgZW51bXMgc2hvdWxkIGJlIHNpZ25lZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzUHJveHkuY3BwCmluZGV4IGEyMjMxZTJkZWQzZjk4M2Ix YjJlZWEzNDg4MTEwNzk3YmYwNDRmOGYuLmFhMTRhMWI4NzQ2OWRmZDI3YmQzYWYwYTBmODBlMjg4 ZGNlOTJhZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3NQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0NoaWxkUHJvY2Vzc1Byb3h5LmNw cApAQCAtMTMyLDE1ICsxMzIsMTUgQEAgdm9pZCBDaGlsZFByb2Nlc3NQcm94eTo6ZGlkRmluaXNo TGF1bmNoaW5nKFByb2Nlc3NMYXVuY2hlciosIElQQzo6Q29ubmVjdGlvbjo6SWQKICAgICBtX2Nv bm5lY3Rpb24tPnNldFNob3VsZENsb3NlQ29ubmVjdGlvbk9uTWFjaEV4Y2VwdGlvbnMoKTsKICNl bmRpZgogCi0gICAgY29ubmVjdGlvbldpbGxPcGVuKG1fY29ubmVjdGlvbi5nZXQoKSk7Ci0gICAg bV9jb25uZWN0aW9uLT5vcGVuKCk7Ci0KICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fcGVu ZGluZ01lc3NhZ2VzLnNpemUoKTsgKytpKSB7CiAgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxJUEM6 Ok1lc3NhZ2VFbmNvZGVyPiBtZXNzYWdlID0gc3RkOjptb3ZlKG1fcGVuZGluZ01lc3NhZ2VzW2ld LmZpcnN0KTsKICAgICAgICAgdW5zaWduZWQgbWVzc2FnZVNlbmRGbGFncyA9IG1fcGVuZGluZ01l c3NhZ2VzW2ldLnNlY29uZDsKICAgICAgICAgbV9jb25uZWN0aW9uLT5zZW5kTWVzc2FnZShzdGQ6 Om1vdmUobWVzc2FnZSksIG1lc3NhZ2VTZW5kRmxhZ3MpOwogICAgIH0KIAorICAgIGNvbm5lY3Rp b25XaWxsT3BlbihtX2Nvbm5lY3Rpb24uZ2V0KCkpOworICAgIG1fY29ubmVjdGlvbi0+b3Blbigp OworCiAgICAgbV9wZW5kaW5nTWVzc2FnZXMuY2xlYXIoKTsKIH0KIAo=