130414 2014-03-18 12:55:31 -0700 WebPageCreationParameters colorSpace should be MAC not COCOA 2014-03-18 13:19:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue joepeck mitz thorton oldest_to_newest 991813 0 joepeck 2014-03-18 12:55:31 -0700 WebPageCreationParameters colorSpace is only used by PLATFORM(MAC), but it is defined as PLATFORM(COCOA). The only use I see is in !PLATFORM(IOS) code: WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 87: setColorSpace(parameters.colorSpace); 991815 1 227093 joepeck 2014-03-18 12:57:54 -0700 Created attachment 227093 [PATCH] Proposed Fix 991821 2 227093 mitz 2014-03-18 13:02:19 -0700 Comment on attachment 227093 [PATCH] Proposed Fix rs=me 991826 3 227093 joepeck 2014-03-18 13:05:35 -0700 Comment on attachment 227093 [PATCH] Proposed Fix I suspect this will collide with another patch changing a line nearby. cq may not work, but lets try anyways. 991834 4 227093 commit-queue 2014-03-18 13:19:08 -0700 Comment on attachment 227093 [PATCH] Proposed Fix Clearing flags on attachment: 227093 Committed r165839: <http://trac.webkit.org/changeset/165839> 991835 5 commit-queue 2014-03-18 13:19:12 -0700 All reviewed patches have been landed. Closing bug. 227093 2014-03-18 12:57:54 -0700 2014-03-18 13:19:08 -0700 [PATCH] Proposed Fix mac.patch text/plain 2277 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxOTU5ZTkwLi43YWRiNzM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDMtMTggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzIGNvbG9yU3BhY2Ugc2hvdWxkIGJlIE1B QyBub3QgQ09DT0EKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMDQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBjb2xvclNwYWNlIHBhcmFtIHdhcyBvbmx5IHNldCBhbmQgdXNlZCBvbiBNYWMsIG5v dCBpT1MuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oOgor ICAgICAgICAqIFNoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2RlKToKKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6ZGVjb2RlKToKKwogMjAxNC0wMy0xOCAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBEYW4gc2F5 cyB0aGF0IG9wdGlvbnMgc2hvdWxkIGJlIHVuc2lnbmVkLCBhbmQgZW51bXMgc2hvdWxkIGJlIHNp Z25lZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25Q YXJhbWV0ZXJzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJh bWV0ZXJzLmNwcAppbmRleCAxM2FhY2Y3Li5lYTk3YTQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcApAQCAtNjMsNyArNjMs NyBAQCB2b2lkIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnM6OmVuY29kZShJUEM6OkFyZ3VtZW50 RW5jb2RlciYgZW5jb2RlcikgY29uc3QKICAgICBlbmNvZGVyIDw8IGJhY2tncm91bmRFeHRlbmRz QmV5b25kUGFnZTsKICAgICBlbmNvZGVyLmVuY29kZUVudW0obGF5ZXJIb3N0aW5nTW9kZSk7CiAK LSNpZiBQTEFURk9STShDT0NPQSkKKyNpZiBQTEFURk9STShNQUMpCiAgICAgZW5jb2RlciA8PCBj b2xvclNwYWNlOwogI2VuZGlmCiAjaWYgUExBVEZPUk0oSU9TKQpAQCAtMTMyLDcgKzEzMiw3IEBA IGJvb2wgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6ZGVjb2RlKElQQzo6QXJndW1lbnREZWNv ZGVyJiBkZWNvZGVyLCBXZWJQYWdlQ3JlCiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZUVudW0ocGFy YW1ldGVycy5sYXllckhvc3RpbmdNb2RlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAot I2lmIFBMQVRGT1JNKENPQ09BKQorI2lmIFBMQVRGT1JNKE1BQykKICAgICBpZiAoIWRlY29kZXIu ZGVjb2RlKHBhcmFtZXRlcnMuY29sb3JTcGFjZSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICNl bmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBh cmFtZXRlcnMuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0 ZXJzLmgKaW5kZXggNmIxZDI5Zi4uMWUzZjdiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv U2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oCkBAIC00MCw3ICs0MCw3IEBACiAjaW5j bHVkZSA8V2ViQ29yZS9WaWV3U3RhdGUuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcu aD4KIAotI2lmIFBMQVRGT1JNKENPQ09BKQorI2lmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlICJD b2xvclNwYWNlRGF0YS5oIgogI2VuZGlmCiAKQEAgLTEwMyw3ICsxMDMsNyBAQCBzdHJ1Y3QgV2Vi UGFnZUNyZWF0aW9uUGFyYW1ldGVycyB7CiAKICAgICBMYXllckhvc3RpbmdNb2RlIGxheWVySG9z dGluZ01vZGU7CiAKLSNpZiBQTEFURk9STShDT0NPQSkKKyNpZiBQTEFURk9STShNQUMpCiAgICAg Q29sb3JTcGFjZURhdGEgY29sb3JTcGFjZTsKICNlbmRpZgogI2lmIFBMQVRGT1JNKElPUykK