130412 2014-03-18 12:05:10 -0700 Web Inspector: Make update-InspectorBackendCommands.rb only update legacy protocol versions 2014-03-18 13:07:59 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 991782 0 joepeck 2014-03-18 12:05:10 -0700 Now that tip of tree files are generated at build time depending on ENABLE flags, this script does not need to update ToT backend commands. It may still be useful to update the legacy protocol versions (iOS6, and iOS7) if the CodeGenerator ever changes to produce slightly different output. 991783 1 227086 joepeck 2014-03-18 12:07:06 -0700 Created attachment 227086 [PATCH] Proposed Fix shell> ./Scripts/update-LegacyInspectorBackendCommands.rb Inspector-iOS-6.0.json -> UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js Inspector-iOS-7.0.json -> UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js 991828 2 227086 commit-queue 2014-03-18 13:07:54 -0700 Comment on attachment 227086 [PATCH] Proposed Fix Clearing flags on attachment: 227086 Committed r165838: <http://trac.webkit.org/changeset/165838> 991829 3 commit-queue 2014-03-18 13:07:59 -0700 All reviewed patches have been landed. Closing bug. 227086 2014-03-18 12:07:06 -0700 2014-03-18 13:07:54 -0700 [PATCH] Proposed Fix scripts.patch text/plain 5356 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkxMmI3YTkuLjY0Yjc5NDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSB1 cGRhdGUtSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiIG9ubHkgdXBkYXRlIGxlZ2FjeSBwcm90 b2NvbCB2ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMwNDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVuYW1lIHRoZSBzY3JpcHQgYW5kIHNpbXBsaWZ5IHRvIG9ubHkgdXBkYXRlIExlZ2Fj eSBwcm90b2NvbCB2ZXJzaW9ucy4KKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLUxlZ2FjeUlu c3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYjogUmVuYW1lZCBmcm9tIFNvdXJjZS9XZWJJbnNwZWN0 b3JVSS9TY3JpcHRzL3VwZGF0ZS1JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMucmIuCisKIDIwMTQt MDMtMTYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogdmVuZGVkIGJhY2tlbmQgY29tbWFuZHMgZmlsZSBzaG91bGQgYmUgZ2VuZXJhdGVkIGFz IHBhcnQgb2YgdGhlIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2Ny aXB0cy91cGRhdGUtSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1NjcmlwdHMvdXBkYXRlLUxlZ2FjeUluc3BlY3RvckJhY2tlbmRDb21tYW5kcy5yYgpz aW1pbGFyaXR5IGluZGV4IDUyJQpyZW5hbWUgZnJvbSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2Ny aXB0cy91cGRhdGUtSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLnJiCnJlbmFtZSB0byBTb3VyY2Uv V2ViSW5zcGVjdG9yVUkvU2NyaXB0cy91cGRhdGUtTGVnYWN5SW5zcGVjdG9yQmFja2VuZENvbW1h bmRzLnJiCmluZGV4IDRmYTM2YzguLmEyNTViZDAgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9TY3JpcHRzL3VwZGF0ZS1JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMucmIKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvdXBkYXRlLUxlZ2FjeUluc3BlY3RvckJhY2tl bmRDb21tYW5kcy5yYgpAQCAtMSw3ICsxLDYgQEAKICMhL3Vzci9iaW4vcnVieQogCiByZXF1aXJl ICdmaWxldXRpbHMnCi1yZXF1aXJlICd0ZW1wZmlsZScKIHJlcXVpcmUgJ3RtcGRpcicKIAogaWYg QVJHVi5zaXplICE9IDAKQEAgLTExLDI2ICsxMCwxNyBAQCBlbmQKIAogV0VCX0lOU1BFQ1RPUl9Q QVRIID0gRmlsZS5leHBhbmRfcGF0aCBGaWxlLmpvaW4oRmlsZS5kaXJuYW1lKF9fRklMRV9fKSwg Ii4uIikKIEpBVkFTQ1JJUFRDT1JFX1BBVEggPSBGaWxlLmV4cGFuZF9wYXRoIEZpbGUuam9pbihG aWxlLmRpcm5hbWUoX19GSUxFX18pLCAiLi4iLCAiLi4iLCAiSmF2YVNjcmlwdENvcmUiKQotV0VC Q09SRV9QQVRIID0gRmlsZS5leHBhbmRfcGF0aCBGaWxlLmpvaW4oRmlsZS5kaXJuYW1lKF9fRklM RV9fKSwgIi4uIiwgIi4uIiwgIldlYkNvcmUiKQotCi1KQVZBU0NSSVBUX0lOU1BFQ1RPUl9QUk9U T0NPTFNfUEFUSCA9IEZpbGUuam9pbiBKQVZBU0NSSVBUQ09SRV9QQVRILCAiaW5zcGVjdG9yIiwg InByb3RvY29sIgotV0VCX0lOU1BFQ1RPUl9QUk9UT0NPTFNfUEFUSCA9IEZpbGUuam9pbiBXRUJD T1JFX1BBVEgsICJpbnNwZWN0b3IiLCAicHJvdG9jb2wiCiAKICRjb2RlX2dlbmVyYXRvcl9wYXRo ID0gRmlsZS5qb2luIEpBVkFTQ1JJUFRDT1JFX1BBVEgsICJpbnNwZWN0b3IiLCAic2NyaXB0cyIs ICJDb2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5IgotJGluc3BlY3Rvcl9qc29uX2dlbmVyYXRvcl9w YXRoID0gRmlsZS5qb2luIEpBVkFTQ1JJUFRDT1JFX1BBVEgsICJpbnNwZWN0b3IiLCAic2NyaXB0 cyIsICJnZW5lcmF0ZS1jb21iaW5lZC1pbnNwZWN0b3ItanNvbi5weSIKLSRpbnNwZWN0b3JfanNf anNvbl9wYXRoID0gVGVtcGZpbGUubmV3KCJnZW5lcmF0ZWQtSW5zcGVjdG9ySlMuanNvbiIpLnBh dGgKLSRpbnNwZWN0b3Jfd2ViX2pzb25fcGF0aCA9IFRlbXBmaWxlLm5ldygiZ2VuZXJhdGVkLUlu c3BlY3RvcldlYi5qc29uIikucGF0aAogJHZlcnNpb25zX2RpcmVjdG9yeV9wYXRoID0gRmlsZS5q b2luIFdFQl9JTlNQRUNUT1JfUEFUSCwgIlZlcnNpb25zIgotJHdlYl9pbnNwZWN0b3JfdXNlcl9p bnRlcmZhY2VfcGF0aCA9IEZpbGUuam9pbiBXRUJfSU5TUEVDVE9SX1BBVEgsICJVc2VySW50ZXJm YWNlIgotJHdlYl9pbnNwZWN0b3JfcHJvdG9jb2xfcGF0aCA9IEZpbGUuam9pbiBXRUJfSU5TUEVD VE9SX1BBVEgsICJVc2VySW50ZXJmYWNlIiwgIlByb3RvY29sIgorJHdlYl9pbnNwZWN0b3JfcHJv dG9jb2xfbGVnYWN5X3BhdGggPSBGaWxlLmpvaW4gV0VCX0lOU1BFQ1RPUl9QQVRILCAiVXNlcklu dGVyZmFjZSIsICJQcm90b2NvbCIsICJMZWdhY3kiCiAKIGNsYXNzIFRhc2sKLSAgZGVmIGluaXRp YWxpemUoaW5wdXRfanNvbl9wYXRoLCBkZXBlbmRlbmN5X2pzb25fcGF0aCwgdHlwZSwgb3V0cHV0 X2RpcmVjdG9yeV9wYXRoLCB2ZXJpZmljYXRpb24pCisgIGRlZiBpbml0aWFsaXplKGlucHV0X2pz b25fcGF0aCwgZGVwZW5kZW5jeV9qc29uX3BhdGgsIHR5cGUsIG91dHB1dF9kaXJlY3RvcnlfcGF0 aCkKICAgICBAdHlwZSA9IHR5cGUKICAgICBAaW5wdXRfanNvbl9wYXRoID0gaW5wdXRfanNvbl9w YXRoCiAgICAgQGRlcGVuZGVuY3lfanNvbl9wYXRoID0gZGVwZW5kZW5jeV9qc29uX3BhdGgKICAg ICBAb3V0cHV0X2RpcmVjdG9yeV9wYXRoID0gb3V0cHV0X2RpcmVjdG9yeV9wYXRoCi0gICAgQHZl cmlmaWNhdGlvbiA9IHZlcmlmaWNhdGlvbgogICBlbmQKIAogICBkZWYgcnVuCkBAIC00Miw4ICsz Miw3IEBAIGNsYXNzIFRhc2sKIAogICAgIERpci5ta3RtcGRpciBkbyB8dG1wZGlyfAogICAgICAg ZGVwZW5kZW5jeSA9IEBkZXBlbmRlbmN5X2pzb25fcGF0aCA/ICInI3tAZGVwZW5kZW5jeV9qc29u X3BhdGh9JyIgOiAiIgotICAgICAgY21kID0gIiN7JGNvZGVfZ2VuZXJhdG9yX3BhdGh9ICcje0Bp bnB1dF9qc29uX3BhdGh9JyAje2RlcGVuZGVuY3l9IC0tb3V0cHV0X2hfZGlyICcje3RtcGRpcn0n IC0tb3V0cHV0X2NwcF9kaXIgJyN7dG1wZGlyfScgLS1vdXRwdXRfanNfZGlyICcje3RtcGRpcn0n IC0td3JpdGVfYWx3YXlzIC0tb3V0cHV0X3R5cGUgJyN7QHR5cGV9JyIKLSAgICAgIGNtZCArPSAi IC0tbm9fdmVyaWZpY2F0aW9uIiBpZiAhQHZlcmlmaWNhdGlvbgorICAgICAgY21kID0gIiN7JGNv ZGVfZ2VuZXJhdG9yX3BhdGh9ICcje0BpbnB1dF9qc29uX3BhdGh9JyAje2RlcGVuZGVuY3l9IC0t bm9fdmVyaWZpY2F0aW9uIC0tb3V0cHV0X2hfZGlyICcje3RtcGRpcn0nIC0tb3V0cHV0X2NwcF9k aXIgJyN7dG1wZGlyfScgLS1vdXRwdXRfanNfZGlyICcje3RtcGRpcn0nIC0td3JpdGVfYWx3YXlz IC0tb3V0cHV0X3R5cGUgJyN7QHR5cGV9JyIKICAgICAgICV4eyAje2NtZH0gfQogICAgICAgaWYg JD8uZXhpdHN0YXR1cyAhPSAwCiAgICAgICAgIHB1dHMgIkVSUk9SOiBFcnJvciBDb2RlICgjeyQ/ LmV4aXRzdGF0dXN9KSBFdmFsdWF0aW5nOiAje2NtZH0iCkBAIC02MiwzNiArNTEsMTUgQEAgY2xh c3MgVGFzawogICBlbmQKIGVuZAogCi1kZWYgZ2VuZXJhdGVfY29tYmluZWRfaW5zcGVjdG9yX2pz b24KLSAgIyBJbnNwZWN0b3JKUy5qc29uCi0gIG91dHB1dCA9ICV4eyAjeyRpbnNwZWN0b3JfanNv bl9nZW5lcmF0b3JfcGF0aH0gIiN7SkFWQVNDUklQVF9JTlNQRUNUT1JfUFJPVE9DT0xTX1BBVEh9 IiA+ICIjeyRpbnNwZWN0b3JfanNfanNvbl9wYXRofSIgfQotICBpZiAkPy5leGl0c3RhdHVzICE9 IDAKLSAgICBwdXRzICJFUlJPUjogQ291bGQgbm90IGdlbmVyYXRlIGNvbWJpbmVkIEluc3BlY3Rv ckpTLmpzb24gZmlsZSIKLSAgICBleGl0IDEKLSAgZW5kCi0KLSAgIyBJbnNwZWN0b3JXZWIuanNv bgotICBvdXRwdXQgPSAleHsgI3skaW5zcGVjdG9yX2pzb25fZ2VuZXJhdG9yX3BhdGh9ICIje1dF Ql9JTlNQRUNUT1JfUFJPVE9DT0xTX1BBVEh9IiA+ICIjeyRpbnNwZWN0b3Jfd2ViX2pzb25fcGF0 aH0iIH0KLSAgaWYgJD8uZXhpdHN0YXR1cyAhPSAwCi0gICAgcHV0cyAiRVJST1I6IENvdWxkIG5v dCBnZW5lcmF0ZSBjb21iaW5lZCBJbnNwZWN0b3JXZWIuanNvbiBmaWxlIgotICAgIGV4aXQgMQot ICBlbmQKLWVuZAotCiBkZWYgYWxsX3Rhc2tzCiAgIHRhc2tzID0gW10KIAotICAjIFRvVCBJbnNw ZWN0b3IganNvbiBmaWxlcy4KLSAgZ2VuZXJhdGVfY29tYmluZWRfaW5zcGVjdG9yX2pzb24KLSAg dGFza3MgPDwgVGFzay5uZXcoJGluc3BlY3Rvcl9qc19qc29uX3BhdGgsIG5pbCwgIkphdmFTY3Jp cHQiLCAkd2ViX2luc3BlY3Rvcl9wcm90b2NvbF9wYXRoLCB0cnVlKQotICB0YXNrcyA8PCBUYXNr Lm5ldygkaW5zcGVjdG9yX3dlYl9qc29uX3BhdGgsICRpbnNwZWN0b3JfanNfanNvbl9wYXRoLCAi V2ViIiwgJHdlYl9pbnNwZWN0b3JfcHJvdG9jb2xfcGF0aCwgdHJ1ZSkKLQogICBoYWRfZXJyb3Ig PSBmYWxzZQogICBEaXIuZ2xvYihGaWxlLmpvaW4oJHZlcnNpb25zX2RpcmVjdG9yeV9wYXRoLCAi Ki5qc29uIikpLmVhY2ggZG8gfHZlcnNpb25fcGF0aHwKICAgICBtYXRjaCA9IEZpbGUuYmFzZW5h bWUodmVyc2lvbl9wYXRoKS5tYXRjaCgvXkluc3BlY3RvciguKj8pXC0oW14tXSs/KVwuanNvbiQv KQogICAgIGlmIG1hdGNoCi0gICAgICBvdXRwdXRfcGF0aCA9IEZpbGUuam9pbiAkd2ViX2luc3Bl Y3Rvcl9wcm90b2NvbF9wYXRoLCAiTGVnYWN5IiwgbWF0Y2hbMl0KLSAgICAgIHRhc2tzIDw8IFRh c2submV3KHZlcnNpb25fcGF0aCwgbmlsLCAiV2ViIiwgb3V0cHV0X3BhdGgsIGZhbHNlKQorICAg ICAgb3V0cHV0X3BhdGggPSBGaWxlLmpvaW4gJHdlYl9pbnNwZWN0b3JfcHJvdG9jb2xfbGVnYWN5 X3BhdGgsIG1hdGNoWzJdCisgICAgICB0YXNrcyA8PCBUYXNrLm5ldyh2ZXJzaW9uX3BhdGgsIG5p bCwgIldlYiIsIG91dHB1dF9wYXRoKQogICAgIGVsc2UKICAgICAgIHB1dHMgIkVSUk9SOiBWZXJz aW9uIGZpbGUgKCN7dmVyc2lvbl9wYXRofSkgZGlkIG5vdCBtYXRjaCB0aGUgdGVtcGxhdGUgSW5z cGVjdG9yPEFOWVRISU5HPi08VkVSU0lPTj4uanMiCiAgICAgICBoYWRfZXJyb3IgPSB0cnVlCg==