130408 2014-03-18 11:23:58 -0700 Extra parens around if clause in a preprocessor define in Parser.cpp 2014-03-18 12:39:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mmirman webkit-unassigned commit-queue fpizlo mmirman oldest_to_newest 991758 0 mmirman 2014-03-18 11:23:58 -0700 This should have caused failure with compiler warnings on. 991759 1 227080 mmirman 2014-03-18 11:26:46 -0700 Created attachment 227080 Fixed extra parens 991796 2 227080 commit-queue 2014-03-18 12:39:46 -0700 Comment on attachment 227080 Fixed extra parens Clearing flags on attachment: 227080 Committed r165831: <http://trac.webkit.org/changeset/165831> 991797 3 commit-queue 2014-03-18 12:39:49 -0700 All reviewed patches have been landed. Closing bug. 227080 2014-03-18 11:26:46 -0700 2014-03-18 12:39:46 -0700 Fixed extra parens 0001-Fixed-extra-parens.patch text/plain 2625 mmirman ZGlmZiAtLWdpdCBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYTgzNzI4NC4uNjM0MDk4ZSAxMDA2NDQKLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wMy0xOCAgTWF0dGhldyBNaXJtYW4gIDxtbWly bWFuQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmVkIGV4dHJhIHBhcmVucyBmcm9tIGlmIHN0 YXRlbWVudCBpbiBhIHByZXByb2Nlc3NvciBkZWZpbmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA0MDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhcnNlci9QYXJzZXIuY3BwOgorCiAyMDE0LTAz LTA3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAg VXNlIE93blB0ciBpbiBTdHJ1Y3R1cmVJRFRhYmxlCmRpZmYgLS1naXQgU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFy c2VyLmNwcAppbmRleCA3NDk5MjhiLi40MGExMGU5IDEwMDY0NAotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L1BhcnNlci5jcHAKQEAgLTUwLDcgKzUwLDcgQEAKICNkZWZpbmUgZmFpbFdpdGhNZXNzYWdlKC4u LikgZG8geyB7IGhhbmRsZUVycm9yVG9rZW4oKTsgdXBkYXRlRXJyb3JNZXNzYWdlKHRydWUsIF9f VkFfQVJHU19fKTsgfSByZXR1cm4gMDsgfSB3aGlsZSAoMCkKICNkZWZpbmUgZmFpbFdpdGhTdGFj a092ZXJmbG93KCkgZG8geyB1cGRhdGVFcnJvck1lc3NhZ2UoZmFsc2UsICJTdGFjayBleGhhdXN0 ZWQiKTsgbV9oYXNTdGFja092ZXJmbG93ID0gdHJ1ZTsgcmV0dXJuIDA7IH0gd2hpbGUgKDApCiAj ZGVmaW5lIGZhaWxJZkZhbHNlKGNvbmQsIC4uLikgZG8geyBpZiAoIShjb25kKSkgeyBoYW5kbGVF cnJvclRva2VuKCk7IGludGVybmFsRmFpbFdpdGhNZXNzYWdlKHRydWUsIF9fVkFfQVJHU19fKTsg fSB9IHdoaWxlICgwKQotI2RlZmluZSBmYWlsSWZUcnVlKGNvbmQsIC4uLikgZG8geyBpZiAoKGNv bmQpKSB7IGhhbmRsZUVycm9yVG9rZW4oKTsgaW50ZXJuYWxGYWlsV2l0aE1lc3NhZ2UodHJ1ZSwg X19WQV9BUkdTX18pOyB9IH0gd2hpbGUgKDApCisjZGVmaW5lIGZhaWxJZlRydWUoY29uZCwgLi4u KSBkbyB7IGlmIChjb25kKSB7IGhhbmRsZUVycm9yVG9rZW4oKTsgaW50ZXJuYWxGYWlsV2l0aE1l c3NhZ2UodHJ1ZSwgX19WQV9BUkdTX18pOyB9IH0gd2hpbGUgKDApCiAjZGVmaW5lIGZhaWxJZlRy dWVJZlN0cmljdChjb25kLCAuLi4pIGRvIHsgaWYgKChjb25kKSAmJiBzdHJpY3RNb2RlKCkpIGlu dGVybmFsRmFpbFdpdGhNZXNzYWdlKGZhbHNlLCBfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCiAj ZGVmaW5lIGZhaWxJZkZhbHNlSWZTdHJpY3QoY29uZCwgLi4uKSBkbyB7IGlmICgoIShjb25kKSkg JiYgc3RyaWN0TW9kZSgpKSBpbnRlcm5hbEZhaWxXaXRoTWVzc2FnZShmYWxzZSwgX19WQV9BUkdT X18pOyB9IHdoaWxlICgwKQogI2RlZmluZSBjb25zdW1lT3JGYWlsKHRva2VuVHlwZSwgLi4uKSBk byB7IGlmICghY29uc3VtZSh0b2tlblR5cGUpKSB7IGhhbmRsZUVycm9yVG9rZW4oKTsgaW50ZXJu YWxGYWlsV2l0aE1lc3NhZ2UodHJ1ZSwgX19WQV9BUkdTX18pOyB9IH0gd2hpbGUgKDApCkBAIC01 OCw3ICs1OCw3IEBACiAjZGVmaW5lIG1hdGNoT3JGYWlsKHRva2VuVHlwZSwgLi4uKSBkbyB7IGlm ICghbWF0Y2godG9rZW5UeXBlKSkgeyBoYW5kbGVFcnJvclRva2VuKCk7IGludGVybmFsRmFpbFdp dGhNZXNzYWdlKHRydWUsIF9fVkFfQVJHU19fKTsgfSB9IHdoaWxlICgwKQogI2RlZmluZSBmYWls SWZTdGFja092ZXJmbG93KCkgZG8geyBpZiAoIWNhblJlY3Vyc2UoKSkgZmFpbFdpdGhTdGFja092 ZXJmbG93KCk7IH0gd2hpbGUgKDApCiAjZGVmaW5lIHNlbWFudGljRmFpbCguLi4pIGRvIHsgaW50 ZXJuYWxGYWlsV2l0aE1lc3NhZ2UoZmFsc2UsIF9fVkFfQVJHU19fKTsgfSB3aGlsZSAoMCkKLSNk ZWZpbmUgc2VtYW50aWNGYWlsSWZUcnVlKGNvbmQsIC4uLikgZG8geyBpZiAoKGNvbmQpKSBpbnRl cm5hbEZhaWxXaXRoTWVzc2FnZShmYWxzZSwgX19WQV9BUkdTX18pOyB9IHdoaWxlICgwKQorI2Rl ZmluZSBzZW1hbnRpY0ZhaWxJZlRydWUoY29uZCwgLi4uKSBkbyB7IGlmIChjb25kKSBpbnRlcm5h bEZhaWxXaXRoTWVzc2FnZShmYWxzZSwgX19WQV9BUkdTX18pOyB9IHdoaWxlICgwKQogI2RlZmlu ZSBzZW1hbnRpY0ZhaWxJZkZhbHNlKGNvbmQsIC4uLikgZG8geyBpZiAoIShjb25kKSkgaW50ZXJu YWxGYWlsV2l0aE1lc3NhZ2UoZmFsc2UsIF9fVkFfQVJHU19fKTsgfSB3aGlsZSAoMCkKICNkZWZp bmUgcmVnZXhGYWlsKGZhaWx1cmUpIGRvIHsgc2V0RXJyb3JNZXNzYWdlKGZhaWx1cmUpOyByZXR1 cm4gMDsgfSB3aGlsZSAoMCkKICNkZWZpbmUgZmFpbER1ZVRvVW5leHBlY3RlZFRva2VuKCkgZG8g e1wK