130388 2014-03-18 03:01:56 -0700 [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build 2014-03-18 06:46:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned cgarcia commit-queue dbates svillar oldest_to_newest 991576 0 berto 2014-03-18 03:01:56 -0700 This happens because the whole check in shouldRemoveCMakeCache() is performed before the build directory is created, so a fresh build prints this error message: print() on closed filehandle CACHED_ARGUMENTS at Tools/Scripts/webkitdirs.pm line 1943. 991577 1 227020 berto 2014-03-18 03:03:38 -0700 Created attachment 227020 Patch 991631 2 227020 svillar 2014-03-18 06:07:30 -0700 Comment on attachment 227020 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227020&action=review r=me > Tools/ChangeLog:7 > + Mind adding a short description of what was happening here? 991642 3 berto 2014-03-18 06:46:39 -0700 (In reply to comment #2) > > Tools/ChangeLog:7 > > + > > Mind adding a short description of what was happening here? It's already included :) Committed r165809: <http://trac.webkit.org/changeset/165809> 227020 2014-03-18 03:03:38 -0700 2014-03-18 06:07:29 -0700 Patch 130388.diff text/plain 1534 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NTQ3 ZjdjLi43ZWEwZGQ4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDMtMTggIEFsYmVydG8gR2FyY2lhICA8YmVy dG9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBbQ01ha2VdIGJ1aWxkLXdlYmtpdC1vcHRp b25zLnR4dCBpcyBub3QgZ2VuZXJhdGVkIGR1cmluZyBhIGZyZXNoIGJ1aWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAzODgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGly cy5wbToKKyAgICAgICAgKHNob3VsZFJlbW92ZUNNYWtlQ2FjaGUpOiBtYWtlIHN1cmUgdGhhdCB0 aGUgYnVpbGQgZGlyZWN0b3J5CisgICAgICAgIGV4aXN0cyBiZWZvcmUgYXR0ZW1wdGluZyB0byBj cmVhdGUgYSBmaWxlIGluIGl0LgorCiAyMDE0LTAzLTE3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIHdlYmtpdHB5IHRlc3QgcmViYXNlbGluZS4KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQppbmRleCBlZWNjNmU4Li4yODc1NDU2IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xOTMzLDkg KzE5MzMsMTEgQEAgc3ViIHNob3VsZFJlbW92ZUNNYWtlQ2FjaGUoQCkKICAgICB9CiAKICAgICAj IFdlIGNoZWNrIHRoaXMgZmlyc3QsIGJlY2F1c2Ugd2UgYWx3YXlzIHdhbnQgdG8gY3JlYXRlIHRo aXMgZmlsZSBmb3IgYSBmcmVzaCBidWlsZC4KLSAgICBteSAkb3B0aW9uc0NhY2hlID0gRmlsZTo6 U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGlyKCksIGNvbmZpZ3VyYXRpb24oKSwgImJ1aWxkLXdl YmtpdC1vcHRpb25zLnR4dCIpOworICAgIG15ICRwcm9kdWN0RGlyID0gRmlsZTo6U3BlYy0+Y2F0 ZGlyKGJhc2VQcm9kdWN0RGlyKCksIGNvbmZpZ3VyYXRpb24oKSk7CisgICAgbXkgJG9wdGlvbnND YWNoZSA9IEZpbGU6OlNwZWMtPmNhdGRpcigkcHJvZHVjdERpciwgImJ1aWxkLXdlYmtpdC1vcHRp b25zLnR4dCIpOwogICAgIG15ICRqb2luZWRCdWlsZEFyZ3MgPSBqb2luKCIgIiwgQGJ1aWxkQXJn cyk7CiAgICAgaWYgKGlzQ2FjaGVkQXJndW1lbnRmaWxlT3V0T2ZEYXRlKCRvcHRpb25zQ2FjaGUs ICRqb2luZWRCdWlsZEFyZ3MpKSB7CisgICAgICAgIEZpbGU6OlBhdGg6Om1rcGF0aCgkcHJvZHVj dERpcikgdW5sZXNzIC1kICRwcm9kdWN0RGlyOwogICAgICAgICBvcGVuKENBQ0hFRF9BUkdVTUVO VFMsICI+IiwgJG9wdGlvbnNDYWNoZSk7CiAgICAgICAgIHByaW50IENBQ0hFRF9BUkdVTUVOVFMg JGpvaW5lZEJ1aWxkQXJnczsKICAgICAgICAgY2xvc2UoQ0FDSEVEX0FSR1VNRU5UUyk7Cg==