130380 2014-03-17 18:31:21 -0700 V8 regexp spends most time in operationGetById 2014-03-17 20:46:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 991498 0 msaboff 2014-03-17 18:31:21 -0700 Profiling shows that operationGetById is the hottest function when running V8 regexp 991508 1 226999 msaboff 2014-03-17 19:04:26 -0700 Created attachment 226999 Patch When V8 regexp is run from the command line, this patch nets a 2% performance improvement. Using the JS performance test script, this patch didn't noticeably improve performance. This is likely due to longer running code being optimized by the DFG. 991537 2 msaboff 2014-03-17 20:46:50 -0700 Committed r165797: <http://trac.webkit.org/changeset/165797> 226999 2014-03-17 19:04:26 -0700 2014-03-17 19:11:12 -0700 Patch 130380.patch text/plain 7791 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1Nzg4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAzLTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFY4IHJlZ2V4cCBzcGVuZHMgbW9zdCBvZiBpdHMgdGltZSBpbiBvcGVyYXRpb25HZXRCeUlk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAzODAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBT dHJpbmcubGVuZ3RoIGNhc2UgdG8gdHJ5Q2FjaGVHZXRCeUlEIHRoYXQgd2lsbCBvbmx5IGhlbHAg dGhlIEJhc2VMaW5lIEpJVC4KKyAgICAgICAgV2hlbiBWOCByZWdleHAgaXMgcnVuIGZyb20gdGhl IGNvbW1hbmQgbGluZSwgdGhpcyBuZXRzIGEgMiUgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCisg ICAgICAgIFdoZW4gdGhlIHRlc3QgaXMgcnVuIGZvciBhIGxvbmdlciBhbW91bnQgb2YgdGltZSwg dGhlcmUgaXMgbXVjaCBsZXNzIGJlbmVmaXQgYXMgdGhlCisgICAgICAgIERGRyB3aWxsIGVtaXQg dGhlIGFwcHJvcHJpYXRlIGNvZGUgZm9yIFN0cmluZy5sZW5ndGguICBUaGlzIGRvZXMgcmVtb3Zl CisgICAgICAgIG9wZXJhdGlvbkdldEJ5SWQgYXMgdGhlIGhvdHRlc3QgZnVuY3Rpb24gd2huZSBy dW4gZnJvbSB0aGUgY29tbWFuZCBsaW5lLgorCisgICAgICAgICogaml0L1JlcGF0Y2guY3BwOgor ICAgICAgICAoSlNDOjp0cnlDYWNoZUdldEJ5SUQpOgorCiAyMDE0LTAzLTE3ICBac29sdCBCb3Ji ZWx5ICA8Ym9yYmV6c0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgRml4IHRoZSAhRU5BQkxF KFBST01JU0VTKSBidWlsZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNo LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3Bw CShyZXZpc2lvbiAxNjU2OTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2gu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzQsNjYgKzM3NCw5NyBAQCBzdGF0aWMgYm9vbCB0cnlD YWNoZUdldEJ5SUQoRXhlY1N0YXRlKiBlCiAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBleGVj LT5jb2RlQmxvY2soKTsKICAgICBWTSogdm0gPSAmZXhlYy0+dm0oKTsKICAgICAKLSAgICBpZiAo aXNKU0FycmF5KGJhc2VWYWx1ZSkgJiYgcHJvcGVydHlOYW1lID09IGV4ZWMtPnByb3BlcnR5TmFt ZXMoKS5sZW5ndGgpIHsKKyAgICBpZiAoKGlzSlNBcnJheShiYXNlVmFsdWUpIHx8IGlzSlNTdHJp bmcoYmFzZVZhbHVlKSkgJiYgcHJvcGVydHlOYW1lID09IGV4ZWMtPnByb3BlcnR5TmFtZXMoKS5s ZW5ndGgpIHsKICAgICAgICAgR1BSUmVnIGJhc2VHUFIgPSBzdGF0aWNfY2FzdDxHUFJSZWc+KHN0 dWJJbmZvLnBhdGNoLmJhc2VHUFIpOwogI2lmIFVTRShKU1ZBTFVFMzJfNjQpCiAgICAgICAgIEdQ UlJlZyByZXN1bHRUYWdHUFIgPSBzdGF0aWNfY2FzdDxHUFJSZWc+KHN0dWJJbmZvLnBhdGNoLnZh bHVlVGFnR1BSKTsKICNlbmRpZgogICAgICAgICBHUFJSZWcgcmVzdWx0R1BSID0gc3RhdGljX2Nh c3Q8R1BSUmVnPihzdHViSW5mby5wYXRjaC52YWx1ZUdQUik7Ci0gICAgICAgIEdQUlJlZyBzY3Jh dGNoR1BSID0gVGVtcFJlZ2lzdGVyU2V0KHN0dWJJbmZvLnBhdGNoLnVzZWRSZWdpc3RlcnMpLmdl dEZyZWVHUFIoKTsKLSAgICAgICAgYm9vbCBuZWVkVG9SZXN0b3JlU2NyYXRjaCA9IGZhbHNlOwot ICAgICAgICAKKwogICAgICAgICBNYWNyb0Fzc2VtYmxlciBzdHViSml0OwotICAgICAgICAKLSAg ICAgICAgaWYgKHNjcmF0Y2hHUFIgPT0gSW52YWxpZEdQUlJlZykgeworCisgICAgICAgIGlmIChp c0pTQXJyYXkoYmFzZVZhbHVlKSkgeworICAgICAgICAgICAgR1BSUmVnIHNjcmF0Y2hHUFIgPSBU ZW1wUmVnaXN0ZXJTZXQoc3R1YkluZm8ucGF0Y2gudXNlZFJlZ2lzdGVycykuZ2V0RnJlZUdQUigp OworICAgICAgICAgICAgYm9vbCBuZWVkVG9SZXN0b3JlU2NyYXRjaCA9IGZhbHNlOworCisgICAg ICAgICAgICBpZiAoc2NyYXRjaEdQUiA9PSBJbnZhbGlkR1BSUmVnKSB7CiAjaWYgVVNFKEpTVkFM VUU2NCkKLSAgICAgICAgICAgIHNjcmF0Y2hHUFIgPSBBc3NlbWJseUhlbHBlcnM6OnNlbGVjdFNj cmF0Y2hHUFIoYmFzZUdQUiwgcmVzdWx0R1BSKTsKKyAgICAgICAgICAgICAgICBzY3JhdGNoR1BS ID0gQXNzZW1ibHlIZWxwZXJzOjpzZWxlY3RTY3JhdGNoR1BSKGJhc2VHUFIsIHJlc3VsdEdQUik7 CiAjZWxzZQotICAgICAgICAgICAgc2NyYXRjaEdQUiA9IEFzc2VtYmx5SGVscGVyczo6c2VsZWN0 U2NyYXRjaEdQUihiYXNlR1BSLCByZXN1bHRHUFIsIHJlc3VsdFRhZ0dQUik7CisgICAgICAgICAg ICAgICAgc2NyYXRjaEdQUiA9IEFzc2VtYmx5SGVscGVyczo6c2VsZWN0U2NyYXRjaEdQUihiYXNl R1BSLCByZXN1bHRHUFIsIHJlc3VsdFRhZ0dQUik7CiAjZW5kaWYKLSAgICAgICAgICAgIHN0dWJK aXQucHVzaFRvU2F2ZShzY3JhdGNoR1BSKTsKLSAgICAgICAgICAgIG5lZWRUb1Jlc3RvcmVTY3Jh dGNoID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBzdHViSml0LnB1c2hUb1NhdmUoc2NyYXRjaEdQ Uik7CisgICAgICAgICAgICAgICAgbmVlZFRvUmVzdG9yZVNjcmF0Y2ggPSB0cnVlOworICAgICAg ICAgICAgfQorCisgICAgICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcExpc3QgZmFpbHVyZUNh c2VzOworCisgICAgICAgICAgICBzdHViSml0LmxvYWQ4KE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNz KGJhc2VHUFIsIEpTQ2VsbDo6aW5kZXhpbmdUeXBlT2Zmc2V0KCkpLCBzY3JhdGNoR1BSKTsKKyAg ICAgICAgICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoc3R1YkppdC5icmFuY2hUZXN0MzIoTWFjcm9B c3NlbWJsZXI6Olplcm8sIHNjcmF0Y2hHUFIsIE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tMzIo SXNBcnJheSkpKTsKKyAgICAgICAgICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoc3R1YkppdC5icmFu Y2hUZXN0MzIoTWFjcm9Bc3NlbWJsZXI6Olplcm8sIHNjcmF0Y2hHUFIsIE1hY3JvQXNzZW1ibGVy OjpUcnVzdGVkSW1tMzIoSW5kZXhpbmdTaGFwZU1hc2spKSk7CisKKyAgICAgICAgICAgIHN0dWJK aXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlR1BSLCBKU09iamVjdDo6YnV0 dGVyZmx5T2Zmc2V0KCkpLCBzY3JhdGNoR1BSKTsKKyAgICAgICAgICAgIHN0dWJKaXQubG9hZDMy KE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKHNjcmF0Y2hHUFIsIEFycmF5U3RvcmFnZTo6bGVuZ3Ro T2Zmc2V0KCkpLCBzY3JhdGNoR1BSKTsKKyAgICAgICAgICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQo c3R1YkppdC5icmFuY2gzMihNYWNyb0Fzc2VtYmxlcjo6TGVzc1RoYW4sIHNjcmF0Y2hHUFIsIE1h Y3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tMzIoMCkpKTsKKworICAgICAgICAgICAgc3R1YkppdC5t b3ZlKHNjcmF0Y2hHUFIsIHJlc3VsdEdQUik7CisjaWYgVVNFKEpTVkFMVUU2NCkKKyAgICAgICAg ICAgIHN0dWJKaXQub3I2NChBc3NlbWJseUhlbHBlcnM6OlRydXN0ZWRJbW02NChUYWdUeXBlTnVt YmVyKSwgcmVzdWx0R1BSKTsKKyNlbGlmIFVTRShKU1ZBTFVFMzJfNjQpCisgICAgICAgICAgICBz dHViSml0Lm1vdmUoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tMzIoMHhmZmZmZmZmZiksIHJl c3VsdFRhZ0dQUik7IC8vIEpTVmFsdWU6OkludDMyVGFnCisjZW5kaWYKKworICAgICAgICAgICAg TWFjcm9Bc3NlbWJsZXI6Okp1bXAgc3VjY2VzcywgZmFpbDsKKworICAgICAgICAgICAgZW1pdFJl c3RvcmVTY3JhdGNoKHN0dWJKaXQsIG5lZWRUb1Jlc3RvcmVTY3JhdGNoLCBzY3JhdGNoR1BSLCBz dWNjZXNzLCBmYWlsLCBmYWlsdXJlQ2FzZXMpOworICAgICAgICAgICAgCisgICAgICAgICAgICBM aW5rQnVmZmVyIHBhdGNoQnVmZmVyKCp2bSwgJnN0dWJKaXQsIGNvZGVCbG9jayk7CisKKyAgICAg ICAgICAgIGxpbmtSZXN0b3JlU2NyYXRjaChwYXRjaEJ1ZmZlciwgbmVlZFRvUmVzdG9yZVNjcmF0 Y2gsIHN0dWJJbmZvLCBzdWNjZXNzLCBmYWlsLCBmYWlsdXJlQ2FzZXMpOworCisgICAgICAgICAg ICBzdHViSW5mby5zdHViUm91dGluZSA9IEZJTkFMSVpFX0NPREVfRk9SX1NUVUIoCisgICAgICAg ICAgICAgICAgZXhlYy0+Y29kZUJsb2NrKCksIHBhdGNoQnVmZmVyLAorICAgICAgICAgICAgICAg ICgiR2V0QnlJZCBhcnJheSBsZW5ndGggc3R1YiBmb3IgJXMsIHJldHVybiBwb2ludCAlcCIsCisg ICAgICAgICAgICAgICAgICAgIHRvQ1N0cmluZygqZXhlYy0+Y29kZUJsb2NrKCkpLmRhdGEoKSwg c3R1YkluZm8uY2FsbFJldHVybkxvY2F0aW9uLmxhYmVsQXRPZmZzZXQoCisgICAgICAgICAgICAg ICAgICAgICAgICBzdHViSW5mby5wYXRjaC5kZWx0YUNhbGxUb0RvbmUpLmV4ZWN1dGFibGVBZGRy ZXNzKCkpKTsKKworICAgICAgICAgICAgUmVwYXRjaEJ1ZmZlciByZXBhdGNoQnVmZmVyKGNvZGVC bG9jayk7CisgICAgICAgICAgICByZXBsYWNlV2l0aEp1bXAocmVwYXRjaEJ1ZmZlciwgc3R1Yklu Zm8sIHN0dWJJbmZvLnN0dWJSb3V0aW5lLT5jb2RlKCkuY29kZSgpKTsKKyAgICAgICAgICAgIHJl cGF0Y2hDYWxsKHJlcGF0Y2hCdWZmZXIsIHN0dWJJbmZvLmNhbGxSZXR1cm5Mb2NhdGlvbiwgb3Bl cmF0aW9uR2V0QnlJZCk7CisKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9Ci0g ICAgICAgIAotICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcExpc3QgZmFpbHVyZUNhc2VzOwot ICAgICAgIAotICAgICAgICBzdHViSml0LmxvYWQ4KE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKGJh c2VHUFIsIEpTQ2VsbDo6aW5kZXhpbmdUeXBlT2Zmc2V0KCkpLCBzY3JhdGNoR1BSKTsKLSAgICAg ICAgZmFpbHVyZUNhc2VzLmFwcGVuZChzdHViSml0LmJyYW5jaFRlc3QzMihNYWNyb0Fzc2VtYmxl cjo6WmVybywgc2NyYXRjaEdQUiwgTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJbW0zMihJc0FycmF5 KSkpOwotICAgICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKHN0dWJKaXQuYnJhbmNoVGVzdDMyKE1h Y3JvQXNzZW1ibGVyOjpaZXJvLCBzY3JhdGNoR1BSLCBNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZElt bTMyKEluZGV4aW5nU2hhcGVNYXNrKSkpOwotICAgICAgICAKLSAgICAgICAgc3R1YkppdC5sb2Fk UHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKGJhc2VHUFIsIEpTT2JqZWN0OjpidXR0ZXJmbHlP ZmZzZXQoKSksIHNjcmF0Y2hHUFIpOwotICAgICAgICBzdHViSml0LmxvYWQzMihNYWNyb0Fzc2Vt Ymxlcjo6QWRkcmVzcyhzY3JhdGNoR1BSLCBBcnJheVN0b3JhZ2U6Omxlbmd0aE9mZnNldCgpKSwg c2NyYXRjaEdQUik7Ci0gICAgICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQoc3R1YkppdC5icmFuY2gz MihNYWNyb0Fzc2VtYmxlcjo6TGVzc1RoYW4sIHNjcmF0Y2hHUFIsIE1hY3JvQXNzZW1ibGVyOjpU cnVzdGVkSW1tMzIoMCkpKTsKIAotICAgICAgICBzdHViSml0Lm1vdmUoc2NyYXRjaEdQUiwgcmVz dWx0R1BSKTsKKyAgICAgICAgLy8gU3RyaW5nLmxlbmd0aCBjYXNlCisgICAgICAgIE1hY3JvQXNz ZW1ibGVyOjpKdW1wIGZhaWx1cmUgPSBzdHViSml0LmJyYW5jaDgoTWFjcm9Bc3NlbWJsZXI6Ok5v dEVxdWFsLCBNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlR1BSLCBKU0NlbGw6OnR5cGVJbmZv VHlwZU9mZnNldCgpKSwgTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJbW0zMihTdHJpbmdUeXBlKSk7 CisKKyAgICAgICAgc3R1YkppdC5sb2FkMzIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoYmFzZUdQ UiwgSlNTdHJpbmc6Om9mZnNldE9mTGVuZ3RoKCkpLCByZXN1bHRHUFIpOworCiAjaWYgVVNFKEpT VkFMVUU2NCkKICAgICAgICAgc3R1YkppdC5vcjY0KEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZElt bTY0KFRhZ1R5cGVOdW1iZXIpLCByZXN1bHRHUFIpOwogI2VsaWYgVVNFKEpTVkFMVUUzMl82NCkK ICAgICAgICAgc3R1YkppdC5tb3ZlKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKDB4ZmZm ZmZmZmYpLCByZXN1bHRUYWdHUFIpOyAvLyBKU1ZhbHVlOjpJbnQzMlRhZwogI2VuZGlmCiAKLSAg ICAgICAgTWFjcm9Bc3NlbWJsZXI6Okp1bXAgc3VjY2VzcywgZmFpbDsKLSAgICAgICAgCi0gICAg ICAgIGVtaXRSZXN0b3JlU2NyYXRjaChzdHViSml0LCBuZWVkVG9SZXN0b3JlU2NyYXRjaCwgc2Ny YXRjaEdQUiwgc3VjY2VzcywgZmFpbCwgZmFpbHVyZUNhc2VzKTsKLSAgICAgICAgCisgICAgICAg IE1hY3JvQXNzZW1ibGVyOjpKdW1wIHN1Y2Nlc3MgPSBzdHViSml0Lmp1bXAoKTsKKwogICAgICAg ICBMaW5rQnVmZmVyIHBhdGNoQnVmZmVyKCp2bSwgJnN0dWJKaXQsIGNvZGVCbG9jayk7Ci0gICAg ICAgIAotICAgICAgICBsaW5rUmVzdG9yZVNjcmF0Y2gocGF0Y2hCdWZmZXIsIG5lZWRUb1Jlc3Rv cmVTY3JhdGNoLCBzdHViSW5mbywgc3VjY2VzcywgZmFpbCwgZmFpbHVyZUNhc2VzKTsKLSAgICAg ICAgCisKKyAgICAgICAgcGF0Y2hCdWZmZXIubGluayhzdWNjZXNzLCBzdHViSW5mby5jYWxsUmV0 dXJuTG9jYXRpb24ubGFiZWxBdE9mZnNldChzdHViSW5mby5wYXRjaC5kZWx0YUNhbGxUb0RvbmUp KTsKKyAgICAgICAgcGF0Y2hCdWZmZXIubGluayhmYWlsdXJlLCBzdHViSW5mby5jYWxsUmV0dXJu TG9jYXRpb24ubGFiZWxBdE9mZnNldChzdHViSW5mby5wYXRjaC5kZWx0YUNhbGxUb1Nsb3dDYXNl KSk7CisKICAgICAgICAgc3R1YkluZm8uc3R1YlJvdXRpbmUgPSBGSU5BTElaRV9DT0RFX0ZPUl9T VFVCKAogICAgICAgICAgICAgZXhlYy0+Y29kZUJsb2NrKCksIHBhdGNoQnVmZmVyLAotICAgICAg ICAgICAgKCJHZXRCeUlkIGFycmF5IGxlbmd0aCBzdHViIGZvciAlcywgcmV0dXJuIHBvaW50ICVw IiwKKyAgICAgICAgICAgICgiR2V0QnlJZCBzdHJpbmcgbGVuZ3RoIHN0dWIgZm9yICVzLCByZXR1 cm4gcG9pbnQgJXAiLAogICAgICAgICAgICAgICAgIHRvQ1N0cmluZygqZXhlYy0+Y29kZUJsb2Nr KCkpLmRhdGEoKSwgc3R1YkluZm8uY2FsbFJldHVybkxvY2F0aW9uLmxhYmVsQXRPZmZzZXQoCiAg ICAgICAgICAgICAgICAgICAgIHN0dWJJbmZvLnBhdGNoLmRlbHRhQ2FsbFRvRG9uZSkuZXhlY3V0 YWJsZUFkZHJlc3MoKSkpOwotICAgICAgICAKKwogICAgICAgICBSZXBhdGNoQnVmZmVyIHJlcGF0 Y2hCdWZmZXIoY29kZUJsb2NrKTsKICAgICAgICAgcmVwbGFjZVdpdGhKdW1wKHJlcGF0Y2hCdWZm ZXIsIHN0dWJJbmZvLCBzdHViSW5mby5zdHViUm91dGluZS0+Y29kZSgpLmNvZGUoKSk7CiAgICAg ICAgIHJlcGF0Y2hDYWxsKHJlcGF0Y2hCdWZmZXIsIHN0dWJJbmZvLmNhbGxSZXR1cm5Mb2NhdGlv biwgb3BlcmF0aW9uR2V0QnlJZCk7Ci0gICAgICAgIAorCiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KLSAgICAKLSAgICAvLyBGSVhNRTogc2hvdWxkIHN1cHBvcnQgbGVuZ3RoIGFjY2VzcyBm b3IgU3RyaW5nLgogCiAgICAgLy8gRklYTUU6IENhY2hlIHByb3BlcnR5IGFjY2VzcyBmb3IgaW1t ZWRpYXRlcy4KICAgICBpZiAoIWJhc2VWYWx1ZS5pc0NlbGwoKSkK