130377 2014-03-17 18:05:11 -0700 Web Inspector: sourceMapResourceLoaded expects statusCode parameter 2014-03-18 07:34:10 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 991488 0 joepeck 2014-03-17 18:05:11 -0700 Harmless, but explicitly provide a status code to our manual call of sourceMapResourceLoaded. 991490 1 226992 joepeck 2014-03-17 18:07:46 -0700 Created attachment 226992 [PATCH] Proposed Fix Harmless, but nice cleanup. Context: ... 82: function sourceMapResourceLoaded(error, body, mimeType, statusCode) 83- { 84- const base64encoded = false; 85- 86- if (error || statusCode >= 400) { 87- this.markAsFailed(); ... js> undefined >= 400 false 991656 2 226992 commit-queue 2014-03-18 07:34:08 -0700 Comment on attachment 226992 [PATCH] Proposed Fix Clearing flags on attachment: 226992 Committed r165811: <http://trac.webkit.org/changeset/165811> 991657 3 commit-queue 2014-03-18 07:34:10 -0700 All reviewed patches have been landed. Closing bug. 226992 2014-03-17 18:07:46 -0700 2014-03-18 07:34:08 -0700 [PATCH] Proposed Fix statuscode.patch text/plain 1499 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhOWJlZmYuLjk0NWNjYmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE0LTAzLTE3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc291cmNl TWFwUmVzb3VyY2VMb2FkZWQgZXhwZWN0cyBzdGF0dXNDb2RlIHBhcmFtZXRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwMzc3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01v ZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qczoKKworMjAxNC0wMy0xNyAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1Z2h0 IEV4Y2VwdGlvbiBpbiBKU0NvbnRleHQgSW5zcGVjdG9yCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzAzNjgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZU1hcFJlc291cmNlLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NvdXJjZU1hcFJlc291 cmNlLmpzCmluZGV4IDY2YTUwOTkuLmVjZjZlMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Tb3VyY2VNYXBSZXNvdXJjZS5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU291cmNlTWFwUmVzb3Vy Y2UuanMKQEAgLTczLDcgKzczLDcgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZU1hcFJlc291cmNlLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAg ICAgICAgICAgLy8gRklYTUU6IFdlIGRvbid0IGtub3cgdGhlIE1JTUUtdHlwZSBmb3IgaW5saW5l IGNvbnRlbnQuIEd1ZXNzIGJ5IGFuYWx5emluZyB0aGUgY29udGVudD8KICAgICAgICAgICAgICAg ICAvLyBHdWVzcyBieSB1c2luZyB0aGUgdHlwZSBvZiB0aGUgb3JpZ2luYWwgcmVzb3VyY2U/Ci0g ICAgICAgICAgICAgICAgc291cmNlTWFwUmVzb3VyY2VMb2FkZWQuY2FsbCh0aGlzLCBudWxsLCBp bmxpbmVDb250ZW50LCAidGV4dC9qYXZhc2NyaXB0Iik7CisgICAgICAgICAgICAgICAgc291cmNl TWFwUmVzb3VyY2VMb2FkZWQuY2FsbCh0aGlzLCBudWxsLCBpbmxpbmVDb250ZW50LCAidGV4dC9q YXZhc2NyaXB0IiwgMjAwKTsKICAgICAgICAgICAgIH0uYmluZCh0aGlzKSk7CiAKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwo=